commit 9d85a2a39a4b9a0bacee8d25b2830784caf8551c
author Yorke Lee <yorkelee@google.com> Wed Nov 07 17:03:08 2012 -0800
committer Yorke Lee <yorkelee@google.com> Wed Nov 07 17:06:42 2012 -0800
tree d7ff99a9c1a0a034809ba84b2efff7b975e9513f
parent 9b1b7bbeb464baa3a28fa8c0b74aa10d83893b7e

Changed Quick Contacts details Button to ImageView

Removed unnecessary button to eliminate accessibility
confusion

Bug: 7434869
Change-Id: Ib503cde9a04566d8e086bb3671868f4a8059d0be

res/layout/quickcontact_photo_container.xml

diff --git a/res/layout/quickcontact_photo_container.xml b/res/layout/quickcontact_photo_container.xml
index e970934..adb647d 100644
--- a/res/layout/quickcontact_photo_container.xml
+++ b/res/layout/quickcontact_photo_container.xml
@@ -38,10 +38,10 @@
             android:layout_alignLeft="@id/photo"
             android:layout_alignRight="@id/photo"
             android:background="#7F000000" />
-        <ImageButton
-            android:id="@+id/open_details_button"
+        <ImageView
+            android:id="@+id/contact_details_image"
             android:src="@drawable/ic_contacts_holo_dark"
-            android:background="?android:attr/selectableItemBackground"
+            android:contentDescription="@null"
             android:layout_height="wrap_content"
             android:layout_width="wrap_content"
             android:layout_marginRight="16dip"

src/com/android/contacts/quickcontact/QuickContactActivity.java

diff --git a/src/com/android/contacts/quickcontact/QuickContactActivity.java b/src/com/android/contacts/quickcontact/QuickContactActivity.java
index 25fb3f4..16814dc 100644
--- a/src/com/android/contacts/quickcontact/QuickContactActivity.java
+++ b/src/com/android/contacts/quickcontact/QuickContactActivity.java
@@ -109,7 +109,7 @@
     private View mSelectedTabRectangle;
     private View mLineAfterTrack;
 
-    private ImageButton mOpenDetailsButton;
+    private ImageView mOpenDetailsImage;
     private ImageButton mOpenDetailsPushLayerButton;
     private ViewPager mListPager;
 
@@ -196,7 +196,7 @@
         mFloatingLayout = (FloatingChildLayout) findViewById(R.id.floating_layout);
         mTrack = (ViewGroup) findViewById(R.id.track);
         mTrackScroller = (HorizontalScrollView) findViewById(R.id.track_scroller);
-        mOpenDetailsButton = (ImageButton) findViewById(R.id.open_details_button);
+        mOpenDetailsImage = (ImageView) findViewById(R.id.contact_details_image);
         mOpenDetailsPushLayerButton = (ImageButton) findViewById(R.id.open_details_push_layer);
         mListPager = (ViewPager) findViewById(R.id.item_list_pager);
         mSelectedTabRectangle = findViewById(R.id.selected_tab_rectangle);
@@ -220,7 +220,6 @@
                 close(false);
             }
         };
-        mOpenDetailsButton.setOnClickListener(openDetailsClickHandler);
         mOpenDetailsPushLayerButton.setOnClickListener(openDetailsClickHandler);
         mListPager.setAdapter(new ViewPagerAdapter(getFragmentManager()));
         mListPager.setOnPageChangeListener(new PageChangeListener());
@@ -333,7 +332,7 @@
         final ResolveCache cache = ResolveCache.getInstance(this);
         final Context context = this;
 
-        mOpenDetailsButton.setVisibility(isMimeExcluded(Contacts.CONTENT_ITEM_TYPE) ? View.GONE
+        mOpenDetailsImage.setVisibility(isMimeExcluded(Contacts.CONTENT_ITEM_TYPE) ? View.GONE
                 : View.VISIBLE);
 
         mDefaultsMap.clear();