commit 1d190985b46986e44a351c71cc6f3ca57b40fa70
author Yabin Huang <yabinh@google.com> Fri Mar 06 15:41:57 2020 -0800
committer Yabin Huang <yabinh@google.com> Sat Mar 07 00:00:12 2020 +0000
tree 68db37e61c8aff77d58e13f5ca720256d04aca81
parent f2c84b17a6f933dbda1fddc39bfa87221504b8aa

Use ImageView rather than ImageButton for non-focusable buttons

ImageButton sets focusable to be true in its constructor, so setting
it to false in layout file won't work. For buttons that shouldn't
be focusable, we should use ImageView instead.

Bug: 150956344
Test: manual
Change-Id: I1c28673ca635655fb3c8f67c719f8225c304bbab

car-ui-lib/res/layout/car_ui_recyclerview_scrollbar.xml

diff --git a/car-ui-lib/res/layout/car_ui_recyclerview_scrollbar.xml b/car-ui-lib/res/layout/car_ui_recyclerview_scrollbar.xml
index a5decce..342bb49 100644
--- a/car-ui-lib/res/layout/car_ui_recyclerview_scrollbar.xml
+++ b/car-ui-lib/res/layout/car_ui_recyclerview_scrollbar.xml
@@ -22,7 +22,7 @@
     android:layout_height="match_parent"
     android:gravity="center">
 
-    <ImageButton
+    <ImageView
         android:id="@+id/page_up"
         android:layout_width="@dimen/car_ui_scrollbar_button_size"
         android:layout_height="@dimen/car_ui_scrollbar_button_size"
@@ -41,7 +41,7 @@
         android:layout_gravity="center_horizontal"
         android:background="@drawable/car_ui_recyclerview_scrollbar_thumb" />
 
-    <ImageButton
+    <ImageView
         android:id="@+id/page_down"
         android:layout_width="@dimen/car_ui_scrollbar_button_size"
         android:layout_height="@dimen/car_ui_scrollbar_button_size"