commit 5438d3faed4603cd6172b3538b56047a77e695ac
author Arnaud Berry <arnaudberry@google.com> Fri Jan 10 14:53:19 2020 -0800
committer Arnaud Berry <arnaudberry@google.com> Wed Jan 15 13:07:50 2020 -0800
tree 1aaaeef72ffa03f22b54ab270a557027947751eb
parent 804e8195ea5568367b89f47c8ee0807a54882185

Cancel image requests for view holder detached from the window.

Fixes: 147510845
Test: manual
Change-Id: I3558adca40b2b0bcd310912736ba12559efb6359

src/com/android/car/media/PlaybackFragment.java

diff --git a/src/com/android/car/media/PlaybackFragment.java b/src/com/android/car/media/PlaybackFragment.java
index 182fd4c..62f272d 100644
--- a/src/com/android/car/media/PlaybackFragment.java
+++ b/src/com/android/car/media/PlaybackFragment.java
@@ -180,6 +180,20 @@
 
             return active;
         }
+
+        void onViewAttachedToWindow() {
+            if (mShowThumbnailForQueueItem) {
+                Context context = mView.getContext();
+                mThumbnailBinder.maybeRestartLoading(context);
+            }
+        }
+
+        void onViewDetachedFromWindow() {
+            if (mShowThumbnailForQueueItem) {
+                Context context = mView.getContext();
+                mThumbnailBinder.maybeCancelLoading(context);
+            }
+        }
     }
 
 
@@ -249,6 +263,18 @@
         }
 
         @Override
+        public void onViewAttachedToWindow(@NonNull QueueViewHolder holder) {
+            super.onViewAttachedToWindow(holder);
+            holder.onViewAttachedToWindow();
+        }
+
+        @Override
+        public void onViewDetachedFromWindow(@NonNull QueueViewHolder holder) {
+            super.onViewDetachedFromWindow(holder);
+            holder.onViewDetachedFromWindow();
+        }
+
+        @Override
         public int getItemCount() {
             return mQueueItems.size();
         }

src/com/android/car/media/browse/BrowseAdapter.java

diff --git a/src/com/android/car/media/browse/BrowseAdapter.java b/src/com/android/car/media/browse/BrowseAdapter.java
index fc0fd99..9ba3cd1 100644
--- a/src/com/android/car/media/browse/BrowseAdapter.java
+++ b/src/com/android/car/media/browse/BrowseAdapter.java
@@ -182,6 +182,18 @@
     }
 
     @Override
+    public void onViewAttachedToWindow(@NonNull BrowseViewHolder holder) {
+        super.onViewAttachedToWindow(holder);
+        holder.onViewAttachedToWindow(mContext);
+    }
+
+    @Override
+    public void onViewDetachedFromWindow(@NonNull BrowseViewHolder holder) {
+        super.onViewDetachedFromWindow(holder);
+        holder.onViewDetachedFromWindow(mContext);
+    }
+
+    @Override
     public int getItemViewType(int position) {
         return getItem(position).mViewType.ordinal();
     }

src/com/android/car/media/browse/BrowseViewHolder.java

diff --git a/src/com/android/car/media/browse/BrowseViewHolder.java b/src/com/android/car/media/browse/BrowseViewHolder.java
index bf8df77..aa4449f 100644
--- a/src/com/android/car/media/browse/BrowseViewHolder.java
+++ b/src/com/android/car/media/browse/BrowseViewHolder.java
@@ -104,4 +104,12 @@
         ViewUtils.setVisible(mSubTitleDownloadIcon, showSubtitle && downloaded);
         ViewUtils.setVisible(mSubTitleExplicitIcon, showSubtitle && explicit);
     }
+
+    void onViewAttachedToWindow(Context context) {
+        mAlbumArtBinder.maybeRestartLoading(context);
+    }
+
+    void onViewDetachedFromWindow(Context context) {
+        mAlbumArtBinder.maybeCancelLoading(context);
+    }
 }