commit 2b55bb3092ca5517906ef62bdb5de4c7711666d9
author Erin Dahlgren <edahlgren@google.com> Thu Nov 07 11:55:49 2013 -0800
committer The Android Automerger <android-build@google.com> Thu Nov 07 17:04:38 2013 -0800
tree ffd21e286cdf6944ac6631a4cc9381367bc598a5
parent 5eefffdfb0b93f7a1b3d4c167c25d8a2a4a68d08

Fix photo mode is getting stuck in a single CameraState.

Bug: 11574716
Change-Id: Ieb3622103798077071bb9350773851b7acbff756

src/com/android/camera/PhotoModule.java

diff --git a/src/com/android/camera/PhotoModule.java b/src/com/android/camera/PhotoModule.java
index ce0deed..347244e 100644
--- a/src/com/android/camera/PhotoModule.java
+++ b/src/com/android/camera/PhotoModule.java
@@ -350,7 +350,6 @@
                     }
 
                     startPreview();
-                    mHandler.sendEmptyMessage(CAMERA_PREVIEW_DONE);
                     break;
                 }
 
@@ -1566,12 +1565,8 @@
         startPreview();
     }
 
+    /** This can run on a background thread, post any view updates to MainHandler. */
     private void startPreview() {
-        if (mCameraState != PREVIEW_STOPPED) {
-            Log.v(TAG, "Already previewing");
-            return;
-        }
-
         if (mPaused || mCameraDevice == null) {
             return;
         }
@@ -1592,6 +1587,12 @@
                 return;
             }
             mCameraDevice.setErrorCallback(mErrorCallback);
+            // ICS camera frameworks has a bug. Face detection state is not cleared 1589
+            // after taking a picture. Stop the preview to work around it. The bug
+            // was fixed in JB.
+            if (mCameraState != PREVIEW_STOPPED) {
+                stopPreview();
+            }
 
             setDisplayOrientation();
 
@@ -1618,6 +1619,7 @@
             if (mSnapshotOnIdle) {
                 mHandler.post(mDoSnapRunnable);
             }
+            mHandler.sendEmptyMessage(CAMERA_PREVIEW_DONE);
         }
     }