commit f1672b4a703ea7600f17f451f6632f1cd399e839
author Owen Lin <owenlin@google.com> Thu May 06 15:14:05 2010 +0800
committer Owen Lin <owenlin@google.com> Tue May 11 11:06:07 2010 +0800
tree 7b6483d1cfc1e29fb026b63d5585e3f99cd0d817
parent 0d73bccf89870682007dd32d4a84bcdb812e2cc7

Initialize zoom in "InitializeSecondTime" so that we can get correct values for
zoom ratios.

Bug: 2643926

The zoom ratios are changed when the preview size changes. We need to read it i
again to get the latest values.

Change-Id: I64a248eba2aa63456f14452ffccaeaab090cc748

src/com/android/camera/Camera.java

diff --git a/src/com/android/camera/Camera.java b/src/com/android/camera/Camera.java
index b42c1a5..9711826 100644
--- a/src/com/android/camera/Camera.java
+++ b/src/com/android/camera/Camera.java
@@ -121,7 +121,6 @@
     private static final int SCREEN_DELAY = 2 * 60 * 1000;
     private static final int FOCUS_BEEP_VOLUME = 100;
 
-
     private static final int ZOOM_STOPPED = 0;
     private static final int ZOOM_START = 1;
     private static final int ZOOM_STOPPING = 2;
@@ -359,9 +358,7 @@
         installIntentFilter();
         initializeFocusTone();
         initializeZoom();
-
         mFirstTimeInitialized = true;
-
         changeHeadUpDisplayState();
         addIdleHandler();
     }
@@ -397,27 +394,21 @@
         if (mRecordLocation) startReceivingLocationUpdates();
 
         installIntentFilter();
-
         initializeFocusTone();
+        initializeZoom();
+        changeHeadUpDisplayState();
 
         keepMediaProviderInstance();
         checkStorage();
 
-        mCameraDevice.setZoomChangeListener(mZoomListener);
-
         if (!mIsImageCaptureIntent) {
             updateThumbnailButton();
         }
-
-        changeHeadUpDisplayState();
     }
 
     private void initializeZoom() {
         if (!mParameters.isZoomSupported()) return;
 
-        // Maximum zoom value may change after preview size is set. Get the
-        // latest parameters here.
-        mParameters = mCameraDevice.getParameters();
         mZoomMax = mParameters.getMaxZoom();
         mSmoothZoomSupported = mParameters.isSmoothZoomSupported();
         mGestureDetector = new GestureDetector(this, new ZoomGestureListener());
@@ -453,12 +444,7 @@
             }
             return result;
         } else {
-            //1.0, 1.2, 1.44, 1.6, 1.8, 2.0
-            float result[] = new float[mZoomMax + 1];
-            for (int i = 0, n = result.length; i < n; ++i) {
-                result[i] = 1 + i * 0.2f;
-            }
-            return result;
+            throw new IllegalStateException("cannot get zoom ratios");
         }
     }
 
@@ -1770,7 +1756,15 @@
         Size optimalSize = getOptimalPreviewSize(
                 sizes, (double) size.width / size.height);
         if (optimalSize != null) {
-            mParameters.setPreviewSize(optimalSize.width, optimalSize.height);
+            Size original = mParameters.getPreviewSize();
+            if (!original.equals(optimalSize)) {
+                mParameters.setPreviewSize(optimalSize.width, optimalSize.height);
+
+                // Zoom related settings will be changed for different preview
+                // sizes, so set and read the parameters to get lastest values
+                mCameraDevice.setParameters(mParameters);
+                mParameters = mCameraDevice.getParameters();
+            }
         }
 
         // Since change scene mode may change supported values,