commit d97a4ef4de155e1b9539845ae393639d13a19d8e
author Wu-cheng Li <wuchengli@google.com> Tue Jul 17 17:46:26 2012 +0800
committer Wu-cheng Li <wuchengli@google.com> Tue Jul 17 18:11:20 2012 +0800
tree 86c9ac11699297d59d87c643acc53bc0b6729f4c
parent a4d59d47b9179d62fb342d7d253e77039e690eeb

Fix the crash when choosing pick your video in effects recording.

In pick your video case, mEffectType is not EFFECTS_NONE and
mEffectsRecorder is null in onPause.

bug:6826528

Change-Id: Id8c933555b1b8a37c541deb04746468efe1787c0

src/com/android/camera/VideoCamera.java

diff --git a/src/com/android/camera/VideoCamera.java b/src/com/android/camera/VideoCamera.java
index dc03217..ae5176b 100755
--- a/src/com/android/camera/VideoCamera.java
+++ b/src/com/android/camera/VideoCamera.java
@@ -851,6 +851,7 @@
             stopPreview();
             if (effectsActive() && mEffectsRecorder != null) {
                 mEffectsRecorder.release();
+                mEffectsRecorder = null;
             }
         }
 
@@ -884,13 +885,15 @@
     // Closing the effects out. Will shut down the effects graph.
     private void closeEffects() {
         Log.v(TAG, "Closing effects");
+        mEffectType = EffectsRecorder.EFFECT_NONE;
         if (mEffectsRecorder == null) {
             Log.d(TAG, "Effects are already closed. Nothing to do");
+            return;
         }
         // This call can handle the case where the camera is already released
         // after the recording has been stopped.
         mEffectsRecorder.release();
-        mEffectType = EffectsRecorder.EFFECT_NONE;
+        mEffectsRecorder = null;
     }
 
     // By default, we want to close the effects as well with the camera.
@@ -920,10 +923,8 @@
             // Disconnect the camera from effects so that camera is ready to
             // be released to the outside world.
             mEffectsRecorder.disconnectCamera();
-            if (closeEffectsAlso) {
-                closeEffects();
-            }
         }
+        if (closeEffectsAlso) closeEffects();
         mCameraDevice.setZoomChangeListener(null);
         mCameraDevice.setErrorCallback(null);
         CameraHolder.instance().release();
@@ -1287,8 +1288,8 @@
             cleanupEmptyFile();
             mEffectsRecorder.release();
             mEffectsRecorder = null;
-            mEffectType = EffectsRecorder.EFFECT_NONE;
         }
+        mEffectType = EffectsRecorder.EFFECT_NONE;
         mVideoFilename = null;
     }
 
@@ -2148,6 +2149,7 @@
                     stopPreview();
                 } else {
                     mEffectsRecorder.release();
+                    mEffectsRecorder = null;
                 }
                 resizeForPreviewAspectRatio();
                 startPreview(); // Parameters will be set in startPreview().