commit f0595b2190f6dcb65b4c83cbf6c0628c34586449
author Vladimir Ivanov <vlivanov@openjdk.org> Thu Apr 23 18:01:38 2015 +0300
committer Vladimir Ivanov <vlivanov@openjdk.org> Thu Apr 23 18:01:38 2015 +0300
tree d8cd65119e2c0f45366d48c63f9a8125ef482421
parent 55c29398fefaa9a4117d9fd4c569324e78d3d09a

8059455: LambdaForm.prepare() does unnecessary work for cached LambdaForms

Reviewed-by: psandoz

jdk/src/share/classes/java/lang/invoke/LambdaForm.java

diff --git a/jdk/src/share/classes/java/lang/invoke/LambdaForm.java b/jdk/src/share/classes/java/lang/invoke/LambdaForm.java
index 5c44107..09a742f 100644
--- a/jdk/src/share/classes/java/lang/invoke/LambdaForm.java
+++ b/jdk/src/share/classes/java/lang/invoke/LambdaForm.java
@@ -631,7 +631,7 @@
      * as a sort of pre-invocation linkage step.)
      */
     public void prepare() {
-        if (COMPILE_THRESHOLD == 0) {
+        if (COMPILE_THRESHOLD == 0 && !isCompiled) {
             compileToBytecode();
         }
         if (this.vmentry != null) {
@@ -645,11 +645,11 @@
 
     /** Generate optimizable bytecode for this form. */
     MemberName compileToBytecode() {
-        MethodType invokerType = methodType();
-        assert(vmentry == null || vmentry.getMethodType().basicType().equals(invokerType));
         if (vmentry != null && isCompiled) {
             return vmentry;  // already compiled somehow
         }
+        MethodType invokerType = methodType();
+        assert(vmentry == null || vmentry.getMethodType().basicType().equals(invokerType));
         try {
             vmentry = InvokerBytecodeGenerator.generateCustomizedCode(this, invokerType);
             if (TRACE_INTERPRETER)