8076294: Cleanup of CollectedHeap::kind()
Reviewed-by: stefank, ecaspole
diff --git a/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp b/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
index d607455..1a3be8c 100644
--- a/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
+++ b/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
@@ -1008,7 +1008,7 @@
// Set _n_par_threads according to a policy TBD.
void set_par_threads();
- virtual CollectedHeap::Name kind() const {
+ virtual Name kind() const {
return CollectedHeap::G1CollectedHeap;
}
diff --git a/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp b/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp
index 82b950a..867bdbf 100644
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp
@@ -83,7 +83,7 @@
MarkSweep
};
- ParallelScavengeHeap::Name kind() const {
+ virtual Name kind() const {
return CollectedHeap::ParallelScavengeHeap;
}
diff --git a/hotspot/src/share/vm/gc_interface/collectedHeap.hpp b/hotspot/src/share/vm/gc_interface/collectedHeap.hpp
index 5c6da39..5dec0ec 100644
--- a/hotspot/src/share/vm/gc_interface/collectedHeap.hpp
+++ b/hotspot/src/share/vm/gc_interface/collectedHeap.hpp
@@ -185,8 +185,6 @@
public:
enum Name {
- Abstract,
- SharedHeap,
GenCollectedHeap,
ParallelScavengeHeap,
G1CollectedHeap
@@ -196,7 +194,7 @@
return _filler_array_max_size;
}
- virtual CollectedHeap::Name kind() const { return CollectedHeap::Abstract; }
+ virtual Name kind() const = 0;
/**
* Returns JNI error code JNI_ENOMEM if memory could not be allocated,
diff --git a/hotspot/src/share/vm/memory/genCollectedHeap.hpp b/hotspot/src/share/vm/memory/genCollectedHeap.hpp
index 77336a4..a914327 100644
--- a/hotspot/src/share/vm/memory/genCollectedHeap.hpp
+++ b/hotspot/src/share/vm/memory/genCollectedHeap.hpp
@@ -139,7 +139,7 @@
// Initialize ("weak") refs processing support
virtual void ref_processing_init();
- virtual CollectedHeap::Name kind() const {
+ virtual Name kind() const {
return CollectedHeap::GenCollectedHeap;
}
diff --git a/hotspot/src/share/vm/runtime/vmStructs.cpp b/hotspot/src/share/vm/runtime/vmStructs.cpp
index 8524679..f7561b6 100644
--- a/hotspot/src/share/vm/runtime/vmStructs.cpp
+++ b/hotspot/src/share/vm/runtime/vmStructs.cpp
@@ -2253,9 +2253,9 @@
\
declare_constant(CardTableRS::youngergen_card) \
\
- declare_constant(CollectedHeap::Abstract) \
- declare_constant(CollectedHeap::SharedHeap) \
declare_constant(CollectedHeap::GenCollectedHeap) \
+ declare_constant(CollectedHeap::ParallelScavengeHeap) \
+ declare_constant(CollectedHeap::G1CollectedHeap) \
\
declare_constant(GenCollectedHeap::max_gens) \
\
