commit 9f6518676d85518024689fa0144c1c32c75cb3fe
author Amarnath Hullur Subramanyam <amarnath@codeaurora.org> Wed Jun 24 19:44:08 2015 +0530
committer Vineeta Srivastava <vsrivastava@google.com> Thu Jul 09 11:59:08 2015 -0700
tree e41f755888f4508511e2bc6ecc820ae0222b324a
parent 8e5a1f11d8d8ca7f0404dd6c926f7b31785a9df2

Wifi-HAL: Fix null check while setting on_alert handler

While setting on_alert handler, check should be for non-null
handler but not null handler.

Change-Id: I1823e72cf6d05779f1cfd018fdb5c69a5f570187

qcwcn/wifi_hal/wifilogger.cpp

diff --git a/qcwcn/wifi_hal/wifilogger.cpp b/qcwcn/wifi_hal/wifilogger.cpp
index 17c4b0c..757e62e 100644
--- a/qcwcn/wifi_hal/wifilogger.cpp
+++ b/qcwcn/wifi_hal/wifilogger.cpp
@@ -548,7 +548,7 @@
 
     info->on_ring_buffer_data = handler.on_ring_buffer_data;
     if (handler.on_ring_buffer_data == NULL) {
-        ALOGE("Input handler is NULL");
+        ALOGE("Set log handler is NULL");
         return WIFI_ERROR_UNKNOWN;
     }
     return WIFI_SUCCESS;
@@ -572,8 +572,8 @@
     wifi_handle wifiHandle = getWifiHandle(iface);
     hal_info *info = getHalInfo(wifiHandle);
 
-    if (handler.on_alert) {
-        ALOGE("Input handler is NULL");
+    if (handler.on_alert == NULL) {
+        ALOGE("Set alert handler is NULL");
         return WIFI_ERROR_UNKNOWN;
     }
     //TODO check locking