commit 8f9c7c32327a1b978a6f8b60a6c3ede580590034
author Naseer Ahmed <naseer@codeaurora.org> Tue Feb 21 16:45:14 2017 -0500
committer Gerrit - the friendly Code Review server <code-review@localhost> Tue Feb 21 15:59:40 2017 -0800
tree ca18725b72c9d11fc798f19dd6325b4efa828392
parent 13321553e518cf8a18200bb29a9aa760062d2ab9

gralloc1: Fixes for hidl

* Fix capabilities check
* Use unique ID for backing store per the hidl spec

CRs-Fixed: 2009826
Change-Id: Ifc2be98a00dc3b0e4fd4e3e4c8d343de6afd8560

libgralloc1/gr_device_impl.cpp

diff --git a/libgralloc1/gr_device_impl.cpp b/libgralloc1/gr_device_impl.cpp
index 121d0cf..2bb66d1 100644
--- a/libgralloc1/gr_device_impl.cpp
+++ b/libgralloc1/gr_device_impl.cpp
@@ -100,16 +100,13 @@
 }
 
 void GrallocImpl::GetCapabilities(struct gralloc1_device *device, uint32_t *out_count,
-                                  int32_t /*gralloc1_capability_t*/ *out_capabilities) {
-  if (!device) {
-    // Need to plan for adding more capabilities
-    if (out_capabilities == NULL) {
-      *out_count = 1;
-    } else {
-      *out_capabilities = GRALLOC1_CAPABILITY_TEST_ALLOCATE;
+                                  int32_t  /*gralloc1_capability_t*/ *out_capabilities) {
+  if (device != nullptr) {
+    if (out_capabilities != nullptr && *out_count > 0) {
+      out_capabilities[0] = GRALLOC1_CAPABILITY_TEST_ALLOCATE;
     }
+    *out_count = 1;
   }
-
   return;
 }
 

libgralloc1/gr_priv_handle.h

diff --git a/libgralloc1/gr_priv_handle.h b/libgralloc1/gr_priv_handle.h
index 61190c2..9a7e7b6 100644
--- a/libgralloc1/gr_priv_handle.h
+++ b/libgralloc1/gr_priv_handle.h
@@ -175,7 +175,7 @@
 
   gralloc1_producer_usage_t GetProducerUsage() const { return producer_usage; }
 
-  int GetBackingstore() const { return fd; }
+  uint64_t GetBackingstore() const { return id; }
 };
 
 #endif  // __GR_PRIV_HANDLE_H__