commit 702c15751ca43c51781ed31491741c56c6122be3
author Kevin Rocard <krocard@google.com> Wed Jul 11 20:52:03 2018 -0700
committer Kevin Rocard <krocard@google.com> Thu Jul 12 17:58:02 2018 +0000
tree c6ed3421a95384933f0b6f866f24ed17b0b0d361
parent 41b4fe4c5750792a2c7afbc479bd742034f9a4df

A2DP set_parameter: return correct status value

The A2DP offload set_parameter code was returning the value
of a temporary variable use to parse the value pairs
instead of the status of the operation.

This mean that an error was wrongly returned when
setting the value of any key that was not
AUDIO_PARAMETER_RECONFIG_A2DP (the last one parsed).

Test: vts-tradefed run commandAndExit vts -m VtsHalAudioV4_0Target
Bug: 111113768
Change-Id: Ic32bdaafb8d048322d1c560f4f4c3deefeba63df
Signed-off-by: Kevin Rocard <krocard@google.com>

hal/audio_extn/a2dp.c

diff --git a/hal/audio_extn/a2dp.c b/hal/audio_extn/a2dp.c
index 4c44fc4..0c18aab 100644
--- a/hal/audio_extn/a2dp.c
+++ b/hal/audio_extn/a2dp.c
@@ -1503,13 +1503,14 @@
 int audio_extn_a2dp_set_parameters(struct str_parms *parms, bool *reconfig)
 {
      int ret = 0, val;
+     int status = 0;
      char value[32] = {0};
      struct audio_usecase *uc_info;
      struct listnode *node;
 
      if (a2dp.is_a2dp_offload_enabled == false) {
         ALOGV("%s: No supported encoders identified,ignoring A2DP setparam", __func__);
-        ret = -EINVAL;
+        status = -EINVAL;
         goto param_handled;
      }
 
@@ -1587,15 +1588,15 @@
                 if (a2dp.a2dp_total_active_session_request > 0) {
                     ALOGD("%s: Calling Bluetooth IPC lib start post suspend state", __func__);
                     if (a2dp.audio_stream_start) {
-                        ret =  a2dp.audio_stream_start();
-                        if (ret != 0) {
+                        status =  a2dp.audio_stream_start();
+                        if (status != 0) {
                             ALOGE("%s: Bluetooth controller start failed", __func__);
                             a2dp.a2dp_started = false;
                         } else {
                             if (!configure_a2dp_encoder_format()) {
                                 ALOGE("%s: Encoder params configuration failed post suspend", __func__);
                                 a2dp.a2dp_started = false;
-                                ret = -ETIMEDOUT;
+                                status = -ETIMEDOUT;
                             }
                         }
                     }
@@ -1631,7 +1632,7 @@
 
 param_handled:
      ALOGV("%s: end of A2DP setparam", __func__);
-     return ret;
+     return status;
 }
 
 void audio_extn_a2dp_set_handoff_mode(bool is_on)