commit 1c9df71d7bfa4bd839227d83dfeb7a706c611ed0
author anil.hiranniah <anil.hiranniah@nxp.com> Fri Mar 20 19:52:36 2020 +0530
committer George Chang <georgekgchang@google.com> Tue Mar 24 11:21:00 2020 +0000
tree d8db3bd5ad0dc3f3d62136befbd474821ffb18c7
parent cb7dde1668673bae9cf8674713542f5f1c8215c7

Fix warnings from static analysis tools

1. FORWARD/REVERSE NULL
   a. phNxpEsePal_spi.c :phNxpEse_spiIoctl()
      Added null check for p_data

Bug: 142626701
Test: VTS
Merged-In: I8932afa39eb93aaf7cbbe2320e1071bf5b450735
Change-Id: I8932afa39eb93aaf7cbbe2320e1071bf5b450735

libese-spi/p73/pal/spi/phNxpEsePal_spi.cpp

diff --git a/libese-spi/p73/pal/spi/phNxpEsePal_spi.cpp b/libese-spi/p73/pal/spi/phNxpEsePal_spi.cpp
index 21057b6..cb2d4c5 100755
--- a/libese-spi/p73/pal/spi/phNxpEsePal_spi.cpp
+++ b/libese-spi/p73/pal/spi/phNxpEsePal_spi.cpp
@@ -89,6 +89,11 @@
   return;
 }
 ESESTATUS phNxpEse_spiIoctl(uint64_t ioctlType, void* p_data) {
+  if (!p_data) {
+    ALOGD_IF(ese_debug_enabled, "%s:p_data is null ioctltyp: %ld", __FUNCTION__,
+             (long)ioctlType);
+    return ESESTATUS_FAILED;
+  }
   ese_nxp_IoctlInOutData_t* inpOutData = (ese_nxp_IoctlInOutData_t*)p_data;
   rf_status = inpOutData->inp.data.nxpCmd.p_cmd[0];
   if (rf_status == 1) {
@@ -99,11 +104,6 @@
         ese_debug_enabled,
         "******************RF IS OFF*************************************");
   }
-  if (p_data != NULL) {
-    ALOGD_IF(ese_debug_enabled,
-             "halimpl phNxpEse_spiIoctl p_data is not null ioctltyp: %ld",
-             (long)ioctlType);
-  }
   return ESESTATUS_SUCCESS;
 }