commit f110ea4893f9d4adc6f62495b284bcb24f34046a
author Treehugger Robot <treehugger-gerrit@google.com> Fri Jul 13 20:32:41 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Fri Jul 13 20:32:41 2018 +0000
tree b766ac105b6b5d3f9b684cb5efce251a12362cef
parent 314f9503a99e86c5036398cf19f577785ed88de3
parent 091880882c10023f9af5f0df6323270767ca4649

Merge "Fix unnecessary copy initialization warnings"

tests/safeunion/1.0/Android.bp

diff --git a/tests/safeunion/1.0/Android.bp b/tests/safeunion/1.0/Android.bp
index 4c6631e..ede8401 100644
--- a/tests/safeunion/1.0/Android.bp
+++ b/tests/safeunion/1.0/Android.bp
@@ -10,6 +10,6 @@
     interfaces: [
         "android.hidl.base@1.0",
     ],
-    gen_java: false,
+    gen_java: true,
 }
 

tests/safeunion/1.0/ISafeUnion.hal

diff --git a/tests/safeunion/1.0/ISafeUnion.hal b/tests/safeunion/1.0/ISafeUnion.hal
index 153d6f4..fedd63b 100644
--- a/tests/safeunion/1.0/ISafeUnion.hal
+++ b/tests/safeunion/1.0/ISafeUnion.hal
@@ -62,14 +62,6 @@
         SmallSafeUnion l;
     };
 
-    // TODO(b/110269925): Test more HIDL types. Missing:
-    // death_recipient, fmq_{sync,unsync}, pointer, ref.
-    safe_union MiscTypesSafeUnion {
-        memory a;
-        handle b;
-        bitfield<BitField> c;
-    };
-
     safe_union InterfaceTypeSafeUnion {
         uint32_t a;
         int8_t[7] b;
@@ -90,11 +82,6 @@
     setK(LargeSafeUnion myUnion, LargeSafeUnion.K k) generates (LargeSafeUnion myUnion);
     setL(LargeSafeUnion myUnion, SmallSafeUnion l) generates (LargeSafeUnion myUnion);
 
-    newMiscTypesSafeUnion() generates (MiscTypesSafeUnion myUnion);
-    setMiscA(MiscTypesSafeUnion myUnion, memory a) generates (MiscTypesSafeUnion myUnion);
-    setMiscB(MiscTypesSafeUnion myUnion, handle b) generates (MiscTypesSafeUnion myUnion);
-    setMiscC(MiscTypesSafeUnion myUnion, bitfield<BitField> c) generates (MiscTypesSafeUnion myUnion);
-
     newInterfaceTypeSafeUnion() generates (InterfaceTypeSafeUnion myUnion);
     setInterfaceA(InterfaceTypeSafeUnion myUnion, uint32_t a) generates (InterfaceTypeSafeUnion myUnion);
     setInterfaceB(InterfaceTypeSafeUnion myUnion, int8_t[7] b) generates (InterfaceTypeSafeUnion myUnion);

tests/safeunion/1.0/default/SafeUnion.cpp

diff --git a/tests/safeunion/1.0/default/SafeUnion.cpp b/tests/safeunion/1.0/default/SafeUnion.cpp
index 55d20f8..7047d16 100644
--- a/tests/safeunion/1.0/default/SafeUnion.cpp
+++ b/tests/safeunion/1.0/default/SafeUnion.cpp
@@ -153,44 +153,6 @@
     return Void();
 }
 
-Return<void> SafeUnion::newMiscTypesSafeUnion(newMiscTypesSafeUnion_cb _hidl_cb) {
-    LOG(INFO) << "SERVER(SafeUnion) newMiscTypesSafeUnion()";
-
-    MiscTypesSafeUnion ret;
-    _hidl_cb(ret);
-    return Void();
-}
-
-Return<void> SafeUnion::setMiscA(const MiscTypesSafeUnion& myUnion, const hidl_memory& a, setMiscA_cb _hidl_cb) {
-    LOG(INFO) << "SERVER(SafeUnion) setMiscA(myUnion, " << toString(a) << ")";
-
-    MiscTypesSafeUnion myNewUnion = myUnion;
-    myNewUnion.a(a);
-
-    _hidl_cb(myNewUnion);
-    return Void();
-}
-
-Return<void> SafeUnion::setMiscB(const MiscTypesSafeUnion& myUnion, const hidl_handle& b, setMiscB_cb _hidl_cb) {
-    LOG(INFO) << "SERVER(SafeUnion) setMiscB(myUnion, " << toString(b) << ")";
-
-    MiscTypesSafeUnion myNewUnion = myUnion;
-    myNewUnion.b(b);
-
-    _hidl_cb(myNewUnion);
-    return Void();
-}
-
-Return<void> SafeUnion::setMiscC(const MiscTypesSafeUnion& myUnion, hidl_bitfield<BitField> c, setMiscC_cb _hidl_cb) {
-    LOG(INFO) << "SERVER(SafeUnion) setMiscC(myUnion, " << c << ")";
-
-    MiscTypesSafeUnion myNewUnion = myUnion;
-    myNewUnion.c(c);
-
-    _hidl_cb(myNewUnion);
-    return Void();
-}
-
 Return<void> SafeUnion::newInterfaceTypeSafeUnion(newInterfaceTypeSafeUnion_cb _hidl_cb) {
     LOG(INFO) << "SERVER(SafeUnion) newInterfaceTypeSafeUnion()";
 

tests/safeunion/1.0/default/SafeUnion.h

diff --git a/tests/safeunion/1.0/default/SafeUnion.h b/tests/safeunion/1.0/default/SafeUnion.h
index e3550b8..07d88d2 100644
--- a/tests/safeunion/1.0/default/SafeUnion.h
+++ b/tests/safeunion/1.0/default/SafeUnion.h
@@ -48,11 +48,6 @@
     Return<void> setK(const LargeSafeUnion& myUnion, const LargeSafeUnion::K& k, setK_cb _hidl_cb) override;
     Return<void> setL(const LargeSafeUnion& myUnion, const SmallSafeUnion& l, setL_cb _hidl_cb) override;
 
-    Return<void> newMiscTypesSafeUnion(newMiscTypesSafeUnion_cb _hidl_cb) override;
-    Return<void> setMiscA(const MiscTypesSafeUnion& myUnion, const hidl_memory& a, setMiscA_cb _hidl_cb) override;
-    Return<void> setMiscB(const MiscTypesSafeUnion& myUnion, const hidl_handle& b, setMiscB_cb _hidl_cb) override;
-    Return<void> setMiscC(const MiscTypesSafeUnion& myUnion, hidl_bitfield<BitField> c, setMiscC_cb _hidl_cb) override;
-
     Return<void> newInterfaceTypeSafeUnion(newInterfaceTypeSafeUnion_cb _hidl_cb) override;
     Return<void> setInterfaceA(const InterfaceTypeSafeUnion& myUnion, uint32_t a, setInterfaceA_cb _hidl_cb) override;
     Return<void> setInterfaceB(const InterfaceTypeSafeUnion& myUnion, const hidl_array<int8_t, 7>& b, setInterfaceB_cb _hidl_cb) override;