commit 7f8fb92524cee19cd8a0ce959ddfb7794846b4f0
author Lajos Molnar <lajos@google.com> Wed Nov 04 11:50:41 2020 -0800
committer Wonsik Kim <wonsik@google.com> Wed Aug 11 17:10:38 2021 +0000
tree 87e4b9fcefde9bd3a9c1079b6aa1a3ded93b4261
parent b2239ad43fdc74e846414e61428be163c9a9804c

omx: validate only standard OMX roles

Test uses ::android::GetComponentRole to get OMX role for media type
that only supports standard types (on GSI where VTS is run).

Bug: 164550113
Bug: 171536493
Bug: 194827876
Test: atest VtsHalMediaOmxV1_0TargetStoreTest
Change-Id: Ia9e64c8d887518f6c7d8c650a942bad7ce3457f0

media/omx/1.0/vts/functional/store/VtsHalMediaOmxV1_0TargetStoreTest.cpp

diff --git a/media/omx/1.0/vts/functional/store/VtsHalMediaOmxV1_0TargetStoreTest.cpp b/media/omx/1.0/vts/functional/store/VtsHalMediaOmxV1_0TargetStoreTest.cpp
index e73196c..8699de3 100644
--- a/media/omx/1.0/vts/functional/store/VtsHalMediaOmxV1_0TargetStoreTest.cpp
+++ b/media/omx/1.0/vts/functional/store/VtsHalMediaOmxV1_0TargetStoreTest.cpp
@@ -264,11 +264,13 @@
 
         // Make sure role name follows expected format based on type and
         // isEncoder
-        const std::string role_name(
-                ::android::GetComponentRole(role.isEncoder, role.type.c_str()));
-        EXPECT_EQ(role_name, role.role) << "Role \"" << role.role << "\" does not match "
-                                        << (role.isEncoder ? "an encoder " : "a decoder ")
-                                        << "for mime type \"" << role.type << ".";
+        const char* role_name = ::android::GetComponentRole(role.isEncoder, role.type.c_str());
+        if (role_name != nullptr) {
+            EXPECT_EQ(std::string(role_name), role.role)
+                    << "Role \"" << role.role << "\" does not match "
+                    << (role.isEncoder ? "an encoder " : "a decoder ") << "for media type \""
+                    << role.type << ".";
+        }
 
         // Check the nodes for this role
         std::set<const std::string> nodeKeys;