commit 8879ba075404ba7a0cbb3bff28a7519f7e59d2ef
author Yilong Li <liyl@google.com> Fri Jan 29 21:33:36 2021 -0800
committer Yilong Li <liyl@google.com> Mon Feb 01 23:37:01 2021 +0000
tree f47f83b5bdea6fd87c19782399bd381ef2a9f3c3
parent c44308b417528b488714460719a966cd5e176dae

fuchsia: Set tiling to linear if sysmem image uses host-visible memory.

For sysmem-backed images, if it uses host-visible memory,
the VkImage created on host always use linear tiling.
When we create VkImage using the VMO, we should set its
tiling to VK_IMAGE_TILING_LINEAR so that it could be
correctly sampled using linear tiling, while clients don't
need to know the exact tiling of that image.

This fixes sysmem images sampling on Intel and NVIDIA
host GPUs.

Change-Id: I62377795b5add05b577786d146b779365cb58da3

system/vulkan_enc/ResourceTracker.cpp

diff --git a/system/vulkan_enc/ResourceTracker.cpp b/system/vulkan_enc/ResourceTracker.cpp
index 0fae9f9..c04703e 100644
--- a/system/vulkan_enc/ResourceTracker.cpp
+++ b/system/vulkan_enc/ResourceTracker.cpp
@@ -3400,6 +3400,15 @@
                               GET_STATUS_SAFE(result, res));
                     }
                 }
+
+                if (info.settings.buffer_settings.heap ==
+                    llcpp::fuchsia::sysmem::HeapType::GOLDFISH_HOST_VISIBLE) {
+                    ALOGD(
+                        "%s: Image uses host visible memory heap; set tiling "
+                        "to linear to match host ImageCreateInfo",
+                        __func__);
+                    localCreateInfo.tiling = VK_IMAGE_TILING_LINEAR;
+                }
             }
             isSysmemBackedMemory = true;
         }