commit 7853faae9313d14f850c95cd8f44f0cec3787c07
author Yahan Zhou <yahan@google.com> Wed Nov 01 11:03:20 2023 -0700
committer Yahan Zhou <yahan@google.com> Wed Nov 01 11:03:20 2023 -0700
tree 9cf57ea9bee436394ad6775c26f64e08b0da0c15
parent ea8f75f109f79a281627c3dd928df6a44600ab24

Fix fatal error when VK_PIPELINE_COMPILE_REQUIRED is returned

According to the spec, vkCreateGraphicsPipelines can return
VK_PIPELINE_COMPILE_REQUIRED when succeeded.

https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkCreateGraphicsPipelines.html

Bug: 2812397
Test: dEQP-VK.pipeline.monolithic.creation_cache_control.graphics_pipelines*
Change-Id: Ic8920c664bf2a783daa1beb7411615a6ef80ef80

host/vulkan/VkDecoderGlobalState.cpp

diff --git a/host/vulkan/VkDecoderGlobalState.cpp b/host/vulkan/VkDecoderGlobalState.cpp
index 46ea389..647927f 100644
--- a/host/vulkan/VkDecoderGlobalState.cpp
+++ b/host/vulkan/VkDecoderGlobalState.cpp
@@ -2619,13 +2619,16 @@
 
         VkResult result = deviceDispatch->vkCreateGraphicsPipelines(
             device, pipelineCache, createInfoCount, pCreateInfos, pAllocator, pPipelines);
-        if (result != VK_SUCCESS) {
+        if (result != VK_SUCCESS && result != VK_PIPELINE_COMPILE_REQUIRED) {
             return result;
         }
 
         std::lock_guard<std::recursive_mutex> lock(mLock);
 
         for (uint32_t i = 0; i < createInfoCount; i++) {
+            if (!pPipelines[i]) {
+                continue;
+            }
             auto& pipelineInfo = mPipelineInfo[pPipelines[i]];
             pipelineInfo.device = device;