commit 89bce0b5af80b2c0adf51e3456da4d5204fe48a8
author Jack Yu <jackyu@google.com> Tue Dec 11 16:19:57 2018 -0800
committer Jack Yu <jackyu@google.com> Tue Dec 11 16:19:57 2018 -0800
tree e203cee8b0f378fd5c1f63d4f0cdac644f852c28
parent fefe13e72fb982c77f1bd7fcff1e138a914d7b75

Cleaned up data enable code

Moved some data enabled logic into carrier action agent. Also
do not notify data connection state when user enable/dsiable data.
The data connection states will be notified when the data connection
state actually changed.

Test: Unit tests
Bug: 73659459
Change-Id: Ie137bd9b438d75c2e566ba6259fa14060f93c92a

src/java/com/android/internal/telephony/CarrierActionAgent.java

diff --git a/src/java/com/android/internal/telephony/CarrierActionAgent.java b/src/java/com/android/internal/telephony/CarrierActionAgent.java
index 4582404..40fe386 100644
--- a/src/java/com/android/internal/telephony/CarrierActionAgent.java
+++ b/src/java/com/android/internal/telephony/CarrierActionAgent.java
@@ -118,6 +118,10 @@
                 log("SET_METERED_APNS_ENABLED: " + mCarrierActionOnMeteredApnEnabled);
                 mMeteredApnEnabledLog.log("SET_METERED_APNS_ENABLED: "
                         + mCarrierActionOnMeteredApnEnabled);
+                int otaspState = (mCarrierActionOnMeteredApnEnabled)
+                        ? mPhone.getServiceStateTracker().getOtasp()
+                        : TelephonyManager.OTASP_SIM_UNPROVISIONED;
+                mPhone.notifyOtaspChanged(otaspState);
                 mMeteredApnEnableRegistrants.notifyRegistrants(
                         new AsyncResult(null, mCarrierActionOnMeteredApnEnabled, null));
                 break;

src/java/com/android/internal/telephony/dataconnection/DcTracker.java

diff --git a/src/java/com/android/internal/telephony/dataconnection/DcTracker.java b/src/java/com/android/internal/telephony/dataconnection/DcTracker.java
index b31da9b..e61499f 100755
--- a/src/java/com/android/internal/telephony/dataconnection/DcTracker.java
+++ b/src/java/com/android/internal/telephony/dataconnection/DcTracker.java
@@ -793,14 +793,6 @@
     private void onSetUserDataEnabled(boolean enabled) {
         if (mDataEnabledSettings.isUserDataEnabled() != enabled) {
             mDataEnabledSettings.setUserDataEnabled(enabled);
-            if (!getDataRoamingEnabled() && mPhone.getServiceState().getDataRoaming()) {
-                if (enabled) {
-                    notifyOffApnsOfAvailability(Phone.REASON_ROAMING_ON);
-                } else {
-                    notifyOffApnsOfAvailability(Phone.REASON_DATA_DISABLED);
-                }
-            }
-
             mPhone.notifyUserMobileDataStateChanged(enabled);
 
             // TODO: We should register for DataEnabledSetting's data enabled/disabled event and
@@ -2229,15 +2221,9 @@
             mDataEnabledSettings.setCarrierDataEnabled(enabled);
 
             if (!enabled) {
-                // Send otasp_sim_unprovisioned so that SuW is able to proceed and notify users
-                mPhone.notifyOtaspChanged(TelephonyManager.OTASP_SIM_UNPROVISIONED);
                 // Tear down all metered apns
                 cleanUpAllConnections(true, Phone.REASON_CARRIER_ACTION_DISABLE_METERED_APN);
             } else {
-                // Re-evaluate Otasp state
-                int otaspState = mPhone.getServiceStateTracker().getOtasp();
-                mPhone.notifyOtaspChanged(otaspState);
-
                 reevaluateDataConnections();
                 setupDataOnConnectableApns(Phone.REASON_DATA_ENABLED);
             }