commit 8ac14eb66361ac301cf3b86dad2d88866005d1cc
author ramindani <ramindani@google.com> Tue Apr 26 20:20:57 2022 +0000
committer ramindani <ramindani@google.com> Wed Apr 27 22:47:11 2022 +0000
tree 19fc1d694fff3bca7782ed778b71492f2c99b9c8
parent a8312269bf484d732d4d81d0f898810589ab3505

Return NO_ERROR for setFrameRate

We were returning BAD_VALUE for this function and in old code because
of some dead code we though BAD_VALUE is correct but the result should be NO_ERROR

Note: This code is not used in the framework.

BUG: 229965137
Test: Test with the ExoPlayer demo app. and with
https: //b.corp.google.com/issues/229965137#comment11
Change-Id: I6c1eb31c71057be1c755b0ab0fe63850e40e99ca

libs/gui/Surface.cpp

diff --git a/libs/gui/Surface.cpp b/libs/gui/Surface.cpp
index 7a2615f..e8aac2f 100644
--- a/libs/gui/Surface.cpp
+++ b/libs/gui/Surface.cpp
@@ -2627,12 +2627,13 @@
     mSurfaceListener->onBuffersDiscarded(discardedBufs);
 }
 
-status_t Surface::setFrameRate(float /*frameRate*/, int8_t /*compatibility*/,
-                               int8_t /*changeFrameRateStrategy*/) {
-    ATRACE_CALL();
-    ALOGV("Surface::setFrameRate");
-    // ISurfaceComposer no longer supports setFrameRate
-    return BAD_VALUE;
+[[deprecated]] status_t Surface::setFrameRate(float /*frameRate*/, int8_t /*compatibility*/,
+                                              int8_t /*changeFrameRateStrategy*/) {
+    ALOGI("Surface::setFrameRate is deprecated, setFrameRate hint is dropped as destination is not "
+          "SurfaceFlinger");
+    // ISurfaceComposer no longer supports setFrameRate, we will return NO_ERROR when the api is
+    // called to avoid apps crashing, as BAD_VALUE can generate fatal exception in apps.
+    return NO_ERROR;
 }
 
 status_t Surface::setFrameTimelineInfo(const FrameTimelineInfo& /*frameTimelineInfo*/) {