commit a243b36b9404616563521ea524a1c8f20eceaf3a
author Treehugger Robot <treehugger-gerrit@google.com> Wed Dec 12 01:23:31 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Dec 12 01:23:31 2018 +0000
tree afec337f35181562fdb0118eb8603f21ad36c463
parent 0c6cd51a520de6f6f8e0b3fdf33844af8470b456
parent 4e8ccba815c7f0f66aad7fddf61b6e598fecaab4

Merge "Fix performance-for-range-copy warnings"

tests/unittest/FontCollectionItemizeTest.cpp

diff --git a/tests/unittest/FontCollectionItemizeTest.cpp b/tests/unittest/FontCollectionItemizeTest.cpp
index c9abc10..2fbba98 100644
--- a/tests/unittest/FontCollectionItemizeTest.cpp
+++ b/tests/unittest/FontCollectionItemizeTest.cpp
@@ -1262,7 +1262,7 @@
 
     auto collection = buildFontCollectionFromXml(kItemizeFontXml);
 
-    for (auto testCase : testCases) {
+    for (const auto& testCase : testCases) {
         SCOPED_TRACE("Test for \"" + testCase.testString + "\" with locales " +
                      testCase.requestedLocales);
 

tests/unittest/FontFamilyTest.cpp

diff --git a/tests/unittest/FontFamilyTest.cpp b/tests/unittest/FontFamilyTest.cpp
index 28662c1..4eb6bcc 100644
--- a/tests/unittest/FontFamilyTest.cpp
+++ b/tests/unittest/FontFamilyTest.cpp
@@ -239,7 +239,7 @@
             {"zh-Hanb", "Kore", NOT_SUPPORTED},
     };
 
-    for (auto testCase : testCases) {
+    for (const auto& testCase : testCases) {
         hb_script_t script = hb_script_from_iso15924_tag(
                 HB_TAG(testCase.requestedScript[0], testCase.requestedScript[1],
                        testCase.requestedScript[2], testCase.requestedScript[3]));
@@ -358,7 +358,7 @@
             "de-Latn-DE-1901-u-em-emoji",
     };
 
-    for (auto subtagEmojiString : subtagEmojiStrings) {
+    for (const auto& subtagEmojiString : subtagEmojiStrings) {
         SCOPED_TRACE("Test for \"" + subtagEmojiString + "\"");
         Locale subtagEmoji = createLocale(subtagEmojiString);
         EXPECT_EQ(EmojiStyle::EMOJI, subtagEmoji.getEmojiStyle());
@@ -385,7 +385,7 @@
             "de-Latn-DE-1901-u-em-text",
     };
 
-    for (auto subtagTextString : subtagTextStrings) {
+    for (const auto& subtagTextString : subtagTextStrings) {
         SCOPED_TRACE("Test for \"" + subtagTextString + "\"");
         Locale subtagText = createLocale(subtagTextString);
         EXPECT_EQ(EmojiStyle::TEXT, subtagText.getEmojiStyle());
@@ -413,7 +413,7 @@
             "de-Latn-DE-1901-u-em-default",
     };
 
-    for (auto subtagDefaultString : subtagDefaultStrings) {
+    for (const auto& subtagDefaultString : subtagDefaultStrings) {
         SCOPED_TRACE("Test for \"" + subtagDefaultString + "\"");
         Locale subtagDefault = createLocale(subtagDefaultString);
         EXPECT_EQ(EmojiStyle::DEFAULT, subtagDefault.getEmojiStyle());
@@ -432,7 +432,7 @@
             "de-Latn-DE-1901",
     };
 
-    for (auto subtagEmptyString : subtagEmptyStrings) {
+    for (const auto& subtagEmptyString : subtagEmptyStrings) {
         SCOPED_TRACE("Test for \"" + subtagEmptyString + "\"");
         Locale subtagEmpty = createLocale(subtagEmptyString);
         EXPECT_EQ(EmojiStyle::EMPTY, subtagEmpty.getEmojiStyle());
@@ -544,7 +544,7 @@
             {"Italic.ttf", false}, {"Bold.ttf", false},  {"BoldItalic.ttf", false},
     };
 
-    for (auto testCase : testCases) {
+    for (const auto& testCase : testCases) {
         SCOPED_TRACE(testCase.hasVSTable ? "Font " + testCase.fontPath +
                                                    " should have a variation sequence table."
                                          : "Font " + testCase.fontPath +