Suppress nullptr dereference warnings.
It's unclear to me if passing nullptr to NormalizeType
can eventually cause a null dereference.
Add a call to slangAssert(Context) before using Context
just to remove the warning on potential null Context.
Bug: 263274255
Test: presubmit; make tidy-frameworks-compile_subset
Change-Id: I19010454cc0ea45d66d2b436d16e6759d0c3cdcd
diff --git a/slang_rs_export_type.cpp b/slang_rs_export_type.cpp
index afeb6c5..ffe8ffc 100644
--- a/slang_rs_export_type.cpp
+++ b/slang_rs_export_type.cpp
@@ -333,6 +333,8 @@
//
// TODO(zonr/srhines): allow bit fields of size 8, 16, 32
if (FD->isBitField()) {
+ // Context can be null from NormalizeType?
+ slangAssert(Context);
Context->ReportError(
FD->getLocation(),
"bit fields are not able to be exported: '%0.%1'")
@@ -415,6 +417,8 @@
case clang::Type::Enum: {
// FIXME: We currently convert enums to integers, rather than reflecting
// a more complete (and nicer type-safe Java version).
+ // Context can be null from NormalizeType?
+ slangAssert(Context);
return Context->getASTContext().IntTy.getTypePtr();
}
default: {
@@ -797,6 +801,8 @@
const clang::PointerType *P = static_cast<const clang::PointerType*>(CTI);
const clang::Type *PT = GetPointeeType(P);
llvm::StringRef PointeeName;
+ // Passing nullptr as Context to NormalizeType can cause TypeExportableHelper
+ // to dereference a null Context?
if (NormalizeType(PT, PointeeName, nullptr, nullptr,
NotLegacyKernelArgument)) {
char *Name = new char[ 1 /* * */ + PointeeName.size() + 1 ];
