commit 5f12f973dfc1baa98d484df269f8b251efcdccab
author Chih-hung Hsieh <chh@google.com> Fri Jul 13 22:45:44 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Fri Jul 13 22:45:44 2018 +0000
tree 475fc5dba555bec847e1b99b9e7a06a1122e4952
parent 2faac495b3b8ba3ecb9dbbdc45a5c490d061a840
parent 48b12a74ce0e19c00b70f34778acf8b01753e7cb

Merge "Fix unnecessary copy initialization warnings"

slang_rs_reflection_state.cpp

diff --git a/slang_rs_reflection_state.cpp b/slang_rs_reflection_state.cpp
index 8fa9411..9bc067a 100644
--- a/slang_rs_reflection_state.cpp
+++ b/slang_rs_reflection_state.cpp
@@ -257,7 +257,7 @@
     return;
 
   const bool IsKernel = EF->isKernelStyle();
-  const std::string Name = EF->getName();
+  const std::string& Name = EF->getName();
   const unsigned Ordinal = EF->getOrdinal();
   const size_t InCount = EF->getInTypes().size();
   const size_t ParamCount = EF->params_count();
@@ -573,7 +573,7 @@
   if (!isActive())
     return;
 
-  const std::string Name = EF->getName(/*Mangle=*/false);
+  const std::string& Name = EF->getName(/*Mangle=*/false);
   const size_t ParamCount = EF->getNumParameters();
 
   auto &invokables = mFiles.Current().mInvokables;
@@ -852,7 +852,7 @@
     if (mReducesOrderFatal)
       return;
 
-    const std::string Name = ER->getNameReduce();
+    const std::string& Name = ER->getNameReduce();
 
     if (reduces.isFinished()) {
       // This doesn't actually break reflection, but that's a