commit f87160eec0f693d7f8fb6c16c6e600919efb03c8
author Yasin Kilicdere <tyk@google.com> Fri May 13 00:31:05 2022 +0100
committer Yasin Kilicdere <tyk@google.com> Mon May 16 15:47:23 2022 +0100
tree 68b3f5dfd563bf7697a30ac83e0de01ab3313fe4
parent 8ade0d824cf5ffd57ad89e5b6b3f40381e700149

Puts mPm.onNewUserCreated inside Binder.withCleanCallingIdentity

PackageManagerService.onNewUserCreated eventually calls
ComputerEngine.getInstalledPackages. And it requires callingUid to have
INTERACT_ACROSS_USERS permission. That was failing some tests for auto.
This CL makes sure that method is called with clean calling identity.

Bug: 228253821
Test: atest CtsMultiUserTestCases:android.multiuser.cts.UserManagerTest#testCreateUser_withNewUserRequest_shouldCreateUserWithCorrectProperties
Change-Id: Ia06b9d5e6501140541e8d520350368df1abe2f15

services/core/java/com/android/server/pm/UserManagerService.java

diff --git a/services/core/java/com/android/server/pm/UserManagerService.java b/services/core/java/com/android/server/pm/UserManagerService.java
index bcdf429..fcdab88 100644
--- a/services/core/java/com/android/server/pm/UserManagerService.java
+++ b/services/core/java/com/android/server/pm/UserManagerService.java
@@ -4207,7 +4207,9 @@
             writeUserListLP();
         }
         updateUserIds();
-        mPm.onNewUserCreated(preCreatedUser.id, /* convertedFromPreCreated= */ true);
+        Binder.withCleanCallingIdentity(() -> {
+            mPm.onNewUserCreated(preCreatedUser.id, /* convertedFromPreCreated= */ true);
+        });
         dispatchUserAdded(preCreatedUser, token);
         return preCreatedUser;
     }