commit b9be4d4dc8c10a48f5658882b639dd22850fc6b1
author Stanislav Zholnin <zholnin@google.com> Mon Jun 28 17:36:29 2021 +0100
committer Stanislav Zholnin <zholnin@google.com> Mon Jun 28 20:11:50 2021 +0000
tree 8dfba6cfdc5ae43397af467e1d50e8497d4103c5
parent f8d2743dd586ccf3f3839f94edb7bed82b4f5f3d

Make getHistoricalOps() properly handle multi-user functionality.

Correct callingUid check in getHistoricalOps() API call so that
PermissionController requests coming from any user on device
were handled properly.

Test: manually verified
Fix: 186871955
Change-Id: I667899ea8e656dd1a7ac974a28bfe5c5d84f5f54

services/core/java/com/android/server/appop/AppOpsService.java

diff --git a/services/core/java/com/android/server/appop/AppOpsService.java b/services/core/java/com/android/server/appop/AppOpsService.java
index 55ed0d6..1eb7154 100644
--- a/services/core/java/com/android/server/appop/AppOpsService.java
+++ b/services/core/java/com/android/server/appop/AppOpsService.java
@@ -2341,8 +2341,9 @@
             boolean isCallerSystem = Binder.getCallingPid() == Process.myPid();
             boolean isCallerPermissionController;
             try {
-                isCallerPermissionController = pm.getPackageUid(
-                        mContext.getPackageManager().getPermissionControllerPackageName(), 0)
+                isCallerPermissionController = pm.getPackageUidAsUser(
+                        mContext.getPackageManager().getPermissionControllerPackageName(), 0,
+                        UserHandle.getUserId(Binder.getCallingUid()))
                         == Binder.getCallingUid();
             } catch (PackageManager.NameNotFoundException doesNotHappen) {
                 return;