blob: 86bab4d11c7150fb98ef7453f6c9b7d396909ddb [file]
/*
* Copyright (C) 2024 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.systemfeatures;
import static com.google.common.truth.Truth.assertThat;
import static org.mockito.Mockito.anyInt;
import static org.mockito.Mockito.anyString;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import android.content.Context;
import android.content.pm.FeatureInfo;
import android.content.pm.PackageManager;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnit;
import org.mockito.junit.MockitoRule;
import java.io.File;
import java.io.IOException;
import java.nio.file.Files;
import java.util.Map;
@RunWith(JUnit4.class)
public class SystemFeaturesGeneratorTest {
@Rule public final MockitoRule mockito = MockitoJUnit.rule();
@Rule public final TemporaryFolder mTemporaryFolder = new TemporaryFolder();
@Mock private Context mContext;
@Mock private PackageManager mPackageManager;
@Before
public void setUp() {
when(mContext.getPackageManager()).thenReturn(mPackageManager);
}
@Test
public void testReadonlyDisabledNoDefinedFeatures() {
// Always report null for conditional queries if readonly codegen is disabled.
assertThat(RwNoFeatures.maybeHasFeature(PackageManager.FEATURE_WATCH, 0)).isNull();
assertThat(RwNoFeatures.maybeHasFeature(PackageManager.FEATURE_WIFI, 0)).isNull();
assertThat(RwNoFeatures.maybeHasFeature(PackageManager.FEATURE_VULKAN, 0)).isNull();
assertThat(RwNoFeatures.maybeHasFeature(PackageManager.FEATURE_AUTO, 0)).isNull();
assertThat(RwNoFeatures.maybeHasFeature("com.arbitrary.feature", 0)).isNull();
assertThat(RwNoFeatures.getReadOnlySystemEnabledFeatures()).isEmpty();
assertThat(RwNoFeatures.maybeHasFeature("", 0)).isNull();
assertThat(RwNoFeatures.maybeHasFeature(null, 0)).isNull();
}
@Test
public void testReadonlyNoDefinedFeatures() {
// If no features are explicitly declared as readonly available, always report
// null for conditional queries.
assertThat(RoNoFeatures.maybeHasFeature(PackageManager.FEATURE_WATCH, 0)).isNull();
assertThat(RoNoFeatures.maybeHasFeature(PackageManager.FEATURE_WIFI, 0)).isNull();
assertThat(RoNoFeatures.maybeHasFeature(PackageManager.FEATURE_VULKAN, 0)).isNull();
assertThat(RoNoFeatures.maybeHasFeature(PackageManager.FEATURE_AUTO, 0)).isNull();
assertThat(RoNoFeatures.maybeHasFeature("com.arbitrary.feature", 0)).isNull();
assertThat(RwNoFeatures.maybeHasFeature("", 0)).isNull();
assertThat(RwNoFeatures.maybeHasFeature(null, 0)).isNull();
assertThat(RoNoFeatures.getReadOnlySystemEnabledFeatures()).isEmpty();
// Also ensure we fall back to the PackageManager for feature APIs without an accompanying
// versioned feature definition.
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_WATCH)).thenReturn(true);
assertThat(RwFeatures.hasFeatureWatch(mContext)).isTrue();
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_WATCH)).thenReturn(false);
assertThat(RwFeatures.hasFeatureWatch(mContext)).isFalse();
}
@Test
public void testReadonlyDisabledWithDefinedFeatures() {
// Always fall back to the PackageManager for defined, explicit features queries.
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_WATCH)).thenReturn(true);
assertThat(RwFeatures.hasFeatureWatch(mContext)).isTrue();
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_WATCH)).thenReturn(false);
assertThat(RwFeatures.hasFeatureWatch(mContext)).isFalse();
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_WIFI)).thenReturn(true);
assertThat(RwFeatures.hasFeatureWifi(mContext)).isTrue();
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_VULKAN)).thenReturn(false);
assertThat(RwFeatures.hasFeatureVulkan(mContext)).isFalse();
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_AUTO)).thenReturn(false);
assertThat(RwFeatures.hasFeatureAuto(mContext)).isFalse();
// For defined and undefined features, conditional queries should report null (unknown).
assertThat(RwFeatures.maybeHasFeature(PackageManager.FEATURE_WATCH, 0)).isNull();
assertThat(RwFeatures.maybeHasFeature(PackageManager.FEATURE_WIFI, 0)).isNull();
assertThat(RwFeatures.maybeHasFeature(PackageManager.FEATURE_VULKAN, 0)).isNull();
assertThat(RwFeatures.maybeHasFeature(PackageManager.FEATURE_AUTO, 0)).isNull();
assertThat(RwFeatures.maybeHasFeature("com.arbitrary.feature", 0)).isNull();
assertThat(RwFeatures.getReadOnlySystemEnabledFeatures()).isEmpty();
}
@Test
public void testReadonlyWithDefinedFeatures() {
// Always use the build-time feature version for defined, explicit feature queries, never
// falling back to the runtime query.
assertThat(RoFeatures.hasFeatureWatch(mContext)).isTrue();
assertThat(RoFeatures.hasFeatureWifi(mContext)).isTrue();
assertThat(RoFeatures.hasFeatureVulkan(mContext)).isFalse();
verify(mPackageManager, never()).hasSystemFeature(anyString(), anyInt());
// For defined feature types, conditional queries should reflect either:
// * Enabled if the feature version is specified
// * Disabled if UNAVAILABLE is specified
// * Unknown if no version value is provided
// VERSION=1
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_WATCH, -1)).isTrue();
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_WATCH, 0)).isTrue();
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_WATCH, 100)).isFalse();
// VERSION=0
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_WIFI, -1)).isTrue();
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_WIFI, 0)).isTrue();
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_WIFI, 100)).isFalse();
// VERSION=UNAVAILABLE
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_VULKAN, -1)).isFalse();
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_VULKAN, 0)).isFalse();
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_VULKAN, 100)).isFalse();
// VERSION=
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_AUTO)).thenReturn(false);
assertThat(RoFeatures.hasFeatureAuto(mContext)).isFalse();
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_AUTO)).thenReturn(true);
assertThat(RoFeatures.hasFeatureAuto(mContext)).isTrue();
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_AUTO, -1)).isNull();
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_AUTO, 0)).isNull();
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_AUTO, 100)).isNull();
// For feature APIs without an associated feature definition, conditional queries should
// report null, and explicit queries should report runtime-defined versions.
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_PC)).thenReturn(true);
assertThat(RoFeatures.hasFeaturePc(mContext)).isTrue();
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_PC)).thenReturn(false);
assertThat(RoFeatures.hasFeaturePc(mContext)).isFalse();
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_PC, -1)).isNull();
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_PC, 0)).isNull();
assertThat(RoFeatures.maybeHasFeature(PackageManager.FEATURE_PC, 100)).isNull();
// For undefined types, conditional queries should report null (unknown).
assertThat(RoFeatures.maybeHasFeature("com.arbitrary.feature", -1)).isNull();
assertThat(RoFeatures.maybeHasFeature("com.arbitrary.feature", 0)).isNull();
assertThat(RoFeatures.maybeHasFeature("com.arbitrary.feature", 100)).isNull();
assertThat(RoFeatures.maybeHasFeature("", 0)).isNull();
assertThat(RoFeatures.maybeHasFeature(null, 0)).isNull();
Map<String, FeatureInfo> compiledFeatures = RoFeatures.getReadOnlySystemEnabledFeatures();
assertThat(compiledFeatures.keySet())
.containsExactly(PackageManager.FEATURE_WATCH, PackageManager.FEATURE_WIFI);
assertThat(compiledFeatures.get(PackageManager.FEATURE_WATCH).version).isEqualTo(1);
assertThat(compiledFeatures.get(PackageManager.FEATURE_WIFI).version).isEqualTo(0);
}
@Test
public void testReadonlyDisabledWithDefinedFeaturesFromXml() {
// Always fall back to the PackageManager for defined, explicit features queries.
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_BLUETOOTH)).thenReturn(true);
assertThat(RwFeaturesFromXml.hasFeatureBluetooth(mContext)).isTrue();
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_EMBEDDED)).thenReturn(true);
assertThat(RwFeaturesFromXml.hasFeatureEmbedded(mContext)).isTrue();
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_PC)).thenReturn(false);
assertThat(RwFeaturesFromXml.hasFeatureWatch(mContext)).isFalse();
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_WATCH)).thenReturn(false);
assertThat(RwFeaturesFromXml.hasFeatureWatch(mContext)).isFalse();
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_WIFI)).thenReturn(true);
assertThat(RwFeaturesFromXml.hasFeatureWifi(mContext)).isTrue();
// For defined and undefined features, conditional queries should report null (unknown).
assertThat(RwFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_BLUETOOTH, 0)).isNull();
assertThat(RwFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_EMBEDDED, 0)).isNull();
assertThat(RwFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_PC, 0)).isNull();
assertThat(RwFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_WATCH, 0)).isNull();
assertThat(RwFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_WIFI, 0)).isNull();
assertThat(RwFeaturesFromXml.maybeHasFeature("com.arbitrary.feature", 0)).isNull();
assertThat(RwFeaturesFromXml.getReadOnlySystemEnabledFeatures()).isEmpty();
}
@Test
public void testReadonlyWithDefinedFeaturesFromXml() {
// Always use the build-time feature version for defined, explicit feature queries, never
// falling back to the runtime query.
assertThat(RoFeaturesFromXml.hasFeatureEmbedded(mContext)).isTrue();
assertThat(RoFeaturesFromXml.hasFeaturePc(mContext)).isFalse();
assertThat(RoFeaturesFromXml.hasFeatureWatch(mContext)).isFalse();
assertThat(RoFeaturesFromXml.hasFeatureWifi(mContext)).isTrue();
verify(mPackageManager, never()).hasSystemFeature(anyString(), anyInt());
// For defined feature types from XML, conditional queries should reflect either:
// * Disabled if the feature was *ever* declared w/ <unavailable-feature />
// * Enabled if the feature was otherwise declared w/ <feature />
// * Unknown for features conditionally enabled on non-low-ram devices (notLowRam="true").
// * Unknown for non platform-defined (custom) features.
// <feature version="1" />
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_EMBEDDED, -1)).isTrue();
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_EMBEDDED, 0)).isTrue();
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_EMBEDDED, 2)).isFalse();
// <feature />
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_WIFI, -1)).isTrue();
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_WIFI, 0)).isTrue();
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_WIFI, 100)).isFalse();
// <unavailable-feature />
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_PC, -1)).isFalse();
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_PC, 0)).isFalse();
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_PC, 100)).isFalse();
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_WATCH, -1)).isFalse();
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_WATCH, 0)).isFalse();
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_WATCH, 100)).isFalse();
// <feature notLowRam="true" />
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_BLUETOOTH, -1))
.isNull();
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_BLUETOOTH, 0)).isNull();
assertThat(RoFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_BLUETOOTH, 100))
.isNull();
// For custom/undefined feature types, conditional queries should report null (unknown).
assertThat(RoFeaturesFromXml.maybeHasFeature("com.arbitrary.feature", -1)).isNull();
assertThat(RoFeaturesFromXml.maybeHasFeature("com.arbitrary.feature", 0)).isNull();
assertThat(RoFeaturesFromXml.maybeHasFeature("com.arbitrary.feature", 100)).isNull();
assertThat(RoFeaturesFromXml.maybeHasFeature("", 0)).isNull();
assertThat(RoFeaturesFromXml.maybeHasFeature(null, 0)).isNull();
Map<String, FeatureInfo> compiledFeatures =
RoFeaturesFromXml.getReadOnlySystemEnabledFeatures();
assertThat(compiledFeatures.keySet())
.containsExactly(PackageManager.FEATURE_EMBEDDED, PackageManager.FEATURE_WIFI);
assertThat(compiledFeatures.get(PackageManager.FEATURE_EMBEDDED).version).isEqualTo(1);
assertThat(compiledFeatures.get(PackageManager.FEATURE_WIFI).version).isEqualTo(0);
}
@Test
public void testReadonlyWithUnavailableFeaturesFromXml() {
// Always use the build-time feature version for explicit feature queries for unavailable
// features, never falling back to the runtime query.
assertThat(RoUnavailableFeaturesFromXml.hasFeaturePc(mContext)).isFalse();
assertThat(RoUnavailableFeaturesFromXml.hasFeatureWatch(mContext)).isFalse();
verify(mPackageManager, never()).hasSystemFeature(anyString(), anyInt());
// When parsing only unavailable feature types from XML, conditional queries should reflect:
// * Disabled if the feature was *ever* declared w/ <unavailable-feature />
// * Unknown otherwise.
// <unavailable-feature />
assertThat(RoUnavailableFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_PC, 0))
.isFalse();
assertThat(RoUnavailableFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_WATCH, 0))
.isFalse();
// For other feature types, conditional queries should report null (unknown).
assertThat(
RoUnavailableFeaturesFromXml.maybeHasFeature(
PackageManager.FEATURE_BLUETOOTH, 0))
.isNull();
assertThat(RoUnavailableFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_EMBEDDED, 0))
.isNull();
assertThat(RoUnavailableFeaturesFromXml.maybeHasFeature(PackageManager.FEATURE_WIFI, 0))
.isNull();
assertThat(RoUnavailableFeaturesFromXml.maybeHasFeature("com.arbitrary.feature", 0))
.isNull();
assertThat(RoUnavailableFeaturesFromXml.maybeHasFeature("", 0)).isNull();
assertThat(RoUnavailableFeaturesFromXml.getReadOnlySystemEnabledFeatures()).isEmpty();
}
@Test
public void testGenerateProguardRules() throws IOException {
File proguardRulesFile = mTemporaryFolder.newFile("proguard-rules.pro");
String[] args =
new String[] {
"com.android.systemfeatures.RoFeatures",
"--readonly=true",
"--feature=WATCH:1",
"--feature=WIFI:0",
"--feature=VULKAN:UNAVAILABLE",
"--feature=AUTO:",
"--output-proguard-rules=" + proguardRulesFile.getAbsolutePath()
};
SystemFeaturesGenerator.generate(args, new StringBuilder());
// While we could test individual lines for the generated rules, we also want to ensure it's
// sorted alphabetically for stability of output.
String content = Files.readString(proguardRulesFile.toPath());
String expectedOutput =
"""
-assumevalues class android.content.pm.PackageManager {
public boolean hasSystemFeature(java.lang.String = android.content.pm.PackageManager.FEATURE_VULKAN) return false;
public boolean hasSystemFeature(java.lang.String = android.content.pm.PackageManager.FEATURE_VULKAN, int) return false;
public boolean hasSystemFeature(java.lang.String = android.content.pm.PackageManager.FEATURE_WATCH) return true;
public boolean hasSystemFeature(java.lang.String = android.content.pm.PackageManager.FEATURE_WATCH, int = -2147483648..1) return true;
public boolean hasSystemFeature(java.lang.String = android.content.pm.PackageManager.FEATURE_WIFI) return true;
public boolean hasSystemFeature(java.lang.String = android.content.pm.PackageManager.FEATURE_WIFI, int = -2147483648..0) return true;
}
""";
assertThat(content.trim()).isEqualTo(expectedOutput.trim());
}
@Test
public void testGenerateProguardRulesNoReadonlyFeatures() throws IOException {
File proguardRulesFile = mTemporaryFolder.newFile("proguard-rules.pro");
String[] args =
new String[] {
"com.android.systemfeatures.RwFeatures",
"--readonly=false",
"--feature=WIFI:0",
"--feature=VULKAN:UNAVAILABLE",
"--output-proguard-rules=" + proguardRulesFile.getAbsolutePath()
};
SystemFeaturesGenerator.generate(args, new StringBuilder());
// If there are no read-only features, the generated proguard output should either be empty
// or consist entirely of comments.
assertThat(
Files.readAllLines(proguardRulesFile.toPath()).stream()
.map(String::trim)
.filter(line -> !line.isEmpty() && !line.startsWith("#")))
.isEmpty();
}
}