commit 20d6caf8888d4114b6ce79d93c7c9cf903ad8c22
author Jean-Baptiste Queru <jbq@google.com> Mon Jun 18 08:53:18 2012 -0700
committer android code review <noreply-gerritcodereview@google.com> Mon Jun 18 08:53:18 2012 -0700
tree ebe3e0949b50622633467b228527dd518a0ef875
parent 0cf342184e030ee6f65d87eeba48484725910a8b
parent bbf7b4cdcfbc5aa436500dad96e73f7a3b32e794

Merge "Fix issue #13366. Take account of stackFromBottom in computeVerticalScrollOffset()."

core/java/android/widget/GridView.java

diff --git a/core/java/android/widget/GridView.java b/core/java/android/widget/GridView.java
index 5d406de..428af836 100644
--- a/core/java/android/widget/GridView.java
+++ b/core/java/android/widget/GridView.java
@@ -2095,8 +2095,13 @@
             int height = view.getHeight();
             if (height > 0) {
                 final int numColumns = mNumColumns;
-                final int whichRow = mFirstPosition / numColumns;
                 final int rowCount = (mItemCount + numColumns - 1) / numColumns;
+                // In case of stackFromBottom the calculation of whichRow needs
+                // to take into account that counting from the top the first row
+                // might not be entirely filled.
+                final int oddItemsOnFirstRow = isStackFromBottom() ? ((rowCount * numColumns) -
+                        mItemCount) : 0;
+                final int whichRow = (mFirstPosition + oddItemsOnFirstRow) / numColumns;
                 return Math.max(whichRow * 100 - (top * 100) / height +
                         (int) ((float) mScrollY / getHeight() * rowCount * 100), 0);
             }