commit a98e4512dfc00ebb5183451e14af313add96f668
author Svetoslav Ganov <svetoslavganov@google.com> Thu Jun 30 23:28:58 2016 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Thu Jun 30 23:28:59 2016 +0000
tree d49f2c047f9a2a49e8bdcfeee543f8c95ece9abc
parent 486c76b5efa8824c1a9460bad13000bf7d1697a7
parent 7709041c99a213af4209fba08f6cb5acc3387307

Merge "Removed warning when objects are added on wrong order." into nyc-dev

core/java/android/util/ArraySet.java

diff --git a/core/java/android/util/ArraySet.java b/core/java/android/util/ArraySet.java
index d39e91f..1e765b6 100644
--- a/core/java/android/util/ArraySet.java
+++ b/core/java/android/util/ArraySet.java
@@ -402,11 +402,14 @@
             throw new IllegalStateException("Array is full");
         }
         if (index > 0 && mHashes[index - 1] > hash) {
-            RuntimeException e = new RuntimeException("here");
-            e.fillInStackTrace();
-            Log.w(TAG, "New hash " + hash
-                    + " is before end of array hash " + mHashes[index - 1]
-                    + " at index " + index, e);
+            // Cannot optimize since it would break the sorted order - fallback to add()
+            if (DEBUG) {
+                RuntimeException e = new RuntimeException("here");
+                e.fillInStackTrace();
+                Log.w(TAG, "New hash " + hash
+                        + " is before end of array hash " + mHashes[index - 1]
+                        + " at index " + index, e);
+            }
             add(value);
             return;
         }