commit 9a56bb838c099a318d4f961f290d324ed5f1949d
author Andrei Popescu <andreip@google.com> Wed Jul 22 19:21:48 2009 +0100
committer Andrei Popescu <andreip@google.com> Wed Jul 22 19:21:48 2009 +0100
tree c378065c3bf20820e72ea0c36f996816f7448772
parent bc4aa5f6935bb91aab3f9913e460771f2f012f8d

cleanup the WebStorage Java class. There were too many calls to syncValues().

core/java/android/webkit/WebStorage.java

diff --git a/core/java/android/webkit/WebStorage.java b/core/java/android/webkit/WebStorage.java
index 7522b5a5..1a60dba 100644
--- a/core/java/android/webkit/WebStorage.java
+++ b/core/java/android/webkit/WebStorage.java
@@ -51,8 +51,9 @@
     // Global instance of a WebStorage
     private static WebStorage sWebStorage;
 
-    // We keep a copy of the origins, quotas and usages
-    // that we protect via a lock and update in syncValues()
+    // We keep the origins, quotas and usages as member values
+    // that we protect via a lock and update in syncValues().
+    // This is needed to transfer this data across threads.
     private static Lock mLock = new ReentrantLock();
     private static Condition mCacheUpdated = mLock.newCondition();
 
@@ -104,18 +105,15 @@
                             Origin website = (Origin) msg.obj;
                             nativeSetQuotaForOrigin(website.getOrigin(),
                                                     website.getQuota());
-                            syncValues();
                             } break;
 
                         case DELETE_ORIGIN: {
                             Origin website = (Origin) msg.obj;
                             nativeDeleteOrigin(website.getOrigin());
-                            syncValues();
                             } break;
 
                         case DELETE_ALL:
                             nativeDeleteAllData();
-                            syncValues();
                             break;
 
                         case UPDATE:
@@ -204,7 +202,6 @@
         if (origin != null) {
             if (WebViewCore.THREAD_NAME.equals(Thread.currentThread().getName())) {
                 nativeSetQuotaForOrigin(origin, quota);
-                syncValues();
             } else {
                 postMessage(Message.obtain(null, SET_QUOTA_ORIGIN,
                     new Origin(origin, quota)));
@@ -220,7 +217,6 @@
         if (origin != null) {
             if (WebViewCore.THREAD_NAME.equals(Thread.currentThread().getName())) {
                 nativeDeleteOrigin(origin);
-                syncValues();
             } else {
                 postMessage(Message.obtain(null, DELETE_ORIGIN,
                     new Origin(origin)));
@@ -235,7 +231,6 @@
     public void deleteAllData() {
         if (WebViewCore.THREAD_NAME.equals(Thread.currentThread().getName())) {
             nativeDeleteAllData();
-            syncValues();
         } else {
             postMessage(Message.obtain(null, DELETE_ALL));
         }
@@ -276,7 +271,7 @@
 
     /**
      * Run on the webcore thread
-     * sync the local cached values with the real ones
+     * set the local values with the current ones
      */
     private void syncValues() {
         mLock.lock();