commit 74fcc57ec427bf0a034c7b2a31678b8638a7ec02
author Alex Buynytskyy <alexbuy@google.com> Tue Sep 22 11:39:53 2020 -0700
committer Alex Buynytskyy <alexbuy@google.com> Wed Sep 23 18:17:40 2020 +0000
tree 538d0020554be3dd577c15ab85d56421492c1ec1
parent b2bf4c16d163eec67a0a0248d9bb9d836ff3fa84

Excessive battery usage fix.

Using wake to forcefully wake up the looper instead of 1s timeout.

Bug: 168156055
Test: atest ApkVerityTest:com.android.apkverity.ApkVerityTest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest ChecksumsTest
Change-Id: If65f65f9214b34bf057ed5f1877348d835251d14

services/incremental/IncrementalService.cpp

diff --git a/services/incremental/IncrementalService.cpp b/services/incremental/IncrementalService.cpp
index a5f0d04..e355a20 100644
--- a/services/incremental/IncrementalService.cpp
+++ b/services/incremental/IncrementalService.cpp
@@ -306,6 +306,7 @@
     }
     mJobCondition.notify_all();
     mJobProcessor.join();
+    mLooper->wake();
     mCmdLooperThread.join();
     mTimedQueue->stop();
     // Ensure that mounts are destroyed while the service is still valid.
@@ -1378,7 +1379,7 @@
 }
 
 void IncrementalService::runCmdLooper() {
-    constexpr auto kTimeoutMsecs = 1000;
+    constexpr auto kTimeoutMsecs = -1;
     while (mRunning.load(std::memory_order_relaxed)) {
         mLooper->pollAll(kTimeoutMsecs);
     }