commit 6e9768e9023b11e565a86e3590abbf53a244d7e7
author Yohei Yukawa <yukawa@google.com> Thu May 14 18:14:24 2020 -0700
committer Yohei Yukawa <yukawa@google.com> Thu May 14 18:14:24 2020 -0700
tree d8a04e28a18401fd862a82c501e7353d74945c8d
parent 8c211a713b538c83f686611b9c85683e82c38203

Make sure to call SomeArgs#recycle() in IMMS#handleMessage

This is a small follow up CL to our previous CL [1], which added a new
internal message MSG_INLINE_SUGGESTIONS_REQUEST and its handler that
rely on SomeArgs but forget to call SomeArgs#recycle().

Although not calling SomeArgs#recycle() doesn't immediately cause any
fatal issue, not doing so basically spoils the purpose of SomeArgs.
With this CL, InputMethodManagerService#handleMessage should call
SomeArgs#recycle() when necessary.

Other than that there is no behavior change.

 [1]: Id222500c373898d576661cacb7a1cb51061041d4
      bc67f2e15813ec05c07f18ef961e7303fd344ff1

Bug: 147037345
Test: atest CtsAutoFillServiceTestCases
Change-Id: I763bb78c7d1ada327abaa110d423309b17d831d8

services/core/java/com/android/server/inputmethod/InputMethodManagerService.java

diff --git a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
index 6efc88e..93ef1264 100644
--- a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
+++ b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
@@ -4262,7 +4262,7 @@
             }
 
             // ---------------------------------------------------------------
-            case MSG_INLINE_SUGGESTIONS_REQUEST:
+            case MSG_INLINE_SUGGESTIONS_REQUEST: {
                 args = (SomeArgs) msg.obj;
                 final InlineSuggestionsRequestInfo requestInfo =
                         (InlineSuggestionsRequestInfo) args.arg2;
@@ -4274,7 +4274,9 @@
                 } catch (RemoteException e) {
                     Slog.w(TAG, "RemoteException calling onCreateInlineSuggestionsRequest(): " + e);
                 }
+                args.recycle();
                 return true;
+            }
         }
         return false;
     }