commit 6157de0e2d87568d6d5071b11aeb033a7986b279
author Chih-Chung Chang <chihchung@google.com> Thu Sep 24 15:29:35 2009 -0700
committer Chih-Chung Chang <chihchung@google.com> Thu Sep 24 15:38:18 2009 -0700
tree 58282c094ff3f2337ecb0f9fe317dc4191552a5f
parent a30071273a8ee59b300eebe515db86f9070ab4a4

Fix 2101425: Camera crashes spontaneously in preview.

The problem is we missed an "obj" parameter while calling
postEventFromNative (which put it in a field of a Message object),
so a garbage value on stack is used.

When the GC tries to follow that "obj" field, expecting to find
another object, it crashes.

core/jni/android_hardware_Camera.cpp

diff --git a/core/jni/android_hardware_Camera.cpp b/core/jni/android_hardware_Camera.cpp
index 6b92994..e944654 100644
--- a/core/jni/android_hardware_Camera.cpp
+++ b/core/jni/android_hardware_Camera.cpp
@@ -112,7 +112,7 @@
     }
     JNIEnv *env = AndroidRuntime::getJNIEnv();
     env->CallStaticVoidMethod(mCameraJClass, fields.post_event,
-            mCameraJObjectWeak, msgType, ext1, ext2);
+            mCameraJObjectWeak, msgType, ext1, ext2, NULL);
 }
 
 void JNICameraContext::copyAndPost(JNIEnv* env, const sp<IMemory>& dataPtr, int msgType)