commit 57d89899c9fb978a1c097f298aa94c5db1f61bb6
author Mathias Agopian <mathias@google.com> Fri May 21 14:51:33 2010 -0700
committer Mathias Agopian <mathias@google.com> Mon May 24 13:47:24 2010 -0700
tree 85e1c021f67a2fdb5ed33547872a769b7d55fba6
parent 884372842bac11f854aa42a9c4de05a3a22cb11f

fix a bug when reallocating a window's buffers is needed

we need to mark the buffers that need to be reallocated,
NOT the buffer's indices.

Change-Id: I809e2e1b03b56c4d2ab983c25523dae99aa1da74

include/private/surfaceflinger/SharedBufferStack.h

diff --git a/include/private/surfaceflinger/SharedBufferStack.h b/include/private/surfaceflinger/SharedBufferStack.h
index c3ac317..de54870 100644
--- a/include/private/surfaceflinger/SharedBufferStack.h
+++ b/include/private/surfaceflinger/SharedBufferStack.h
@@ -303,6 +303,7 @@
             : mCapacity(c), mList(0) { }
         status_t add(int value);
         status_t remove(int value);
+        uint32_t getMask() const { return mList; }
 
         class const_iterator {
             friend class BufferList;

libs/surfaceflinger_client/SharedBufferStack.cpp

diff --git a/libs/surfaceflinger_client/SharedBufferStack.cpp b/libs/surfaceflinger_client/SharedBufferStack.cpp
index e2e1591..8681b59 100644
--- a/libs/surfaceflinger_client/SharedBufferStack.cpp
+++ b/libs/surfaceflinger_client/SharedBufferStack.cpp
@@ -440,7 +440,7 @@
 bool SharedBufferClient::needNewBuffer(int buf) const
 {
     SharedBufferStack& stack( *mSharedStack );
-    const uint32_t mask = 1<<buf;
+    const uint32_t mask = 1<<(31-buf);
     return (android_atomic_and(~mask, &stack.reallocMask) & mask) != 0;
 }
 
@@ -532,7 +532,7 @@
     RWLock::AutoRLock _l(mLock);
 
     SharedBufferStack& stack( *mSharedStack );
-    uint32_t mask = (1<<mNumBuffers)-1;
+    uint32_t mask = mBufferList.getMask();
     android_atomic_or(mask, &stack.reallocMask); 
     return NO_ERROR;
 }