Remove appLayerReplacesLauncher test from transfer splash screen test.

The splash screen layer can overlay with app window, so actually the
"ignoreSplashscreen" parameter should be true, and better to set
isOptional to false in isSplashScreenVisibleFor. But while using
SurfaceView to draw splash screen icon, not every layer need to be
visible, so it won't pass isSplashScreenVisibleFor assert.
Overall, seems appWindowAfterSplash can cover the original purpose
of this test, so remove appLayerReplacesLauncher for transfer splash
screen test.

Bug: 307366441
Test: atest OpenTransferSplashscreenAppFromLauncherTransition
Change-Id: If4820f8fa7cdfaf2b7a6f7b4eb24b3a818acc101
diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/launch/common/OpenTransferSplashscreenAppFromLauncherTransition.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/launch/common/OpenTransferSplashscreenAppFromLauncherTransition.kt
index 17f7490..97ba99e 100644
--- a/tests/FlickerTests/src/com/android/server/wm/flicker/launch/common/OpenTransferSplashscreenAppFromLauncherTransition.kt
+++ b/tests/FlickerTests/src/com/android/server/wm/flicker/launch/common/OpenTransferSplashscreenAppFromLauncherTransition.kt
@@ -24,7 +24,6 @@
 import androidx.test.filters.FlakyTest
 import androidx.test.filters.RequiresDevice
 import com.android.server.wm.flicker.helpers.TransferSplashscreenAppHelper
-import com.android.server.wm.flicker.replacesLayer
 import org.junit.FixMethodOrder
 import org.junit.Test
 import org.junit.runner.RunWith
@@ -119,18 +118,6 @@
 
     @FlakyTest(bugId = 240916028)
     @Test
-    override fun appLayerReplacesLauncher() {
-        flicker.replacesLayer(
-            ComponentNameMatcher.LAUNCHER,
-            testApp,
-            ignoreEntriesWithRotationLayer = true,
-            ignoreSnapshot = true,
-            ignoreSplashscreen = false
-        )
-    }
-
-    @FlakyTest(bugId = 240916028)
-    @Test
     override fun cujCompleted() {
         super.cujCompleted()
     }