commit 3d7e855df3e8556b311ef3900990047554aaa0e5
author Suchi Amalapurapu <asuchitra@google.com> Thu Sep 17 15:38:20 2009 -0700
committer Suchi Amalapurapu <asuchitra@google.com> Thu Sep 17 16:30:14 2009 -0700
tree 21e294b6c263f661be5f2174f5314e6b605494dd
parent 7805933738de33b1961bd03553237a86d90792dd

Check if rename of current settings file was successful before persisting
new changes to settings.

services/java/com/android/server/PackageManagerService.java

diff --git a/services/java/com/android/server/PackageManagerService.java b/services/java/com/android/server/PackageManagerService.java
index 45e0ceb..323a11f 100644
--- a/services/java/com/android/server/PackageManagerService.java
+++ b/services/java/com/android/server/PackageManagerService.java
@@ -6376,7 +6376,10 @@
                 if (mBackupSettingsFilename.exists()) {
                     mBackupSettingsFilename.delete();
                 }
-                mSettingsFilename.renameTo(mBackupSettingsFilename);
+                if (!mSettingsFilename.renameTo(mBackupSettingsFilename)) {
+                    Log.w(TAG, "Unable to backup package manager settings, current changes will be lost at reboot");
+                    return;
+                }
             }
 
             mPastSignatures.clear();