commit 2d0c7b02bc2e6e8393331f92d0e560abd786bde2
author Matt Pietal <mpietal@google.com> Thu Jun 18 12:16:56 2020 -0400
committer Matt Pietal <mpietal@google.com> Thu Jun 18 12:16:56 2020 -0400
tree b28d9ebb075ff166c522a4e5fe4b335e795fa416
parent 35e288c6c6b523d8953048e7f3aa8357c47cb4a3

Resolver/Chooser - Fix reuse of textview

Upon reuse of a view by the recyclerview, it was possible to show a
reused view's sublabel, as it was doing incorrect comparisons. Make
sure to always reset the textviews, and hide it if necessary.

Fixes: 150813955
Test: manual, but helpful to have many apps installed and launch the sharesheet
Change-Id: Idb0c03c0b0917104bd9f26cdd9ed33a0055fa6f2

core/java/com/android/internal/app/ResolverListAdapter.java

diff --git a/core/java/com/android/internal/app/ResolverListAdapter.java b/core/java/com/android/internal/app/ResolverListAdapter.java
index 04a186c..094fb1e 100644
--- a/core/java/com/android/internal/app/ResolverListAdapter.java
+++ b/core/java/com/android/internal/app/ResolverListAdapter.java
@@ -689,17 +689,17 @@
         }
 
         public void bindLabel(CharSequence label, CharSequence subLabel, boolean showSubLabel) {
-            if (!TextUtils.equals(text.getText(), label)) {
-                text.setText(label);
-            }
+            text.setText(label);
 
             if (TextUtils.equals(label, subLabel)) {
-                subLabel = "";
+                subLabel = null;
             }
 
-            if (showSubLabel || !TextUtils.equals(text2.getText(), subLabel)) {
+            text2.setText(subLabel);
+            if (showSubLabel || subLabel != null) {
                 text2.setVisibility(View.VISIBLE);
-                text2.setText(subLabel);
+            } else {
+                text2.setVisibility(View.GONE);
             }
 
             itemView.setContentDescription(null);