commit 1c509615592635ed1551901915ab63b5cc80f8c7
author Sudheer Shanka <sudheersai@google.com> Thu Sep 24 15:51:24 2020 -0700
committer Sudheer Shanka <sudheersai@google.com> Fri Sep 25 04:42:08 2020 +0000
tree cb833e1551b5c28c80bfc5f7c127c7d8fae7e24c
parent d6af5b5d1e5986c2d63dfc89d996c899416cf9f8

Disable use of RevocableFileDescriptor for blob reads.

We are using RevocableFileDescriptor as a precaution
to make sure when blobs get deleted, apps are not
holding onto those fds and preventing disk space from
getting freed but this might not be much
of a concern since non-system apps cannot be
persistent (so they eventually gets killed) and apps
can already fill up disk space if they want and given
that we are seeing issues with fuse reads, disabling
the use of RevocableFileDescriptor for blob reads.

Bug: 162662834
Test: atest --test-mapping apex/blobstore
Change-Id: I13a504fac154e2a3cacfb37e83a9cfec4ae80b63

apex/blobstore/service/java/com/android/server/blob/BlobStoreConfig.java

diff --git a/apex/blobstore/service/java/com/android/server/blob/BlobStoreConfig.java b/apex/blobstore/service/java/com/android/server/blob/BlobStoreConfig.java
index bb9f13f..5cebf8d 100644
--- a/apex/blobstore/service/java/com/android/server/blob/BlobStoreConfig.java
+++ b/apex/blobstore/service/java/com/android/server/blob/BlobStoreConfig.java
@@ -128,7 +128,7 @@
          */
         public static final String KEY_USE_REVOCABLE_FD_FOR_READS =
                 "use_revocable_fd_for_reads";
-        public static final boolean DEFAULT_USE_REVOCABLE_FD_FOR_READS = true;
+        public static final boolean DEFAULT_USE_REVOCABLE_FD_FOR_READS = false;
         public static boolean USE_REVOCABLE_FD_FOR_READS =
                 DEFAULT_USE_REVOCABLE_FD_FOR_READS;