commit 17b0bda4db04d0918df807786a2cd7addbdd4f25
author Keisuke Kuroyanagi <ksk@google.com> Fri Jun 19 15:24:07 2015 +0900
committer Keisuke Kuroyanagi <ksk@google.com> Fri Jun 19 15:24:07 2015 +0900
tree 4b1b6d45699c2b15e8a59e5fdfd65fff0931103a
parent 0463cad783e78381f390855d1cc9d7d8d803b634

Fix: TextView makes new layouts too frequently.

TextView#checkForRelayout was almost always called in
TextView#onRtlPropertiesChanged.
However, #onRtlPropertiesChanged just checks if re-layout
can be skipped for when the text has changed. As a result,
TextView makes new layouts too frequently in that method.

With this patch, TextView#checkForRelayout is called only
when mTextDir has actually changed.

Bug: 17971103
Change-Id: I449d8c8fd7370495cd5af9e38cada942744ca801

core/java/android/widget/TextView.java

diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java
index 78b5d5d..3b95130 100644
--- a/core/java/android/widget/TextView.java
+++ b/core/java/android/widget/TextView.java
@@ -9499,10 +9499,12 @@
     public void onRtlPropertiesChanged(int layoutDirection) {
         super.onRtlPropertiesChanged(layoutDirection);
 
-        mTextDir = getTextDirectionHeuristic();
-
-        if (mLayout != null) {
-            checkForRelayout();
+        final TextDirectionHeuristic newTextDir = getTextDirectionHeuristic();
+        if (mTextDir != newTextDir) {
+            mTextDir = newTextDir;
+            if (mLayout != null) {
+                checkForRelayout();
+            }
         }
     }