commit 0a1344efc268283a16c04d932722e7824114185a
author Vasu Nori <vnori@google.com> Thu Mar 18 22:17:24 2010 -0700
committer Vasu Nori <vnori@google.com> Fri Mar 19 10:37:09 2010 -0700
tree a51cedda78d9985f2dd6ea5f6eae92298ba5bfc5
parent aa773543c4b93e0396eac39d31bdb85f8465688e

limit sql statement in finalizer warning to 100 chars

too long a sql statement reduces the amount of stack trace printed.

Change-Id: Id980b184850adb2bcb5e47eebe35796bc731a490

core/java/android/database/sqlite/SQLiteCompiledSql.java

diff --git a/core/java/android/database/sqlite/SQLiteCompiledSql.java b/core/java/android/database/sqlite/SQLiteCompiledSql.java
index 816f8a8..72ceb9b 100644
--- a/core/java/android/database/sqlite/SQLiteCompiledSql.java
+++ b/core/java/android/database/sqlite/SQLiteCompiledSql.java
@@ -139,7 +139,10 @@
             if (SQLiteDebug.DEBUG_ACTIVE_CURSOR_FINALIZATION) {
                 Log.v(TAG, "** warning ** Finalized DbObj (id#" + nStatement + ")");
             }
-            Log.w(TAG, "finalizer should never be called on sql: " + mSqlStmt, mStackTrace);
+            int len = mSqlStmt.length();
+            Log.w(TAG, "Releasing statement in a finalizer. Please ensure " +
+                    "that you explicitly call close() on your cursor: " +
+                    mSqlStmt.substring(0, (len > 100) ? 100 : len), mStackTrace);
             releaseSqlStatement();
         } finally {
             super.finalize();