commit f86a441cb5b0dccd3106019e578c3535498e5315
author dcashman <dcashman@google.com> Fri Sep 11 09:33:01 2015 -0700
committer Daniel Cashman <dcashman@google.com> Mon Sep 14 20:57:04 2015 +0000
tree 1e9f60fbd6870c8994653fb69d0c4eb0bbb24f64
parent 4374b187e5e72056f8e814dae752b62cb60fc9a4

Add DUMP permission check to ResourceManagerService.

Bug: 23999740
Change-Id: I3165404add455528b22951ba47b682a075b50087
(cherry picked from commit 014e91e471edba3f9b2c71ff6025274716b0f587)

services/mediaresourcemanager/ResourceManagerService.cpp

diff --git a/services/mediaresourcemanager/ResourceManagerService.cpp b/services/mediaresourcemanager/ResourceManagerService.cpp
index e54cc5a..4790754 100644
--- a/services/mediaresourcemanager/ResourceManagerService.cpp
+++ b/services/mediaresourcemanager/ResourceManagerService.cpp
@@ -96,6 +96,15 @@
     const size_t SIZE = 256;
     char buffer[SIZE];
 
+    if (checkCallingPermission(String16("android.permission.DUMP")) == false) {
+        result.format("Permission Denial: "
+                "can't dump ResourceManagerService from pid=%d, uid=%d\n",
+                IPCThreadState::self()->getCallingPid(),
+                IPCThreadState::self()->getCallingUid());
+        write(fd, result.string(), result.size());
+        return PERMISSION_DENIED;
+    }
+
     snprintf(buffer, SIZE, "ResourceManagerService: %p\n", this);
     result.append(buffer);
     result.append("  Policies:\n");