commit d82310461655725146716bef20a223fecbde27ea
author Jaideep Sharma <quic_jaidshar@quicinc.com> Mon Aug 14 13:03:18 2023 +0530
committer Jaideep Sharma <quic_jaidshar@quicinc.com> Mon Aug 14 07:42:39 2023 +0000
tree fad1dc6f0a2540843b22b5698a6661bf9830ebb0
parent a8fb91216621a1d2d862b5bd4b67c37ebac4b14d

av: Fix command/setParameter for inactive subEffects

Fix the code to send command, setParameters for inactive
subeffects. With current conditional, if active subeffect
is at index 0 then all other subeffects won't be iterated.
Fix by running over all items and then skipping for active
index.

Bug: 295787396

Change-Id: I49a794fa121c5b78b239906067b95572d84bc0c3

media/libaudiohal/impl/EffectProxy.cpp

diff --git a/media/libaudiohal/impl/EffectProxy.cpp b/media/libaudiohal/impl/EffectProxy.cpp
index 5e465d9..8b629ed 100644
--- a/media/libaudiohal/impl/EffectProxy.cpp
+++ b/media/libaudiohal/impl/EffectProxy.cpp
@@ -238,7 +238,10 @@
     }
 
     // proceed with others
-    for (size_t i = 0; i < mSubEffects.size() && i != mActiveSubIdx; i++) {
+    for (size_t i = 0; i < mSubEffects.size(); i++) {
+        if (i == mActiveSubIdx) {
+            continue;
+        }
         if (!mSubEffects[i].handle) {
             ALOGE("%s null sub-effect interface for %s", __func__,
                   mSubEffects[i].descriptor.common.id.uuid.toString().c_str());