commit 9c96d25f1184f812adabaa0b20b32da1370f1f63
author Wonsik Kim <wonsik@google.com> Mon Oct 26 16:42:00 2020 -0700
committer Wonsik Kim <wonsik@google.com> Mon Dec 07 18:02:10 2020 -0800
tree ac538198a4fec32748dc3ee90eee9d0b425d1e56
parent 789055bbcb4560b42faf19103b1cda5534e8f9cb

CCodecConfig: don't dup input format

Input format reference does not get updated in MediaCodec.

Bug: 169831253
Test: atest CtsMediaTestCases -- --module-arg CtsMediaTestCases:size:small
Change-Id: I173164c91796cab9414d9645cea88e1133667053

media/codec2/sfplugin/CCodecConfig.cpp

diff --git a/media/codec2/sfplugin/CCodecConfig.cpp b/media/codec2/sfplugin/CCodecConfig.cpp
index 96f86e8..79c6227 100644
--- a/media/codec2/sfplugin/CCodecConfig.cpp
+++ b/media/codec2/sfplugin/CCodecConfig.cpp
@@ -1151,14 +1151,11 @@
 
     bool changed = false;
     if (domain & mInputDomain) {
-        sp<AMessage> oldFormat = mInputFormat;
-        mInputFormat = mInputFormat->dup(); // trigger format changed
+        sp<AMessage> oldFormat = mInputFormat->dup();
         mInputFormat->extend(getFormatForDomain(reflected, mInputDomain));
         if (mInputFormat->countEntries() != oldFormat->countEntries()
                 || mInputFormat->changesFrom(oldFormat)->countEntries() > 0) {
             changed = true;
-        } else {
-            mInputFormat = oldFormat; // no change
         }
     }
     if (domain & mOutputDomain) {