commit 9d657cfd664122541086e5ab7ca19b25f1c4b90e
author Erik Språng <sprang@google.com> Tue Apr 28 14:00:58 2015 +0200
committer Erik Språng <sprang@google.com> Tue Apr 28 12:00:29 2015 +0000
tree 2a7e939125aa67ed4cef1c1ed91d1dd038d30435
parent beb9798ab4c334617e3023a9c2811e1e34b5a49f

Fix dangling pointer in screenshare_loopback

BUG=
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/52369004

Cr-Commit-Position: refs/heads/master@{#9098}

webrtc/video/screenshare_loopback.cc

diff --git a/webrtc/video/screenshare_loopback.cc b/webrtc/video/screenshare_loopback.cc
index 38bf0e9..2ac3b29 100644
--- a/webrtc/video/screenshare_loopback.cc
+++ b/webrtc/video/screenshare_loopback.cc
@@ -109,7 +109,12 @@
 
 class ScreenshareLoopback : public test::Loopback {
  public:
-  explicit ScreenshareLoopback(const Config& config) : Loopback(config) {}
+  explicit ScreenshareLoopback(const Config& config) : Loopback(config) {
+    vp8_settings_ = VideoEncoder::GetDefaultVp8Settings();
+    vp8_settings_.denoisingOn = false;
+    vp8_settings_.frameDroppingOn = false;
+    vp8_settings_.numberOfTemporalLayers = 2;
+  }
   virtual ~ScreenshareLoopback() {}
 
  protected:
@@ -118,11 +123,7 @@
     VideoStream* stream = &encoder_config.streams[0];
     encoder_config.content_type = VideoEncoderConfig::ContentType::kScreen;
     encoder_config.min_transmit_bitrate_bps = flags::MinTransmitBitrate();
-    VideoCodecVP8 vp8_settings = VideoEncoder::GetDefaultVp8Settings();
-    vp8_settings.denoisingOn = false;
-    vp8_settings.frameDroppingOn = false;
-    vp8_settings.numberOfTemporalLayers = 2;
-    encoder_config.encoder_specific_settings = &vp8_settings;
+    encoder_config.encoder_specific_settings = &vp8_settings_;
     stream->temporal_layer_thresholds_bps.clear();
     stream->target_bitrate_bps =
         static_cast<int>(config_.start_bitrate_kbps) * 1000;
@@ -145,6 +146,8 @@
     EXPECT_TRUE(capturer->Init());
     return capturer;
   }
+
+  VideoCodecVP8 vp8_settings_;
 };
 
 void Loopback() {