commit 83dfad685322119ffe85ff5670cabbbaf385a111
author perkj <perkj@webrtc.org> Mon Nov 09 07:39:49 2015 -0800
committer Commit bot <commit-bot@chromium.org> Mon Nov 09 15:39:55 2015 +0000
tree 4506a83cf40a699f13beacb80e19ed71cfc75aa8
parent 48407f71221635aec2d2a382ee24dea28e4f69cf

VideoCapturerAndroid: Changed camera freeze check to check that all frames are pending before reporting a client error.

BUG=b/25514149

Review URL: https://codereview.webrtc.org/1423073006

Cr-Commit-Position: refs/heads/master@{#10563}

talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java

diff --git a/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java b/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java
index 6dbf003..8b6345b 100644
--- a/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java
+++ b/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java
@@ -83,7 +83,7 @@
   private int id;
   private Camera.CameraInfo info;
   private final FramePool videoBuffers;
-  private final CameraStatistics cameraStatistics = new CameraStatistics();
+  private final CameraStatistics cameraStatistics;
   // Remember the requested format in case we want to switch cameras.
   private int requestedWidth;
   private int requestedHeight;
@@ -138,10 +138,10 @@
           ". Pending buffers: " + cameraStatistics.pendingFramesTimeStamps());
       if (cameraFramesCount == 0) {
         ++freezePeriodCount;
-        if (CAMERA_OBSERVER_PERIOD_MS * freezePeriodCount > CAMERA_FREEZE_REPORT_TIMOUT_MS &&
-            eventsHandler != null) {
+        if (CAMERA_OBSERVER_PERIOD_MS * freezePeriodCount > CAMERA_FREEZE_REPORT_TIMOUT_MS
+            && eventsHandler != null) {
           Logging.e(TAG, "Camera freezed.");
-          if (cameraStatistics.pendingFramesCount() > 0) {
+          if (cameraStatistics.pendingFramesCount() == cameraStatistics.maxPendingFrames) {
             eventsHandler.onCameraError("Camera failure. Client must return video buffers.");
           } else {
             eventsHandler.onCameraError("Camera failure.");
@@ -159,8 +159,10 @@
     private int frameCount = 0;
     private final ThreadUtils.ThreadChecker threadChecker = new ThreadUtils.ThreadChecker();
     private final Set<Long> timeStampsNs = new HashSet<Long>();
+    public final int maxPendingFrames;
 
-    CameraStatistics() {
+    CameraStatistics(int maxPendingFrames) {
+      this.maxPendingFrames = maxPendingFrames;
       threadChecker.detachThread();
     }
 
@@ -354,6 +356,8 @@
     cameraThreadHandler = new Handler(cameraThread.getLooper());
     videoBuffers = new FramePool(cameraThread);
     isCapturingToTexture = (sharedContext != null);
+    cameraStatistics =
+        new CameraStatistics(isCapturingToTexture ? 1 : videoBuffers.numCaptureBuffers);
     surfaceHelper = SurfaceTextureHelper.create(
         isCapturingToTexture ? sharedContext : EGL10.EGL_NO_CONTEXT, cameraThreadHandler);
     if (isCapturingToTexture) {
@@ -475,7 +479,7 @@
           return;
         }
         openCameraAttempts = 0;
-        throw new RuntimeException(e);
+        throw e;
       }
 
       try {
@@ -772,7 +776,7 @@
     // Arbitrary queue depth.  Higher number means more memory allocated & held,
     // lower number means more sensitivity to processing time in the client (and
     // potentially stalling the capturer if it runs out of buffers to write to).
-    private static final int numCaptureBuffers = 3;
+    public static final int numCaptureBuffers = 3;
     // This container tracks the buffers added as camera callback buffers. It is needed for finding
     // the corresponding ByteBuffer given a byte[].
     private final Map<byte[], ByteBuffer> queuedBuffers = new IdentityHashMap<byte[], ByteBuffer>();