commit 6bfc82aaf18e42fcc7328b81ffb3ec3cf360d732
author pkasting <pkasting@chromium.org> Tue Jun 23 14:38:36 2015 -0700
committer Commit bot <commit-bot@chromium.org> Tue Jun 23 21:38:42 2015 +0000
tree 4dc496c079d5dccd5095151e68b821125adce882
parent 39b31001d2d74373f1e60cdbc8e57e402bdf34e3

Test whether removing a cast still hurts performance.

BUG=499241
TEST=none
TBR=andrew

Review URL: https://codereview.webrtc.org/1206653002

Cr-Commit-Position: refs/heads/master@{#9491}

webrtc/common_audio/signal_processing/cross_correlation.c

diff --git a/webrtc/common_audio/signal_processing/cross_correlation.c b/webrtc/common_audio/signal_processing/cross_correlation.c
index 6c8f22c..c14ce4c 100644
--- a/webrtc/common_audio/signal_processing/cross_correlation.c
+++ b/webrtc/common_audio/signal_processing/cross_correlation.c
@@ -23,10 +23,8 @@
   for (i = 0; i < dim_cross_correlation; i++) {
     int32_t corr = 0;
     /* Unrolling doesn't seem to improve performance. */
-    for (j = 0; j < dim_seq; j++) {
-      // It's not clear why casting |right_shifts| here helps performance.
-      corr += (seq1[j] * seq2[j]) >> (int16_t)right_shifts;
-    }
+    for (j = 0; j < dim_seq; j++)
+      corr += (seq1[j] * seq2[j]) >> right_shifts;
     seq2 += step_seq2;
     *cross_correlation++ = corr;
   }