commit 58126f92bf96236d7ceda3d959b7db99f3c043c4
author Henrik Boström <hbos@webrtc.org> Mon Jun 07 12:14:09 2021 +0200
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 08 13:19:23 2021 +0000
tree 0f6afb34145352595cab85049c41c5b3d044991f
parent d9a135b088b60a1e852d70694ef8044776b2f4b9

Update the only 3 remaining kFilterBilinear to kFilterBox.

Bilinear is faster but lesser quality, box is best quality. Our code
base has disagreed about which filter to use for quite some time,
causing aliasing bug reports. In an effort to avoid aliasing artifacts
and make our scaling filters more predictable, we're updating all uses
to kFilterBox.

WebRTC already uses kFilterBox everywhere except for these three
places. The main discrepency was between Chromium and WebRTC but that
has already been fixed. This CL fixes the last remaining bilinears.

This brings the WebRTC kFilterBox use count up from 11 to 14 and the
kFilterBilinear use count down from 3 to 0.

Bug: chromium:1212630
Change-Id: I5fe4aa92b9275d65b91ea97925533055d190d317
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/221372
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34248}

api/video/nv12_buffer.cc

diff --git a/api/video/nv12_buffer.cc b/api/video/nv12_buffer.cc
index 974620b..37d688b 100644
--- a/api/video/nv12_buffer.cc
+++ b/api/video/nv12_buffer.cc
@@ -144,11 +144,10 @@
   const uint8_t* uv_plane =
       src.DataUV() + src.StrideUV() * uv_offset_y + uv_offset_x * 2;
 
-  // kFilterBox is unsupported in libyuv, so using kFilterBilinear instead.
   int res = libyuv::NV12Scale(y_plane, src.StrideY(), uv_plane, src.StrideUV(),
                               crop_width, crop_height, MutableDataY(),
                               StrideY(), MutableDataUV(), StrideUV(), width(),
-                              height(), libyuv::kFilterBilinear);
+                              height(), libyuv::kFilterBox);
 
   RTC_DCHECK_EQ(res, 0);
 }

modules/video_coding/codecs/h264/h264_encoder_impl.cc

diff --git a/modules/video_coding/codecs/h264/h264_encoder_impl.cc b/modules/video_coding/codecs/h264/h264_encoder_impl.cc
index 949c51b..733f00f 100644
--- a/modules/video_coding/codecs/h264/h264_encoder_impl.cc
+++ b/modules/video_coding/codecs/h264/h264_encoder_impl.cc
@@ -445,7 +445,7 @@
                         pictures_[i].iStride[0], pictures_[i].pData[1],
                         pictures_[i].iStride[1], pictures_[i].pData[2],
                         pictures_[i].iStride[2], configurations_[i].width,
-                        configurations_[i].height, libyuv::kFilterBilinear);
+                        configurations_[i].height, libyuv::kFilterBox);
     }
 
     if (!configurations_[i].sending) {

rtc_tools/frame_analyzer/video_geometry_aligner.cc

diff --git a/rtc_tools/frame_analyzer/video_geometry_aligner.cc b/rtc_tools/frame_analyzer/video_geometry_aligner.cc
index db397bc..88da26d 100644
--- a/rtc_tools/frame_analyzer/video_geometry_aligner.cc
+++ b/rtc_tools/frame_analyzer/video_geometry_aligner.cc
@@ -61,7 +61,7 @@
                     adjusted_frame->MutableDataY(), adjusted_frame->StrideY(),
                     adjusted_frame->MutableDataU(), adjusted_frame->StrideU(),
                     adjusted_frame->MutableDataV(), adjusted_frame->StrideV(),
-                    frame->width(), frame->height(), libyuv::kFilterBilinear);
+                    frame->width(), frame->height(), libyuv::kFilterBox);
 
   return adjusted_frame;
 }