commit 27e5898f451f9412e57b8fca97b1932b4ed4565e
author pbos@webrtc.org <pbos@webrtc.org> Tue Oct 07 17:56:53 2014 +0000
committer pbos@webrtc.org <pbos@webrtc.org> Tue Oct 07 17:56:53 2014 +0000
tree a795394d0ade57a5fbd45bed3e415614a7c27262
parent 46ffc7087860789ddd2a794bfc1949e26ed3152b

Explicitly unpoison FDs for MSan.

MSan doesn't handle inline assembly that's used by FD_ZERO causing a
false positive.

R=earthdok@chromium.org, henrike@webrtc.org
BUG=chromium:344505

Review URL: https://webrtc-codereview.appspot.com/25799004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7388 4adac7df-926f-26a2-2b94-8c16560cd09d

webrtc/base/physicalsocketserver.cc

diff --git a/webrtc/base/physicalsocketserver.cc b/webrtc/base/physicalsocketserver.cc
index cff5e4d..3b12547 100644
--- a/webrtc/base/physicalsocketserver.cc
+++ b/webrtc/base/physicalsocketserver.cc
@@ -14,6 +14,10 @@
 
 #include <assert.h>
 
+#ifdef MEMORY_SANITIZER
+#include <sanitizer/msan_interface.h>
+#endif
+
 #if defined(WEBRTC_POSIX)
 #include <string.h>
 #include <errno.h>
@@ -1311,6 +1315,13 @@
   FD_ZERO(&fdsRead);
   fd_set fdsWrite;
   FD_ZERO(&fdsWrite);
+  // Explicitly unpoison these FDs on MemorySanitizer which doesn't handle the
+  // inline assembly in FD_ZERO.
+  // http://crbug.com/344505
+#ifdef MEMORY_SANITIZER
+  __msan_unpoison(&fdsRead, sizeof(fdsRead));
+  __msan_unpoison(&fdsWrite, sizeof(fdsWrite));
+#endif
 
   fWait_ = true;