commit b68912af2c8cefa52bb16634b077938ff074f03a
author Urvang Joshi <urvang@google.com> Fri Apr 05 11:24:59 2013 -0700
committer Urvang Joshi <urvang@google.com> Fri Apr 05 11:24:59 2013 -0700
tree 1116d19baa5588341a07573cd1e901ae7d21808b
parent 82abbe12fb97e86625d7021fd589e3cb7f3a8f67

pngdec: Avoid a double-free.

Earlier, at line#275, if ok == 0, it would have triggered a double free
of 'rgb'.

Change-Id: Iaee1f35824a66f6e4b488e523416f73b87c5ec30

examples/pngdec.c

diff --git a/examples/pngdec.c b/examples/pngdec.c
index 7a7649c..7835356 100644
--- a/examples/pngdec.c
+++ b/examples/pngdec.c
@@ -207,7 +207,6 @@
  Error:
     MetadataFree(metadata);
     png_destroy_read_struct(&png, &info, &end_info);
-    free(rgb);
     goto End;
   }
 
@@ -270,13 +269,13 @@
   pic->use_argb = 1;
   ok = has_alpha ? WebPPictureImportRGBA(pic, rgb, stride)
                  : WebPPictureImportRGB(pic, rgb, stride);
-  free(rgb);
 
   if (!ok) {
     goto Error;
   }
 
  End:
+  free(rgb);
   return ok;
 }
 #else  // !WEBP_HAVE_PNG