| /* Copyright (c) 2015-2017 The Khronos Group Inc. |
| * Copyright (c) 2015-2017 Valve Corporation |
| * Copyright (c) 2015-2017 LunarG, Inc. |
| * Copyright (C) 2015-2017 Google Inc. |
| * |
| * Licensed under the Apache License, Version 2.0 (the "License"); |
| * you may not use this file except in compliance with the License. |
| * You may obtain a copy of the License at |
| * |
| * http://www.apache.org/licenses/LICENSE-2.0 |
| * |
| * Unless required by applicable law or agreed to in writing, software |
| * distributed under the License is distributed on an "AS IS" BASIS, |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| * See the License for the specific language governing permissions and |
| * limitations under the License. |
| * |
| * Author: Cody Northrop <cnorthrop@google.com> |
| * Author: Michael Lentine <mlentine@google.com> |
| * Author: Tobin Ehlis <tobine@google.com> |
| * Author: Chia-I Wu <olv@google.com> |
| * Author: Chris Forbes <chrisf@ijw.co.nz> |
| * Author: Mark Lobodzinski <mark@lunarg.com> |
| * Author: Ian Elliott <ianelliott@google.com> |
| * Author: Dave Houlton <daveh@lunarg.com> |
| * Author: Dustin Graves <dustin@lunarg.com> |
| * Author: Jeremy Hayes <jeremy@lunarg.com> |
| * Author: Jon Ashburn <jon@lunarg.com> |
| * Author: Karl Schultz <karl@lunarg.com> |
| * Author: Mark Young <marky@lunarg.com> |
| * Author: Mike Schuchardt <mikes@lunarg.com> |
| * Author: Mike Weiblen <mikew@lunarg.com> |
| * Author: Tony Barbour <tony@LunarG.com> |
| */ |
| |
| // Allow use of STL min and max functions in Windows |
| #define NOMINMAX |
| |
| #include <algorithm> |
| #include <array> |
| #include <assert.h> |
| #include <iostream> |
| #include <list> |
| #include <map> |
| #include <memory> |
| #include <mutex> |
| #include <set> |
| #include <sstream> |
| #include <stdio.h> |
| #include <stdlib.h> |
| #include <string.h> |
| #include <string> |
| #include <valarray> |
| #include <inttypes.h> |
| |
| #include "vk_loader_platform.h" |
| #include "vk_dispatch_table_helper.h" |
| #include "vk_enum_string_helper.h" |
| #if defined(__GNUC__) |
| #pragma GCC diagnostic ignored "-Wwrite-strings" |
| #endif |
| #if defined(__GNUC__) |
| #pragma GCC diagnostic warning "-Wwrite-strings" |
| #endif |
| #include "core_validation.h" |
| #include "buffer_validation.h" |
| #include "shader_validation.h" |
| #include "vk_layer_table.h" |
| #include "vk_layer_data.h" |
| #include "vk_layer_extension_utils.h" |
| #include "vk_layer_utils.h" |
| #include "vk_typemap_helper.h" |
| |
| #if defined __ANDROID__ |
| #include <android/log.h> |
| #define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) |
| #else |
| #define LOGCONSOLE(...) \ |
| { \ |
| printf(__VA_ARGS__); \ |
| printf("\n"); \ |
| } |
| #endif |
| |
| // This intentionally includes a cpp file |
| #include "vk_safe_struct.cpp" |
| |
| using mutex_t = std::mutex; |
| using lock_guard_t = std::lock_guard<mutex_t>; |
| using unique_lock_t = std::unique_lock<mutex_t>; |
| |
| namespace core_validation { |
| |
| using std::max; |
| using std::string; |
| using std::stringstream; |
| using std::unique_ptr; |
| using std::unordered_map; |
| using std::unordered_set; |
| using std::vector; |
| |
| // WSI Image Objects bypass usual Image Object creation methods. A special Memory |
| // Object value will be used to identify them internally. |
| static const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); |
| // 2nd special memory handle used to flag object as unbound from memory |
| static const VkDeviceMemory MEMORY_UNBOUND = VkDeviceMemory(~((uint64_t)(0)) - 1); |
| |
| struct instance_layer_data { |
| VkInstance instance = VK_NULL_HANDLE; |
| debug_report_data *report_data = nullptr; |
| std::vector<VkDebugReportCallbackEXT> logging_callback; |
| VkLayerInstanceDispatchTable dispatch_table; |
| |
| CALL_STATE vkEnumeratePhysicalDevicesState = UNCALLED; |
| uint32_t physical_devices_count = 0; |
| CALL_STATE vkEnumeratePhysicalDeviceGroupsState = UNCALLED; |
| uint32_t physical_device_groups_count = 0; |
| CHECK_DISABLED disabled = {}; |
| |
| unordered_map<VkPhysicalDevice, PHYSICAL_DEVICE_STATE> physical_device_map; |
| unordered_map<VkSurfaceKHR, SURFACE_STATE> surface_map; |
| |
| InstanceExtensions extensions; |
| }; |
| |
| struct layer_data { |
| debug_report_data *report_data = nullptr; |
| VkLayerDispatchTable dispatch_table; |
| |
| DeviceExtensions extensions = {}; |
| unordered_set<VkQueue> queues; // All queues under given device |
| // Layer specific data |
| unordered_map<VkSampler, unique_ptr<SAMPLER_STATE>> samplerMap; |
| unordered_map<VkImageView, unique_ptr<IMAGE_VIEW_STATE>> imageViewMap; |
| unordered_map<VkImage, unique_ptr<IMAGE_STATE>> imageMap; |
| unordered_map<VkBufferView, unique_ptr<BUFFER_VIEW_STATE>> bufferViewMap; |
| unordered_map<VkBuffer, unique_ptr<BUFFER_STATE>> bufferMap; |
| unordered_map<VkPipeline, unique_ptr<PIPELINE_STATE>> pipelineMap; |
| unordered_map<VkCommandPool, COMMAND_POOL_NODE> commandPoolMap; |
| unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_STATE *> descriptorPoolMap; |
| unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; |
| unordered_map<VkDescriptorSetLayout, std::shared_ptr<cvdescriptorset::DescriptorSetLayout>> descriptorSetLayoutMap; |
| unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; |
| unordered_map<VkDeviceMemory, unique_ptr<DEVICE_MEM_INFO>> memObjMap; |
| unordered_map<VkFence, FENCE_NODE> fenceMap; |
| unordered_map<VkQueue, QUEUE_STATE> queueMap; |
| unordered_map<VkEvent, EVENT_STATE> eventMap; |
| unordered_map<QueryObject, bool> queryToStateMap; |
| unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; |
| unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; |
| unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; |
| unordered_map<VkFramebuffer, unique_ptr<FRAMEBUFFER_STATE>> frameBufferMap; |
| unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; |
| unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; |
| unordered_map<VkRenderPass, std::shared_ptr<RENDER_PASS_STATE>> renderPassMap; |
| unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; |
| unordered_map<VkDescriptorUpdateTemplateKHR, unique_ptr<TEMPLATE_STATE>> desc_template_map; |
| unordered_map<VkSwapchainKHR, std::unique_ptr<SWAPCHAIN_NODE>> swapchainMap; |
| |
| VkDevice device = VK_NULL_HANDLE; |
| VkPhysicalDevice physical_device = VK_NULL_HANDLE; |
| |
| instance_layer_data *instance_data = nullptr; // from device to enclosing instance |
| |
| VkPhysicalDeviceFeatures enabled_features = {}; |
| // Device specific data |
| PHYS_DEV_PROPERTIES_NODE phys_dev_properties = {}; |
| VkPhysicalDeviceMemoryProperties phys_dev_mem_props = {}; |
| VkPhysicalDeviceProperties phys_dev_props = {}; |
| // Device extension properties -- storing properties gathered from VkPhysicalDeviceProperties2KHR::pNext chain |
| struct DeviceExtensionProperties { |
| uint32_t max_push_descriptors; // from VkPhysicalDevicePushDescriptorPropertiesKHR::maxPushDescriptors |
| }; |
| DeviceExtensionProperties phys_dev_ext_props = {}; |
| bool external_sync_warning = false; |
| }; |
| |
| // TODO : Do we need to guard access to layer_data_map w/ lock? |
| static unordered_map<void *, layer_data *> layer_data_map; |
| static unordered_map<void *, instance_layer_data *> instance_layer_data_map; |
| |
| static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION; |
| |
| static const VkLayerProperties global_layer = { |
| "VK_LAYER_LUNARG_core_validation", |
| VK_LAYER_API_VERSION, |
| 1, |
| "LunarG Validation Layer", |
| }; |
| |
| static const VkExtensionProperties device_extensions[] = { |
| {VK_EXT_VALIDATION_CACHE_EXTENSION_NAME, VK_EXT_VALIDATION_CACHE_SPEC_VERSION}, |
| }; |
| |
| template <class TCreateInfo> |
| void ValidateLayerOrdering(const TCreateInfo &createInfo) { |
| bool foundLayer = false; |
| for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { |
| if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { |
| foundLayer = true; |
| } |
| // This has to be logged to console as we don't have a callback at this point. |
| if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { |
| LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", global_layer.layerName); |
| } |
| } |
| } |
| |
| // TODO : This can be much smarter, using separate locks for separate global data |
| static mutex_t global_lock; |
| |
| // Return IMAGE_VIEW_STATE ptr for specified imageView or else NULL |
| IMAGE_VIEW_STATE *GetImageViewState(const layer_data *dev_data, VkImageView image_view) { |
| auto iv_it = dev_data->imageViewMap.find(image_view); |
| if (iv_it == dev_data->imageViewMap.end()) { |
| return nullptr; |
| } |
| return iv_it->second.get(); |
| } |
| // Return sampler node ptr for specified sampler or else NULL |
| SAMPLER_STATE *GetSamplerState(const layer_data *dev_data, VkSampler sampler) { |
| auto sampler_it = dev_data->samplerMap.find(sampler); |
| if (sampler_it == dev_data->samplerMap.end()) { |
| return nullptr; |
| } |
| return sampler_it->second.get(); |
| } |
| // Return image state ptr for specified image or else NULL |
| IMAGE_STATE *GetImageState(const layer_data *dev_data, VkImage image) { |
| auto img_it = dev_data->imageMap.find(image); |
| if (img_it == dev_data->imageMap.end()) { |
| return nullptr; |
| } |
| return img_it->second.get(); |
| } |
| // Return buffer state ptr for specified buffer or else NULL |
| BUFFER_STATE *GetBufferState(const layer_data *dev_data, VkBuffer buffer) { |
| auto buff_it = dev_data->bufferMap.find(buffer); |
| if (buff_it == dev_data->bufferMap.end()) { |
| return nullptr; |
| } |
| return buff_it->second.get(); |
| } |
| // Return swapchain node for specified swapchain or else NULL |
| SWAPCHAIN_NODE *GetSwapchainNode(const layer_data *dev_data, VkSwapchainKHR swapchain) { |
| auto swp_it = dev_data->swapchainMap.find(swapchain); |
| if (swp_it == dev_data->swapchainMap.end()) { |
| return nullptr; |
| } |
| return swp_it->second.get(); |
| } |
| // Return buffer node ptr for specified buffer or else NULL |
| BUFFER_VIEW_STATE *GetBufferViewState(const layer_data *dev_data, VkBufferView buffer_view) { |
| auto bv_it = dev_data->bufferViewMap.find(buffer_view); |
| if (bv_it == dev_data->bufferViewMap.end()) { |
| return nullptr; |
| } |
| return bv_it->second.get(); |
| } |
| |
| FENCE_NODE *GetFenceNode(layer_data *dev_data, VkFence fence) { |
| auto it = dev_data->fenceMap.find(fence); |
| if (it == dev_data->fenceMap.end()) { |
| return nullptr; |
| } |
| return &it->second; |
| } |
| |
| EVENT_STATE *GetEventNode(layer_data *dev_data, VkEvent event) { |
| auto it = dev_data->eventMap.find(event); |
| if (it == dev_data->eventMap.end()) { |
| return nullptr; |
| } |
| return &it->second; |
| } |
| |
| QUERY_POOL_NODE *GetQueryPoolNode(layer_data *dev_data, VkQueryPool query_pool) { |
| auto it = dev_data->queryPoolMap.find(query_pool); |
| if (it == dev_data->queryPoolMap.end()) { |
| return nullptr; |
| } |
| return &it->second; |
| } |
| |
| QUEUE_STATE *GetQueueState(layer_data *dev_data, VkQueue queue) { |
| auto it = dev_data->queueMap.find(queue); |
| if (it == dev_data->queueMap.end()) { |
| return nullptr; |
| } |
| return &it->second; |
| } |
| |
| SEMAPHORE_NODE *GetSemaphoreNode(layer_data *dev_data, VkSemaphore semaphore) { |
| auto it = dev_data->semaphoreMap.find(semaphore); |
| if (it == dev_data->semaphoreMap.end()) { |
| return nullptr; |
| } |
| return &it->second; |
| } |
| |
| COMMAND_POOL_NODE *GetCommandPoolNode(layer_data *dev_data, VkCommandPool pool) { |
| auto it = dev_data->commandPoolMap.find(pool); |
| if (it == dev_data->commandPoolMap.end()) { |
| return nullptr; |
| } |
| return &it->second; |
| } |
| |
| PHYSICAL_DEVICE_STATE *GetPhysicalDeviceState(instance_layer_data *instance_data, VkPhysicalDevice phys) { |
| auto it = instance_data->physical_device_map.find(phys); |
| if (it == instance_data->physical_device_map.end()) { |
| return nullptr; |
| } |
| return &it->second; |
| } |
| |
| SURFACE_STATE *GetSurfaceState(instance_layer_data *instance_data, VkSurfaceKHR surface) { |
| auto it = instance_data->surface_map.find(surface); |
| if (it == instance_data->surface_map.end()) { |
| return nullptr; |
| } |
| return &it->second; |
| } |
| |
| DeviceExtensions const *GetEnabledExtensions(layer_data const *dev_data) { return &dev_data->extensions; } |
| |
| // Return ptr to memory binding for given handle of specified type |
| static BINDABLE *GetObjectMemBinding(layer_data *dev_data, uint64_t handle, VulkanObjectType type) { |
| switch (type) { |
| case kVulkanObjectTypeImage: |
| return GetImageState(dev_data, VkImage(handle)); |
| case kVulkanObjectTypeBuffer: |
| return GetBufferState(dev_data, VkBuffer(handle)); |
| default: |
| break; |
| } |
| return nullptr; |
| } |
| // prototype |
| GLOBAL_CB_NODE *GetCBNode(layer_data const *, const VkCommandBuffer); |
| |
| // Return ptr to info in map container containing mem, or NULL if not found |
| // Calls to this function should be wrapped in mutex |
| DEVICE_MEM_INFO *GetMemObjInfo(const layer_data *dev_data, const VkDeviceMemory mem) { |
| auto mem_it = dev_data->memObjMap.find(mem); |
| if (mem_it == dev_data->memObjMap.end()) { |
| return NULL; |
| } |
| return mem_it->second.get(); |
| } |
| |
| static void add_mem_obj_info(layer_data *dev_data, void *object, const VkDeviceMemory mem, |
| const VkMemoryAllocateInfo *pAllocateInfo) { |
| assert(object != NULL); |
| |
| dev_data->memObjMap[mem] = unique_ptr<DEVICE_MEM_INFO>(new DEVICE_MEM_INFO(object, mem, pAllocateInfo)); |
| |
| if (pAllocateInfo->pNext) { |
| auto struct_header = reinterpret_cast<const GENERIC_HEADER *>(pAllocateInfo->pNext); |
| while (struct_header) { |
| if (VK_STRUCTURE_TYPE_IMPORT_MEMORY_FD_INFO_KHR == struct_header->sType || |
| VK_STRUCTURE_TYPE_IMPORT_MEMORY_WIN32_HANDLE_INFO_KHR == struct_header->sType) { |
| dev_data->memObjMap[mem]->global_valid = true; |
| break; |
| } |
| struct_header = reinterpret_cast<const GENERIC_HEADER *>(struct_header->pNext); |
| } |
| } |
| } |
| |
| // For given bound_object_handle, bound to given mem allocation, verify that the range for the bound object is valid |
| static bool ValidateMemoryIsValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t bound_object_handle, VulkanObjectType type, |
| const char *functionName) { |
| DEVICE_MEM_INFO *mem_info = GetMemObjInfo(dev_data, mem); |
| if (mem_info) { |
| if (!mem_info->bound_ranges[bound_object_handle].valid) { |
| return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", |
| "%s: Cannot read invalid region of memory allocation 0x%" PRIx64 " for bound %s object 0x%" PRIx64 |
| ", please fill the memory before using.", |
| functionName, HandleToUint64(mem), object_string[type], bound_object_handle); |
| } |
| } |
| return false; |
| } |
| // For given image_state |
| // If mem is special swapchain key, then verify that image_state valid member is true |
| // Else verify that the image's bound memory range is valid |
| bool ValidateImageMemoryIsValid(layer_data *dev_data, IMAGE_STATE *image_state, const char *functionName) { |
| if (image_state->binding.mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { |
| if (!image_state->valid) { |
| return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(image_state->binding.mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", |
| "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", |
| functionName, HandleToUint64(image_state->image)); |
| } |
| } else { |
| return ValidateMemoryIsValid(dev_data, image_state->binding.mem, HandleToUint64(image_state->image), kVulkanObjectTypeImage, |
| functionName); |
| } |
| return false; |
| } |
| // For given buffer_state, verify that the range it's bound to is valid |
| bool ValidateBufferMemoryIsValid(layer_data *dev_data, BUFFER_STATE *buffer_state, const char *functionName) { |
| return ValidateMemoryIsValid(dev_data, buffer_state->binding.mem, HandleToUint64(buffer_state->buffer), kVulkanObjectTypeBuffer, |
| functionName); |
| } |
| // For the given memory allocation, set the range bound by the given handle object to the valid param value |
| static void SetMemoryValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, bool valid) { |
| DEVICE_MEM_INFO *mem_info = GetMemObjInfo(dev_data, mem); |
| if (mem_info) { |
| mem_info->bound_ranges[handle].valid = valid; |
| } |
| } |
| // For given image node |
| // If mem is special swapchain key, then set entire image_state to valid param value |
| // Else set the image's bound memory range to valid param value |
| void SetImageMemoryValid(layer_data *dev_data, IMAGE_STATE *image_state, bool valid) { |
| if (image_state->binding.mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { |
| image_state->valid = valid; |
| } else { |
| SetMemoryValid(dev_data, image_state->binding.mem, HandleToUint64(image_state->image), valid); |
| } |
| } |
| // For given buffer node set the buffer's bound memory range to valid param value |
| void SetBufferMemoryValid(layer_data *dev_data, BUFFER_STATE *buffer_state, bool valid) { |
| SetMemoryValid(dev_data, buffer_state->binding.mem, HandleToUint64(buffer_state->buffer), valid); |
| } |
| |
| // Create binding link between given sampler and command buffer node |
| void AddCommandBufferBindingSampler(GLOBAL_CB_NODE *cb_node, SAMPLER_STATE *sampler_state) { |
| sampler_state->cb_bindings.insert(cb_node); |
| cb_node->object_bindings.insert({HandleToUint64(sampler_state->sampler), kVulkanObjectTypeSampler}); |
| } |
| |
| // Create binding link between given image node and command buffer node |
| void AddCommandBufferBindingImage(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_STATE *image_state) { |
| // Skip validation if this image was created through WSI |
| if (image_state->binding.mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { |
| // First update CB binding in MemObj mini CB list |
| for (auto mem_binding : image_state->GetBoundMemory()) { |
| DEVICE_MEM_INFO *pMemInfo = GetMemObjInfo(dev_data, mem_binding); |
| if (pMemInfo) { |
| pMemInfo->cb_bindings.insert(cb_node); |
| // Now update CBInfo's Mem reference list |
| cb_node->memObjs.insert(mem_binding); |
| } |
| } |
| // Now update cb binding for image |
| cb_node->object_bindings.insert({HandleToUint64(image_state->image), kVulkanObjectTypeImage}); |
| image_state->cb_bindings.insert(cb_node); |
| } |
| } |
| |
| // Create binding link between given image view node and its image with command buffer node |
| void AddCommandBufferBindingImageView(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_VIEW_STATE *view_state) { |
| // First add bindings for imageView |
| view_state->cb_bindings.insert(cb_node); |
| cb_node->object_bindings.insert({HandleToUint64(view_state->image_view), kVulkanObjectTypeImageView}); |
| auto image_state = GetImageState(dev_data, view_state->create_info.image); |
| // Add bindings for image within imageView |
| if (image_state) { |
| AddCommandBufferBindingImage(dev_data, cb_node, image_state); |
| } |
| } |
| |
| // Create binding link between given buffer node and command buffer node |
| void AddCommandBufferBindingBuffer(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_STATE *buffer_state) { |
| // First update CB binding in MemObj mini CB list |
| for (auto mem_binding : buffer_state->GetBoundMemory()) { |
| DEVICE_MEM_INFO *pMemInfo = GetMemObjInfo(dev_data, mem_binding); |
| if (pMemInfo) { |
| pMemInfo->cb_bindings.insert(cb_node); |
| // Now update CBInfo's Mem reference list |
| cb_node->memObjs.insert(mem_binding); |
| } |
| } |
| // Now update cb binding for buffer |
| cb_node->object_bindings.insert({HandleToUint64(buffer_state->buffer), kVulkanObjectTypeBuffer}); |
| buffer_state->cb_bindings.insert(cb_node); |
| } |
| |
| // Create binding link between given buffer view node and its buffer with command buffer node |
| void AddCommandBufferBindingBufferView(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_VIEW_STATE *view_state) { |
| // First add bindings for bufferView |
| view_state->cb_bindings.insert(cb_node); |
| cb_node->object_bindings.insert({HandleToUint64(view_state->buffer_view), kVulkanObjectTypeBufferView}); |
| auto buffer_state = GetBufferState(dev_data, view_state->create_info.buffer); |
| // Add bindings for buffer within bufferView |
| if (buffer_state) { |
| AddCommandBufferBindingBuffer(dev_data, cb_node, buffer_state); |
| } |
| } |
| |
| // For every mem obj bound to particular CB, free bindings related to that CB |
| static void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { |
| if (cb_node) { |
| if (cb_node->memObjs.size() > 0) { |
| for (auto mem : cb_node->memObjs) { |
| DEVICE_MEM_INFO *pInfo = GetMemObjInfo(dev_data, mem); |
| if (pInfo) { |
| pInfo->cb_bindings.erase(cb_node); |
| } |
| } |
| cb_node->memObjs.clear(); |
| } |
| } |
| } |
| |
| // Clear a single object binding from given memory object, or report error if binding is missing |
| static bool ClearMemoryObjectBinding(layer_data *dev_data, uint64_t handle, VulkanObjectType type, VkDeviceMemory mem) { |
| DEVICE_MEM_INFO *mem_info = GetMemObjInfo(dev_data, mem); |
| // This obj is bound to a memory object. Remove the reference to this object in that memory object's list |
| if (mem_info) { |
| mem_info->obj_bindings.erase({handle, type}); |
| } |
| return false; |
| } |
| |
| // ClearMemoryObjectBindings clears the binding of objects to memory |
| // For the given object it pulls the memory bindings and makes sure that the bindings |
| // no longer refer to the object being cleared. This occurs when objects are destroyed. |
| bool ClearMemoryObjectBindings(layer_data *dev_data, uint64_t handle, VulkanObjectType type) { |
| bool skip = false; |
| BINDABLE *mem_binding = GetObjectMemBinding(dev_data, handle, type); |
| if (mem_binding) { |
| if (!mem_binding->sparse) { |
| skip = ClearMemoryObjectBinding(dev_data, handle, type, mem_binding->binding.mem); |
| } else { // Sparse, clear all bindings |
| for (auto &sparse_mem_binding : mem_binding->sparse_bindings) { |
| skip |= ClearMemoryObjectBinding(dev_data, handle, type, sparse_mem_binding.mem); |
| } |
| } |
| } |
| return skip; |
| } |
| |
| // For given mem object, verify that it is not null or UNBOUND, if it is, report error. Return skip value. |
| bool VerifyBoundMemoryIsValid(const layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, const char *api_name, |
| const char *type_name, UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| bool result = false; |
| if (VK_NULL_HANDLE == mem) { |
| result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, handle, |
| __LINE__, error_code, "MEM", |
| "%s: Vk%s object 0x%" PRIx64 |
| " used with no memory bound. Memory should be bound by calling vkBind%sMemory(). %s", |
| api_name, type_name, handle, type_name, validation_error_map[error_code]); |
| } else if (MEMORY_UNBOUND == mem) { |
| result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, handle, |
| __LINE__, error_code, "MEM", |
| "%s: Vk%s object 0x%" PRIx64 |
| " used with no memory bound and previously bound memory was freed. Memory must not be freed prior to this " |
| "operation. %s", |
| api_name, type_name, handle, validation_error_map[error_code]); |
| } |
| return result; |
| } |
| |
| // Check to see if memory was ever bound to this image |
| bool ValidateMemoryIsBoundToImage(const layer_data *dev_data, const IMAGE_STATE *image_state, const char *api_name, |
| UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| bool result = false; |
| if (0 == (static_cast<uint32_t>(image_state->createInfo.flags) & VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) { |
| result = VerifyBoundMemoryIsValid(dev_data, image_state->binding.mem, HandleToUint64(image_state->image), api_name, "Image", |
| error_code); |
| } |
| return result; |
| } |
| |
| // Check to see if memory was bound to this buffer |
| bool ValidateMemoryIsBoundToBuffer(const layer_data *dev_data, const BUFFER_STATE *buffer_state, const char *api_name, |
| UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| bool result = false; |
| if (0 == (static_cast<uint32_t>(buffer_state->createInfo.flags) & VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) { |
| result = VerifyBoundMemoryIsValid(dev_data, buffer_state->binding.mem, HandleToUint64(buffer_state->buffer), api_name, |
| "Buffer", error_code); |
| } |
| return result; |
| } |
| |
| // SetMemBinding is used to establish immutable, non-sparse binding between a single image/buffer object and memory object. |
| // Corresponding valid usage checks are in ValidateSetMemBinding(). |
| static void SetMemBinding(layer_data *dev_data, VkDeviceMemory mem, BINDABLE *mem_binding, VkDeviceSize memory_offset, |
| uint64_t handle, VulkanObjectType type, const char *apiName) { |
| assert(mem_binding); |
| mem_binding->binding.mem = mem; |
| mem_binding->UpdateBoundMemorySet(); // force recreation of cached set |
| mem_binding->binding.offset = memory_offset; |
| mem_binding->binding.size = mem_binding->requirements.size; |
| |
| if (mem != VK_NULL_HANDLE) { |
| DEVICE_MEM_INFO *mem_info = GetMemObjInfo(dev_data, mem); |
| if (mem_info) { |
| mem_info->obj_bindings.insert({handle, type}); |
| // For image objects, make sure default memory state is correctly set |
| // TODO : What's the best/correct way to handle this? |
| if (kVulkanObjectTypeImage == type) { |
| auto const image_state = reinterpret_cast<const IMAGE_STATE *>(mem_binding); |
| if (image_state) { |
| VkImageCreateInfo ici = image_state->createInfo; |
| if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { |
| // TODO:: More memory state transition stuff. |
| } |
| } |
| } |
| } |
| } |
| } |
| |
| // Valid usage checks for a call to SetMemBinding(). |
| // For NULL mem case, output warning |
| // Make sure given object is in global object map |
| // IF a previous binding existed, output validation error |
| // Otherwise, add reference from objectInfo to memoryInfo |
| // Add reference off of objInfo |
| // TODO: We may need to refactor or pass in multiple valid usage statements to handle multiple valid usage conditions. |
| static bool ValidateSetMemBinding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, VulkanObjectType type, |
| const char *apiName) { |
| bool skip = false; |
| // It's an error to bind an object to NULL memory |
| if (mem != VK_NULL_HANDLE) { |
| BINDABLE *mem_binding = GetObjectMemBinding(dev_data, handle, type); |
| assert(mem_binding); |
| if (mem_binding->sparse) { |
| UNIQUE_VALIDATION_ERROR_CODE error_code = VALIDATION_ERROR_1740082a; |
| const char *handle_type = "IMAGE"; |
| if (type == kVulkanObjectTypeBuffer) { |
| error_code = VALIDATION_ERROR_1700080c; |
| handle_type = "BUFFER"; |
| } else { |
| assert(type == kVulkanObjectTypeImage); |
| } |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem), __LINE__, error_code, "MEM", |
| "In %s, attempting to bind memory (0x%" PRIx64 ") to object (0x%" PRIx64 |
| ") which was created with sparse memory flags (VK_%s_CREATE_SPARSE_*_BIT). %s", |
| apiName, HandleToUint64(mem), handle, handle_type, validation_error_map[error_code]); |
| } |
| DEVICE_MEM_INFO *mem_info = GetMemObjInfo(dev_data, mem); |
| if (mem_info) { |
| DEVICE_MEM_INFO *prev_binding = GetMemObjInfo(dev_data, mem_binding->binding.mem); |
| if (prev_binding) { |
| UNIQUE_VALIDATION_ERROR_CODE error_code = VALIDATION_ERROR_17400828; |
| if (type == kVulkanObjectTypeBuffer) { |
| error_code = VALIDATION_ERROR_1700080a; |
| } else { |
| assert(type == kVulkanObjectTypeImage); |
| } |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem), __LINE__, error_code, "MEM", |
| "In %s, attempting to bind memory (0x%" PRIx64 ") to object (0x%" PRIx64 |
| ") which has already been bound to mem object 0x%" PRIx64 ". %s", |
| apiName, HandleToUint64(mem), handle, HandleToUint64(prev_binding->mem), |
| validation_error_map[error_code]); |
| } else if (mem_binding->binding.mem == MEMORY_UNBOUND) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem), __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", |
| "In %s, attempting to bind memory (0x%" PRIx64 ") to object (0x%" PRIx64 |
| ") which was previous bound to memory that has since been freed. Memory bindings are immutable in " |
| "Vulkan so this attempt to bind to new memory is not allowed.", |
| apiName, HandleToUint64(mem), handle); |
| } |
| } |
| } |
| return skip; |
| } |
| |
| // For NULL mem case, clear any previous binding Else... |
| // Make sure given object is in its object map |
| // IF a previous binding existed, update binding |
| // Add reference from objectInfo to memoryInfo |
| // Add reference off of object's binding info |
| // Return VK_TRUE if addition is successful, VK_FALSE otherwise |
| static bool SetSparseMemBinding(layer_data *dev_data, MEM_BINDING binding, uint64_t handle, VulkanObjectType type) { |
| bool skip = VK_FALSE; |
| // Handle NULL case separately, just clear previous binding & decrement reference |
| if (binding.mem == VK_NULL_HANDLE) { |
| // TODO : This should cause the range of the resource to be unbound according to spec |
| } else { |
| BINDABLE *mem_binding = GetObjectMemBinding(dev_data, handle, type); |
| assert(mem_binding); |
| assert(mem_binding->sparse); |
| DEVICE_MEM_INFO *mem_info = GetMemObjInfo(dev_data, binding.mem); |
| if (mem_info) { |
| mem_info->obj_bindings.insert({handle, type}); |
| // Need to set mem binding for this object |
| mem_binding->sparse_bindings.insert(binding); |
| mem_binding->UpdateBoundMemorySet(); |
| } |
| } |
| return skip; |
| } |
| |
| // Check object status for selected flag state |
| static bool validate_status(layer_data *dev_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, |
| const char *fail_msg, UNIQUE_VALIDATION_ERROR_CODE const msg_code) { |
| if (!(pNode->status & status_mask)) { |
| char const *const message = validation_error_map[msg_code]; |
| return log_msg(dev_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pNode->commandBuffer), __LINE__, msg_code, "DS", |
| "command buffer object 0x%" PRIx64 ": %s. %s.", HandleToUint64(pNode->commandBuffer), fail_msg, message); |
| } |
| return false; |
| } |
| |
| // Retrieve pipeline node ptr for given pipeline object |
| static PIPELINE_STATE *getPipelineState(layer_data const *dev_data, VkPipeline pipeline) { |
| auto it = dev_data->pipelineMap.find(pipeline); |
| if (it == dev_data->pipelineMap.end()) { |
| return nullptr; |
| } |
| return it->second.get(); |
| } |
| |
| RENDER_PASS_STATE *GetRenderPassState(layer_data const *dev_data, VkRenderPass renderpass) { |
| auto it = dev_data->renderPassMap.find(renderpass); |
| if (it == dev_data->renderPassMap.end()) { |
| return nullptr; |
| } |
| return it->second.get(); |
| } |
| |
| std::shared_ptr<RENDER_PASS_STATE> GetRenderPassStateSharedPtr(layer_data const *dev_data, VkRenderPass renderpass) { |
| auto it = dev_data->renderPassMap.find(renderpass); |
| if (it == dev_data->renderPassMap.end()) { |
| return nullptr; |
| } |
| return it->second; |
| } |
| |
| FRAMEBUFFER_STATE *GetFramebufferState(const layer_data *dev_data, VkFramebuffer framebuffer) { |
| auto it = dev_data->frameBufferMap.find(framebuffer); |
| if (it == dev_data->frameBufferMap.end()) { |
| return nullptr; |
| } |
| return it->second.get(); |
| } |
| |
| std::shared_ptr<cvdescriptorset::DescriptorSetLayout const> const GetDescriptorSetLayout(layer_data const *dev_data, |
| VkDescriptorSetLayout dsLayout) { |
| auto it = dev_data->descriptorSetLayoutMap.find(dsLayout); |
| if (it == dev_data->descriptorSetLayoutMap.end()) { |
| return nullptr; |
| } |
| return it->second; |
| } |
| |
| static PIPELINE_LAYOUT_NODE const *getPipelineLayout(layer_data const *dev_data, VkPipelineLayout pipeLayout) { |
| auto it = dev_data->pipelineLayoutMap.find(pipeLayout); |
| if (it == dev_data->pipelineLayoutMap.end()) { |
| return nullptr; |
| } |
| return &it->second; |
| } |
| |
| shader_module const *GetShaderModuleState(layer_data const *dev_data, VkShaderModule module) { |
| auto it = dev_data->shaderModuleMap.find(module); |
| if (it == dev_data->shaderModuleMap.end()) { |
| return nullptr; |
| } |
| return it->second.get(); |
| } |
| |
| // Return true if for a given PSO, the given state enum is dynamic, else return false |
| static bool isDynamic(const PIPELINE_STATE *pPipeline, const VkDynamicState state) { |
| if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { |
| for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { |
| if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) return true; |
| } |
| } |
| return false; |
| } |
| |
| // Validate state stored as flags at time of draw call |
| static bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_STATE *pPipe, bool indexed, |
| UNIQUE_VALIDATION_ERROR_CODE const msg_code) { |
| bool result = false; |
| if (pPipe->graphicsPipelineCI.pInputAssemblyState && |
| ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || |
| (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { |
| result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| "Dynamic line width state not set for this command buffer", msg_code); |
| } |
| if (pPipe->graphicsPipelineCI.pRasterizationState && |
| (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { |
| result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| "Dynamic depth bias state not set for this command buffer", msg_code); |
| } |
| if (pPipe->blendConstantsEnabled) { |
| result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| "Dynamic blend constants state not set for this command buffer", msg_code); |
| } |
| if (pPipe->graphicsPipelineCI.pDepthStencilState && |
| (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { |
| result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| "Dynamic depth bounds state not set for this command buffer", msg_code); |
| } |
| if (pPipe->graphicsPipelineCI.pDepthStencilState && |
| (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { |
| result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| "Dynamic stencil read mask state not set for this command buffer", msg_code); |
| result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| "Dynamic stencil write mask state not set for this command buffer", msg_code); |
| result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| "Dynamic stencil reference state not set for this command buffer", msg_code); |
| } |
| if (indexed) { |
| result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| "Index buffer object not bound to this command buffer when Indexed Draw attempted", msg_code); |
| } |
| |
| return result; |
| } |
| |
| static bool logInvalidAttachmentMessage(layer_data const *dev_data, const char *type1_string, const RENDER_PASS_STATE *rp1_state, |
| const char *type2_string, const RENDER_PASS_STATE *rp2_state, uint32_t primary_attach, |
| uint32_t secondary_attach, const char *msg, const char *caller, |
| UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| HandleToUint64(rp1_state->renderPass), __LINE__, error_code, "DS", |
| "%s: RenderPasses incompatible between %s w/ renderPass 0x%" PRIx64 " and %s w/ renderPass 0x%" PRIx64 |
| " Attachment %u is not compatible with %u: %s. %s", |
| caller, type1_string, HandleToUint64(rp1_state->renderPass), type2_string, HandleToUint64(rp2_state->renderPass), |
| primary_attach, secondary_attach, msg, validation_error_map[error_code]); |
| } |
| |
| static bool validateAttachmentCompatibility(layer_data const *dev_data, const char *type1_string, |
| const RENDER_PASS_STATE *rp1_state, const char *type2_string, |
| const RENDER_PASS_STATE *rp2_state, uint32_t primary_attach, uint32_t secondary_attach, |
| const char *caller, UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| bool skip = false; |
| const auto &primaryPassCI = rp1_state->createInfo; |
| const auto &secondaryPassCI = rp2_state->createInfo; |
| if (primaryPassCI.attachmentCount <= primary_attach) { |
| primary_attach = VK_ATTACHMENT_UNUSED; |
| } |
| if (secondaryPassCI.attachmentCount <= secondary_attach) { |
| secondary_attach = VK_ATTACHMENT_UNUSED; |
| } |
| if (primary_attach == VK_ATTACHMENT_UNUSED && secondary_attach == VK_ATTACHMENT_UNUSED) { |
| return skip; |
| } |
| if (primary_attach == VK_ATTACHMENT_UNUSED) { |
| skip |= logInvalidAttachmentMessage(dev_data, type1_string, rp1_state, type2_string, rp2_state, primary_attach, |
| secondary_attach, "The first is unused while the second is not.", caller, error_code); |
| return skip; |
| } |
| if (secondary_attach == VK_ATTACHMENT_UNUSED) { |
| skip |= logInvalidAttachmentMessage(dev_data, type1_string, rp1_state, type2_string, rp2_state, primary_attach, |
| secondary_attach, "The second is unused while the first is not.", caller, error_code); |
| return skip; |
| } |
| if (primaryPassCI.pAttachments[primary_attach].format != secondaryPassCI.pAttachments[secondary_attach].format) { |
| skip |= logInvalidAttachmentMessage(dev_data, type1_string, rp1_state, type2_string, rp2_state, primary_attach, |
| secondary_attach, "They have different formats.", caller, error_code); |
| } |
| if (primaryPassCI.pAttachments[primary_attach].samples != secondaryPassCI.pAttachments[secondary_attach].samples) { |
| skip |= logInvalidAttachmentMessage(dev_data, type1_string, rp1_state, type2_string, rp2_state, primary_attach, |
| secondary_attach, "They have different samples.", caller, error_code); |
| } |
| if (primaryPassCI.pAttachments[primary_attach].flags != secondaryPassCI.pAttachments[secondary_attach].flags) { |
| skip |= logInvalidAttachmentMessage(dev_data, type1_string, rp1_state, type2_string, rp2_state, primary_attach, |
| secondary_attach, "They have different flags.", caller, error_code); |
| } |
| |
| return skip; |
| } |
| |
| static bool validateSubpassCompatibility(layer_data const *dev_data, const char *type1_string, const RENDER_PASS_STATE *rp1_state, |
| const char *type2_string, const RENDER_PASS_STATE *rp2_state, const int subpass, |
| const char *caller, UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| bool skip = false; |
| const auto &primary_desc = rp1_state->createInfo.pSubpasses[subpass]; |
| const auto &secondary_desc = rp2_state->createInfo.pSubpasses[subpass]; |
| uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); |
| for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { |
| uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; |
| if (i < primary_desc.inputAttachmentCount) { |
| primary_input_attach = primary_desc.pInputAttachments[i].attachment; |
| } |
| if (i < secondary_desc.inputAttachmentCount) { |
| secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; |
| } |
| skip |= validateAttachmentCompatibility(dev_data, type1_string, rp1_state, type2_string, rp2_state, primary_input_attach, |
| secondary_input_attach, caller, error_code); |
| } |
| uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); |
| for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { |
| uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; |
| if (i < primary_desc.colorAttachmentCount) { |
| primary_color_attach = primary_desc.pColorAttachments[i].attachment; |
| } |
| if (i < secondary_desc.colorAttachmentCount) { |
| secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; |
| } |
| skip |= validateAttachmentCompatibility(dev_data, type1_string, rp1_state, type2_string, rp2_state, primary_color_attach, |
| secondary_color_attach, caller, error_code); |
| uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; |
| if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { |
| primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; |
| } |
| if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { |
| secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; |
| } |
| skip |= validateAttachmentCompatibility(dev_data, type1_string, rp1_state, type2_string, rp2_state, primary_resolve_attach, |
| secondary_resolve_attach, caller, error_code); |
| } |
| uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; |
| if (primary_desc.pDepthStencilAttachment) { |
| primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; |
| } |
| if (secondary_desc.pDepthStencilAttachment) { |
| secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; |
| } |
| skip |= validateAttachmentCompatibility(dev_data, type1_string, rp1_state, type2_string, rp2_state, primary_depthstencil_attach, |
| secondary_depthstencil_attach, caller, error_code); |
| return skip; |
| } |
| |
| // Verify that given renderPass CreateInfo for primary and secondary command buffers are compatible. |
| // This function deals directly with the CreateInfo, there are overloaded versions below that can take the renderPass handle and |
| // will then feed into this function |
| static bool validateRenderPassCompatibility(layer_data const *dev_data, const char *type1_string, |
| const RENDER_PASS_STATE *rp1_state, const char *type2_string, |
| const RENDER_PASS_STATE *rp2_state, const char *caller, |
| UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| bool skip = false; |
| |
| if (rp1_state->createInfo.subpassCount != rp2_state->createInfo.subpassCount) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| HandleToUint64(rp1_state->renderPass), __LINE__, error_code, "DS", |
| "%s: RenderPasses incompatible between %s w/ renderPass 0x%" PRIx64 |
| " with a subpassCount of %u and %s w/ renderPass 0x%" PRIx64 " with a subpassCount of %u. %s", |
| caller, type1_string, HandleToUint64(rp1_state->renderPass), rp1_state->createInfo.subpassCount, type2_string, |
| HandleToUint64(rp2_state->renderPass), rp2_state->createInfo.subpassCount, validation_error_map[error_code]); |
| } else { |
| for (uint32_t i = 0; i < rp1_state->createInfo.subpassCount; ++i) { |
| skip |= validateSubpassCompatibility(dev_data, type1_string, rp1_state, type2_string, rp2_state, i, caller, error_code); |
| } |
| } |
| return skip; |
| } |
| |
| // Return Set node ptr for specified set or else NULL |
| cvdescriptorset::DescriptorSet *GetSetNode(const layer_data *dev_data, VkDescriptorSet set) { |
| auto set_it = dev_data->setMap.find(set); |
| if (set_it == dev_data->setMap.end()) { |
| return NULL; |
| } |
| return set_it->second; |
| } |
| |
| // For given pipeline, return number of MSAA samples, or one if MSAA disabled |
| static VkSampleCountFlagBits getNumSamples(PIPELINE_STATE const *pipe) { |
| if (pipe->graphicsPipelineCI.pMultisampleState != NULL && |
| VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { |
| return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; |
| } |
| return VK_SAMPLE_COUNT_1_BIT; |
| } |
| |
| static void list_bits(std::ostream &s, uint32_t bits) { |
| for (int i = 0; i < 32 && bits; i++) { |
| if (bits & (1 << i)) { |
| s << i; |
| bits &= ~(1 << i); |
| if (bits) { |
| s << ","; |
| } |
| } |
| } |
| } |
| |
| // Validate draw-time state related to the PSO |
| static bool ValidatePipelineDrawtimeState(layer_data const *dev_data, LAST_BOUND_STATE const &state, const GLOBAL_CB_NODE *pCB, |
| CMD_TYPE cmd_type, PIPELINE_STATE const *pPipeline, const char *caller) { |
| bool skip = false; |
| |
| // Verify vertex binding |
| if (pPipeline->vertexBindingDescriptions.size() > 0) { |
| for (size_t i = 0; i < pPipeline->vertexBindingDescriptions.size(); i++) { |
| auto vertex_binding = pPipeline->vertexBindingDescriptions[i].binding; |
| if ((pCB->currentDrawData.buffers.size() < (vertex_binding + 1)) || |
| (pCB->currentDrawData.buffers[vertex_binding] == VK_NULL_HANDLE)) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCB->commandBuffer), __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", |
| "The Pipeline State Object (0x%" PRIx64 |
| ") expects that this Command Buffer's vertex binding Index %u should be set via " |
| "vkCmdBindVertexBuffers. This is because VkVertexInputBindingDescription struct at " |
| "index " PRINTF_SIZE_T_SPECIFIER " of pVertexBindingDescriptions has a binding value of %u.", |
| HandleToUint64(state.pipeline_state->pipeline), vertex_binding, i, vertex_binding); |
| } |
| } |
| } else { |
| if (!pCB->currentDrawData.buffers.empty() && !pCB->vertex_buffer_used) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(pCB->commandBuffer), __LINE__, |
| DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", |
| "Vertex buffers are bound to command buffer (0x%" PRIx64 |
| ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIx64 ").", |
| HandleToUint64(pCB->commandBuffer), HandleToUint64(state.pipeline_state->pipeline)); |
| } |
| } |
| // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. |
| // Skip check if rasterization is disabled or there is no viewport. |
| if ((!pPipeline->graphicsPipelineCI.pRasterizationState || |
| (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && |
| pPipeline->graphicsPipelineCI.pViewportState) { |
| bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); |
| bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); |
| |
| if (dynViewport) { |
| auto requiredViewportsMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->viewportCount) - 1; |
| auto missingViewportMask = ~pCB->viewportMask & requiredViewportsMask; |
| if (missingViewportMask) { |
| std::stringstream ss; |
| ss << "Dynamic viewport(s) "; |
| list_bits(ss, missingViewportMask); |
| ss << " are used by pipeline state object, but were not provided via calls to vkCmdSetViewport()."; |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "%s", ss.str().c_str()); |
| } |
| } |
| |
| if (dynScissor) { |
| auto requiredScissorMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->scissorCount) - 1; |
| auto missingScissorMask = ~pCB->scissorMask & requiredScissorMask; |
| if (missingScissorMask) { |
| std::stringstream ss; |
| ss << "Dynamic scissor(s) "; |
| list_bits(ss, missingScissorMask); |
| ss << " are used by pipeline state object, but were not provided via calls to vkCmdSetScissor()."; |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "%s", ss.str().c_str()); |
| } |
| } |
| } |
| |
| // Verify that any MSAA request in PSO matches sample# in bound FB |
| // Skip the check if rasterization is disabled. |
| if (!pPipeline->graphicsPipelineCI.pRasterizationState || |
| (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { |
| VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); |
| if (pCB->activeRenderPass) { |
| auto const render_pass_info = pCB->activeRenderPass->createInfo.ptr(); |
| const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; |
| uint32_t i; |
| unsigned subpass_num_samples = 0; |
| |
| for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { |
| auto attachment = subpass_desc->pColorAttachments[i].attachment; |
| if (attachment != VK_ATTACHMENT_UNUSED) |
| subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; |
| } |
| |
| if (subpass_desc->pDepthStencilAttachment && |
| subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| auto attachment = subpass_desc->pDepthStencilAttachment->attachment; |
| subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; |
| } |
| |
| if (!dev_data->extensions.vk_amd_mixed_attachment_samples && |
| ((subpass_num_samples & static_cast<unsigned>(pso_num_samples)) != subpass_num_samples)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", |
| "Num samples mismatch! At draw-time in Pipeline (0x%" PRIx64 |
| ") with %u samples while current RenderPass (0x%" PRIx64 ") w/ %u samples!", |
| HandleToUint64(pPipeline->pipeline), pso_num_samples, |
| HandleToUint64(pCB->activeRenderPass->renderPass), subpass_num_samples); |
| } |
| } else { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", |
| "No active render pass found at draw-time in Pipeline (0x%" PRIx64 ")!", |
| HandleToUint64(pPipeline->pipeline)); |
| } |
| } |
| // Verify that PSO creation renderPass is compatible with active renderPass |
| if (pCB->activeRenderPass) { |
| // TODO: Move all of the error codes common across different Draws into a LUT accessed by cmd_type |
| // TODO: AMD extension codes are included here, but actual function entrypoints are not yet intercepted |
| // Error codes for renderpass and subpass mismatches |
| auto rp_error = VALIDATION_ERROR_1a200366, sp_error = VALIDATION_ERROR_1a200368; |
| switch (cmd_type) { |
| case CMD_DRAWINDEXED: |
| rp_error = VALIDATION_ERROR_1a40038c; |
| sp_error = VALIDATION_ERROR_1a40038e; |
| break; |
| case CMD_DRAWINDIRECT: |
| rp_error = VALIDATION_ERROR_1aa003be; |
| sp_error = VALIDATION_ERROR_1aa003c0; |
| break; |
| case CMD_DRAWINDIRECTCOUNTAMD: |
| rp_error = VALIDATION_ERROR_1ac003f6; |
| sp_error = VALIDATION_ERROR_1ac003f8; |
| break; |
| case CMD_DRAWINDEXEDINDIRECT: |
| rp_error = VALIDATION_ERROR_1a600426; |
| sp_error = VALIDATION_ERROR_1a600428; |
| break; |
| case CMD_DRAWINDEXEDINDIRECTCOUNTAMD: |
| rp_error = VALIDATION_ERROR_1a800460; |
| sp_error = VALIDATION_ERROR_1a800462; |
| break; |
| default: |
| assert(CMD_DRAW == cmd_type); |
| break; |
| } |
| std::string err_string; |
| if (pCB->activeRenderPass->renderPass != pPipeline->rp_state->renderPass) { |
| // renderPass that PSO was created with must be compatible with active renderPass that PSO is being used with |
| skip |= validateRenderPassCompatibility(dev_data, "active render pass", pCB->activeRenderPass, "pipeline state object", |
| pPipeline->rp_state.get(), caller, rp_error); |
| } |
| if (pPipeline->graphicsPipelineCI.subpass != pCB->activeSubpass) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, sp_error, "DS", |
| "Pipeline was built for subpass %u but used in subpass %u. %s", pPipeline->graphicsPipelineCI.subpass, |
| pCB->activeSubpass, validation_error_map[sp_error]); |
| } |
| } |
| |
| return skip; |
| } |
| |
| // For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to |
| // pipelineLayout[layoutIndex] |
| static bool verify_set_layout_compatibility(const cvdescriptorset::DescriptorSet *descriptor_set, |
| PIPELINE_LAYOUT_NODE const *pipeline_layout, const uint32_t layoutIndex, |
| string &errorMsg) { |
| auto num_sets = pipeline_layout->set_layouts.size(); |
| if (layoutIndex >= num_sets) { |
| stringstream errorStr; |
| errorStr << "VkPipelineLayout (" << pipeline_layout->layout << ") only contains " << num_sets |
| << " setLayouts corresponding to sets 0-" << num_sets - 1 << ", but you're attempting to bind set to index " |
| << layoutIndex; |
| errorMsg = errorStr.str(); |
| return false; |
| } |
| if (descriptor_set->IsPushDescriptor()) return true; |
| auto layout_node = pipeline_layout->set_layouts[layoutIndex]; |
| return descriptor_set->IsCompatible(layout_node.get(), &errorMsg); |
| } |
| |
| // Validate overall state at the time of a draw call |
| static bool ValidateDrawState(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, CMD_TYPE cmd_type, const bool indexed, |
| const VkPipelineBindPoint bind_point, const char *function, |
| UNIQUE_VALIDATION_ERROR_CODE const msg_code) { |
| bool result = false; |
| auto const &state = cb_node->lastBound[bind_point]; |
| PIPELINE_STATE *pPipe = state.pipeline_state; |
| if (nullptr == pPipe) { |
| result |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", |
| "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); |
| // Early return as any further checks below will be busted w/o a pipeline |
| if (result) return true; |
| } |
| // First check flag states |
| if (VK_PIPELINE_BIND_POINT_GRAPHICS == bind_point) |
| result = validate_draw_state_flags(dev_data, cb_node, pPipe, indexed, msg_code); |
| |
| // Now complete other state checks |
| if (VK_NULL_HANDLE != state.pipeline_layout.layout) { |
| string errorString; |
| auto pipeline_layout = pPipe->pipeline_layout; |
| |
| for (const auto &set_binding_pair : pPipe->active_slots) { |
| uint32_t setIndex = set_binding_pair.first; |
| // If valid set is not bound throw an error |
| if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { |
| result |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_node->commandBuffer), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", |
| "VkPipeline 0x%" PRIx64 " uses set #%u but that set is not bound.", HandleToUint64(pPipe->pipeline), setIndex); |
| } else if (!verify_set_layout_compatibility(state.boundDescriptorSets[setIndex], &pipeline_layout, setIndex, |
| errorString)) { |
| // Set is bound but not compatible w/ overlapping pipeline_layout from PSO |
| VkDescriptorSet setHandle = state.boundDescriptorSets[setIndex]->GetSet(); |
| result |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
| HandleToUint64(setHandle), __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", |
| "VkDescriptorSet (0x%" PRIx64 |
| ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIx64 " due to: %s", |
| HandleToUint64(setHandle), setIndex, HandleToUint64(pipeline_layout.layout), errorString.c_str()); |
| } else { // Valid set is bound and layout compatible, validate that it's updated |
| // Pull the set node |
| cvdescriptorset::DescriptorSet *descriptor_set = state.boundDescriptorSets[setIndex]; |
| // Validate the draw-time state for this descriptor set |
| std::string err_str; |
| if (!descriptor_set->IsPushDescriptor()) { |
| // For the "bindless" style resource usage with many descriptors, need to optimize command <-> descriptor |
| // binding validation. Take the requested binding set and prefilter it to eliminate redundant validation checks. |
| // Here, the currently bound pipeline determines whether an image validation check is redundant... |
| // for images are the "req" portion of the binding_req is indirectly (but tightly) coupled to the pipeline. |
| const cvdescriptorset::PrefilterBindRequestMap reduced_map(*descriptor_set, set_binding_pair.second, cb_node, |
| pPipe); |
| const auto &binding_req_map = reduced_map.Map(); |
| |
| if (!descriptor_set->ValidateDrawState(binding_req_map, state.dynamicOffsets[setIndex], cb_node, function, |
| &err_str)) { |
| auto set = descriptor_set->GetSet(); |
| result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, HandleToUint64(set), __LINE__, |
| DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", |
| "Descriptor set 0x%" PRIx64 " encountered the following validation error at %s time: %s", |
| HandleToUint64(set), function, err_str.c_str()); |
| } |
| } |
| } |
| } |
| } |
| |
| // Check general pipeline state that needs to be validated at drawtime |
| if (VK_PIPELINE_BIND_POINT_GRAPHICS == bind_point) |
| result |= ValidatePipelineDrawtimeState(dev_data, state, cb_node, cmd_type, pPipe, function); |
| |
| return result; |
| } |
| |
| static void UpdateDrawState(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, const VkPipelineBindPoint bind_point) { |
| auto const &state = cb_state->lastBound[bind_point]; |
| PIPELINE_STATE *pPipe = state.pipeline_state; |
| if (VK_NULL_HANDLE != state.pipeline_layout.layout) { |
| for (const auto &set_binding_pair : pPipe->active_slots) { |
| uint32_t setIndex = set_binding_pair.first; |
| // Pull the set node |
| cvdescriptorset::DescriptorSet *descriptor_set = state.boundDescriptorSets[setIndex]; |
| if (!descriptor_set->IsPushDescriptor()) { |
| // For the "bindless" style resource usage with many descriptors, need to optimize command <-> descriptor binding |
| const cvdescriptorset::PrefilterBindRequestMap reduced_map(*descriptor_set, set_binding_pair.second, cb_state); |
| const auto &binding_req_map = reduced_map.Map(); |
| |
| // Bind this set and its active descriptor resources to the command buffer |
| descriptor_set->BindCommandBuffer(cb_state, binding_req_map); |
| // For given active slots record updated images & buffers |
| descriptor_set->GetStorageUpdates(binding_req_map, &cb_state->updateBuffers, &cb_state->updateImages); |
| } |
| } |
| } |
| if (pPipe->vertexBindingDescriptions.size() > 0) { |
| cb_state->vertex_buffer_used = true; |
| } |
| } |
| |
| static bool ValidatePipelineLocked(layer_data *dev_data, std::vector<std::unique_ptr<PIPELINE_STATE>> const &pPipelines, |
| int pipelineIndex) { |
| bool skip = false; |
| |
| PIPELINE_STATE *pPipeline = pPipelines[pipelineIndex].get(); |
| |
| // If create derivative bit is set, check that we've specified a base |
| // pipeline correctly, and that the base pipeline was created to allow |
| // derivatives. |
| if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { |
| PIPELINE_STATE *pBasePipeline = nullptr; |
| if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ |
| (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { |
| // This check is a superset of VALIDATION_ERROR_096005a8 and VALIDATION_ERROR_096005aa |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
| "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); |
| } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { |
| if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_208005a0, "DS", |
| "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline. %s", |
| validation_error_map[VALIDATION_ERROR_208005a0]); |
| } else { |
| pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex].get(); |
| } |
| } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { |
| pBasePipeline = getPipelineState(dev_data, pPipeline->graphicsPipelineCI.basePipelineHandle); |
| } |
| |
| if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
| "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); |
| } |
| } |
| |
| return skip; |
| } |
| |
| // UNLOCKED pipeline validation. DO NOT lookup objects in the layer_data->* maps in this function. |
| static bool ValidatePipelineUnlocked(layer_data *dev_data, std::vector<std::unique_ptr<PIPELINE_STATE>> const &pPipelines, |
| int pipelineIndex) { |
| bool skip = false; |
| |
| PIPELINE_STATE *pPipeline = pPipelines[pipelineIndex].get(); |
| |
| // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state |
| // produces nonsense errors that confuse users. Other layers should already |
| // emit errors for renderpass being invalid. |
| auto subpass_desc = &pPipeline->rp_state->createInfo.pSubpasses[pPipeline->graphicsPipelineCI.subpass]; |
| if (pPipeline->graphicsPipelineCI.subpass >= pPipeline->rp_state->createInfo.subpassCount) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_096005ee, "DS", |
| "Invalid Pipeline CreateInfo State: Subpass index %u is out of range for this renderpass (0..%u). %s", |
| pPipeline->graphicsPipelineCI.subpass, pPipeline->rp_state->createInfo.subpassCount - 1, |
| validation_error_map[VALIDATION_ERROR_096005ee]); |
| subpass_desc = nullptr; |
| } |
| |
| if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { |
| const safe_VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; |
| if (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_096005d4, "DS", |
| "vkCreateGraphicsPipelines(): Render pass (0x%" PRIx64 |
| ") subpass %u has colorAttachmentCount of %u which doesn't match the pColorBlendState->attachmentCount of %u. %s", |
| HandleToUint64(pPipeline->rp_state->renderPass), pPipeline->graphicsPipelineCI.subpass, |
| subpass_desc->colorAttachmentCount, color_blend_state->attachmentCount, |
| validation_error_map[VALIDATION_ERROR_096005d4]); |
| } |
| if (!dev_data->enabled_features.independentBlend) { |
| if (pPipeline->attachments.size() > 1) { |
| VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; |
| for (size_t i = 1; i < pPipeline->attachments.size(); i++) { |
| // Quoting the spec: "If [the independent blend] feature is not enabled, the VkPipelineColorBlendAttachmentState |
| // settings for all color attachments must be identical." VkPipelineColorBlendAttachmentState contains |
| // only attachment state, so memcmp is best suited for the comparison |
| if (memcmp(static_cast<const void *>(pAttachments), static_cast<const void *>(&pAttachments[i]), |
| sizeof(pAttachments[0]))) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_0f4004ba, "DS", |
| "Invalid Pipeline CreateInfo: If independent blend feature not enabled, all elements of " |
| "pAttachments must be identical. %s", |
| validation_error_map[VALIDATION_ERROR_0f4004ba]); |
| break; |
| } |
| } |
| } |
| } |
| if (!dev_data->enabled_features.logicOp && (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_0f4004bc, "DS", |
| "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE. %s", |
| validation_error_map[VALIDATION_ERROR_0f4004bc]); |
| } |
| } |
| |
| if (validate_and_capture_pipeline_shader_state(dev_data, pPipeline)) { |
| skip = true; |
| } |
| // Each shader's stage must be unique |
| if (pPipeline->duplicate_shaders) { |
| for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { |
| if (pPipeline->duplicate_shaders & stage) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
| "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", |
| string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); |
| } |
| } |
| } |
| // VS is required |
| if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_096005ae, "DS", |
| "Invalid Pipeline CreateInfo State: Vertex Shader required. %s", |
| validation_error_map[VALIDATION_ERROR_096005ae]); |
| } |
| // Either both or neither TC/TE shaders should be defined |
| bool has_control = (pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) != 0; |
| bool has_eval = (pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) != 0; |
| if (has_control && !has_eval) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_096005b2, "DS", |
| "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair. %s", |
| validation_error_map[VALIDATION_ERROR_096005b2]); |
| } |
| if (!has_control && has_eval) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_096005b4, "DS", |
| "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair. %s", |
| validation_error_map[VALIDATION_ERROR_096005b4]); |
| } |
| // Compute shaders should be specified independent of Gfx shaders |
| if (pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_096005b0, "DS", |
| "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline. %s", |
| validation_error_map[VALIDATION_ERROR_096005b0]); |
| } |
| // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. |
| // Mismatching primitive topology and tessellation fails graphics pipeline creation. |
| if (has_control && has_eval && |
| (!pPipeline->graphicsPipelineCI.pInputAssemblyState || |
| pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_096005c0, "DS", |
| "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA topology for " |
| "tessellation pipelines. %s", |
| validation_error_map[VALIDATION_ERROR_096005c0]); |
| } |
| if (pPipeline->graphicsPipelineCI.pInputAssemblyState && |
| pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { |
| if (!has_control || !has_eval) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_096005c2, "DS", |
| "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid " |
| "for tessellation pipelines. %s", |
| validation_error_map[VALIDATION_ERROR_096005c2]); |
| } |
| } |
| |
| // If a rasterization state is provided... |
| if (pPipeline->graphicsPipelineCI.pRasterizationState) { |
| if ((pPipeline->graphicsPipelineCI.pRasterizationState->depthClampEnable == VK_TRUE) && |
| (!dev_data->enabled_features.depthClamp)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_1020061c, "DS", |
| "vkCreateGraphicsPipelines(): the depthClamp device feature is disabled: the depthClampEnable member " |
| "of the VkPipelineRasterizationStateCreateInfo structure must be set to VK_FALSE. %s", |
| validation_error_map[VALIDATION_ERROR_1020061c]); |
| } |
| |
| if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_DEPTH_BIAS) && |
| (pPipeline->graphicsPipelineCI.pRasterizationState->depthBiasClamp != 0.0) && |
| (!dev_data->enabled_features.depthBiasClamp)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_FEATURE, "DS", |
| "vkCreateGraphicsPipelines(): the depthBiasClamp device feature is disabled: the depthBiasClamp member " |
| "of the VkPipelineRasterizationStateCreateInfo structure must be set to 0.0 unless the " |
| "VK_DYNAMIC_STATE_DEPTH_BIAS dynamic state is enabled"); |
| } |
| |
| // If rasterization is enabled... |
| if (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE) { |
| if ((pPipeline->graphicsPipelineCI.pMultisampleState->alphaToOneEnable == VK_TRUE) && |
| (!dev_data->enabled_features.alphaToOne)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_10000622, "DS", |
| "vkCreateGraphicsPipelines(): the alphaToOne device feature is disabled: the alphaToOneEnable " |
| "member of the VkPipelineMultisampleStateCreateInfo structure must be set to VK_FALSE. %s", |
| validation_error_map[VALIDATION_ERROR_10000622]); |
| } |
| |
| // If subpass uses a depth/stencil attachment, pDepthStencilState must be a pointer to a valid structure |
| if (subpass_desc && subpass_desc->pDepthStencilAttachment && |
| subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| if (!pPipeline->graphicsPipelineCI.pDepthStencilState) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_096005e0, "DS", |
| "Invalid Pipeline CreateInfo State: pDepthStencilState is NULL when rasterization is enabled " |
| "and subpass uses a depth/stencil attachment. %s", |
| validation_error_map[VALIDATION_ERROR_096005e0]); |
| |
| } else if ((pPipeline->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE) && |
| (!dev_data->enabled_features.depthBounds)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_0f6004ac, "DS", |
| "vkCreateGraphicsPipelines(): the depthBounds device feature is disabled: the " |
| "depthBoundsTestEnable member of the VkPipelineDepthStencilStateCreateInfo structure must be " |
| "set to VK_FALSE. %s", |
| validation_error_map[VALIDATION_ERROR_0f6004ac]); |
| } |
| } |
| |
| // If subpass uses color attachments, pColorBlendState must be valid pointer |
| if (subpass_desc) { |
| uint32_t color_attachment_count = 0; |
| for (uint32_t i = 0; i < subpass_desc->colorAttachmentCount; ++i) { |
| if (subpass_desc->pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) { |
| ++color_attachment_count; |
| } |
| } |
| if (color_attachment_count > 0 && pPipeline->graphicsPipelineCI.pColorBlendState == nullptr) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_096005e2, "DS", |
| "Invalid Pipeline CreateInfo State: pColorBlendState is NULL when rasterization is enabled and " |
| "subpass uses color attachments. %s", |
| validation_error_map[VALIDATION_ERROR_096005e2]); |
| } |
| } |
| } |
| } |
| |
| auto vi = pPipeline->graphicsPipelineCI.pVertexInputState; |
| if (vi != NULL) { |
| for (uint32_t j = 0; j < vi->vertexAttributeDescriptionCount; j++) { |
| VkFormat format = vi->pVertexAttributeDescriptions[j].format; |
| // Internal call to get format info. Still goes through layers, could potentially go directly to ICD. |
| VkFormatProperties properties; |
| dev_data->instance_data->dispatch_table.GetPhysicalDeviceFormatProperties(dev_data->physical_device, format, |
| &properties); |
| if ((properties.bufferFeatures & VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT) == 0) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_14a004de, "IMAGE", |
| "vkCreateGraphicsPipelines: pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].format " |
| "(%s) is not a supported vertex buffer format. %s", |
| pipelineIndex, j, string_VkFormat(format), validation_error_map[VALIDATION_ERROR_14a004de]); |
| } |
| } |
| } |
| |
| if (dev_data->extensions.vk_amd_mixed_attachment_samples) { |
| VkSampleCountFlagBits max_sample_count = static_cast<VkSampleCountFlagBits>(0); |
| for (uint32_t i = 0; i < subpass_desc->colorAttachmentCount; ++i) { |
| if (subpass_desc->pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) { |
| max_sample_count = |
| std::max(max_sample_count, |
| pPipeline->rp_state->createInfo.pAttachments[subpass_desc->pColorAttachments[i].attachment].samples); |
| } |
| } |
| if (subpass_desc->pDepthStencilAttachment && subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| max_sample_count = |
| std::max(max_sample_count, |
| pPipeline->rp_state->createInfo.pAttachments[subpass_desc->pDepthStencilAttachment->attachment].samples); |
| } |
| if (pPipeline->graphicsPipelineCI.pMultisampleState->rasterizationSamples != max_sample_count) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pPipeline->pipeline), __LINE__, VALIDATION_ERROR_09600bc2, "DS", |
| "vkCreateGraphicsPipelines: pCreateInfo[%d].pMultisampleState->rasterizationSamples (%s) != max " |
| "attachment samples (%s) used in subpass %u. %s", |
| pipelineIndex, |
| string_VkSampleCountFlagBits(pPipeline->graphicsPipelineCI.pMultisampleState->rasterizationSamples), |
| string_VkSampleCountFlagBits(max_sample_count), pPipeline->graphicsPipelineCI.subpass, |
| validation_error_map[VALIDATION_ERROR_09600bc2]); |
| } |
| } |
| |
| return skip; |
| } |
| |
| // Block of code at start here specifically for managing/tracking DSs |
| |
| // Return Pool node ptr for specified pool or else NULL |
| DESCRIPTOR_POOL_STATE *GetDescriptorPoolState(const layer_data *dev_data, const VkDescriptorPool pool) { |
| auto pool_it = dev_data->descriptorPoolMap.find(pool); |
| if (pool_it == dev_data->descriptorPoolMap.end()) { |
| return NULL; |
| } |
| return pool_it->second; |
| } |
| |
| // Validate that given set is valid and that it's not being used by an in-flight CmdBuffer |
| // func_str is the name of the calling function |
| // Return false if no errors occur |
| // Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) |
| static bool validateIdleDescriptorSet(const layer_data *dev_data, VkDescriptorSet set, std::string func_str) { |
| if (dev_data->instance_data->disabled.idle_descriptor_set) return false; |
| bool skip = false; |
| auto set_node = dev_data->setMap.find(set); |
| if (set_node == dev_data->setMap.end()) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
| HandleToUint64(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", |
| "Cannot call %s() on descriptor set 0x%" PRIx64 " that has not been allocated.", func_str.c_str(), |
| HandleToUint64(set)); |
| } else { |
| // TODO : This covers various error cases so should pass error enum into this function and use passed in enum here |
| if (set_node->second->in_use.load()) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
| HandleToUint64(set), __LINE__, VALIDATION_ERROR_2860026a, "DS", |
| "Cannot call %s() on descriptor set 0x%" PRIx64 " that is in use by a command buffer. %s", |
| func_str.c_str(), HandleToUint64(set), validation_error_map[VALIDATION_ERROR_2860026a]); |
| } |
| } |
| return skip; |
| } |
| |
| // Remove set from setMap and delete the set |
| static void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { |
| dev_data->setMap.erase(descriptor_set->GetSet()); |
| delete descriptor_set; |
| } |
| // Free all DS Pools including their Sets & related sub-structs |
| // NOTE : Calls to this function should be wrapped in mutex |
| static void deletePools(layer_data *dev_data) { |
| for (auto ii = dev_data->descriptorPoolMap.begin(); ii != dev_data->descriptorPoolMap.end();) { |
| // Remove this pools' sets from setMap and delete them |
| for (auto ds : ii->second->sets) { |
| freeDescriptorSet(dev_data, ds); |
| } |
| ii->second->sets.clear(); |
| delete ii->second; |
| ii = dev_data->descriptorPoolMap.erase(ii); |
| } |
| } |
| |
| static void clearDescriptorPool(layer_data *dev_data, const VkDevice device, const VkDescriptorPool pool, |
| VkDescriptorPoolResetFlags flags) { |
| DESCRIPTOR_POOL_STATE *pPool = GetDescriptorPoolState(dev_data, pool); |
| // TODO: validate flags |
| // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet |
| for (auto ds : pPool->sets) { |
| freeDescriptorSet(dev_data, ds); |
| } |
| pPool->sets.clear(); |
| // Reset available count for each type and available sets for this pool |
| for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { |
| pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; |
| } |
| pPool->availableSets = pPool->maxSets; |
| } |
| |
| // For given CB object, fetch associated CB Node from map |
| GLOBAL_CB_NODE *GetCBNode(layer_data const *dev_data, const VkCommandBuffer cb) { |
| auto it = dev_data->commandBufferMap.find(cb); |
| if (it == dev_data->commandBufferMap.end()) { |
| return NULL; |
| } |
| return it->second; |
| } |
| |
| // If a renderpass is active, verify that the given command type is appropriate for current subpass state |
| bool ValidateCmdSubpassState(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { |
| if (!pCB->activeRenderPass) return false; |
| bool skip = false; |
| if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && |
| (cmd_type != CMD_EXECUTECOMMANDS && cmd_type != CMD_NEXTSUBPASS && cmd_type != CMD_ENDRENDERPASS)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| "Commands cannot be called in a subpass using secondary command buffers."); |
| } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); |
| } |
| return skip; |
| } |
| |
| bool ValidateCmdQueueFlags(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *caller_name, |
| VkQueueFlags required_flags, UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| auto pool = GetCommandPoolNode(dev_data, cb_node->createInfo.commandPool); |
| if (pool) { |
| VkQueueFlags queue_flags = dev_data->phys_dev_properties.queue_family_properties[pool->queueFamilyIndex].queueFlags; |
| if (!(required_flags & queue_flags)) { |
| string required_flags_string; |
| for (auto flag : {VK_QUEUE_TRANSFER_BIT, VK_QUEUE_GRAPHICS_BIT, VK_QUEUE_COMPUTE_BIT}) { |
| if (flag & required_flags) { |
| if (required_flags_string.size()) { |
| required_flags_string += " or "; |
| } |
| required_flags_string += string_VkQueueFlagBits(flag); |
| } |
| } |
| return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_node->commandBuffer), __LINE__, error_code, "DS", |
| "Cannot call %s on a command buffer allocated from a pool without %s capabilities. %s.", caller_name, |
| required_flags_string.c_str(), validation_error_map[error_code]); |
| } |
| } |
| return false; |
| } |
| |
| static char const *GetCauseStr(VK_OBJECT obj) { |
| if (obj.type == kVulkanObjectTypeDescriptorSet) return "destroyed or updated"; |
| if (obj.type == kVulkanObjectTypeCommandBuffer) return "destroyed or rerecorded"; |
| return "destroyed"; |
| } |
| |
| static bool ReportInvalidCommandBuffer(layer_data *dev_data, const GLOBAL_CB_NODE *cb_state, const char *call_source) { |
| bool skip = false; |
| for (auto obj : cb_state->broken_bindings) { |
| const char *type_str = object_string[obj.type]; |
| const char *cause_str = GetCauseStr(obj); |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| "You are adding %s to command buffer 0x%" PRIx64 " that is invalid because bound %s 0x%" PRIx64 " was %s.", |
| call_source, HandleToUint64(cb_state->commandBuffer), type_str, obj.handle, cause_str); |
| } |
| return skip; |
| } |
| |
| // 'commandBuffer must be in the recording state' valid usage error code for each command |
| // Note: grepping for ^^^^^^^^^ in vk_validation_database is easily massaged into the following list |
| // Note: C++11 doesn't automatically devolve enum types to the underlying type for hash traits purposes (fixed in C++14) |
| using CmdTypeHashType = std::underlying_type<CMD_TYPE>::type; |
| static const std::unordered_map<CmdTypeHashType, UNIQUE_VALIDATION_ERROR_CODE> must_be_recording_map = { |
| {CMD_NONE, VALIDATION_ERROR_UNDEFINED}, // UNMATCHED |
| {CMD_BEGINQUERY, VALIDATION_ERROR_17802413}, |
| {CMD_BEGINRENDERPASS, VALIDATION_ERROR_17a02413}, |
| {CMD_BINDDESCRIPTORSETS, VALIDATION_ERROR_17c02413}, |
| {CMD_BINDINDEXBUFFER, VALIDATION_ERROR_17e02413}, |
| {CMD_BINDPIPELINE, VALIDATION_ERROR_18002413}, |
| {CMD_BINDVERTEXBUFFERS, VALIDATION_ERROR_18202413}, |
| {CMD_BLITIMAGE, VALIDATION_ERROR_18402413}, |
| {CMD_CLEARATTACHMENTS, VALIDATION_ERROR_18602413}, |
| {CMD_CLEARCOLORIMAGE, VALIDATION_ERROR_18802413}, |
| {CMD_CLEARDEPTHSTENCILIMAGE, VALIDATION_ERROR_18a02413}, |
| {CMD_COPYBUFFER, VALIDATION_ERROR_18c02413}, |
| {CMD_COPYBUFFERTOIMAGE, VALIDATION_ERROR_18e02413}, |
| {CMD_COPYIMAGE, VALIDATION_ERROR_19002413}, |
| {CMD_COPYIMAGETOBUFFER, VALIDATION_ERROR_19202413}, |
| {CMD_COPYQUERYPOOLRESULTS, VALIDATION_ERROR_19402413}, |
| {CMD_DEBUGMARKERBEGINEXT, VALIDATION_ERROR_19602413}, |
| {CMD_DEBUGMARKERENDEXT, VALIDATION_ERROR_19802413}, |
| {CMD_DEBUGMARKERINSERTEXT, VALIDATION_ERROR_19a02413}, |
| {CMD_DISPATCH, VALIDATION_ERROR_19c02413}, |
| // Exclude KHX (if not already present) { CMD_DISPATCHBASEKHX, VALIDATION_ERROR_19e02413 }, |
| {CMD_DISPATCHINDIRECT, VALIDATION_ERROR_1a002413}, |
| {CMD_DRAW, VALIDATION_ERROR_1a202413}, |
| {CMD_DRAWINDEXED, VALIDATION_ERROR_1a402413}, |
| {CMD_DRAWINDEXEDINDIRECT, VALIDATION_ERROR_1a602413}, |
| // Exclude vendor ext (if not already present) { CMD_DRAWINDEXEDINDIRECTCOUNTAMD, VALIDATION_ERROR_1a802413 }, |
| {CMD_DRAWINDIRECT, VALIDATION_ERROR_1aa02413}, |
| // Exclude vendor ext (if not already present) { CMD_DRAWINDIRECTCOUNTAMD, VALIDATION_ERROR_1ac02413 }, |
| {CMD_ENDCOMMANDBUFFER, VALIDATION_ERROR_27400076}, |
| {CMD_ENDQUERY, VALIDATION_ERROR_1ae02413}, |
| {CMD_ENDRENDERPASS, VALIDATION_ERROR_1b002413}, |
| {CMD_EXECUTECOMMANDS, VALIDATION_ERROR_1b202413}, |
| {CMD_FILLBUFFER, VALIDATION_ERROR_1b402413}, |
| {CMD_NEXTSUBPASS, VALIDATION_ERROR_1b602413}, |
| {CMD_PIPELINEBARRIER, VALIDATION_ERROR_1b802413}, |
| // Exclude vendor ext (if not already present) { CMD_PROCESSCOMMANDSNVX, VALIDATION_ERROR_1ba02413 }, |
| {CMD_PUSHCONSTANTS, VALIDATION_ERROR_1bc02413}, |
| {CMD_PUSHDESCRIPTORSETKHR, VALIDATION_ERROR_1be02413}, |
| {CMD_PUSHDESCRIPTORSETWITHTEMPLATEKHR, VALIDATION_ERROR_1c002413}, |
| // Exclude vendor ext (if not already present) { CMD_RESERVESPACEFORCOMMANDSNVX, VALIDATION_ERROR_1c202413 }, |
| {CMD_RESETEVENT, VALIDATION_ERROR_1c402413}, |
| {CMD_RESETQUERYPOOL, VALIDATION_ERROR_1c602413}, |
| {CMD_RESOLVEIMAGE, VALIDATION_ERROR_1c802413}, |
| {CMD_SETBLENDCONSTANTS, VALIDATION_ERROR_1ca02413}, |
| {CMD_SETDEPTHBIAS, VALIDATION_ERROR_1cc02413}, |
| {CMD_SETDEPTHBOUNDS, VALIDATION_ERROR_1ce02413}, |
| // Exclude KHX (if not already present) { CMD_SETDEVICEMASKKHX, VALIDATION_ERROR_1d002413 }, |
| {CMD_SETDISCARDRECTANGLEEXT, VALIDATION_ERROR_1d202413}, |
| {CMD_SETEVENT, VALIDATION_ERROR_1d402413}, |
| {CMD_SETLINEWIDTH, VALIDATION_ERROR_1d602413}, |
| {CMD_SETSAMPLELOCATIONSEXT, VALIDATION_ERROR_3e202413}, |
| {CMD_SETSCISSOR, VALIDATION_ERROR_1d802413}, |
| {CMD_SETSTENCILCOMPAREMASK, VALIDATION_ERROR_1da02413}, |
| {CMD_SETSTENCILREFERENCE, VALIDATION_ERROR_1dc02413}, |
| {CMD_SETSTENCILWRITEMASK, VALIDATION_ERROR_1de02413}, |
| {CMD_SETVIEWPORT, VALIDATION_ERROR_1e002413}, |
| // Exclude vendor ext (if not already present) { CMD_SETVIEWPORTWSCALINGNV, VALIDATION_ERROR_1e202413 }, |
| {CMD_UPDATEBUFFER, VALIDATION_ERROR_1e402413}, |
| {CMD_WAITEVENTS, VALIDATION_ERROR_1e602413}, |
| {CMD_WRITETIMESTAMP, VALIDATION_ERROR_1e802413}, |
| }; |
| |
| // Validate the given command being added to the specified cmd buffer, flagging errors if CB is not in the recording state or if |
| // there's an issue with the Cmd ordering |
| bool ValidateCmd(layer_data *dev_data, const GLOBAL_CB_NODE *cb_state, const CMD_TYPE cmd, const char *caller_name) { |
| switch (cb_state->state) { |
| case CB_RECORDING: |
| return ValidateCmdSubpassState(dev_data, cb_state, cmd); |
| |
| case CB_INVALID_COMPLETE: |
| case CB_INVALID_INCOMPLETE: |
| return ReportInvalidCommandBuffer(dev_data, cb_state, caller_name); |
| |
| default: |
| auto error_it = must_be_recording_map.find(cmd); |
| // This assert lets us know that a vkCmd.* entrypoint has been added without enabling it in the map |
| assert(error_it != must_be_recording_map.cend()); |
| if (error_it == must_be_recording_map.cend()) { |
| error_it = must_be_recording_map.find(CMD_NONE); // But we'll handle the asserting case, in case of a test gap |
| } |
| const auto error = error_it->second; |
| return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, error, "DS", |
| "You must call vkBeginCommandBuffer() before this call to %s. %s", caller_name, |
| validation_error_map[error]); |
| } |
| } |
| |
| // For given object struct return a ptr of BASE_NODE type for its wrapping struct |
| BASE_NODE *GetStateStructPtrFromObject(layer_data *dev_data, VK_OBJECT object_struct) { |
| BASE_NODE *base_ptr = nullptr; |
| switch (object_struct.type) { |
| case kVulkanObjectTypeDescriptorSet: { |
| base_ptr = GetSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypeSampler: { |
| base_ptr = GetSamplerState(dev_data, reinterpret_cast<VkSampler &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypeQueryPool: { |
| base_ptr = GetQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypePipeline: { |
| base_ptr = getPipelineState(dev_data, reinterpret_cast<VkPipeline &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypeBuffer: { |
| base_ptr = GetBufferState(dev_data, reinterpret_cast<VkBuffer &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypeBufferView: { |
| base_ptr = GetBufferViewState(dev_data, reinterpret_cast<VkBufferView &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypeImage: { |
| base_ptr = GetImageState(dev_data, reinterpret_cast<VkImage &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypeImageView: { |
| base_ptr = GetImageViewState(dev_data, reinterpret_cast<VkImageView &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypeEvent: { |
| base_ptr = GetEventNode(dev_data, reinterpret_cast<VkEvent &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypeDescriptorPool: { |
| base_ptr = GetDescriptorPoolState(dev_data, reinterpret_cast<VkDescriptorPool &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypeCommandPool: { |
| base_ptr = GetCommandPoolNode(dev_data, reinterpret_cast<VkCommandPool &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypeFramebuffer: { |
| base_ptr = GetFramebufferState(dev_data, reinterpret_cast<VkFramebuffer &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypeRenderPass: { |
| base_ptr = GetRenderPassState(dev_data, reinterpret_cast<VkRenderPass &>(object_struct.handle)); |
| break; |
| } |
| case kVulkanObjectTypeDeviceMemory: { |
| base_ptr = GetMemObjInfo(dev_data, reinterpret_cast<VkDeviceMemory &>(object_struct.handle)); |
| break; |
| } |
| default: |
| // TODO : Any other objects to be handled here? |
| assert(0); |
| break; |
| } |
| return base_ptr; |
| } |
| |
| // Tie the VK_OBJECT to the cmd buffer which includes: |
| // Add object_binding to cmd buffer |
| // Add cb_binding to object |
| static void addCommandBufferBinding(std::unordered_set<GLOBAL_CB_NODE *> *cb_bindings, VK_OBJECT obj, GLOBAL_CB_NODE *cb_node) { |
| cb_bindings->insert(cb_node); |
| cb_node->object_bindings.insert(obj); |
| } |
| // For a given object, if cb_node is in that objects cb_bindings, remove cb_node |
| static void removeCommandBufferBinding(layer_data *dev_data, VK_OBJECT const *object, GLOBAL_CB_NODE *cb_node) { |
| BASE_NODE *base_obj = GetStateStructPtrFromObject(dev_data, *object); |
| if (base_obj) base_obj->cb_bindings.erase(cb_node); |
| } |
| // Reset the command buffer state |
| // Maintain the createInfo and set state to CB_NEW, but clear all other state |
| static void ResetCommandBufferState(layer_data *dev_data, const VkCommandBuffer cb) { |
| GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; |
| if (pCB) { |
| pCB->in_use.store(0); |
| // Reset CB state (note that createInfo is not cleared) |
| pCB->commandBuffer = cb; |
| memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); |
| memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); |
| pCB->hasDrawCmd = false; |
| pCB->state = CB_NEW; |
| pCB->submitCount = 0; |
| pCB->image_layout_change_count = 1; // Start at 1. 0 is insert value for validation cache versions, s.t. new == dirty |
| pCB->status = 0; |
| pCB->static_status = 0; |
| pCB->viewportMask = 0; |
| pCB->scissorMask = 0; |
| |
| for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { |
| pCB->lastBound[i].reset(); |
| } |
| |
| memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); |
| pCB->activeRenderPass = nullptr; |
| pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; |
| pCB->activeSubpass = 0; |
| pCB->broken_bindings.clear(); |
| pCB->waitedEvents.clear(); |
| pCB->events.clear(); |
| pCB->writeEventsBeforeWait.clear(); |
| pCB->waitedEventsBeforeQueryReset.clear(); |
| pCB->queryToStateMap.clear(); |
| pCB->activeQueries.clear(); |
| pCB->startedQueries.clear(); |
| pCB->imageLayoutMap.clear(); |
| pCB->eventToStageMap.clear(); |
| pCB->drawData.clear(); |
| pCB->currentDrawData.buffers.clear(); |
| pCB->vertex_buffer_used = false; |
| pCB->primaryCommandBuffer = VK_NULL_HANDLE; |
| // If secondary, invalidate any primary command buffer that may call us. |
| if (pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) { |
| invalidateCommandBuffers(dev_data, pCB->linkedCommandBuffers, {HandleToUint64(cb), kVulkanObjectTypeCommandBuffer}); |
| } |
| |
| // Remove reverse command buffer links. |
| for (auto pSubCB : pCB->linkedCommandBuffers) { |
| pSubCB->linkedCommandBuffers.erase(pCB); |
| } |
| pCB->linkedCommandBuffers.clear(); |
| pCB->updateImages.clear(); |
| pCB->updateBuffers.clear(); |
| clear_cmd_buf_and_mem_references(dev_data, pCB); |
| pCB->queue_submit_functions.clear(); |
| pCB->cmd_execute_commands_functions.clear(); |
| pCB->eventUpdates.clear(); |
| pCB->queryUpdates.clear(); |
| |
| // Remove object bindings |
| for (auto obj : pCB->object_bindings) { |
| removeCommandBufferBinding(dev_data, &obj, pCB); |
| } |
| pCB->object_bindings.clear(); |
| // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list |
| for (auto framebuffer : pCB->framebuffers) { |
| auto fb_state = GetFramebufferState(dev_data, framebuffer); |
| if (fb_state) fb_state->cb_bindings.erase(pCB); |
| } |
| pCB->framebuffers.clear(); |
| pCB->activeFramebuffer = VK_NULL_HANDLE; |
| } |
| } |
| |
| CBStatusFlags MakeStaticStateMask(VkPipelineDynamicStateCreateInfo const *ds) { |
| // initially assume everything is static state |
| CBStatusFlags flags = CBSTATUS_ALL_STATE_SET; |
| |
| if (ds) { |
| for (uint32_t i = 0; i < ds->dynamicStateCount; i++) { |
| switch (ds->pDynamicStates[i]) { |
| case VK_DYNAMIC_STATE_LINE_WIDTH: |
| flags &= ~CBSTATUS_LINE_WIDTH_SET; |
| break; |
| case VK_DYNAMIC_STATE_DEPTH_BIAS: |
| flags &= ~CBSTATUS_DEPTH_BIAS_SET; |
| break; |
| case VK_DYNAMIC_STATE_BLEND_CONSTANTS: |
| flags &= ~CBSTATUS_BLEND_CONSTANTS_SET; |
| break; |
| case VK_DYNAMIC_STATE_DEPTH_BOUNDS: |
| flags &= ~CBSTATUS_DEPTH_BOUNDS_SET; |
| break; |
| case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: |
| flags &= ~CBSTATUS_STENCIL_READ_MASK_SET; |
| break; |
| case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: |
| flags &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; |
| break; |
| case VK_DYNAMIC_STATE_STENCIL_REFERENCE: |
| flags &= ~CBSTATUS_STENCIL_REFERENCE_SET; |
| break; |
| case VK_DYNAMIC_STATE_SCISSOR: |
| flags &= ~CBSTATUS_SCISSOR_SET; |
| break; |
| case VK_DYNAMIC_STATE_VIEWPORT: |
| flags &= ~CBSTATUS_VIEWPORT_SET; |
| break; |
| default: |
| break; |
| } |
| } |
| } |
| |
| return flags; |
| } |
| |
| // Flags validation error if the associated call is made inside a render pass. The apiName routine should ONLY be called outside a |
| // render pass. |
| bool insideRenderPass(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const char *apiName, |
| UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
| bool inside = false; |
| if (pCB->activeRenderPass) { |
| inside = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCB->commandBuffer), __LINE__, msgCode, "DS", |
| "%s: It is invalid to issue this call inside an active render pass (0x%" PRIx64 "). %s", apiName, |
| HandleToUint64(pCB->activeRenderPass->renderPass), validation_error_map[msgCode]); |
| } |
| return inside; |
| } |
| |
| // Flags validation error if the associated call is made outside a render pass. The apiName |
| // routine should ONLY be called inside a render pass. |
| bool outsideRenderPass(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, const char *apiName, UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
| bool outside = false; |
| if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || |
| ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && |
| !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { |
| outside = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCB->commandBuffer), __LINE__, msgCode, "DS", |
| "%s: This call must be issued inside an active render pass. %s", apiName, validation_error_map[msgCode]); |
| } |
| return outside; |
| } |
| |
| static void init_core_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { |
| layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); |
| } |
| |
| // For the given ValidationCheck enum, set all relevant instance disabled flags to true |
| void SetDisabledFlags(instance_layer_data *instance_data, const VkValidationFlagsEXT *val_flags_struct) { |
| for (uint32_t i = 0; i < val_flags_struct->disabledValidationCheckCount; ++i) { |
| switch (val_flags_struct->pDisabledValidationChecks[i]) { |
| case VK_VALIDATION_CHECK_SHADERS_EXT: |
| instance_data->disabled.shader_validation = true; |
| break; |
| case VK_VALIDATION_CHECK_ALL_EXT: |
| // Set all disabled flags to true |
| instance_data->disabled.SetAll(true); |
| break; |
| default: |
| break; |
| } |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, |
| VkInstance *pInstance) { |
| VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); |
| |
| assert(chain_info->u.pLayerInfo); |
| PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; |
| PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); |
| if (fpCreateInstance == NULL) return VK_ERROR_INITIALIZATION_FAILED; |
| |
| // Advance the link info for the next element on the chain |
| chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; |
| |
| VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); |
| if (result != VK_SUCCESS) return result; |
| |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map); |
| instance_data->instance = *pInstance; |
| layer_init_instance_dispatch_table(*pInstance, &instance_data->dispatch_table, fpGetInstanceProcAddr); |
| instance_data->report_data = debug_report_create_instance( |
| &instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, pCreateInfo->ppEnabledExtensionNames); |
| instance_data->extensions.InitFromInstanceCreateInfo(pCreateInfo); |
| init_core_validation(instance_data, pAllocator); |
| |
| ValidateLayerOrdering(*pCreateInfo); |
| // Parse any pNext chains |
| const auto *validation_flags_ext = lvl_find_in_chain<VkValidationFlagsEXT>(pCreateInfo->pNext); |
| if (validation_flags_ext) { |
| SetDisabledFlags(instance_data, validation_flags_ext); |
| } |
| |
| return result; |
| } |
| |
| // Hook DestroyInstance to remove tableInstanceMap entry |
| VKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { |
| // TODOSC : Shouldn't need any customization here |
| dispatch_key key = get_dispatch_key(instance); |
| // TBD: Need any locking this early, in case this function is called at the |
| // same time by more than one thread? |
| instance_layer_data *instance_data = GetLayerDataPtr(key, instance_layer_data_map); |
| instance_data->dispatch_table.DestroyInstance(instance, pAllocator); |
| |
| lock_guard_t lock(global_lock); |
| // Clean up logging callback, if any |
| while (instance_data->logging_callback.size() > 0) { |
| VkDebugReportCallbackEXT callback = instance_data->logging_callback.back(); |
| layer_destroy_msg_callback(instance_data->report_data, callback, pAllocator); |
| instance_data->logging_callback.pop_back(); |
| } |
| |
| layer_debug_report_destroy_instance(instance_data->report_data); |
| FreeLayerDataPtr(key, instance_layer_data_map); |
| } |
| |
| static bool ValidatePhysicalDeviceQueueFamily(instance_layer_data *instance_data, const PHYSICAL_DEVICE_STATE *pd_state, |
| uint32_t requested_queue_family, int32_t err_code, const char *cmd_name, |
| const char *queue_family_var_name, const char *vu_note = nullptr) { |
| bool skip = false; |
| |
| if (!vu_note) vu_note = validation_error_map[err_code]; |
| |
| const char *conditional_ext_cmd = |
| instance_data->extensions.vk_khr_get_physical_device_properties_2 ? "or vkGetPhysicalDeviceQueueFamilyProperties2KHR" : ""; |
| |
| std::string count_note = (UNCALLED == pd_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) |
| ? "the pQueueFamilyPropertyCount was never obtained" |
| : "i.e. is not less than " + std::to_string(pd_state->queue_family_count); |
| |
| if (requested_queue_family >= pd_state->queue_family_count) { |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| HandleToUint64(pd_state->phys_device), __LINE__, err_code, "DL", |
| "%s: %s (= %" PRIu32 |
| ") is not less than any previously obtained pQueueFamilyPropertyCount from " |
| "vkGetPhysicalDeviceQueueFamilyProperties%s (%s). %s", |
| cmd_name, queue_family_var_name, requested_queue_family, conditional_ext_cmd, count_note.c_str(), vu_note); |
| } |
| return skip; |
| } |
| |
| // Verify VkDeviceQueueCreateInfos |
| static bool ValidateDeviceQueueCreateInfos(instance_layer_data *instance_data, const PHYSICAL_DEVICE_STATE *pd_state, |
| uint32_t info_count, const VkDeviceQueueCreateInfo *infos) { |
| bool skip = false; |
| |
| for (uint32_t i = 0; i < info_count; ++i) { |
| const auto requested_queue_family = infos[i].queueFamilyIndex; |
| |
| // Verify that requested queue family is known to be valid at this point in time |
| std::string queue_family_var_name = "pCreateInfo->pQueueCreateInfos[" + std::to_string(i) + "].queueFamilyIndex"; |
| skip |= ValidatePhysicalDeviceQueueFamily(instance_data, pd_state, requested_queue_family, VALIDATION_ERROR_06c002fa, |
| "vkCreateDevice", queue_family_var_name.c_str()); |
| |
| // Verify that requested queue count of queue family is known to be valid at this point in time |
| if (requested_queue_family < pd_state->queue_family_count) { |
| const auto requested_queue_count = infos[i].queueCount; |
| const auto queue_family_props_count = pd_state->queue_family_properties.size(); |
| const bool queue_family_has_props = requested_queue_family < queue_family_props_count; |
| const char *conditional_ext_cmd = instance_data->extensions.vk_khr_get_physical_device_properties_2 |
| ? "or vkGetPhysicalDeviceQueueFamilyProperties2KHR" |
| : ""; |
| std::string count_note = |
| !queue_family_has_props |
| ? "the pQueueFamilyProperties[" + std::to_string(requested_queue_family) + "] was never obtained" |
| : "i.e. is not less than or equal to " + |
| std::to_string(pd_state->queue_family_properties[requested_queue_family].queueCount); |
| |
| if (!queue_family_has_props || |
| requested_queue_count > pd_state->queue_family_properties[requested_queue_family].queueCount) { |
| skip |= log_msg( |
| instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| HandleToUint64(pd_state->phys_device), __LINE__, VALIDATION_ERROR_06c002fc, "DL", |
| "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueCount (=%" PRIu32 |
| ") is not less than or equal to available queue count for this pCreateInfo->pQueueCreateInfos[%" PRIu32 |
| "].queueFamilyIndex} (=%" PRIu32 |
| ") obtained previously from vkGetPhysicalDeviceQueueFamilyProperties%s (%s). %s", |
| i, requested_queue_count, i, requested_queue_family, conditional_ext_cmd, count_note.c_str(), |
| validation_error_map[VALIDATION_ERROR_06c002fc]); |
| } |
| } |
| } |
| |
| return skip; |
| } |
| |
| // Verify that features have been queried and that they are available |
| static bool ValidateRequestedFeatures(instance_layer_data *instance_data, const PHYSICAL_DEVICE_STATE *pd_state, |
| const VkPhysicalDeviceFeatures *requested_features) { |
| bool skip = false; |
| |
| const VkBool32 *actual = reinterpret_cast<const VkBool32 *>(&pd_state->features); |
| const VkBool32 *requested = reinterpret_cast<const VkBool32 *>(requested_features); |
| // TODO : This is a nice, compact way to loop through struct, but a bad way to report issues |
| // Need to provide the struct member name with the issue. To do that seems like we'll |
| // have to loop through each struct member which should be done w/ codegen to keep in synch. |
| uint32_t errors = 0; |
| uint32_t total_bools = sizeof(VkPhysicalDeviceFeatures) / sizeof(VkBool32); |
| for (uint32_t i = 0; i < total_bools; i++) { |
| if (requested[i] > actual[i]) { |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, "DL", |
| "While calling vkCreateDevice(), requesting feature '%s' in VkPhysicalDeviceFeatures struct, which is " |
| "not available on this device.", |
| GetPhysDevFeatureString(i)); |
| errors++; |
| } |
| } |
| if (errors && (UNCALLED == pd_state->vkGetPhysicalDeviceFeaturesState)) { |
| // If user didn't request features, notify them that they should |
| // TODO: Verify this against the spec. I believe this is an invalid use of the API and should return an error |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, "DL", |
| "You requested features that are unavailable on this device. You should first query feature availability " |
| "by calling vkGetPhysicalDeviceFeatures()."); |
| } |
| return skip; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { |
| bool skip = false; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(gpu), instance_layer_data_map); |
| |
| unique_lock_t lock(global_lock); |
| auto pd_state = GetPhysicalDeviceState(instance_data, gpu); |
| |
| // TODO: object_tracker should perhaps do this instead |
| // and it does not seem to currently work anyway -- the loader just crashes before this point |
| if (!GetPhysicalDeviceState(instance_data, gpu)) { |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| 0, __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", |
| "Invalid call to vkCreateDevice() w/o first calling vkEnumeratePhysicalDevices()."); |
| } |
| |
| // Check that any requested features are available |
| // The enabled features can come from either pEnabledFeatures, or from the pNext chain |
| const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures; |
| if (nullptr == enabled_features_found) { |
| const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext); |
| if (features2) { |
| enabled_features_found = &(features2->features); |
| } |
| } |
| |
| if (enabled_features_found) { |
| skip |= ValidateRequestedFeatures(instance_data, pd_state, enabled_features_found); |
| } |
| |
| skip |= |
| ValidateDeviceQueueCreateInfos(instance_data, pd_state, pCreateInfo->queueCreateInfoCount, pCreateInfo->pQueueCreateInfos); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); |
| |
| assert(chain_info->u.pLayerInfo); |
| PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; |
| PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; |
| PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(instance_data->instance, "vkCreateDevice"); |
| if (fpCreateDevice == NULL) { |
| return VK_ERROR_INITIALIZATION_FAILED; |
| } |
| |
| // Advance the link info for the next element on the chain |
| chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; |
| |
| lock.unlock(); |
| |
| VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); |
| if (result != VK_SUCCESS) { |
| return result; |
| } |
| |
| lock.lock(); |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map); |
| |
| device_data->instance_data = instance_data; |
| // Setup device dispatch table |
| layer_init_device_dispatch_table(*pDevice, &device_data->dispatch_table, fpGetDeviceProcAddr); |
| device_data->device = *pDevice; |
| // Save PhysicalDevice handle |
| device_data->physical_device = gpu; |
| |
| device_data->report_data = layer_debug_report_create_device(instance_data->report_data, *pDevice); |
| device_data->extensions.InitFromDeviceCreateInfo(&instance_data->extensions, pCreateInfo); |
| |
| // Get physical device limits for this device |
| instance_data->dispatch_table.GetPhysicalDeviceProperties(gpu, &(device_data->phys_dev_properties.properties)); |
| uint32_t count; |
| instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); |
| device_data->phys_dev_properties.queue_family_properties.resize(count); |
| instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties( |
| gpu, &count, &device_data->phys_dev_properties.queue_family_properties[0]); |
| // TODO: device limits should make sure these are compatible |
| if (enabled_features_found) { |
| device_data->enabled_features = *enabled_features_found; |
| } else { |
| memset(&device_data->enabled_features, 0, sizeof(VkPhysicalDeviceFeatures)); |
| } |
| // Store physical device properties and physical device mem limits into device layer_data structs |
| instance_data->dispatch_table.GetPhysicalDeviceMemoryProperties(gpu, &device_data->phys_dev_mem_props); |
| instance_data->dispatch_table.GetPhysicalDeviceProperties(gpu, &device_data->phys_dev_props); |
| |
| if (device_data->extensions.vk_khr_push_descriptor) { |
| // Get the needed push_descriptor limits |
| auto push_descriptor_prop = lvl_init_struct<VkPhysicalDevicePushDescriptorPropertiesKHR>(); |
| auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&push_descriptor_prop); |
| instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(gpu, &prop2); |
| device_data->phys_dev_ext_props.max_push_descriptors = push_descriptor_prop.maxPushDescriptors; |
| } |
| |
| lock.unlock(); |
| |
| ValidateLayerOrdering(*pCreateInfo); |
| |
| return result; |
| } |
| |
| // prototype |
| VKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { |
| // TODOSC : Shouldn't need any customization here |
| dispatch_key key = get_dispatch_key(device); |
| layer_data *dev_data = GetLayerDataPtr(key, layer_data_map); |
| // Free all the memory |
| unique_lock_t lock(global_lock); |
| dev_data->pipelineMap.clear(); |
| dev_data->renderPassMap.clear(); |
| for (auto ii = dev_data->commandBufferMap.begin(); ii != dev_data->commandBufferMap.end(); ++ii) { |
| delete (*ii).second; |
| } |
| dev_data->commandBufferMap.clear(); |
| // This will also delete all sets in the pool & remove them from setMap |
| deletePools(dev_data); |
| // All sets should be removed |
| assert(dev_data->setMap.empty()); |
| dev_data->descriptorSetLayoutMap.clear(); |
| dev_data->imageViewMap.clear(); |
| dev_data->imageMap.clear(); |
| dev_data->imageSubresourceMap.clear(); |
| dev_data->imageLayoutMap.clear(); |
| dev_data->bufferViewMap.clear(); |
| dev_data->bufferMap.clear(); |
| // Queues persist until device is destroyed |
| dev_data->queueMap.clear(); |
| // Report any memory leaks |
| layer_debug_report_destroy_device(device); |
| lock.unlock(); |
| |
| #if DISPATCH_MAP_DEBUG |
| fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); |
| #endif |
| |
| dev_data->dispatch_table.DestroyDevice(device, pAllocator); |
| FreeLayerDataPtr(key, layer_data_map); |
| } |
| |
| static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; |
| |
| // For given stage mask, if Geometry shader stage is on w/o GS being enabled, report geo_error_id |
| // and if Tessellation Control or Evaluation shader stages are on w/o TS being enabled, report tess_error_id |
| static bool ValidateStageMaskGsTsEnables(layer_data *dev_data, VkPipelineStageFlags stageMask, const char *caller, |
| UNIQUE_VALIDATION_ERROR_CODE geo_error_id, UNIQUE_VALIDATION_ERROR_CODE tess_error_id) { |
| bool skip = false; |
| if (!dev_data->enabled_features.geometryShader && (stageMask & VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| geo_error_id, "DL", |
| "%s call includes a stageMask with VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT bit set when device does not have " |
| "geometryShader feature enabled. %s", |
| caller, validation_error_map[geo_error_id]); |
| } |
| if (!dev_data->enabled_features.tessellationShader && |
| (stageMask & (VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT | VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT))) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| tess_error_id, "DL", |
| "%s call includes a stageMask with VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT and/or " |
| "VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT bit(s) set when device does not have " |
| "tessellationShader feature enabled. %s", |
| caller, validation_error_map[tess_error_id]); |
| } |
| return skip; |
| } |
| |
| // Loop through bound objects and increment their in_use counts. |
| static void IncrementBoundObjects(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { |
| for (auto obj : cb_node->object_bindings) { |
| auto base_obj = GetStateStructPtrFromObject(dev_data, obj); |
| if (base_obj) { |
| base_obj->in_use.fetch_add(1); |
| } |
| } |
| } |
| // Track which resources are in-flight by atomically incrementing their "in_use" count |
| static void incrementResources(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { |
| cb_node->submitCount++; |
| cb_node->in_use.fetch_add(1); |
| |
| // First Increment for all "generic" objects bound to cmd buffer, followed by special-case objects below |
| IncrementBoundObjects(dev_data, cb_node); |
| // TODO : We should be able to remove the NULL look-up checks from the code below as long as |
| // all the corresponding cases are verified to cause CB_INVALID state and the CB_INVALID state |
| // should then be flagged prior to calling this function |
| for (auto drawDataElement : cb_node->drawData) { |
| for (auto buffer : drawDataElement.buffers) { |
| auto buffer_state = GetBufferState(dev_data, buffer); |
| if (buffer_state) { |
| buffer_state->in_use.fetch_add(1); |
| } |
| } |
| } |
| for (auto event : cb_node->writeEventsBeforeWait) { |
| auto event_state = GetEventNode(dev_data, event); |
| if (event_state) event_state->write_in_use++; |
| } |
| } |
| |
| // Note: This function assumes that the global lock is held by the calling thread. |
| // For the given queue, verify the queue state up to the given seq number. |
| // Currently the only check is to make sure that if there are events to be waited on prior to |
| // a QueryReset, make sure that all such events have been signalled. |
| static bool VerifyQueueStateToSeq(layer_data *dev_data, QUEUE_STATE *initial_queue, uint64_t initial_seq) { |
| bool skip = false; |
| |
| // sequence number we want to validate up to, per queue |
| std::unordered_map<QUEUE_STATE *, uint64_t> target_seqs{{initial_queue, initial_seq}}; |
| // sequence number we've completed validation for, per queue |
| std::unordered_map<QUEUE_STATE *, uint64_t> done_seqs; |
| std::vector<QUEUE_STATE *> worklist{initial_queue}; |
| |
| while (worklist.size()) { |
| auto queue = worklist.back(); |
| worklist.pop_back(); |
| |
| auto target_seq = target_seqs[queue]; |
| auto seq = std::max(done_seqs[queue], queue->seq); |
| auto sub_it = queue->submissions.begin() + int(seq - queue->seq); // seq >= queue->seq |
| |
| for (; seq < target_seq; ++sub_it, ++seq) { |
| for (auto &wait : sub_it->waitSemaphores) { |
| auto other_queue = GetQueueState(dev_data, wait.queue); |
| |
| if (other_queue == queue) continue; // semaphores /always/ point backwards, so no point here. |
| |
| auto other_target_seq = std::max(target_seqs[other_queue], wait.seq); |
| auto other_done_seq = std::max(done_seqs[other_queue], other_queue->seq); |
| |
| // if this wait is for another queue, and covers new sequence |
| // numbers beyond what we've already validated, mark the new |
| // target seq and (possibly-re)add the queue to the worklist. |
| if (other_done_seq < other_target_seq) { |
| target_seqs[other_queue] = other_target_seq; |
| worklist.push_back(other_queue); |
| } |
| } |
| |
| for (auto cb : sub_it->cbs) { |
| auto cb_node = GetCBNode(dev_data, cb); |
| if (cb_node) { |
| for (auto queryEventsPair : cb_node->waitedEventsBeforeQueryReset) { |
| for (auto event : queryEventsPair.second) { |
| if (dev_data->eventMap[event].needsSignaled) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", |
| "Cannot get query results on queryPool 0x%" PRIx64 |
| " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", |
| HandleToUint64(queryEventsPair.first.pool), queryEventsPair.first.index, |
| HandleToUint64(event)); |
| } |
| } |
| } |
| } |
| } |
| } |
| |
| // finally mark the point we've now validated this queue to. |
| done_seqs[queue] = seq; |
| } |
| |
| return skip; |
| } |
| |
| // When the given fence is retired, verify outstanding queue operations through the point of the fence |
| static bool VerifyQueueStateToFence(layer_data *dev_data, VkFence fence) { |
| auto fence_state = GetFenceNode(dev_data, fence); |
| if (fence_state->scope == kSyncScopeInternal && VK_NULL_HANDLE != fence_state->signaler.first) { |
| return VerifyQueueStateToSeq(dev_data, GetQueueState(dev_data, fence_state->signaler.first), fence_state->signaler.second); |
| } |
| return false; |
| } |
| |
| // Decrement in-use count for objects bound to command buffer |
| static void DecrementBoundResources(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { |
| BASE_NODE *base_obj = nullptr; |
| for (auto obj : cb_node->object_bindings) { |
| base_obj = GetStateStructPtrFromObject(dev_data, obj); |
| if (base_obj) { |
| base_obj->in_use.fetch_sub(1); |
| } |
| } |
| } |
| |
| static void RetireWorkOnQueue(layer_data *dev_data, QUEUE_STATE *pQueue, uint64_t seq) { |
| std::unordered_map<VkQueue, uint64_t> otherQueueSeqs; |
| |
| // Roll this queue forward, one submission at a time. |
| while (pQueue->seq < seq) { |
| auto &submission = pQueue->submissions.front(); |
| |
| for (auto &wait : submission.waitSemaphores) { |
| auto pSemaphore = GetSemaphoreNode(dev_data, wait.semaphore); |
| if (pSemaphore) { |
| pSemaphore->in_use.fetch_sub(1); |
| } |
| auto &lastSeq = otherQueueSeqs[wait.queue]; |
| lastSeq = std::max(lastSeq, wait.seq); |
| } |
| |
| for (auto &semaphore : submission.signalSemaphores) { |
| auto pSemaphore = GetSemaphoreNode(dev_data, semaphore); |
| if (pSemaphore) { |
| pSemaphore->in_use.fetch_sub(1); |
| } |
| } |
| |
| for (auto &semaphore : submission.externalSemaphores) { |
| auto pSemaphore = GetSemaphoreNode(dev_data, semaphore); |
| if (pSemaphore) { |
| pSemaphore->in_use.fetch_sub(1); |
| } |
| } |
| |
| for (auto cb : submission.cbs) { |
| auto cb_node = GetCBNode(dev_data, cb); |
| if (!cb_node) { |
| continue; |
| } |
| // First perform decrement on general case bound objects |
| DecrementBoundResources(dev_data, cb_node); |
| for (auto drawDataElement : cb_node->drawData) { |
| for (auto buffer : drawDataElement.buffers) { |
| auto buffer_state = GetBufferState(dev_data, buffer); |
| if (buffer_state) { |
| buffer_state->in_use.fetch_sub(1); |
| } |
| } |
| } |
| for (auto event : cb_node->writeEventsBeforeWait) { |
| auto eventNode = dev_data->eventMap.find(event); |
| if (eventNode != dev_data->eventMap.end()) { |
| eventNode->second.write_in_use--; |
| } |
| } |
| for (auto queryStatePair : cb_node->queryToStateMap) { |
| dev_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; |
| } |
| for (auto eventStagePair : cb_node->eventToStageMap) { |
| dev_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; |
| } |
| |
| cb_node->in_use.fetch_sub(1); |
| } |
| |
| auto pFence = GetFenceNode(dev_data, submission.fence); |
| if (pFence && pFence->scope == kSyncScopeInternal) { |
| pFence->state = FENCE_RETIRED; |
| } |
| |
| pQueue->submissions.pop_front(); |
| pQueue->seq++; |
| } |
| |
| // Roll other queues forward to the highest seq we saw a wait for |
| for (auto qs : otherQueueSeqs) { |
| RetireWorkOnQueue(dev_data, GetQueueState(dev_data, qs.first), qs.second); |
| } |
| } |
| |
| // Submit a fence to a queue, delimiting previous fences and previous untracked |
| // work by it. |
| static void SubmitFence(QUEUE_STATE *pQueue, FENCE_NODE *pFence, uint64_t submitCount) { |
| pFence->state = FENCE_INFLIGHT; |
| pFence->signaler.first = pQueue->queue; |
| pFence->signaler.second = pQueue->seq + pQueue->submissions.size() + submitCount; |
| } |
| |
| static bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB, int current_submit_count) { |
| bool skip = false; |
| if ((pCB->in_use.load() || current_submit_count > 1) && |
| !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| __LINE__, VALIDATION_ERROR_31a0008e, "DS", |
| "Command Buffer 0x%" PRIx64 " is already in use and is not marked for simultaneous use. %s", |
| HandleToUint64(pCB->commandBuffer), validation_error_map[VALIDATION_ERROR_31a0008e]); |
| } |
| return skip; |
| } |
| |
| static bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, const char *call_source, |
| int current_submit_count, UNIQUE_VALIDATION_ERROR_CODE vu_id) { |
| bool skip = false; |
| if (dev_data->instance_data->disabled.command_buffer_state) return skip; |
| // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once |
| if ((cb_state->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && |
| (cb_state->submitCount + current_submit_count > 1)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", |
| "Commandbuffer 0x%" PRIx64 |
| " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT set, but has been submitted 0x%" PRIxLEAST64 |
| " times.", |
| HandleToUint64(cb_state->commandBuffer), cb_state->submitCount + current_submit_count); |
| } |
| |
| // Validate that cmd buffers have been updated |
| switch (cb_state->state) { |
| case CB_INVALID_INCOMPLETE: |
| case CB_INVALID_COMPLETE: |
| skip |= ReportInvalidCommandBuffer(dev_data, cb_state, call_source); |
| break; |
| |
| case CB_NEW: |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| (uint64_t)(cb_state->commandBuffer), __LINE__, vu_id, "DS", |
| "Command buffer 0x%" PRIx64 " used in the call to %s is unrecorded and contains no commands. %s", |
| HandleToUint64(cb_state->commandBuffer), call_source, validation_error_map[vu_id]); |
| break; |
| |
| case CB_RECORDING: |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", |
| "You must call vkEndCommandBuffer() on command buffer 0x%" PRIx64 " before this call to %s!", |
| HandleToUint64(cb_state->commandBuffer), call_source); |
| break; |
| |
| default: /* recorded */ |
| break; |
| } |
| return skip; |
| } |
| |
| static bool validateResources(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { |
| bool skip = false; |
| |
| // TODO : We should be able to remove the NULL look-up checks from the code below as long as |
| // all the corresponding cases are verified to cause CB_INVALID state and the CB_INVALID state |
| // should then be flagged prior to calling this function |
| for (auto drawDataElement : cb_node->drawData) { |
| for (auto buffer : drawDataElement.buffers) { |
| auto buffer_state = GetBufferState(dev_data, buffer); |
| if (buffer != VK_NULL_HANDLE && !buffer_state) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| HandleToUint64(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", |
| "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", HandleToUint64(buffer)); |
| } |
| } |
| } |
| return skip; |
| } |
| |
| // Check that the queue family index of 'queue' matches one of the entries in pQueueFamilyIndices |
| bool ValidImageBufferQueue(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, const VK_OBJECT *object, VkQueue queue, uint32_t count, |
| const uint32_t *indices) { |
| bool found = false; |
| bool skip = false; |
| auto queue_state = GetQueueState(dev_data, queue); |
| if (queue_state) { |
| for (uint32_t i = 0; i < count; i++) { |
| if (indices[i] == queue_state->queueFamilyIndex) { |
| found = true; |
| break; |
| } |
| } |
| |
| if (!found) { |
| skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, get_debug_report_enum[object->type], |
| object->handle, __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", |
| "vkQueueSubmit: Command buffer 0x%" PRIx64 " contains %s 0x%" PRIx64 |
| " which was not created allowing concurrent access to this queue family %d.", |
| HandleToUint64(cb_node->commandBuffer), object_string[object->type], object->handle, |
| queue_state->queueFamilyIndex); |
| } |
| } |
| return skip; |
| } |
| |
| // Validate that queueFamilyIndices of primary command buffers match this queue |
| // Secondary command buffers were previously validated in vkCmdExecuteCommands(). |
| static bool validateQueueFamilyIndices(layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkQueue queue) { |
| bool skip = false; |
| auto pPool = GetCommandPoolNode(dev_data, pCB->createInfo.commandPool); |
| auto queue_state = GetQueueState(dev_data, queue); |
| |
| if (pPool && queue_state) { |
| if (pPool->queueFamilyIndex != queue_state->queueFamilyIndex) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCB->commandBuffer), __LINE__, VALIDATION_ERROR_31a00094, "DS", |
| "vkQueueSubmit: Primary command buffer 0x%" PRIx64 |
| " created in queue family %d is being submitted on queue 0x%" PRIx64 " from queue family %d. %s", |
| HandleToUint64(pCB->commandBuffer), pPool->queueFamilyIndex, HandleToUint64(queue), |
| queue_state->queueFamilyIndex, validation_error_map[VALIDATION_ERROR_31a00094]); |
| } |
| |
| // Ensure that any bound images or buffers created with SHARING_MODE_CONCURRENT have access to the current queue family |
| for (auto object : pCB->object_bindings) { |
| if (object.type == kVulkanObjectTypeImage) { |
| auto image_state = GetImageState(dev_data, reinterpret_cast<VkImage &>(object.handle)); |
| if (image_state && image_state->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { |
| skip |= ValidImageBufferQueue(dev_data, pCB, &object, queue, image_state->createInfo.queueFamilyIndexCount, |
| image_state->createInfo.pQueueFamilyIndices); |
| } |
| } else if (object.type == kVulkanObjectTypeBuffer) { |
| auto buffer_state = GetBufferState(dev_data, reinterpret_cast<VkBuffer &>(object.handle)); |
| if (buffer_state && buffer_state->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { |
| skip |= ValidImageBufferQueue(dev_data, pCB, &object, queue, buffer_state->createInfo.queueFamilyIndexCount, |
| buffer_state->createInfo.pQueueFamilyIndices); |
| } |
| } |
| } |
| } |
| |
| return skip; |
| } |
| |
| static bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, int current_submit_count) { |
| // Track in-use for resources off of primary and any secondary CBs |
| bool skip = false; |
| |
| // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing |
| // on device |
| skip |= validateCommandBufferSimultaneousUse(dev_data, pCB, current_submit_count); |
| |
| skip |= validateResources(dev_data, pCB); |
| |
| for (auto pSubCB : pCB->linkedCommandBuffers) { |
| skip |= validateResources(dev_data, pSubCB); |
| // TODO: replace with invalidateCommandBuffers() at recording. |
| if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && |
| !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| __LINE__, VALIDATION_ERROR_31a00092, "DS", |
| "Commandbuffer 0x%" PRIx64 " was submitted with secondary buffer 0x%" PRIx64 |
| " but that buffer has subsequently been bound to primary cmd buffer 0x%" PRIx64 |
| " and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set. %s", |
| HandleToUint64(pCB->commandBuffer), HandleToUint64(pSubCB->commandBuffer), |
| HandleToUint64(pSubCB->primaryCommandBuffer), validation_error_map[VALIDATION_ERROR_31a00092]); |
| } |
| } |
| |
| skip |= validateCommandBufferState(dev_data, pCB, "vkQueueSubmit()", current_submit_count, VALIDATION_ERROR_31a00090); |
| |
| return skip; |
| } |
| |
| static bool ValidateFenceForSubmit(layer_data *dev_data, FENCE_NODE *pFence) { |
| bool skip = false; |
| |
| if (pFence && pFence->scope == kSyncScopeInternal) { |
| if (pFence->state == FENCE_INFLIGHT) { |
| // TODO: opportunities for VALIDATION_ERROR_31a00080, VALIDATION_ERROR_316008b4, VALIDATION_ERROR_16400a0e |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| HandleToUint64(pFence->fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", |
| "Fence 0x%" PRIx64 " is already in use by another submission.", HandleToUint64(pFence->fence)); |
| } |
| |
| else if (pFence->state == FENCE_RETIRED) { |
| // TODO: opportunities for VALIDATION_ERROR_31a0007e, VALIDATION_ERROR_316008b2, VALIDATION_ERROR_16400a0e |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| HandleToUint64(pFence->fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", |
| "Fence 0x%" PRIx64 " submitted in SIGNALED state. Fences must be reset before being submitted", |
| HandleToUint64(pFence->fence)); |
| } |
| } |
| |
| return skip; |
| } |
| |
| static void PostCallRecordQueueSubmit(layer_data *dev_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, |
| VkFence fence) { |
| uint64_t early_retire_seq = 0; |
| auto pQueue = GetQueueState(dev_data, queue); |
| auto pFence = GetFenceNode(dev_data, fence); |
| |
| if (pFence) { |
| if (pFence->scope == kSyncScopeInternal) { |
| // Mark fence in use |
| SubmitFence(pQueue, pFence, std::max(1u, submitCount)); |
| if (!submitCount) { |
| // If no submissions, but just dropping a fence on the end of the queue, |
| // record an empty submission with just the fence, so we can determine |
| // its completion. |
| pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), std::vector<SEMAPHORE_WAIT>(), |
| std::vector<VkSemaphore>(), std::vector<VkSemaphore>(), fence); |
| } |
| } else { |
| // Retire work up until this fence early, we will not see the wait that corresponds to this signal |
| early_retire_seq = pQueue->seq + pQueue->submissions.size(); |
| if (!dev_data->external_sync_warning) { |
| dev_data->external_sync_warning = true; |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| HandleToUint64(fence), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
| "vkQueueSubmit(): Signaling external fence 0x%" PRIx64 " on queue 0x%" PRIx64 |
| " will disable validation of preceding command buffer lifecycle states and the in-use status of associated " |
| "objects.", |
| HandleToUint64(fence), HandleToUint64(queue)); |
| } |
| } |
| } |
| |
| // Now process each individual submit |
| for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { |
| std::vector<VkCommandBuffer> cbs; |
| const VkSubmitInfo *submit = &pSubmits[submit_idx]; |
| vector<SEMAPHORE_WAIT> semaphore_waits; |
| vector<VkSemaphore> semaphore_signals; |
| vector<VkSemaphore> semaphore_externals; |
| for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { |
| VkSemaphore semaphore = submit->pWaitSemaphores[i]; |
| auto pSemaphore = GetSemaphoreNode(dev_data, semaphore); |
| if (pSemaphore) { |
| if (pSemaphore->scope == kSyncScopeInternal) { |
| if (pSemaphore->signaler.first != VK_NULL_HANDLE) { |
| semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); |
| pSemaphore->in_use.fetch_add(1); |
| } |
| pSemaphore->signaler.first = VK_NULL_HANDLE; |
| pSemaphore->signaled = false; |
| } else { |
| semaphore_externals.push_back(semaphore); |
| pSemaphore->in_use.fetch_add(1); |
| if (pSemaphore->scope == kSyncScopeExternalTemporary) { |
| pSemaphore->scope = kSyncScopeInternal; |
| } |
| } |
| } |
| } |
| for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { |
| VkSemaphore semaphore = submit->pSignalSemaphores[i]; |
| auto pSemaphore = GetSemaphoreNode(dev_data, semaphore); |
| if (pSemaphore) { |
| if (pSemaphore->scope == kSyncScopeInternal) { |
| pSemaphore->signaler.first = queue; |
| pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; |
| pSemaphore->signaled = true; |
| pSemaphore->in_use.fetch_add(1); |
| semaphore_signals.push_back(semaphore); |
| } else { |
| // Retire work up until this submit early, we will not see the wait that corresponds to this signal |
| early_retire_seq = std::max(early_retire_seq, pQueue->seq + pQueue->submissions.size() + 1); |
| if (!dev_data->external_sync_warning) { |
| dev_data->external_sync_warning = true; |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| HandleToUint64(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
| "vkQueueSubmit(): Signaling external semaphore 0x%" PRIx64 " on queue 0x%" PRIx64 |
| " will disable validation of preceding command buffer lifecycle states and the in-use status of " |
| "associated objects.", |
| HandleToUint64(semaphore), HandleToUint64(queue)); |
| } |
| } |
| } |
| } |
| for (uint32_t i = 0; i < submit->commandBufferCount; i++) { |
| auto cb_node = GetCBNode(dev_data, submit->pCommandBuffers[i]); |
| if (cb_node) { |
| cbs.push_back(submit->pCommandBuffers[i]); |
| for (auto secondaryCmdBuffer : cb_node->linkedCommandBuffers) { |
| cbs.push_back(secondaryCmdBuffer->commandBuffer); |
| UpdateCmdBufImageLayouts(dev_data, secondaryCmdBuffer); |
| incrementResources(dev_data, secondaryCmdBuffer); |
| } |
| UpdateCmdBufImageLayouts(dev_data, cb_node); |
| incrementResources(dev_data, cb_node); |
| } |
| } |
| pQueue->submissions.emplace_back(cbs, semaphore_waits, semaphore_signals, semaphore_externals, |
| submit_idx == submitCount - 1 ? fence : VK_NULL_HANDLE); |
| } |
| |
| if (early_retire_seq) { |
| RetireWorkOnQueue(dev_data, pQueue, early_retire_seq); |
| } |
| } |
| |
| static bool PreCallValidateQueueSubmit(layer_data *dev_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, |
| VkFence fence) { |
| auto pFence = GetFenceNode(dev_data, fence); |
| bool skip = ValidateFenceForSubmit(dev_data, pFence); |
| if (skip) { |
| return true; |
| } |
| |
| unordered_set<VkSemaphore> signaled_semaphores; |
| unordered_set<VkSemaphore> unsignaled_semaphores; |
| unordered_set<VkSemaphore> internal_semaphores; |
| vector<VkCommandBuffer> current_cmds; |
| unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> localImageLayoutMap; |
| // Now verify each individual submit |
| for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { |
| const VkSubmitInfo *submit = &pSubmits[submit_idx]; |
| for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { |
| skip |= ValidateStageMaskGsTsEnables(dev_data, submit->pWaitDstStageMask[i], "vkQueueSubmit()", |
| VALIDATION_ERROR_13c00098, VALIDATION_ERROR_13c0009a); |
| VkSemaphore semaphore = submit->pWaitSemaphores[i]; |
| auto pSemaphore = GetSemaphoreNode(dev_data, semaphore); |
| if (pSemaphore && (pSemaphore->scope == kSyncScopeInternal || internal_semaphores.count(semaphore))) { |
| if (unsignaled_semaphores.count(semaphore) || |
| (!(signaled_semaphores.count(semaphore)) && !(pSemaphore->signaled))) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| HandleToUint64(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
| "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", |
| HandleToUint64(queue), HandleToUint64(semaphore)); |
| } else { |
| signaled_semaphores.erase(semaphore); |
| unsignaled_semaphores.insert(semaphore); |
| } |
| } |
| if (pSemaphore && pSemaphore->scope == kSyncScopeExternalTemporary) { |
| internal_semaphores.insert(semaphore); |
| } |
| } |
| for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { |
| VkSemaphore semaphore = submit->pSignalSemaphores[i]; |
| auto pSemaphore = GetSemaphoreNode(dev_data, semaphore); |
| if (pSemaphore && (pSemaphore->scope == kSyncScopeInternal || internal_semaphores.count(semaphore))) { |
| if (signaled_semaphores.count(semaphore) || (!(unsignaled_semaphores.count(semaphore)) && pSemaphore->signaled)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| HandleToUint64(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
| "Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 |
| " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", |
| HandleToUint64(queue), HandleToUint64(semaphore), HandleToUint64(pSemaphore->signaler.first)); |
| } else { |
| unsignaled_semaphores.erase(semaphore); |
| signaled_semaphores.insert(semaphore); |
| } |
| } |
| } |
| for (uint32_t i = 0; i < submit->commandBufferCount; i++) { |
| auto cb_node = GetCBNode(dev_data, submit->pCommandBuffers[i]); |
| if (cb_node) { |
| skip |= ValidateCmdBufImageLayouts(dev_data, cb_node, dev_data->imageLayoutMap, localImageLayoutMap); |
| current_cmds.push_back(submit->pCommandBuffers[i]); |
| skip |= validatePrimaryCommandBufferState( |
| dev_data, cb_node, (int)std::count(current_cmds.begin(), current_cmds.end(), submit->pCommandBuffers[i])); |
| skip |= validateQueueFamilyIndices(dev_data, cb_node, queue); |
| |
| // Potential early exit here as bad object state may crash in delayed function calls |
| if (skip) { |
| return true; |
| } |
| |
| // Call submit-time functions to validate/update state |
| for (auto &function : cb_node->queue_submit_functions) { |
| skip |= function(); |
| } |
| for (auto &function : cb_node->eventUpdates) { |
| skip |= function(queue); |
| } |
| for (auto &function : cb_node->queryUpdates) { |
| skip |= function(queue); |
| } |
| } |
| } |
| } |
| return skip; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL QueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| bool skip = PreCallValidateQueueSubmit(dev_data, queue, submitCount, pSubmits, fence); |
| lock.unlock(); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| VkResult result = dev_data->dispatch_table.QueueSubmit(queue, submitCount, pSubmits, fence); |
| |
| lock.lock(); |
| PostCallRecordQueueSubmit(dev_data, queue, submitCount, pSubmits, fence); |
| lock.unlock(); |
| return result; |
| } |
| |
| static bool PreCallValidateAllocateMemory(layer_data *dev_data) { |
| bool skip = false; |
| if (dev_data->memObjMap.size() >= dev_data->phys_dev_properties.properties.limits.maxMemoryAllocationCount) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_16c004f8, "MEM", |
| "Number of currently valid memory objects is not less than the maximum allowed (%u). %s", |
| dev_data->phys_dev_properties.properties.limits.maxMemoryAllocationCount, |
| validation_error_map[VALIDATION_ERROR_16c004f8]); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordAllocateMemory(layer_data *dev_data, const VkMemoryAllocateInfo *pAllocateInfo, VkDeviceMemory *pMemory) { |
| add_mem_obj_info(dev_data, dev_data->device, *pMemory, pAllocateInfo); |
| return; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, |
| const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateAllocateMemory(dev_data); |
| if (!skip) { |
| lock.unlock(); |
| result = dev_data->dispatch_table.AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); |
| lock.lock(); |
| if (VK_SUCCESS == result) { |
| PostCallRecordAllocateMemory(dev_data, pAllocateInfo, pMemory); |
| } |
| } |
| return result; |
| } |
| |
| // For given obj node, if it is use, flag a validation error and return callback result, else return false |
| bool ValidateObjectNotInUse(const layer_data *dev_data, BASE_NODE *obj_node, VK_OBJECT obj_struct, const char *caller_name, |
| UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| if (dev_data->instance_data->disabled.object_in_use) return false; |
| bool skip = false; |
| if (obj_node->in_use.load()) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, get_debug_report_enum[obj_struct.type], |
| obj_struct.handle, __LINE__, error_code, "DS", |
| "Cannot call %s on %s 0x%" PRIx64 " that is currently in use by a command buffer. %s", caller_name, |
| object_string[obj_struct.type], obj_struct.handle, validation_error_map[error_code]); |
| } |
| return skip; |
| } |
| |
| static bool PreCallValidateFreeMemory(layer_data *dev_data, VkDeviceMemory mem, DEVICE_MEM_INFO **mem_info, VK_OBJECT *obj_struct) { |
| *mem_info = GetMemObjInfo(dev_data, mem); |
| *obj_struct = {HandleToUint64(mem), kVulkanObjectTypeDeviceMemory}; |
| if (dev_data->instance_data->disabled.free_memory) return false; |
| bool skip = false; |
| if (*mem_info) { |
| skip |= ValidateObjectNotInUse(dev_data, *mem_info, *obj_struct, "vkFreeMemory", VALIDATION_ERROR_2880054a); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordFreeMemory(layer_data *dev_data, VkDeviceMemory mem, DEVICE_MEM_INFO *mem_info, VK_OBJECT obj_struct) { |
| // Clear mem binding for any bound objects |
| for (auto obj : mem_info->obj_bindings) { |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, get_debug_report_enum[obj.type], obj.handle, __LINE__, |
| MEMTRACK_FREED_MEM_REF, "MEM", "VK Object 0x%" PRIx64 " still has a reference to mem obj 0x%" PRIx64, |
| HandleToUint64(obj.handle), HandleToUint64(mem_info->mem)); |
| BINDABLE *bindable_state = nullptr; |
| switch (obj.type) { |
| case kVulkanObjectTypeImage: |
| bindable_state = GetImageState(dev_data, reinterpret_cast<VkImage &>(obj.handle)); |
| break; |
| case kVulkanObjectTypeBuffer: |
| bindable_state = GetBufferState(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); |
| break; |
| default: |
| // Should only have buffer or image objects bound to memory |
| assert(0); |
| } |
| |
| assert(bindable_state); |
| bindable_state->binding.mem = MEMORY_UNBOUND; |
| bindable_state->UpdateBoundMemorySet(); |
| } |
| // Any bound cmd buffers are now invalid |
| invalidateCommandBuffers(dev_data, mem_info->cb_bindings, obj_struct); |
| dev_data->memObjMap.erase(mem); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL FreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| DEVICE_MEM_INFO *mem_info = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateFreeMemory(dev_data, mem, &mem_info, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.FreeMemory(device, mem, pAllocator); |
| lock.lock(); |
| if (mem != VK_NULL_HANDLE) { |
| PostCallRecordFreeMemory(dev_data, mem, mem_info, obj_struct); |
| } |
| } |
| } |
| |
| // Validate that given Map memory range is valid. This means that the memory should not already be mapped, |
| // and that the size of the map range should be: |
| // 1. Not zero |
| // 2. Within the size of the memory allocation |
| static bool ValidateMapMemRange(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { |
| bool skip = false; |
| |
| if (size == 0) { |
| skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem), __LINE__, MEMTRACK_INVALID_MAP, "MEM", |
| "VkMapMemory: Attempting to map memory range of size zero"); |
| } |
| |
| auto mem_element = dev_data->memObjMap.find(mem); |
| if (mem_element != dev_data->memObjMap.end()) { |
| auto mem_info = mem_element->second.get(); |
| // It is an application error to call VkMapMemory on an object that is already mapped |
| if (mem_info->mem_range.size != 0) { |
| skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem), __LINE__, MEMTRACK_INVALID_MAP, "MEM", |
| "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIx64, HandleToUint64(mem)); |
| } |
| |
| // Validate that offset + size is within object's allocationSize |
| if (size == VK_WHOLE_SIZE) { |
| if (offset >= mem_info->alloc_info.allocationSize) { |
| skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem), __LINE__, MEMTRACK_INVALID_MAP, "MEM", |
| "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 |
| " with size of VK_WHOLE_SIZE oversteps total array size 0x%" PRIx64, |
| offset, mem_info->alloc_info.allocationSize, mem_info->alloc_info.allocationSize); |
| } |
| } else { |
| if ((offset + size) > mem_info->alloc_info.allocationSize) { |
| skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem), __LINE__, VALIDATION_ERROR_31200552, "MEM", |
| "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " oversteps total array size 0x%" PRIx64 ". %s", |
| offset, size + offset, mem_info->alloc_info.allocationSize, |
| validation_error_map[VALIDATION_ERROR_31200552]); |
| } |
| } |
| } |
| return skip; |
| } |
| |
| static void storeMemRanges(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { |
| auto mem_info = GetMemObjInfo(dev_data, mem); |
| if (mem_info) { |
| mem_info->mem_range.offset = offset; |
| mem_info->mem_range.size = size; |
| } |
| } |
| |
| static bool deleteMemRanges(layer_data *dev_data, VkDeviceMemory mem) { |
| bool skip = false; |
| auto mem_info = GetMemObjInfo(dev_data, mem); |
| if (mem_info) { |
| if (!mem_info->mem_range.size) { |
| // Valid Usage: memory must currently be mapped |
| skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem), __LINE__, VALIDATION_ERROR_33600562, "MEM", |
| "Unmapping Memory without memory being mapped: mem obj 0x%" PRIx64 ". %s", HandleToUint64(mem), |
| validation_error_map[VALIDATION_ERROR_33600562]); |
| } |
| mem_info->mem_range.size = 0; |
| if (mem_info->shadow_copy) { |
| free(mem_info->shadow_copy_base); |
| mem_info->shadow_copy_base = 0; |
| mem_info->shadow_copy = 0; |
| } |
| } |
| return skip; |
| } |
| |
| // Guard value for pad data |
| static char NoncoherentMemoryFillValue = 0xb; |
| |
| static void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, |
| void **ppData) { |
| auto mem_info = GetMemObjInfo(dev_data, mem); |
| if (mem_info) { |
| mem_info->p_driver_data = *ppData; |
| uint32_t index = mem_info->alloc_info.memoryTypeIndex; |
| if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { |
| mem_info->shadow_copy = 0; |
| } else { |
| if (size == VK_WHOLE_SIZE) { |
| size = mem_info->alloc_info.allocationSize - offset; |
| } |
| mem_info->shadow_pad_size = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; |
| assert(SafeModulo(mem_info->shadow_pad_size, dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment) == |
| 0); |
| // Ensure start of mapped region reflects hardware alignment constraints |
| uint64_t map_alignment = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; |
| |
| // From spec: (ppData - offset) must be aligned to at least limits::minMemoryMapAlignment. |
| uint64_t start_offset = offset % map_alignment; |
| // Data passed to driver will be wrapped by a guardband of data to detect over- or under-writes. |
| mem_info->shadow_copy_base = |
| malloc(static_cast<size_t>(2 * mem_info->shadow_pad_size + size + map_alignment + start_offset)); |
| |
| mem_info->shadow_copy = |
| reinterpret_cast<char *>((reinterpret_cast<uintptr_t>(mem_info->shadow_copy_base) + map_alignment) & |
| ~(map_alignment - 1)) + |
| start_offset; |
| assert(SafeModulo(reinterpret_cast<uintptr_t>(mem_info->shadow_copy) + mem_info->shadow_pad_size - start_offset, |
| map_alignment) == 0); |
| |
| memset(mem_info->shadow_copy, NoncoherentMemoryFillValue, static_cast<size_t>(2 * mem_info->shadow_pad_size + size)); |
| *ppData = static_cast<char *>(mem_info->shadow_copy) + mem_info->shadow_pad_size; |
| } |
| } |
| } |
| |
| // Verify that state for fence being waited on is appropriate. That is, |
| // a fence being waited on should not already be signaled and |
| // it should have been submitted on a queue or during acquire next image |
| static inline bool verifyWaitFenceState(layer_data *dev_data, VkFence fence, const char *apiCall) { |
| bool skip = false; |
| |
| auto pFence = GetFenceNode(dev_data, fence); |
| if (pFence && pFence->scope == kSyncScopeInternal) { |
| if (pFence->state == FENCE_UNSIGNALED) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| HandleToUint64(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", |
| "%s called for fence 0x%" PRIx64 " which has not been submitted on a Queue or during acquire next image.", |
| apiCall, HandleToUint64(fence)); |
| } |
| } |
| return skip; |
| } |
| |
| static void RetireFence(layer_data *dev_data, VkFence fence) { |
| auto pFence = GetFenceNode(dev_data, fence); |
| if (pFence->scope == kSyncScopeInternal) { |
| if (pFence->signaler.first != VK_NULL_HANDLE) { |
| // Fence signaller is a queue -- use this as proof that prior operations on that queue have completed. |
| RetireWorkOnQueue(dev_data, GetQueueState(dev_data, pFence->signaler.first), pFence->signaler.second); |
| } else { |
| // Fence signaller is the WSI. We're not tracking what the WSI op actually /was/ in CV yet, but we need to mark |
| // the fence as retired. |
| pFence->state = FENCE_RETIRED; |
| } |
| } |
| } |
| |
| static bool PreCallValidateWaitForFences(layer_data *dev_data, uint32_t fence_count, const VkFence *fences) { |
| if (dev_data->instance_data->disabled.wait_for_fences) return false; |
| bool skip = false; |
| for (uint32_t i = 0; i < fence_count; i++) { |
| skip |= verifyWaitFenceState(dev_data, fences[i], "vkWaitForFences"); |
| skip |= VerifyQueueStateToFence(dev_data, fences[i]); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordWaitForFences(layer_data *dev_data, uint32_t fence_count, const VkFence *fences, VkBool32 wait_all) { |
| // When we know that all fences are complete we can clean/remove their CBs |
| if ((VK_TRUE == wait_all) || (1 == fence_count)) { |
| for (uint32_t i = 0; i < fence_count; i++) { |
| RetireFence(dev_data, fences[i]); |
| } |
| } |
| // NOTE : Alternate case not handled here is when some fences have completed. In |
| // this case for app to guarantee which fences completed it will have to call |
| // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL WaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, |
| uint64_t timeout) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| // Verify fence status of submitted fences |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateWaitForFences(dev_data, fenceCount, pFences); |
| lock.unlock(); |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| VkResult result = dev_data->dispatch_table.WaitForFences(device, fenceCount, pFences, waitAll, timeout); |
| |
| if (result == VK_SUCCESS) { |
| lock.lock(); |
| PostCallRecordWaitForFences(dev_data, fenceCount, pFences, waitAll); |
| lock.unlock(); |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateGetFenceStatus(layer_data *dev_data, VkFence fence) { |
| if (dev_data->instance_data->disabled.get_fence_state) return false; |
| return verifyWaitFenceState(dev_data, fence, "vkGetFenceStatus"); |
| } |
| |
| static void PostCallRecordGetFenceStatus(layer_data *dev_data, VkFence fence) { RetireFence(dev_data, fence); } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateGetFenceStatus(dev_data, fence); |
| lock.unlock(); |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| VkResult result = dev_data->dispatch_table.GetFenceStatus(device, fence); |
| if (result == VK_SUCCESS) { |
| lock.lock(); |
| PostCallRecordGetFenceStatus(dev_data, fence); |
| lock.unlock(); |
| } |
| return result; |
| } |
| |
| static void PostCallRecordGetDeviceQueue(layer_data *dev_data, uint32_t q_family_index, VkQueue queue) { |
| // Add queue to tracking set only if it is new |
| auto result = dev_data->queues.emplace(queue); |
| if (result.second == true) { |
| QUEUE_STATE *queue_state = &dev_data->queueMap[queue]; |
| queue_state->queue = queue; |
| queue_state->queueFamilyIndex = q_family_index; |
| queue_state->seq = 0; |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| dev_data->dispatch_table.GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); |
| lock_guard_t lock(global_lock); |
| |
| PostCallRecordGetDeviceQueue(dev_data, queueFamilyIndex, *pQueue); |
| } |
| |
| static bool PreCallValidateQueueWaitIdle(layer_data *dev_data, VkQueue queue, QUEUE_STATE **queue_state) { |
| *queue_state = GetQueueState(dev_data, queue); |
| if (dev_data->instance_data->disabled.queue_wait_idle) return false; |
| return VerifyQueueStateToSeq(dev_data, *queue_state, (*queue_state)->seq + (*queue_state)->submissions.size()); |
| } |
| |
| static void PostCallRecordQueueWaitIdle(layer_data *dev_data, QUEUE_STATE *queue_state) { |
| RetireWorkOnQueue(dev_data, queue_state, queue_state->seq + queue_state->submissions.size()); |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map); |
| QUEUE_STATE *queue_state = nullptr; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateQueueWaitIdle(dev_data, queue, &queue_state); |
| lock.unlock(); |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| VkResult result = dev_data->dispatch_table.QueueWaitIdle(queue); |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| PostCallRecordQueueWaitIdle(dev_data, queue_state); |
| lock.unlock(); |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateDeviceWaitIdle(layer_data *dev_data) { |
| if (dev_data->instance_data->disabled.device_wait_idle) return false; |
| bool skip = false; |
| for (auto &queue : dev_data->queueMap) { |
| skip |= VerifyQueueStateToSeq(dev_data, &queue.second, queue.second.seq + queue.second.submissions.size()); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordDeviceWaitIdle(layer_data *dev_data) { |
| for (auto &queue : dev_data->queueMap) { |
| RetireWorkOnQueue(dev_data, &queue.second, queue.second.seq + queue.second.submissions.size()); |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDeviceWaitIdle(dev_data); |
| lock.unlock(); |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| VkResult result = dev_data->dispatch_table.DeviceWaitIdle(device); |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| PostCallRecordDeviceWaitIdle(dev_data); |
| lock.unlock(); |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateDestroyFence(layer_data *dev_data, VkFence fence, FENCE_NODE **fence_node, VK_OBJECT *obj_struct) { |
| *fence_node = GetFenceNode(dev_data, fence); |
| *obj_struct = {HandleToUint64(fence), kVulkanObjectTypeFence}; |
| if (dev_data->instance_data->disabled.destroy_fence) return false; |
| bool skip = false; |
| if (*fence_node) { |
| if ((*fence_node)->scope == kSyncScopeInternal && (*fence_node)->state == FENCE_INFLIGHT) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| HandleToUint64(fence), __LINE__, VALIDATION_ERROR_24e008c0, "DS", "Fence 0x%" PRIx64 " is in use. %s", |
| HandleToUint64(fence), validation_error_map[VALIDATION_ERROR_24e008c0]); |
| } |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordDestroyFence(layer_data *dev_data, VkFence fence) { dev_data->fenceMap.erase(fence); } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| // Common data objects used pre & post call |
| FENCE_NODE *fence_node = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroyFence(dev_data, fence, &fence_node, &obj_struct); |
| |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyFence(device, fence, pAllocator); |
| lock.lock(); |
| PostCallRecordDestroyFence(dev_data, fence); |
| } |
| } |
| |
| static bool PreCallValidateDestroySemaphore(layer_data *dev_data, VkSemaphore semaphore, SEMAPHORE_NODE **sema_node, |
| VK_OBJECT *obj_struct) { |
| *sema_node = GetSemaphoreNode(dev_data, semaphore); |
| *obj_struct = {HandleToUint64(semaphore), kVulkanObjectTypeSemaphore}; |
| if (dev_data->instance_data->disabled.destroy_semaphore) return false; |
| bool skip = false; |
| if (*sema_node) { |
| skip |= ValidateObjectNotInUse(dev_data, *sema_node, *obj_struct, "vkDestroySemaphore", VALIDATION_ERROR_268008e2); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordDestroySemaphore(layer_data *dev_data, VkSemaphore sema) { dev_data->semaphoreMap.erase(sema); } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| SEMAPHORE_NODE *sema_node; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroySemaphore(dev_data, semaphore, &sema_node, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroySemaphore(device, semaphore, pAllocator); |
| lock.lock(); |
| PostCallRecordDestroySemaphore(dev_data, semaphore); |
| } |
| } |
| |
| static bool PreCallValidateDestroyEvent(layer_data *dev_data, VkEvent event, EVENT_STATE **event_state, VK_OBJECT *obj_struct) { |
| *event_state = GetEventNode(dev_data, event); |
| *obj_struct = {HandleToUint64(event), kVulkanObjectTypeEvent}; |
| if (dev_data->instance_data->disabled.destroy_event) return false; |
| bool skip = false; |
| if (*event_state) { |
| skip |= ValidateObjectNotInUse(dev_data, *event_state, *obj_struct, "vkDestroyEvent", VALIDATION_ERROR_24c008f2); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordDestroyEvent(layer_data *dev_data, VkEvent event, EVENT_STATE *event_state, VK_OBJECT obj_struct) { |
| invalidateCommandBuffers(dev_data, event_state->cb_bindings, obj_struct); |
| dev_data->eventMap.erase(event); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| EVENT_STATE *event_state = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroyEvent(dev_data, event, &event_state, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyEvent(device, event, pAllocator); |
| lock.lock(); |
| if (event != VK_NULL_HANDLE) { |
| PostCallRecordDestroyEvent(dev_data, event, event_state, obj_struct); |
| } |
| } |
| } |
| |
| static bool PreCallValidateDestroyQueryPool(layer_data *dev_data, VkQueryPool query_pool, QUERY_POOL_NODE **qp_state, |
| VK_OBJECT *obj_struct) { |
| *qp_state = GetQueryPoolNode(dev_data, query_pool); |
| *obj_struct = {HandleToUint64(query_pool), kVulkanObjectTypeQueryPool}; |
| if (dev_data->instance_data->disabled.destroy_query_pool) return false; |
| bool skip = false; |
| if (*qp_state) { |
| skip |= ValidateObjectNotInUse(dev_data, *qp_state, *obj_struct, "vkDestroyQueryPool", VALIDATION_ERROR_26200632); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordDestroyQueryPool(layer_data *dev_data, VkQueryPool query_pool, QUERY_POOL_NODE *qp_state, |
| VK_OBJECT obj_struct) { |
| invalidateCommandBuffers(dev_data, qp_state->cb_bindings, obj_struct); |
| dev_data->queryPoolMap.erase(query_pool); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| QUERY_POOL_NODE *qp_state = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroyQueryPool(dev_data, queryPool, &qp_state, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyQueryPool(device, queryPool, pAllocator); |
| lock.lock(); |
| if (queryPool != VK_NULL_HANDLE) { |
| PostCallRecordDestroyQueryPool(dev_data, queryPool, qp_state, obj_struct); |
| } |
| } |
| } |
| static bool PreCallValidateGetQueryPoolResults(layer_data *dev_data, VkQueryPool query_pool, uint32_t first_query, |
| uint32_t query_count, VkQueryResultFlags flags, |
| unordered_map<QueryObject, vector<VkCommandBuffer>> *queries_in_flight) { |
| bool skip = false; |
| auto query_pool_state = dev_data->queryPoolMap.find(query_pool); |
| if (query_pool_state != dev_data->queryPoolMap.end()) { |
| if ((query_pool_state->second.createInfo.queryType == VK_QUERY_TYPE_TIMESTAMP) && (flags & VK_QUERY_RESULT_PARTIAL_BIT)) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, |
| VALIDATION_ERROR_2fa00664, "DS", |
| "QueryPool 0x%" PRIx64 |
| " was created with a queryType of VK_QUERY_TYPE_TIMESTAMP but flags contains VK_QUERY_RESULT_PARTIAL_BIT. %s", |
| HandleToUint64(query_pool), validation_error_map[VALIDATION_ERROR_2fa00664]); |
| } |
| } |
| |
| // TODO: clean this up, it's insanely wasteful. |
| for (auto cmd_buffer : dev_data->commandBufferMap) { |
| if (cmd_buffer.second->in_use.load()) { |
| for (auto query_state_pair : cmd_buffer.second->queryToStateMap) { |
| (*queries_in_flight)[query_state_pair.first].push_back(cmd_buffer.first); |
| } |
| } |
| } |
| |
| if (dev_data->instance_data->disabled.get_query_pool_results) return false; |
| for (uint32_t i = 0; i < query_count; ++i) { |
| QueryObject query = {query_pool, first_query + i}; |
| auto qif_pair = queries_in_flight->find(query); |
| auto query_state_pair = dev_data->queryToStateMap.find(query); |
| if (query_state_pair != dev_data->queryToStateMap.end()) { |
| // Available and in flight |
| if (qif_pair != queries_in_flight->end()) { |
| if (query_state_pair->second) { |
| for (auto cmd_buffer : qif_pair->second) { |
| auto cb = GetCBNode(dev_data, cmd_buffer); |
| auto query_event_pair = cb->waitedEventsBeforeQueryReset.find(query); |
| if (query_event_pair == cb->waitedEventsBeforeQueryReset.end()) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", |
| "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", |
| HandleToUint64(query_pool), first_query + i); |
| } |
| } |
| } |
| } else if (!query_state_pair->second) { // Unavailable and Not in flight |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, |
| __LINE__, DRAWSTATE_INVALID_QUERY, "DS", |
| "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", |
| HandleToUint64(query_pool), first_query + i); |
| } |
| } else { // Uninitialized |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, |
| __LINE__, DRAWSTATE_INVALID_QUERY, "DS", |
| "Cannot get query results on queryPool 0x%" PRIx64 |
| " with index %d as data has not been collected for this index.", |
| HandleToUint64(query_pool), first_query + i); |
| } |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordGetQueryPoolResults(layer_data *dev_data, VkQueryPool query_pool, uint32_t first_query, |
| uint32_t query_count, |
| unordered_map<QueryObject, vector<VkCommandBuffer>> *queries_in_flight) { |
| for (uint32_t i = 0; i < query_count; ++i) { |
| QueryObject query = {query_pool, first_query + i}; |
| auto qif_pair = queries_in_flight->find(query); |
| auto query_state_pair = dev_data->queryToStateMap.find(query); |
| if (query_state_pair != dev_data->queryToStateMap.end()) { |
| // Available and in flight |
| if (qif_pair != queries_in_flight->end() && query_state_pair != dev_data->queryToStateMap.end() && |
| query_state_pair->second) { |
| for (auto cmd_buffer : qif_pair->second) { |
| auto cb = GetCBNode(dev_data, cmd_buffer); |
| auto query_event_pair = cb->waitedEventsBeforeQueryReset.find(query); |
| if (query_event_pair != cb->waitedEventsBeforeQueryReset.end()) { |
| for (auto event : query_event_pair->second) { |
| dev_data->eventMap[event].needsSignaled = true; |
| } |
| } |
| } |
| } |
| } |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, |
| size_t dataSize, void *pData, VkDeviceSize stride, VkQueryResultFlags flags) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unordered_map<QueryObject, vector<VkCommandBuffer>> queries_in_flight; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateGetQueryPoolResults(dev_data, queryPool, firstQuery, queryCount, flags, &queries_in_flight); |
| lock.unlock(); |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| VkResult result = |
| dev_data->dispatch_table.GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, flags); |
| lock.lock(); |
| PostCallRecordGetQueryPoolResults(dev_data, queryPool, firstQuery, queryCount, &queries_in_flight); |
| lock.unlock(); |
| return result; |
| } |
| |
| // Return true if given ranges intersect, else false |
| // Prereq : For both ranges, range->end - range->start > 0. This case should have already resulted |
| // in an error so not checking that here |
| // pad_ranges bool indicates a linear and non-linear comparison which requires padding |
| // In the case where padding is required, if an alias is encountered then a validation error is reported and skip |
| // may be set by the callback function so caller should merge in skip value if padding case is possible. |
| // This check can be skipped by passing skip_checks=true, for call sites outside the validation path. |
| static bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, MEMORY_RANGE const *range2, bool *skip, |
| bool skip_checks) { |
| *skip = false; |
| auto r1_start = range1->start; |
| auto r1_end = range1->end; |
| auto r2_start = range2->start; |
| auto r2_end = range2->end; |
| VkDeviceSize pad_align = 1; |
| if (range1->linear != range2->linear) { |
| pad_align = dev_data->phys_dev_properties.properties.limits.bufferImageGranularity; |
| } |
| if ((r1_end & ~(pad_align - 1)) < (r2_start & ~(pad_align - 1))) return false; |
| if ((r1_start & ~(pad_align - 1)) > (r2_end & ~(pad_align - 1))) return false; |
| |
| if (!skip_checks && (range1->linear != range2->linear)) { |
| // In linear vs. non-linear case, warn of aliasing |
| const char *r1_linear_str = range1->linear ? "Linear" : "Non-linear"; |
| const char *r1_type_str = range1->image ? "image" : "buffer"; |
| const char *r2_linear_str = range2->linear ? "linear" : "non-linear"; |
| const char *r2_type_str = range2->image ? "image" : "buffer"; |
| auto obj_type = range1->image ? VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT : VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT; |
| *skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, obj_type, range1->handle, 0, MEMTRACK_INVALID_ALIASING, "MEM", |
| "%s %s 0x%" PRIx64 " is aliased with %s %s 0x%" PRIx64 |
| " which may indicate a bug. For further info refer to the Buffer-Image Granularity section of the Vulkan " |
| "specification. " |
| "(https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#resources-bufferimagegranularity)", |
| r1_linear_str, r1_type_str, range1->handle, r2_linear_str, r2_type_str, range2->handle); |
| } |
| // Ranges intersect |
| return true; |
| } |
| // Simplified rangesIntersect that calls above function to check range1 for intersection with offset & end addresses |
| bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, VkDeviceSize offset, VkDeviceSize end) { |
| // Create a local MEMORY_RANGE struct to wrap offset/size |
| MEMORY_RANGE range_wrap; |
| // Synch linear with range1 to avoid padding and potential validation error case |
| range_wrap.linear = range1->linear; |
| range_wrap.start = offset; |
| range_wrap.end = end; |
| bool tmp_bool; |
| return rangesIntersect(dev_data, range1, &range_wrap, &tmp_bool, true); |
| } |
| // For given mem_info, set all ranges valid that intersect [offset-end] range |
| // TODO : For ranges where there is no alias, we may want to create new buffer ranges that are valid |
| static void SetMemRangesValid(layer_data const *dev_data, DEVICE_MEM_INFO *mem_info, VkDeviceSize offset, VkDeviceSize end) { |
| bool tmp_bool = false; |
| MEMORY_RANGE map_range = {}; |
| map_range.linear = true; |
| map_range.start = offset; |
| map_range.end = end; |
| for (auto &handle_range_pair : mem_info->bound_ranges) { |
| if (rangesIntersect(dev_data, &handle_range_pair.second, &map_range, &tmp_bool, false)) { |
| // TODO : WARN here if tmp_bool true? |
| handle_range_pair.second.valid = true; |
| } |
| } |
| } |
| |
| static bool ValidateInsertMemoryRange(layer_data const *dev_data, uint64_t handle, DEVICE_MEM_INFO *mem_info, |
| VkDeviceSize memoryOffset, VkMemoryRequirements memRequirements, bool is_image, |
| bool is_linear, const char *api_name) { |
| bool skip = false; |
| |
| MEMORY_RANGE range; |
| range.image = is_image; |
| range.handle = handle; |
| range.linear = is_linear; |
| range.valid = mem_info->global_valid; |
| range.memory = mem_info->mem; |
| range.start = memoryOffset; |
| range.size = memRequirements.size; |
| range.end = memoryOffset + memRequirements.size - 1; |
| range.aliases.clear(); |
| |
| // Check for aliasing problems. |
| for (auto &obj_range_pair : mem_info->bound_ranges) { |
| auto check_range = &obj_range_pair.second; |
| bool intersection_error = false; |
| if (rangesIntersect(dev_data, &range, check_range, &intersection_error, false)) { |
| skip |= intersection_error; |
| range.aliases.insert(check_range); |
| } |
| } |
| |
| if (memoryOffset >= mem_info->alloc_info.allocationSize) { |
| UNIQUE_VALIDATION_ERROR_CODE error_code = is_image ? VALIDATION_ERROR_1740082c : VALIDATION_ERROR_1700080e; |
| skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem_info->mem), __LINE__, error_code, "MEM", |
| "In %s, attempting to bind memory (0x%" PRIx64 ") to object (0x%" PRIx64 "), memoryOffset=0x%" PRIxLEAST64 |
| " must be less than the memory allocation size 0x%" PRIxLEAST64 ". %s", |
| api_name, HandleToUint64(mem_info->mem), HandleToUint64(handle), memoryOffset, |
| mem_info->alloc_info.allocationSize, validation_error_map[error_code]); |
| } |
| |
| return skip; |
| } |
| |
| // Object with given handle is being bound to memory w/ given mem_info struct. |
| // Track the newly bound memory range with given memoryOffset |
| // Also scan any previous ranges, track aliased ranges with new range, and flag an error if a linear |
| // and non-linear range incorrectly overlap. |
| // Return true if an error is flagged and the user callback returns "true", otherwise false |
| // is_image indicates an image object, otherwise handle is for a buffer |
| // is_linear indicates a buffer or linear image |
| static void InsertMemoryRange(layer_data const *dev_data, uint64_t handle, DEVICE_MEM_INFO *mem_info, VkDeviceSize memoryOffset, |
| VkMemoryRequirements memRequirements, bool is_image, bool is_linear) { |
| MEMORY_RANGE range; |
| |
| range.image = is_image; |
| range.handle = handle; |
| range.linear = is_linear; |
| range.valid = mem_info->global_valid; |
| range.memory = mem_info->mem; |
| range.start = memoryOffset; |
| range.size = memRequirements.size; |
| range.end = memoryOffset + memRequirements.size - 1; |
| range.aliases.clear(); |
| // Update Memory aliasing |
| // Save aliased ranges so we can copy into final map entry below. Can't do it in loop b/c we don't yet have final ptr. If we |
| // inserted into map before loop to get the final ptr, then we may enter loop when not needed & we check range against itself |
| std::unordered_set<MEMORY_RANGE *> tmp_alias_ranges; |
| for (auto &obj_range_pair : mem_info->bound_ranges) { |
| auto check_range = &obj_range_pair.second; |
| bool intersection_error = false; |
| if (rangesIntersect(dev_data, &range, check_range, &intersection_error, true)) { |
| range.aliases.insert(check_range); |
| tmp_alias_ranges.insert(check_range); |
| } |
| } |
| mem_info->bound_ranges[handle] = std::move(range); |
| for (auto tmp_range : tmp_alias_ranges) { |
| tmp_range->aliases.insert(&mem_info->bound_ranges[handle]); |
| } |
| if (is_image) |
| mem_info->bound_images.insert(handle); |
| else |
| mem_info->bound_buffers.insert(handle); |
| } |
| |
| static bool ValidateInsertImageMemoryRange(layer_data const *dev_data, VkImage image, DEVICE_MEM_INFO *mem_info, |
| VkDeviceSize mem_offset, VkMemoryRequirements mem_reqs, bool is_linear, |
| const char *api_name) { |
| return ValidateInsertMemoryRange(dev_data, HandleToUint64(image), mem_info, mem_offset, mem_reqs, true, is_linear, api_name); |
| } |
| static void InsertImageMemoryRange(layer_data const *dev_data, VkImage image, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, |
| VkMemoryRequirements mem_reqs, bool is_linear) { |
| InsertMemoryRange(dev_data, HandleToUint64(image), mem_info, mem_offset, mem_reqs, true, is_linear); |
| } |
| |
| static bool ValidateInsertBufferMemoryRange(layer_data const *dev_data, VkBuffer buffer, DEVICE_MEM_INFO *mem_info, |
| VkDeviceSize mem_offset, VkMemoryRequirements mem_reqs, const char *api_name) { |
| return ValidateInsertMemoryRange(dev_data, HandleToUint64(buffer), mem_info, mem_offset, mem_reqs, false, true, api_name); |
| } |
| static void InsertBufferMemoryRange(layer_data const *dev_data, VkBuffer buffer, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, |
| VkMemoryRequirements mem_reqs) { |
| InsertMemoryRange(dev_data, HandleToUint64(buffer), mem_info, mem_offset, mem_reqs, false, true); |
| } |
| |
| // Remove MEMORY_RANGE struct for give handle from bound_ranges of mem_info |
| // is_image indicates if handle is for image or buffer |
| // This function will also remove the handle-to-index mapping from the appropriate |
| // map and clean up any aliases for range being removed. |
| static void RemoveMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info, bool is_image) { |
| auto erase_range = &mem_info->bound_ranges[handle]; |
| for (auto alias_range : erase_range->aliases) { |
| alias_range->aliases.erase(erase_range); |
| } |
| erase_range->aliases.clear(); |
| mem_info->bound_ranges.erase(handle); |
| if (is_image) { |
| mem_info->bound_images.erase(handle); |
| } else { |
| mem_info->bound_buffers.erase(handle); |
| } |
| } |
| |
| void RemoveBufferMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, false); } |
| |
| void RemoveImageMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, true); } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| BUFFER_STATE *buffer_state = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroyBuffer(dev_data, buffer, &buffer_state, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyBuffer(device, buffer, pAllocator); |
| lock.lock(); |
| if (buffer != VK_NULL_HANDLE) { |
| PostCallRecordDestroyBuffer(dev_data, buffer, buffer_state, obj_struct); |
| } |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| // Common data objects used pre & post call |
| BUFFER_VIEW_STATE *buffer_view_state = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| // Validate state before calling down chain, update common data if we'll be calling down chain |
| bool skip = PreCallValidateDestroyBufferView(dev_data, bufferView, &buffer_view_state, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyBufferView(device, bufferView, pAllocator); |
| lock.lock(); |
| if (bufferView != VK_NULL_HANDLE) { |
| PostCallRecordDestroyBufferView(dev_data, bufferView, buffer_view_state, obj_struct); |
| } |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| IMAGE_STATE *image_state = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroyImage(dev_data, image, &image_state, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyImage(device, image, pAllocator); |
| lock.lock(); |
| if (image != VK_NULL_HANDLE) { |
| PostCallRecordDestroyImage(dev_data, image, image_state, obj_struct); |
| } |
| } |
| } |
| |
| static bool ValidateMemoryTypes(const layer_data *dev_data, const DEVICE_MEM_INFO *mem_info, const uint32_t memory_type_bits, |
| const char *funcName, UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
| bool skip = false; |
| if (((1 << mem_info->alloc_info.memoryTypeIndex) & memory_type_bits) == 0) { |
| skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem_info->mem), __LINE__, msgCode, "MT", |
| "%s(): MemoryRequirements->memoryTypeBits (0x%X) for this object type are not compatible with the memory " |
| "type (0x%X) of this memory object 0x%" PRIx64 ". %s", |
| funcName, memory_type_bits, mem_info->alloc_info.memoryTypeIndex, HandleToUint64(mem_info->mem), |
| validation_error_map[msgCode]); |
| } |
| return skip; |
| } |
| |
| static bool PreCallValidateBindBufferMemory(layer_data *dev_data, VkBuffer buffer, BUFFER_STATE *buffer_state, VkDeviceMemory mem, |
| VkDeviceSize memoryOffset, const char *api_name) { |
| bool skip = false; |
| if (buffer_state) { |
| unique_lock_t lock(global_lock); |
| // Track objects tied to memory |
| uint64_t buffer_handle = HandleToUint64(buffer); |
| skip = ValidateSetMemBinding(dev_data, mem, buffer_handle, kVulkanObjectTypeBuffer, api_name); |
| if (!buffer_state->memory_requirements_checked) { |
| // There's not an explicit requirement in the spec to call vkGetBufferMemoryRequirements() prior to calling |
| // BindBufferMemory, but it's implied in that memory being bound must conform with VkMemoryRequirements from |
| // vkGetBufferMemoryRequirements() |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| buffer_handle, __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", |
| "%s: Binding memory to buffer 0x%" PRIx64 |
| " but vkGetBufferMemoryRequirements() has not been called on that buffer.", |
| api_name, HandleToUint64(buffer_handle)); |
| // Make the call for them so we can verify the state |
| lock.unlock(); |
| dev_data->dispatch_table.GetBufferMemoryRequirements(dev_data->device, buffer, &buffer_state->requirements); |
| lock.lock(); |
| } |
| |
| // Validate bound memory range information |
| auto mem_info = GetMemObjInfo(dev_data, mem); |
| if (mem_info) { |
| skip |= ValidateInsertBufferMemoryRange(dev_data, buffer, mem_info, memoryOffset, buffer_state->requirements, api_name); |
| skip |= ValidateMemoryTypes(dev_data, mem_info, buffer_state->requirements.memoryTypeBits, api_name, |
| VALIDATION_ERROR_17000816); |
| } |
| |
| // Validate memory requirements alignment |
| if (SafeModulo(memoryOffset, buffer_state->requirements.alignment) != 0) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| buffer_handle, __LINE__, VALIDATION_ERROR_17000818, "DS", |
| "%s: memoryOffset is 0x%" PRIxLEAST64 |
| " but must be an integer multiple of the VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 |
| ", returned from a call to vkGetBufferMemoryRequirements with buffer. %s", |
| api_name, memoryOffset, buffer_state->requirements.alignment, |
| validation_error_map[VALIDATION_ERROR_17000818]); |
| } |
| |
| // Validate memory requirements size |
| if (mem_info) { |
| if (buffer_state->requirements.size > (mem_info->alloc_info.allocationSize - memoryOffset)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| buffer_handle, __LINE__, VALIDATION_ERROR_1700081a, "DS", |
| "%s: memory size minus memoryOffset is 0x%" PRIxLEAST64 |
| " but must be at least as large as VkMemoryRequirements::size value 0x%" PRIxLEAST64 |
| ", returned from a call to vkGetBufferMemoryRequirements with buffer. %s", |
| api_name, mem_info->alloc_info.allocationSize - memoryOffset, buffer_state->requirements.size, |
| validation_error_map[VALIDATION_ERROR_1700081a]); |
| } |
| } |
| |
| // Validate device limits alignments |
| static const VkBufferUsageFlagBits usage_list[3] = { |
| static_cast<VkBufferUsageFlagBits>(VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT), |
| VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT, VK_BUFFER_USAGE_STORAGE_BUFFER_BIT}; |
| static const char *memory_type[3] = {"texel", "uniform", "storage"}; |
| static const char *offset_name[3] = {"minTexelBufferOffsetAlignment", "minUniformBufferOffsetAlignment", |
| "minStorageBufferOffsetAlignment"}; |
| |
| // TODO: vk_validation_stats.py cannot abide braces immediately preceding or following a validation error enum |
| // clang-format off |
| static const UNIQUE_VALIDATION_ERROR_CODE msgCode[3] = { VALIDATION_ERROR_17000810, VALIDATION_ERROR_17000812, |
| VALIDATION_ERROR_17000814 }; |
| // clang-format on |
| |
| // Keep this one fresh! |
| const VkDeviceSize offset_requirement[3] = { |
| dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment, |
| dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment, |
| dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment}; |
| VkBufferUsageFlags usage = dev_data->bufferMap[buffer].get()->createInfo.usage; |
| |
| for (int i = 0; i < 3; i++) { |
| if (usage & usage_list[i]) { |
| if (SafeModulo(memoryOffset, offset_requirement[i]) != 0) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| buffer_handle, __LINE__, msgCode[i], "DS", |
| "%s: %s memoryOffset is 0x%" PRIxLEAST64 |
| " but must be a multiple of device limit %s 0x%" PRIxLEAST64 ". %s", |
| api_name, memory_type[i], memoryOffset, offset_name[i], offset_requirement[i], |
| validation_error_map[msgCode[i]]); |
| } |
| } |
| } |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordBindBufferMemory(layer_data *dev_data, VkBuffer buffer, BUFFER_STATE *buffer_state, VkDeviceMemory mem, |
| VkDeviceSize memoryOffset, const char *api_name) { |
| if (buffer_state) { |
| unique_lock_t lock(global_lock); |
| // Track bound memory range information |
| auto mem_info = GetMemObjInfo(dev_data, mem); |
| if (mem_info) { |
| InsertBufferMemoryRange(dev_data, buffer, mem_info, memoryOffset, buffer_state->requirements); |
| } |
| |
| // Track objects tied to memory |
| uint64_t buffer_handle = HandleToUint64(buffer); |
| SetMemBinding(dev_data, mem, buffer_state, memoryOffset, buffer_handle, kVulkanObjectTypeBuffer, api_name); |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL BindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| BUFFER_STATE *buffer_state; |
| { |
| unique_lock_t lock(global_lock); |
| buffer_state = GetBufferState(dev_data, buffer); |
| } |
| bool skip = PreCallValidateBindBufferMemory(dev_data, buffer, buffer_state, mem, memoryOffset, "vkBindBufferMemory()"); |
| if (!skip) { |
| result = dev_data->dispatch_table.BindBufferMemory(device, buffer, mem, memoryOffset); |
| if (result == VK_SUCCESS) { |
| PostCallRecordBindBufferMemory(dev_data, buffer, buffer_state, mem, memoryOffset, "vkBindBufferMemory()"); |
| } |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateBindBufferMemory2KHR(layer_data *dev_data, std::vector<BUFFER_STATE *> *buffer_state, |
| uint32_t bindInfoCount, const VkBindBufferMemoryInfoKHR *pBindInfos) { |
| { |
| unique_lock_t lock(global_lock); |
| for (uint32_t i = 0; i < bindInfoCount; i++) { |
| (*buffer_state)[i] = GetBufferState(dev_data, pBindInfos[i].buffer); |
| } |
| } |
| bool skip = false; |
| char api_name[64]; |
| for (uint32_t i = 0; i < bindInfoCount; i++) { |
| sprintf(api_name, "vkBindBufferMemory2KHR() pBindInfos[%u]", i); |
| skip |= PreCallValidateBindBufferMemory(dev_data, pBindInfos[i].buffer, (*buffer_state)[i], pBindInfos[i].memory, |
| pBindInfos[i].memoryOffset, api_name); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordBindBufferMemory2KHR(layer_data *dev_data, const std::vector<BUFFER_STATE *> &buffer_state, |
| uint32_t bindInfoCount, const VkBindBufferMemoryInfoKHR *pBindInfos) { |
| for (uint32_t i = 0; i < bindInfoCount; i++) { |
| PostCallRecordBindBufferMemory(dev_data, pBindInfos[i].buffer, buffer_state[i], pBindInfos[i].memory, |
| pBindInfos[i].memoryOffset, "vkBindBufferMemory2KHR()"); |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL BindBufferMemory2KHR(VkDevice device, uint32_t bindInfoCount, |
| const VkBindBufferMemoryInfoKHR *pBindInfos) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| std::vector<BUFFER_STATE *> buffer_state(bindInfoCount); |
| if (!PreCallValidateBindBufferMemory2KHR(dev_data, &buffer_state, bindInfoCount, pBindInfos)) { |
| result = dev_data->dispatch_table.BindBufferMemory2KHR(device, bindInfoCount, pBindInfos); |
| if (result == VK_SUCCESS) { |
| PostCallRecordBindBufferMemory2KHR(dev_data, buffer_state, bindInfoCount, pBindInfos); |
| } |
| } |
| return result; |
| } |
| |
| static void PostCallRecordGetBufferMemoryRequirements(layer_data *dev_data, VkBuffer buffer, |
| VkMemoryRequirements *pMemoryRequirements) { |
| BUFFER_STATE *buffer_state; |
| { |
| unique_lock_t lock(global_lock); |
| buffer_state = GetBufferState(dev_data, buffer); |
| } |
| if (buffer_state) { |
| buffer_state->requirements = *pMemoryRequirements; |
| buffer_state->memory_requirements_checked = true; |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL GetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, |
| VkMemoryRequirements *pMemoryRequirements) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| dev_data->dispatch_table.GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); |
| PostCallRecordGetBufferMemoryRequirements(dev_data, buffer, pMemoryRequirements); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL GetBufferMemoryRequirements2KHR(VkDevice device, const VkBufferMemoryRequirementsInfo2KHR *pInfo, |
| VkMemoryRequirements2KHR *pMemoryRequirements) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| dev_data->dispatch_table.GetBufferMemoryRequirements2KHR(device, pInfo, pMemoryRequirements); |
| PostCallRecordGetBufferMemoryRequirements(dev_data, pInfo->buffer, &pMemoryRequirements->memoryRequirements); |
| } |
| |
| static void PostCallRecordGetImageMemoryRequirements(layer_data *dev_data, VkImage image, |
| VkMemoryRequirements *pMemoryRequirements) { |
| IMAGE_STATE *image_state; |
| { |
| unique_lock_t lock(global_lock); |
| image_state = GetImageState(dev_data, image); |
| } |
| if (image_state) { |
| image_state->requirements = *pMemoryRequirements; |
| image_state->memory_requirements_checked = true; |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL GetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| dev_data->dispatch_table.GetImageMemoryRequirements(device, image, pMemoryRequirements); |
| PostCallRecordGetImageMemoryRequirements(dev_data, image, pMemoryRequirements); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL GetImageMemoryRequirements2KHR(VkDevice device, const VkImageMemoryRequirementsInfo2KHR *pInfo, |
| VkMemoryRequirements2KHR *pMemoryRequirements) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| dev_data->dispatch_table.GetImageMemoryRequirements2KHR(device, pInfo, pMemoryRequirements); |
| PostCallRecordGetImageMemoryRequirements(dev_data, pInfo->image, &pMemoryRequirements->memoryRequirements); |
| } |
| |
| static void PostCallRecordGetImageSparseMemoryRequirements(IMAGE_STATE *image_state, uint32_t req_count, |
| VkSparseImageMemoryRequirements *reqs) { |
| image_state->get_sparse_reqs_called = true; |
| image_state->sparse_requirements.resize(req_count); |
| if (reqs) { |
| std::copy(reqs, reqs + req_count, image_state->sparse_requirements.begin()); |
| } |
| for (const auto &req : image_state->sparse_requirements) { |
| if (req.formatProperties.aspectMask & VK_IMAGE_ASPECT_METADATA_BIT) { |
| image_state->sparse_metadata_required = true; |
| } |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL GetImageSparseMemoryRequirements(VkDevice device, VkImage image, uint32_t *pSparseMemoryRequirementCount, |
| VkSparseImageMemoryRequirements *pSparseMemoryRequirements) { |
| // TODO : Implement tracking here, just passthrough initially |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| dev_data->dispatch_table.GetImageSparseMemoryRequirements(device, image, pSparseMemoryRequirementCount, |
| pSparseMemoryRequirements); |
| unique_lock_t lock(global_lock); |
| auto image_state = GetImageState(dev_data, image); |
| PostCallRecordGetImageSparseMemoryRequirements(image_state, *pSparseMemoryRequirementCount, pSparseMemoryRequirements); |
| } |
| |
| static void PostCallRecordGetImageSparseMemoryRequirements2KHR(IMAGE_STATE *image_state, uint32_t req_count, |
| VkSparseImageMemoryRequirements2KHR *reqs) { |
| std::vector<VkSparseImageMemoryRequirements> sparse_reqs(req_count); |
| // Migrate to old struct type for common handling with GetImageSparseMemoryRequirements() |
| for (uint32_t i = 0; i < req_count; ++i) { |
| assert(!reqs[i].pNext); // TODO: If an extension is ever added here we need to handle it |
| sparse_reqs[i] = reqs[i].memoryRequirements; |
| } |
| PostCallRecordGetImageSparseMemoryRequirements(image_state, req_count, sparse_reqs.data()); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL GetImageSparseMemoryRequirements2KHR(VkDevice device, |
| const VkImageSparseMemoryRequirementsInfo2KHR *pInfo, |
| uint32_t *pSparseMemoryRequirementCount, |
| VkSparseImageMemoryRequirements2KHR *pSparseMemoryRequirements) { |
| // TODO : Implement tracking here, just passthrough initially |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| dev_data->dispatch_table.GetImageSparseMemoryRequirements2KHR(device, pInfo, pSparseMemoryRequirementCount, |
| pSparseMemoryRequirements); |
| unique_lock_t lock(global_lock); |
| auto image_state = GetImageState(dev_data, pInfo->image); |
| PostCallRecordGetImageSparseMemoryRequirements2KHR(image_state, *pSparseMemoryRequirementCount, pSparseMemoryRequirements); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL GetPhysicalDeviceSparseImageFormatProperties(VkPhysicalDevice physicalDevice, VkFormat format, |
| VkImageType type, VkSampleCountFlagBits samples, |
| VkImageUsageFlags usage, VkImageTiling tiling, |
| uint32_t *pPropertyCount, |
| VkSparseImageFormatProperties *pProperties) { |
| // TODO : Implement this intercept, track sparse image format properties and make sure they are obeyed. |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| instance_data->dispatch_table.GetPhysicalDeviceSparseImageFormatProperties(physicalDevice, format, type, samples, usage, tiling, |
| pPropertyCount, pProperties); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL GetPhysicalDeviceSparseImageFormatProperties2KHR( |
| VkPhysicalDevice physicalDevice, const VkPhysicalDeviceSparseImageFormatInfo2KHR *pFormatInfo, uint32_t *pPropertyCount, |
| VkSparseImageFormatProperties2KHR *pProperties) { |
| // TODO : Implement this intercept, track sparse image format properties and make sure they are obeyed. |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| instance_data->dispatch_table.GetPhysicalDeviceSparseImageFormatProperties2KHR(physicalDevice, pFormatInfo, pPropertyCount, |
| pProperties); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| // Common data objects used pre & post call |
| IMAGE_VIEW_STATE *image_view_state = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroyImageView(dev_data, imageView, &image_view_state, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyImageView(device, imageView, pAllocator); |
| lock.lock(); |
| if (imageView != VK_NULL_HANDLE) { |
| PostCallRecordDestroyImageView(dev_data, imageView, image_view_state, obj_struct); |
| } |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyShaderModule(VkDevice device, VkShaderModule shaderModule, |
| const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| |
| unique_lock_t lock(global_lock); |
| dev_data->shaderModuleMap.erase(shaderModule); |
| lock.unlock(); |
| |
| dev_data->dispatch_table.DestroyShaderModule(device, shaderModule, pAllocator); |
| } |
| |
| static bool PreCallValidateDestroyPipeline(layer_data *dev_data, VkPipeline pipeline, PIPELINE_STATE **pipeline_state, |
| VK_OBJECT *obj_struct) { |
| *pipeline_state = getPipelineState(dev_data, pipeline); |
| *obj_struct = {HandleToUint64(pipeline), kVulkanObjectTypePipeline}; |
| if (dev_data->instance_data->disabled.destroy_pipeline) return false; |
| bool skip = false; |
| if (*pipeline_state) { |
| skip |= ValidateObjectNotInUse(dev_data, *pipeline_state, *obj_struct, "vkDestroyPipeline", VALIDATION_ERROR_25c005fa); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordDestroyPipeline(layer_data *dev_data, VkPipeline pipeline, PIPELINE_STATE *pipeline_state, |
| VK_OBJECT obj_struct) { |
| // Any bound cmd buffers are now invalid |
| invalidateCommandBuffers(dev_data, pipeline_state->cb_bindings, obj_struct); |
| dev_data->pipelineMap.erase(pipeline); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| PIPELINE_STATE *pipeline_state = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroyPipeline(dev_data, pipeline, &pipeline_state, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyPipeline(device, pipeline, pAllocator); |
| lock.lock(); |
| if (pipeline != VK_NULL_HANDLE) { |
| PostCallRecordDestroyPipeline(dev_data, pipeline, pipeline_state, obj_struct); |
| } |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, |
| const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| dev_data->pipelineLayoutMap.erase(pipelineLayout); |
| lock.unlock(); |
| |
| dev_data->dispatch_table.DestroyPipelineLayout(device, pipelineLayout, pAllocator); |
| } |
| |
| static bool PreCallValidateDestroySampler(layer_data *dev_data, VkSampler sampler, SAMPLER_STATE **sampler_state, |
| VK_OBJECT *obj_struct) { |
| *sampler_state = GetSamplerState(dev_data, sampler); |
| *obj_struct = {HandleToUint64(sampler), kVulkanObjectTypeSampler}; |
| if (dev_data->instance_data->disabled.destroy_sampler) return false; |
| bool skip = false; |
| if (*sampler_state) { |
| skip |= ValidateObjectNotInUse(dev_data, *sampler_state, *obj_struct, "vkDestroySampler", VALIDATION_ERROR_26600874); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordDestroySampler(layer_data *dev_data, VkSampler sampler, SAMPLER_STATE *sampler_state, |
| VK_OBJECT obj_struct) { |
| // Any bound cmd buffers are now invalid |
| if (sampler_state) invalidateCommandBuffers(dev_data, sampler_state->cb_bindings, obj_struct); |
| dev_data->samplerMap.erase(sampler); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| SAMPLER_STATE *sampler_state = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroySampler(dev_data, sampler, &sampler_state, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroySampler(device, sampler, pAllocator); |
| lock.lock(); |
| if (sampler != VK_NULL_HANDLE) { |
| PostCallRecordDestroySampler(dev_data, sampler, sampler_state, obj_struct); |
| } |
| } |
| } |
| |
| static void PostCallRecordDestroyDescriptorSetLayout(layer_data *dev_data, VkDescriptorSetLayout ds_layout) { |
| auto layout_it = dev_data->descriptorSetLayoutMap.find(ds_layout); |
| if (layout_it != dev_data->descriptorSetLayoutMap.end()) { |
| layout_it->second.get()->MarkDestroyed(); |
| dev_data->descriptorSetLayoutMap.erase(layout_it); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, |
| const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| dev_data->dispatch_table.DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); |
| unique_lock_t lock(global_lock); |
| PostCallRecordDestroyDescriptorSetLayout(dev_data, descriptorSetLayout); |
| } |
| |
| static bool PreCallValidateDestroyDescriptorPool(layer_data *dev_data, VkDescriptorPool pool, |
| DESCRIPTOR_POOL_STATE **desc_pool_state, VK_OBJECT *obj_struct) { |
| *desc_pool_state = GetDescriptorPoolState(dev_data, pool); |
| *obj_struct = {HandleToUint64(pool), kVulkanObjectTypeDescriptorPool}; |
| if (dev_data->instance_data->disabled.destroy_descriptor_pool) return false; |
| bool skip = false; |
| if (*desc_pool_state) { |
| skip |= |
| ValidateObjectNotInUse(dev_data, *desc_pool_state, *obj_struct, "vkDestroyDescriptorPool", VALIDATION_ERROR_2440025e); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordDestroyDescriptorPool(layer_data *dev_data, VkDescriptorPool descriptorPool, |
| DESCRIPTOR_POOL_STATE *desc_pool_state, VK_OBJECT obj_struct) { |
| // Any bound cmd buffers are now invalid |
| invalidateCommandBuffers(dev_data, desc_pool_state->cb_bindings, obj_struct); |
| // Free sets that were in this pool |
| for (auto ds : desc_pool_state->sets) { |
| freeDescriptorSet(dev_data, ds); |
| } |
| dev_data->descriptorPoolMap.erase(descriptorPool); |
| delete desc_pool_state; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, |
| const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| DESCRIPTOR_POOL_STATE *desc_pool_state = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroyDescriptorPool(dev_data, descriptorPool, &desc_pool_state, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyDescriptorPool(device, descriptorPool, pAllocator); |
| lock.lock(); |
| if (descriptorPool != VK_NULL_HANDLE) { |
| PostCallRecordDestroyDescriptorPool(dev_data, descriptorPool, desc_pool_state, obj_struct); |
| } |
| } |
| } |
| // Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip result |
| // If this is a secondary command buffer, then make sure its primary is also in-flight |
| // If primary is not in-flight, then remove secondary from global in-flight set |
| // This function is only valid at a point when cmdBuffer is being reset or freed |
| static bool checkCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action, |
| UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| bool skip = false; |
| if (cb_node->in_use.load()) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_node->commandBuffer), __LINE__, error_code, "DS", |
| "Attempt to %s command buffer (0x%" PRIx64 ") which is in use. %s", action, |
| HandleToUint64(cb_node->commandBuffer), validation_error_map[error_code]); |
| } |
| return skip; |
| } |
| |
| // Iterate over all cmdBuffers in given commandPool and verify that each is not in use |
| static bool checkCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool, const char *action, |
| UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| bool skip = false; |
| for (auto cmd_buffer : pPool->commandBuffers) { |
| skip |= checkCommandBufferInFlight(dev_data, GetCBNode(dev_data, cmd_buffer), action, error_code); |
| } |
| return skip; |
| } |
| |
| // Free all command buffers in given list, removing all references/links to them using ResetCommandBufferState |
| static void FreeCommandBufferStates(layer_data *dev_data, COMMAND_POOL_NODE *pool_state, const uint32_t command_buffer_count, |
| const VkCommandBuffer *command_buffers) { |
| for (uint32_t i = 0; i < command_buffer_count; i++) { |
| auto cb_state = GetCBNode(dev_data, command_buffers[i]); |
| // Remove references to command buffer's state and delete |
| if (cb_state) { |
| // reset prior to delete, removing various references to it. |
| // TODO: fix this, it's insane. |
| ResetCommandBufferState(dev_data, cb_state->commandBuffer); |
| // Remove the cb_state's references from layer_data and COMMAND_POOL_NODE |
| dev_data->commandBufferMap.erase(cb_state->commandBuffer); |
| pool_state->commandBuffers.erase(command_buffers[i]); |
| delete cb_state; |
| } |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL FreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, |
| const VkCommandBuffer *pCommandBuffers) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool skip = false; |
| unique_lock_t lock(global_lock); |
| |
| for (uint32_t i = 0; i < commandBufferCount; i++) { |
| auto cb_node = GetCBNode(dev_data, pCommandBuffers[i]); |
| // Delete CB information structure, and remove from commandBufferMap |
| if (cb_node) { |
| skip |= checkCommandBufferInFlight(dev_data, cb_node, "free", VALIDATION_ERROR_2840005e); |
| } |
| } |
| |
| if (skip) return; |
| |
| auto pPool = GetCommandPoolNode(dev_data, commandPool); |
| FreeCommandBufferStates(dev_data, pPool, commandBufferCount, pCommandBuffers); |
| lock.unlock(); |
| |
| dev_data->dispatch_table.FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| |
| VkResult result = dev_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); |
| |
| if (VK_SUCCESS == result) { |
| lock_guard_t lock(global_lock); |
| dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; |
| dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool skip = false; |
| if (pCreateInfo && pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) { |
| if (!dev_data->enabled_features.pipelineStatisticsQuery) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, |
| __LINE__, VALIDATION_ERROR_11c0062e, "DS", |
| "Query pool with type VK_QUERY_TYPE_PIPELINE_STATISTICS created on a device with " |
| "VkDeviceCreateInfo.pEnabledFeatures.pipelineStatisticsQuery == VK_FALSE. %s", |
| validation_error_map[VALIDATION_ERROR_11c0062e]); |
| } |
| } |
| |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| if (!skip) { |
| result = dev_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); |
| } |
| if (result == VK_SUCCESS) { |
| lock_guard_t lock(global_lock); |
| QUERY_POOL_NODE *qp_node = &dev_data->queryPoolMap[*pQueryPool]; |
| qp_node->createInfo = *pCreateInfo; |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateDestroyCommandPool(layer_data *dev_data, VkCommandPool pool) { |
| COMMAND_POOL_NODE *cp_state = GetCommandPoolNode(dev_data, pool); |
| if (dev_data->instance_data->disabled.destroy_command_pool) return false; |
| bool skip = false; |
| if (cp_state) { |
| // Verify that command buffers in pool are complete (not in-flight) |
| skip |= checkCommandBuffersInFlight(dev_data, cp_state, "destroy command pool with", VALIDATION_ERROR_24000052); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordDestroyCommandPool(layer_data *dev_data, VkCommandPool pool) { |
| COMMAND_POOL_NODE *cp_state = GetCommandPoolNode(dev_data, pool); |
| // Remove cmdpool from cmdpoolmap, after freeing layer data for the command buffers |
| // "When a pool is destroyed, all command buffers allocated from the pool are freed." |
| if (cp_state) { |
| // Create a vector, as FreeCommandBufferStates deletes from cp_state->commandBuffers during iteration. |
| std::vector<VkCommandBuffer> cb_vec{cp_state->commandBuffers.begin(), cp_state->commandBuffers.end()}; |
| FreeCommandBufferStates(dev_data, cp_state, static_cast<uint32_t>(cb_vec.size()), cb_vec.data()); |
| dev_data->commandPoolMap.erase(pool); |
| } |
| } |
| |
| // Destroy commandPool along with all of the commandBuffers allocated from that pool |
| VKAPI_ATTR void VKAPI_CALL DestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroyCommandPool(dev_data, commandPool); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyCommandPool(device, commandPool, pAllocator); |
| lock.lock(); |
| if (commandPool != VK_NULL_HANDLE) { |
| PostCallRecordDestroyCommandPool(dev_data, commandPool); |
| } |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL ResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool skip = false; |
| |
| unique_lock_t lock(global_lock); |
| auto pPool = GetCommandPoolNode(dev_data, commandPool); |
| skip |= checkCommandBuffersInFlight(dev_data, pPool, "reset command pool with", VALIDATION_ERROR_32800050); |
| lock.unlock(); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| VkResult result = dev_data->dispatch_table.ResetCommandPool(device, commandPool, flags); |
| |
| // Reset all of the CBs allocated from this pool |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| for (auto cmdBuffer : pPool->commandBuffers) { |
| ResetCommandBufferState(dev_data, cmdBuffer); |
| } |
| lock.unlock(); |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool skip = false; |
| unique_lock_t lock(global_lock); |
| for (uint32_t i = 0; i < fenceCount; ++i) { |
| auto pFence = GetFenceNode(dev_data, pFences[i]); |
| if (pFence && pFence->scope == kSyncScopeInternal && pFence->state == FENCE_INFLIGHT) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| HandleToUint64(pFences[i]), __LINE__, VALIDATION_ERROR_32e008c6, "DS", "Fence 0x%" PRIx64 " is in use. %s", |
| HandleToUint64(pFences[i]), validation_error_map[VALIDATION_ERROR_32e008c6]); |
| } |
| } |
| lock.unlock(); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| VkResult result = dev_data->dispatch_table.ResetFences(device, fenceCount, pFences); |
| |
| if (result == VK_SUCCESS) { |
| lock.lock(); |
| for (uint32_t i = 0; i < fenceCount; ++i) { |
| auto pFence = GetFenceNode(dev_data, pFences[i]); |
| if (pFence) { |
| if (pFence->scope == kSyncScopeInternal) { |
| pFence->state = FENCE_UNSIGNALED; |
| } else if (pFence->scope == kSyncScopeExternalTemporary) { |
| pFence->scope = kSyncScopeInternal; |
| } |
| } |
| } |
| lock.unlock(); |
| } |
| |
| return result; |
| } |
| |
| // For given cb_nodes, invalidate them and track object causing invalidation |
| void invalidateCommandBuffers(const layer_data *dev_data, std::unordered_set<GLOBAL_CB_NODE *> const &cb_nodes, VK_OBJECT obj) { |
| for (auto cb_node : cb_nodes) { |
| if (cb_node->state == CB_RECORDING) { |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| "Invalidating a command buffer that's currently being recorded: 0x%" PRIx64 ".", |
| HandleToUint64(cb_node->commandBuffer)); |
| cb_node->state = CB_INVALID_INCOMPLETE; |
| } else if (cb_node->state == CB_RECORDED) { |
| cb_node->state = CB_INVALID_COMPLETE; |
| } |
| cb_node->broken_bindings.push_back(obj); |
| |
| // if secondary, then propagate the invalidation to the primaries that will call us. |
| if (cb_node->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) { |
| invalidateCommandBuffers(dev_data, cb_node->linkedCommandBuffers, obj); |
| } |
| } |
| } |
| |
| static bool PreCallValidateDestroyFramebuffer(layer_data *dev_data, VkFramebuffer framebuffer, |
| FRAMEBUFFER_STATE **framebuffer_state, VK_OBJECT *obj_struct) { |
| *framebuffer_state = GetFramebufferState(dev_data, framebuffer); |
| *obj_struct = {HandleToUint64(framebuffer), kVulkanObjectTypeFramebuffer}; |
| if (dev_data->instance_data->disabled.destroy_framebuffer) return false; |
| bool skip = false; |
| if (*framebuffer_state) { |
| skip |= |
| ValidateObjectNotInUse(dev_data, *framebuffer_state, *obj_struct, "vkDestroyFrameBuffer", VALIDATION_ERROR_250006f8); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordDestroyFramebuffer(layer_data *dev_data, VkFramebuffer framebuffer, FRAMEBUFFER_STATE *framebuffer_state, |
| VK_OBJECT obj_struct) { |
| invalidateCommandBuffers(dev_data, framebuffer_state->cb_bindings, obj_struct); |
| dev_data->frameBufferMap.erase(framebuffer); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| FRAMEBUFFER_STATE *framebuffer_state = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroyFramebuffer(dev_data, framebuffer, &framebuffer_state, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyFramebuffer(device, framebuffer, pAllocator); |
| lock.lock(); |
| if (framebuffer != VK_NULL_HANDLE) { |
| PostCallRecordDestroyFramebuffer(dev_data, framebuffer, framebuffer_state, obj_struct); |
| } |
| } |
| } |
| |
| static bool PreCallValidateDestroyRenderPass(layer_data *dev_data, VkRenderPass render_pass, RENDER_PASS_STATE **rp_state, |
| VK_OBJECT *obj_struct) { |
| *rp_state = GetRenderPassState(dev_data, render_pass); |
| *obj_struct = {HandleToUint64(render_pass), kVulkanObjectTypeRenderPass}; |
| if (dev_data->instance_data->disabled.destroy_renderpass) return false; |
| bool skip = false; |
| if (*rp_state) { |
| skip |= ValidateObjectNotInUse(dev_data, *rp_state, *obj_struct, "vkDestroyRenderPass", VALIDATION_ERROR_264006d2); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordDestroyRenderPass(layer_data *dev_data, VkRenderPass render_pass, RENDER_PASS_STATE *rp_state, |
| VK_OBJECT obj_struct) { |
| invalidateCommandBuffers(dev_data, rp_state->cb_bindings, obj_struct); |
| dev_data->renderPassMap.erase(render_pass); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| RENDER_PASS_STATE *rp_state = nullptr; |
| VK_OBJECT obj_struct; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateDestroyRenderPass(dev_data, renderPass, &rp_state, &obj_struct); |
| if (!skip) { |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator); |
| lock.lock(); |
| if (renderPass != VK_NULL_HANDLE) { |
| PostCallRecordDestroyRenderPass(dev_data, renderPass, rp_state, obj_struct); |
| } |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateCreateBuffer(dev_data, pCreateInfo); |
| lock.unlock(); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| VkResult result = dev_data->dispatch_table.CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); |
| |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| PostCallRecordCreateBuffer(dev_data, pCreateInfo, pBuffer); |
| lock.unlock(); |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateCreateBufferView(dev_data, pCreateInfo); |
| lock.unlock(); |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| VkResult result = dev_data->dispatch_table.CreateBufferView(device, pCreateInfo, pAllocator, pView); |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| PostCallRecordCreateBufferView(dev_data, pCreateInfo, pView); |
| lock.unlock(); |
| } |
| return result; |
| } |
| |
| // Access helper functions for external modules |
| VkFormatProperties GetFormatProperties(core_validation::layer_data *device_data, VkFormat format) { |
| VkFormatProperties format_properties; |
| instance_layer_data *instance_data = |
| GetLayerDataPtr(get_dispatch_key(device_data->instance_data->instance), instance_layer_data_map); |
| instance_data->dispatch_table.GetPhysicalDeviceFormatProperties(device_data->physical_device, format, &format_properties); |
| return format_properties; |
| } |
| |
| VkResult GetImageFormatProperties(core_validation::layer_data *device_data, const VkImageCreateInfo *image_ci, |
| VkImageFormatProperties *pImageFormatProperties) { |
| instance_layer_data *instance_data = |
| GetLayerDataPtr(get_dispatch_key(device_data->instance_data->instance), instance_layer_data_map); |
| return instance_data->dispatch_table.GetPhysicalDeviceImageFormatProperties( |
| device_data->physical_device, image_ci->format, image_ci->imageType, image_ci->tiling, image_ci->usage, image_ci->flags, |
| pImageFormatProperties); |
| } |
| |
| const debug_report_data *GetReportData(const core_validation::layer_data *device_data) { return device_data->report_data; } |
| |
| const VkPhysicalDeviceProperties *GetPhysicalDeviceProperties(core_validation::layer_data *device_data) { |
| return &device_data->phys_dev_props; |
| } |
| |
| const CHECK_DISABLED *GetDisables(core_validation::layer_data *device_data) { return &device_data->instance_data->disabled; } |
| |
| std::unordered_map<VkImage, std::unique_ptr<IMAGE_STATE>> *GetImageMap(core_validation::layer_data *device_data) { |
| return &device_data->imageMap; |
| } |
| |
| std::unordered_map<VkImage, std::vector<ImageSubresourcePair>> *GetImageSubresourceMap(core_validation::layer_data *device_data) { |
| return &device_data->imageSubresourceMap; |
| } |
| |
| std::unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> *GetImageLayoutMap(layer_data *device_data) { |
| return &device_data->imageLayoutMap; |
| } |
| |
| std::unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> const *GetImageLayoutMap(layer_data const *device_data) { |
| return &device_data->imageLayoutMap; |
| } |
| |
| std::unordered_map<VkBuffer, std::unique_ptr<BUFFER_STATE>> *GetBufferMap(layer_data *device_data) { |
| return &device_data->bufferMap; |
| } |
| |
| std::unordered_map<VkBufferView, std::unique_ptr<BUFFER_VIEW_STATE>> *GetBufferViewMap(layer_data *device_data) { |
| return &device_data->bufferViewMap; |
| } |
| |
| std::unordered_map<VkImageView, std::unique_ptr<IMAGE_VIEW_STATE>> *GetImageViewMap(layer_data *device_data) { |
| return &device_data->imageViewMap; |
| } |
| |
| const PHYS_DEV_PROPERTIES_NODE *GetPhysDevProperties(const layer_data *device_data) { return &device_data->phys_dev_properties; } |
| |
| const VkPhysicalDeviceFeatures *GetEnabledFeatures(const layer_data *device_data) { return &device_data->enabled_features; } |
| |
| const DeviceExtensions *GetDeviceExtensions(const layer_data *device_data) { return &device_data->extensions; } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkImage *pImage) { |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool skip = PreCallValidateCreateImage(dev_data, pCreateInfo, pAllocator, pImage); |
| if (!skip) { |
| result = dev_data->dispatch_table.CreateImage(device, pCreateInfo, pAllocator, pImage); |
| } |
| if (VK_SUCCESS == result) { |
| lock_guard_t lock(global_lock); |
| PostCallRecordCreateImage(dev_data, pCreateInfo, pImage); |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkImageView *pView) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateCreateImageView(dev_data, pCreateInfo); |
| lock.unlock(); |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| VkResult result = dev_data->dispatch_table.CreateImageView(device, pCreateInfo, pAllocator, pView); |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| PostCallRecordCreateImageView(dev_data, pCreateInfo, *pView); |
| lock.unlock(); |
| } |
| |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkFence *pFence) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.CreateFence(device, pCreateInfo, pAllocator, pFence); |
| if (VK_SUCCESS == result) { |
| lock_guard_t lock(global_lock); |
| auto &fence_node = dev_data->fenceMap[*pFence]; |
| fence_node.fence = *pFence; |
| fence_node.createInfo = *pCreateInfo; |
| fence_node.state = (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) ? FENCE_RETIRED : FENCE_UNSIGNALED; |
| } |
| return result; |
| } |
| |
| // TODO handle pipeline caches |
| VKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); |
| return result; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, |
| const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| dev_data->dispatch_table.DestroyPipelineCache(device, pipelineCache, pAllocator); |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, |
| void *pData) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.GetPipelineCacheData(device, pipelineCache, pDataSize, pData); |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL MergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, |
| const VkPipelineCache *pSrcCaches) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); |
| return result; |
| } |
| |
| // Validation cache: |
| // CV is the bottommost implementor of this extension. Don't pass calls down. |
| VKAPI_ATTR VkResult VKAPI_CALL CreateValidationCacheEXT(VkDevice device, const VkValidationCacheCreateInfoEXT *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, |
| VkValidationCacheEXT *pValidationCache) { |
| *pValidationCache = ValidationCache::Create(pCreateInfo); |
| return *pValidationCache ? VK_SUCCESS : VK_ERROR_INITIALIZATION_FAILED; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyValidationCacheEXT(VkDevice device, VkValidationCacheEXT validationCache, |
| const VkAllocationCallbacks *pAllocator) { |
| delete (ValidationCache *)validationCache; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetValidationCacheDataEXT(VkDevice device, VkValidationCacheEXT validationCache, size_t *pDataSize, |
| void *pData) { |
| size_t inSize = *pDataSize; |
| ((ValidationCache *)validationCache)->Write(pDataSize, pData); |
| return (pData && *pDataSize != inSize) ? VK_INCOMPLETE : VK_SUCCESS; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL MergeValidationCachesEXT(VkDevice device, VkValidationCacheEXT dstCache, uint32_t srcCacheCount, |
| const VkValidationCacheEXT *pSrcCaches) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool skip = false; |
| auto dst = (ValidationCache *)dstCache; |
| auto src = (ValidationCache const *const *)pSrcCaches; |
| VkResult result = VK_SUCCESS; |
| for (uint32_t i = 0; i < srcCacheCount; i++) { |
| if (src[i] == dst) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_VALIDATION_CACHE_EXT, |
| 0, __LINE__, VALIDATION_ERROR_3e600c00, "DS", |
| "vkMergeValidationCachesEXT: dstCache (0x%" PRIx64 ") must not appear in pSrcCaches array. %s", |
| HandleToUint64(dstCache), validation_error_map[VALIDATION_ERROR_3e600c00]); |
| result = VK_ERROR_VALIDATION_FAILED_EXT; |
| } |
| if (!skip) { |
| dst->Merge(src[i]); |
| } |
| } |
| |
| return result; |
| } |
| |
| // utility function to set collective state for pipeline |
| void set_pipeline_state(PIPELINE_STATE *pPipe) { |
| // If any attachment used by this pipeline has blendEnable, set top-level blendEnable |
| if (pPipe->graphicsPipelineCI.pColorBlendState) { |
| for (size_t i = 0; i < pPipe->attachments.size(); ++i) { |
| if (VK_TRUE == pPipe->attachments[i].blendEnable) { |
| if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && |
| (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || |
| ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && |
| (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || |
| ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && |
| (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || |
| ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && |
| (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { |
| pPipe->blendConstantsEnabled = true; |
| } |
| } |
| } |
| } |
| } |
| |
| bool validate_dual_src_blend_feature(layer_data *device_data, PIPELINE_STATE *pipe_state) { |
| bool skip = false; |
| if (pipe_state->graphicsPipelineCI.pColorBlendState) { |
| for (size_t i = 0; i < pipe_state->attachments.size(); ++i) { |
| if (!device_data->enabled_features.dualSrcBlend) { |
| if ((pipe_state->attachments[i].dstAlphaBlendFactor == VK_BLEND_FACTOR_SRC1_COLOR) || |
| (pipe_state->attachments[i].dstAlphaBlendFactor == VK_BLEND_FACTOR_ONE_MINUS_SRC1_COLOR) || |
| (pipe_state->attachments[i].dstAlphaBlendFactor == VK_BLEND_FACTOR_SRC1_ALPHA) || |
| (pipe_state->attachments[i].dstAlphaBlendFactor == VK_BLEND_FACTOR_ONE_MINUS_SRC1_ALPHA) || |
| (pipe_state->attachments[i].srcAlphaBlendFactor == VK_BLEND_FACTOR_SRC1_COLOR) || |
| (pipe_state->attachments[i].srcAlphaBlendFactor == VK_BLEND_FACTOR_ONE_MINUS_SRC1_COLOR) || |
| (pipe_state->attachments[i].srcAlphaBlendFactor == VK_BLEND_FACTOR_SRC1_ALPHA) || |
| (pipe_state->attachments[i].srcAlphaBlendFactor == VK_BLEND_FACTOR_ONE_MINUS_SRC1_ALPHA)) { |
| skip |= |
| log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| HandleToUint64(pipe_state->pipeline), __LINE__, DRAWSTATE_INVALID_FEATURE, "DS", |
| "CmdBindPipeline: vkPipeline (0x%" PRIx64 ") attachment[" PRINTF_SIZE_T_SPECIFIER |
| "] has a dual-source blend factor but this device feature is not enabled.", |
| HandleToUint64(pipe_state->pipeline), i); |
| } |
| } |
| } |
| } |
| return skip; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, |
| const VkGraphicsPipelineCreateInfo *pCreateInfos, |
| const VkAllocationCallbacks *pAllocator, VkPipeline *pPipelines) { |
| // The order of operations here is a little convoluted but gets the job done |
| // 1. Pipeline create state is first shadowed into PIPELINE_STATE struct |
| // 2. Create state is then validated (which uses flags setup during shadowing) |
| // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap |
| bool skip = false; |
| vector<std::unique_ptr<PIPELINE_STATE>> pipe_state; |
| pipe_state.reserve(count); |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| |
| uint32_t i = 0; |
| unique_lock_t lock(global_lock); |
| |
| for (i = 0; i < count; i++) { |
| pipe_state.push_back(std::unique_ptr<PIPELINE_STATE>(new PIPELINE_STATE)); |
| pipe_state[i]->initGraphicsPipeline(&pCreateInfos[i], GetRenderPassStateSharedPtr(dev_data, pCreateInfos[i].renderPass)); |
| pipe_state[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); |
| } |
| |
| for (i = 0; i < count; i++) { |
| skip |= ValidatePipelineLocked(dev_data, pipe_state, i); |
| } |
| |
| lock.unlock(); |
| |
| for (i = 0; i < count; i++) { |
| skip |= ValidatePipelineUnlocked(dev_data, pipe_state, i); |
| } |
| |
| if (skip) { |
| for (i = 0; i < count; i++) { |
| pPipelines[i] = VK_NULL_HANDLE; |
| } |
| return VK_ERROR_VALIDATION_FAILED_EXT; |
| } |
| |
| auto result = |
| dev_data->dispatch_table.CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines); |
| lock.lock(); |
| for (i = 0; i < count; i++) { |
| if (pPipelines[i] != VK_NULL_HANDLE) { |
| pipe_state[i]->pipeline = pPipelines[i]; |
| dev_data->pipelineMap[pPipelines[i]] = std::move(pipe_state[i]); |
| } |
| } |
| |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, |
| const VkComputePipelineCreateInfo *pCreateInfos, |
| const VkAllocationCallbacks *pAllocator, VkPipeline *pPipelines) { |
| bool skip = false; |
| |
| vector<std::unique_ptr<PIPELINE_STATE>> pPipeState; |
| pPipeState.reserve(count); |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| |
| uint32_t i = 0; |
| unique_lock_t lock(global_lock); |
| for (i = 0; i < count; i++) { |
| // Create and initialize internal tracking data structure |
| pPipeState.push_back(unique_ptr<PIPELINE_STATE>(new PIPELINE_STATE)); |
| pPipeState[i]->initComputePipeline(&pCreateInfos[i]); |
| pPipeState[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); |
| |
| // TODO: Add Compute Pipeline Verification |
| skip |= validate_compute_pipeline(dev_data, pPipeState[i].get()); |
| } |
| |
| if (skip) { |
| for (i = 0; i < count; i++) { |
| pPipelines[i] = VK_NULL_HANDLE; |
| } |
| return VK_ERROR_VALIDATION_FAILED_EXT; |
| } |
| |
| lock.unlock(); |
| auto result = |
| dev_data->dispatch_table.CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines); |
| lock.lock(); |
| for (i = 0; i < count; i++) { |
| if (pPipelines[i] != VK_NULL_HANDLE) { |
| pPipeState[i]->pipeline = pPipelines[i]; |
| dev_data->pipelineMap[pPipelines[i]] = std::move(pPipeState[i]); |
| } |
| } |
| |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.CreateSampler(device, pCreateInfo, pAllocator, pSampler); |
| if (VK_SUCCESS == result) { |
| lock_guard_t lock(global_lock); |
| dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_STATE>(new SAMPLER_STATE(pSampler, pCreateInfo)); |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateCreateDescriptorSetLayout(layer_data *dev_data, const VkDescriptorSetLayoutCreateInfo *create_info) { |
| if (dev_data->instance_data->disabled.create_descriptor_set_layout) return false; |
| return cvdescriptorset::DescriptorSetLayout::ValidateCreateInfo(dev_data->report_data, create_info, |
| dev_data->extensions.vk_khr_push_descriptor, |
| dev_data->phys_dev_ext_props.max_push_descriptors); |
| } |
| |
| static void PostCallRecordCreateDescriptorSetLayout(layer_data *dev_data, const VkDescriptorSetLayoutCreateInfo *create_info, |
| VkDescriptorSetLayout set_layout) { |
| dev_data->descriptorSetLayoutMap[set_layout] = std::make_shared<cvdescriptorset::DescriptorSetLayout>(create_info, set_layout); |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, |
| VkDescriptorSetLayout *pSetLayout) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateCreateDescriptorSetLayout(dev_data, pCreateInfo); |
| if (!skip) { |
| lock.unlock(); |
| result = dev_data->dispatch_table.CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| PostCallRecordCreateDescriptorSetLayout(dev_data, pCreateInfo, *pSetLayout); |
| } |
| } |
| return result; |
| } |
| |
| // Used by CreatePipelineLayout and CmdPushConstants. |
| // Note that the index argument is optional and only used by CreatePipelineLayout. |
| static bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, |
| const char *caller_name, uint32_t index = 0) { |
| if (dev_data->instance_data->disabled.push_constant_range) return false; |
| uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; |
| bool skip = false; |
| // Check that offset + size don't exceed the max. |
| // Prevent arithetic overflow here by avoiding addition and testing in this order. |
| if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { |
| // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. |
| if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { |
| if (offset >= maxPushConstantsSize) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_11a0024c, "DS", |
| "%s call has push constants index %u with offset %u that exceeds this device's maxPushConstantSize of %u. %s", |
| caller_name, index, offset, maxPushConstantsSize, validation_error_map[VALIDATION_ERROR_11a0024c]); |
| } |
| if (size > maxPushConstantsSize - offset) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_11a00254, "DS", |
| "%s call has push constants index %u with offset %u and size %u that exceeds this device's " |
| "maxPushConstantSize of %u. %s", |
| caller_name, index, offset, size, maxPushConstantsSize, |
| validation_error_map[VALIDATION_ERROR_11a00254]); |
| } |
| } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { |
| if (offset >= maxPushConstantsSize) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_1bc002e4, "DS", |
| "%s call has push constants index %u with offset %u that exceeds this device's maxPushConstantSize of %u. %s", |
| caller_name, index, offset, maxPushConstantsSize, validation_error_map[VALIDATION_ERROR_1bc002e4]); |
| } |
| if (size > maxPushConstantsSize - offset) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_1bc002e6, "DS", |
| "%s call has push constants index %u with offset %u and size %u that exceeds this device's " |
| "maxPushConstantSize of %u. %s", |
| caller_name, index, offset, size, maxPushConstantsSize, |
| validation_error_map[VALIDATION_ERROR_1bc002e6]); |
| } |
| } else { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); |
| } |
| } |
| // size needs to be non-zero and a multiple of 4. |
| if ((size == 0) || ((size & 0x3) != 0)) { |
| if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { |
| if (size == 0) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_11a00250, "DS", |
| "%s call has push constants index %u with size %u. Size must be greater than zero. %s", caller_name, |
| index, size, validation_error_map[VALIDATION_ERROR_11a00250]); |
| } |
| if (size & 0x3) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_11a00252, "DS", |
| "%s call has push constants index %u with size %u. Size must be a multiple of 4. %s", caller_name, |
| index, size, validation_error_map[VALIDATION_ERROR_11a00252]); |
| } |
| } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { |
| if (size == 0) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_1bc2c21b, "DS", |
| "%s call has push constants index %u with size %u. Size must be greater than zero. %s", caller_name, |
| index, size, validation_error_map[VALIDATION_ERROR_1bc2c21b]); |
| } |
| if (size & 0x3) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_1bc002e2, "DS", |
| "%s call has push constants index %u with size %u. Size must be a multiple of 4. %s", caller_name, |
| index, size, validation_error_map[VALIDATION_ERROR_1bc002e2]); |
| } |
| } else { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); |
| } |
| } |
| // offset needs to be a multiple of 4. |
| if ((offset & 0x3) != 0) { |
| if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_11a0024e, "DS", |
| "%s call has push constants index %u with offset %u. Offset must be a multiple of 4. %s", caller_name, |
| index, offset, validation_error_map[VALIDATION_ERROR_11a0024e]); |
| } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_1bc002e0, "DS", |
| "%s call has push constants with offset %u. Offset must be a multiple of 4. %s", caller_name, offset, |
| validation_error_map[VALIDATION_ERROR_1bc002e0]); |
| } else { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); |
| } |
| } |
| return skip; |
| } |
| |
| enum DSL_DESCRIPTOR_GROUPS { |
| DSL_TYPE_SAMPLERS = 0, |
| DSL_TYPE_UNIFORM_BUFFERS, |
| DSL_TYPE_STORAGE_BUFFERS, |
| DSL_TYPE_SAMPLED_IMAGES, |
| DSL_TYPE_STORAGE_IMAGES, |
| DSL_TYPE_INPUT_ATTACHMENTS, |
| DSL_NUM_DESCRIPTOR_GROUPS |
| }; |
| |
| // Used by PreCallValiateCreatePipelineLayout. |
| // Returns an array of size DSL_NUM_DESCRIPTOR_GROUPS of the maximum number of descriptors used in any single pipeline stage |
| std::valarray<uint32_t> GetDescriptorCountMaxPerStage( |
| const layer_data *dev_data, const std::vector<std::shared_ptr<cvdescriptorset::DescriptorSetLayout const>> set_layouts) { |
| // Identify active pipeline stages |
| std::vector<VkShaderStageFlags> stage_flags = {VK_SHADER_STAGE_VERTEX_BIT, VK_SHADER_STAGE_FRAGMENT_BIT, |
| VK_SHADER_STAGE_COMPUTE_BIT}; |
| if (dev_data->enabled_features.geometryShader) { |
| stage_flags.push_back(VK_SHADER_STAGE_GEOMETRY_BIT); |
| } |
| if (dev_data->enabled_features.tessellationShader) { |
| stage_flags.push_back(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); |
| stage_flags.push_back(VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT); |
| } |
| |
| // Allow iteration over enum values |
| std::vector<DSL_DESCRIPTOR_GROUPS> dsl_groups = {DSL_TYPE_SAMPLERS, DSL_TYPE_UNIFORM_BUFFERS, DSL_TYPE_STORAGE_BUFFERS, |
| DSL_TYPE_SAMPLED_IMAGES, DSL_TYPE_STORAGE_IMAGES, DSL_TYPE_INPUT_ATTACHMENTS}; |
| |
| // Sum by layouts per stage, then pick max of stages per type |
| std::valarray<uint32_t> max_sum(0U, DSL_NUM_DESCRIPTOR_GROUPS); // max descriptor sum among all pipeline stages |
| for (auto stage : stage_flags) { |
| std::valarray<uint32_t> stage_sum(0U, DSL_NUM_DESCRIPTOR_GROUPS); // per-stage sums |
| for (auto dsl : set_layouts) { |
| for (uint32_t binding_idx = 0; binding_idx < dsl->GetBindingCount(); binding_idx++) { |
| const VkDescriptorSetLayoutBinding *binding = dsl->GetDescriptorSetLayoutBindingPtrFromIndex(binding_idx); |
| if (0 != (stage & binding->stageFlags)) { |
| switch (binding->descriptorType) { |
| case VK_DESCRIPTOR_TYPE_SAMPLER: |
| stage_sum[DSL_TYPE_SAMPLERS] += binding->descriptorCount; |
| break; |
| case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: |
| case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: |
| stage_sum[DSL_TYPE_UNIFORM_BUFFERS] += binding->descriptorCount; |
| break; |
| case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: |
| case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: |
| stage_sum[DSL_TYPE_STORAGE_BUFFERS] += binding->descriptorCount; |
| break; |
| case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: |
| case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: |
| stage_sum[DSL_TYPE_SAMPLED_IMAGES] += binding->descriptorCount; |
| break; |
| case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: |
| case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: |
| stage_sum[DSL_TYPE_STORAGE_IMAGES] += binding->descriptorCount; |
| break; |
| case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: |
| stage_sum[DSL_TYPE_SAMPLED_IMAGES] += binding->descriptorCount; |
| stage_sum[DSL_TYPE_SAMPLERS] += binding->descriptorCount; |
| break; |
| case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT: |
| stage_sum[DSL_TYPE_INPUT_ATTACHMENTS] += binding->descriptorCount; |
| break; |
| default: |
| break; |
| } |
| } |
| } |
| } |
| for (auto type : dsl_groups) { |
| max_sum[type] = std::max(stage_sum[type], max_sum[type]); |
| } |
| } |
| return max_sum; |
| } |
| |
| // Used by PreCallValidateCreatePipelineLayout. |
| // Returns an array of size VK_DESCRIPTOR_TYPE_RANGE_SIZE of the summed descriptors by type. |
| // Note: descriptors only count against the limit once even if used by multiple stages. |
| std::valarray<uint32_t> GetDescriptorSum( |
| const layer_data *dev_data, const std::vector<std::shared_ptr<cvdescriptorset::DescriptorSetLayout const>> &set_layouts) { |
| std::valarray<uint32_t> sum_by_type(0U, VK_DESCRIPTOR_TYPE_RANGE_SIZE); |
| for (auto dsl : set_layouts) { |
| for (uint32_t binding_idx = 0; binding_idx < dsl->GetBindingCount(); binding_idx++) { |
| const VkDescriptorSetLayoutBinding *binding = dsl->GetDescriptorSetLayoutBindingPtrFromIndex(binding_idx); |
| sum_by_type[binding->descriptorType] += binding->descriptorCount; |
| } |
| } |
| return sum_by_type; |
| } |
| |
| static bool PreCallValiateCreatePipelineLayout(const layer_data *dev_data, const VkPipelineLayoutCreateInfo *pCreateInfo) { |
| bool skip = false; |
| |
| // Validate layout count against device physical limit |
| if (pCreateInfo->setLayoutCount > dev_data->phys_dev_props.limits.maxBoundDescriptorSets) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe0023c, "DS", |
| "vkCreatePipelineLayout(): setLayoutCount (%d) exceeds physical device maxBoundDescriptorSets limit (%d). %s", |
| pCreateInfo->setLayoutCount, dev_data->phys_dev_props.limits.maxBoundDescriptorSets, |
| validation_error_map[VALIDATION_ERROR_0fe0023c]); |
| } |
| |
| // Validate Push Constant ranges |
| uint32_t i, j; |
| for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { |
| skip |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, |
| pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); |
| if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_11a2dc03, "DS", "vkCreatePipelineLayout() call has no stageFlags set. %s", |
| validation_error_map[VALIDATION_ERROR_11a2dc03]); |
| } |
| } |
| |
| // As of 1.0.28, there is a VU that states that a stage flag cannot appear more than once in the list of push constant ranges. |
| for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { |
| for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { |
| if (0 != (pCreateInfo->pPushConstantRanges[i].stageFlags & pCreateInfo->pPushConstantRanges[j].stageFlags)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_0fe00248, "DS", |
| "vkCreatePipelineLayout() Duplicate stage flags found in ranges %d and %d. %s", i, j, |
| validation_error_map[VALIDATION_ERROR_0fe00248]); |
| } |
| } |
| } |
| |
| // Early-out |
| if (skip) return skip; |
| |
| std::vector<std::shared_ptr<cvdescriptorset::DescriptorSetLayout const>> set_layouts(pCreateInfo->setLayoutCount, nullptr); |
| unsigned int push_descriptor_set_count = 0; |
| { |
| unique_lock_t lock(global_lock); // Lock while accessing global state |
| for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { |
| set_layouts[i] = GetDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); |
| if (set_layouts[i]->IsPushDescriptor()) ++push_descriptor_set_count; |
| } |
| } // Unlock |
| |
| if (push_descriptor_set_count > 1) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe0024a, "DS", "vkCreatePipelineLayout() Multiple push descriptor sets found. %s", |
| validation_error_map[VALIDATION_ERROR_0fe0024a]); |
| } |
| |
| // Max descriptors by type, within a single pipeline stage |
| std::valarray<uint32_t> max_descriptors_per_stage = GetDescriptorCountMaxPerStage(dev_data, set_layouts); |
| // Samplers |
| if (max_descriptors_per_stage[DSL_TYPE_SAMPLERS] > dev_data->phys_dev_props.limits.maxPerStageDescriptorSamplers) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe0023e, "DS", |
| "vkCreatePipelineLayout(): max per-stage sampler bindings count (%d) exceeds device " |
| "maxPerStageDescriptorSamplers limit (%d). %s", |
| max_descriptors_per_stage[DSL_TYPE_SAMPLERS], dev_data->phys_dev_props.limits.maxPerStageDescriptorSamplers, |
| validation_error_map[VALIDATION_ERROR_0fe0023e]); |
| } |
| |
| // Uniform buffers |
| if (max_descriptors_per_stage[DSL_TYPE_UNIFORM_BUFFERS] > dev_data->phys_dev_props.limits.maxPerStageDescriptorUniformBuffers) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00240, "DS", |
| "vkCreatePipelineLayout(): max per-stage uniform buffer bindings count (%d) exceeds device " |
| "maxPerStageDescriptorUniformBuffers limit (%d). %s", |
| max_descriptors_per_stage[DSL_TYPE_UNIFORM_BUFFERS], |
| dev_data->phys_dev_props.limits.maxPerStageDescriptorUniformBuffers, |
| validation_error_map[VALIDATION_ERROR_0fe00240]); |
| } |
| |
| // Storage buffers |
| if (max_descriptors_per_stage[DSL_TYPE_STORAGE_BUFFERS] > dev_data->phys_dev_props.limits.maxPerStageDescriptorStorageBuffers) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00242, "DS", |
| "vkCreatePipelineLayout(): max per-stage storage buffer bindings count (%d) exceeds device " |
| "maxPerStageDescriptorStorageBuffers limit (%d). %s", |
| max_descriptors_per_stage[DSL_TYPE_STORAGE_BUFFERS], |
| dev_data->phys_dev_props.limits.maxPerStageDescriptorStorageBuffers, |
| validation_error_map[VALIDATION_ERROR_0fe00242]); |
| } |
| |
| // Sampled images |
| if (max_descriptors_per_stage[DSL_TYPE_SAMPLED_IMAGES] > dev_data->phys_dev_props.limits.maxPerStageDescriptorSampledImages) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00244, "DS", |
| "vkCreatePipelineLayout(): max per-stage sampled image bindings count (%d) exceeds device " |
| "maxPerStageDescriptorSampledImages limit (%d). %s", |
| max_descriptors_per_stage[DSL_TYPE_SAMPLED_IMAGES], |
| dev_data->phys_dev_props.limits.maxPerStageDescriptorSampledImages, |
| validation_error_map[VALIDATION_ERROR_0fe00244]); |
| } |
| |
| // Storage images |
| if (max_descriptors_per_stage[DSL_TYPE_STORAGE_IMAGES] > dev_data->phys_dev_props.limits.maxPerStageDescriptorStorageImages) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00246, "DS", |
| "vkCreatePipelineLayout(): max per-stage storage image bindings count (%d) exceeds device " |
| "maxPerStageDescriptorStorageImages limit (%d). %s", |
| max_descriptors_per_stage[DSL_TYPE_STORAGE_IMAGES], |
| dev_data->phys_dev_props.limits.maxPerStageDescriptorStorageImages, |
| validation_error_map[VALIDATION_ERROR_0fe00246]); |
| } |
| |
| // Input attachments |
| if (max_descriptors_per_stage[DSL_TYPE_INPUT_ATTACHMENTS] > |
| dev_data->phys_dev_props.limits.maxPerStageDescriptorInputAttachments) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00d18, "DS", |
| "vkCreatePipelineLayout(): max per-stage input attachment bindings count (%d) exceeds device " |
| "maxPerStageDescriptorInputAttachments limit (%d). %s", |
| max_descriptors_per_stage[DSL_TYPE_INPUT_ATTACHMENTS], |
| dev_data->phys_dev_props.limits.maxPerStageDescriptorInputAttachments, |
| validation_error_map[VALIDATION_ERROR_0fe00d18]); |
| } |
| |
| // Total descriptors by type |
| // |
| std::valarray<uint32_t> sum_all_stages = GetDescriptorSum(dev_data, set_layouts); |
| // Samplers |
| if ((sum_all_stages[VK_DESCRIPTOR_TYPE_SAMPLER] + sum_all_stages[VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER]) > |
| dev_data->phys_dev_props.limits.maxDescriptorSetSamplers) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00d1a, "DS", |
| "vkCreatePipelineLayout(): sum of sampler bindings among all stages (%d) exceeds device " |
| "maxDescriptorSetSamplers limit (%d). %s", |
| sum_all_stages[VK_DESCRIPTOR_TYPE_SAMPLER] + sum_all_stages[VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER], |
| dev_data->phys_dev_props.limits.maxDescriptorSetSamplers, validation_error_map[VALIDATION_ERROR_0fe00d1a]); |
| } |
| |
| // Uniform buffers |
| if (sum_all_stages[VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER] > dev_data->phys_dev_props.limits.maxDescriptorSetUniformBuffers) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00d1c, "DS", |
| "vkCreatePipelineLayout(): sum of uniform buffer bindings among all stages (%d) exceeds device " |
| "maxDescriptorSetUniformBuffers limit (%d). %s", |
| sum_all_stages[VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER], |
| dev_data->phys_dev_props.limits.maxDescriptorSetUniformBuffers, |
| validation_error_map[VALIDATION_ERROR_0fe00d1c]); |
| } |
| |
| // Dynamic uniform buffers |
| if (sum_all_stages[VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC] > |
| dev_data->phys_dev_props.limits.maxDescriptorSetUniformBuffersDynamic) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00d1e, "DS", |
| "vkCreatePipelineLayout(): sum of dynamic uniform buffer bindings among all stages (%d) exceeds device " |
| "maxDescriptorSetUniformBuffersDynamic limit (%d). %s", |
| sum_all_stages[VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC], |
| dev_data->phys_dev_props.limits.maxDescriptorSetUniformBuffersDynamic, |
| validation_error_map[VALIDATION_ERROR_0fe00d1e]); |
| } |
| |
| // Storage buffers |
| if (sum_all_stages[VK_DESCRIPTOR_TYPE_STORAGE_BUFFER] > dev_data->phys_dev_props.limits.maxDescriptorSetStorageBuffers) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00d20, "DS", |
| "vkCreatePipelineLayout(): sum of storage buffer bindings among all stages (%d) exceeds device " |
| "maxDescriptorSetStorageBuffers limit (%d). %s", |
| sum_all_stages[VK_DESCRIPTOR_TYPE_STORAGE_BUFFER], |
| dev_data->phys_dev_props.limits.maxDescriptorSetStorageBuffers, |
| validation_error_map[VALIDATION_ERROR_0fe00d20]); |
| } |
| |
| // Dynamic storage buffers |
| if (sum_all_stages[VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC] > |
| dev_data->phys_dev_props.limits.maxDescriptorSetStorageBuffersDynamic) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00d22, "DS", |
| "vkCreatePipelineLayout(): sum of dynamic storage buffer bindings among all stages (%d) exceeds device " |
| "maxDescriptorSetStorageBuffersDynamic limit (%d). %s", |
| sum_all_stages[VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC], |
| dev_data->phys_dev_props.limits.maxDescriptorSetStorageBuffersDynamic, |
| validation_error_map[VALIDATION_ERROR_0fe00d22]); |
| } |
| |
| // Sampled images |
| if ((sum_all_stages[VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE] + sum_all_stages[VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER] + |
| sum_all_stages[VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER]) > dev_data->phys_dev_props.limits.maxDescriptorSetSampledImages) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00d24, "DS", |
| "vkCreatePipelineLayout(): sum of sampled image bindings among all stages (%d) exceeds device " |
| "maxDescriptorSetSampledImages limit (%d). %s", |
| sum_all_stages[VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE] + sum_all_stages[VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER] + |
| sum_all_stages[VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER], |
| dev_data->phys_dev_props.limits.maxDescriptorSetSampledImages, validation_error_map[VALIDATION_ERROR_0fe00d24]); |
| } |
| |
| // Storage images |
| if ((sum_all_stages[VK_DESCRIPTOR_TYPE_STORAGE_IMAGE] + sum_all_stages[VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER]) > |
| dev_data->phys_dev_props.limits.maxDescriptorSetStorageImages) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00d26, "DS", |
| "vkCreatePipelineLayout(): sum of storage image bindings among all stages (%d) exceeds device " |
| "maxDescriptorSetStorageImages limit (%d). %s", |
| sum_all_stages[VK_DESCRIPTOR_TYPE_STORAGE_IMAGE] + sum_all_stages[VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER], |
| dev_data->phys_dev_props.limits.maxDescriptorSetStorageImages, validation_error_map[VALIDATION_ERROR_0fe00d26]); |
| } |
| |
| // Input attachments |
| if (sum_all_stages[VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT] > dev_data->phys_dev_props.limits.maxDescriptorSetInputAttachments) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_0fe00d28, "DS", |
| "vkCreatePipelineLayout(): sum of input attachment bindings among all stages (%d) exceeds device " |
| "maxDescriptorSetInputAttachments limit (%d). %s", |
| sum_all_stages[VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT], |
| dev_data->phys_dev_props.limits.maxDescriptorSetInputAttachments, |
| validation_error_map[VALIDATION_ERROR_0fe00d28]); |
| } |
| |
| return skip; |
| } |
| |
| static void PostCallRecordCreatePipelineLayout(layer_data *dev_data, const VkPipelineLayoutCreateInfo *pCreateInfo, |
| const VkPipelineLayout *pPipelineLayout) { |
| unique_lock_t lock(global_lock); // Lock while accessing state |
| |
| PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; |
| plNode.layout = *pPipelineLayout; |
| plNode.set_layouts.resize(pCreateInfo->setLayoutCount); |
| for (uint32_t i = 0; i < pCreateInfo->setLayoutCount; ++i) { |
| plNode.set_layouts[i] = GetDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); |
| } |
| plNode.push_constant_ranges.resize(pCreateInfo->pushConstantRangeCount); |
| for (uint32_t i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { |
| plNode.push_constant_ranges[i] = pCreateInfo->pPushConstantRanges[i]; |
| } |
| // Implicit unlock |
| }; |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| |
| bool skip = PreCallValiateCreatePipelineLayout(dev_data, pCreateInfo); |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| VkResult result = dev_data->dispatch_table.CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); |
| |
| if (VK_SUCCESS == result) { |
| PostCallRecordCreatePipelineLayout(dev_data, pCreateInfo, pPipelineLayout); |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); |
| if (VK_SUCCESS == result) { |
| DESCRIPTOR_POOL_STATE *pNewNode = new DESCRIPTOR_POOL_STATE(*pDescriptorPool, pCreateInfo); |
| if (NULL == pNewNode) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, |
| HandleToUint64(*pDescriptorPool), __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", |
| "Out of memory while attempting to allocate DESCRIPTOR_POOL_STATE in vkCreateDescriptorPool()")) |
| return VK_ERROR_VALIDATION_FAILED_EXT; |
| } else { |
| lock_guard_t lock(global_lock); |
| dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; |
| } |
| } else { |
| // Need to do anything if pool create fails? |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL ResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, |
| VkDescriptorPoolResetFlags flags) { |
| // TODO : Add checks for VALIDATION_ERROR_32a00272 |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.ResetDescriptorPool(device, descriptorPool, flags); |
| if (VK_SUCCESS == result) { |
| lock_guard_t lock(global_lock); |
| clearDescriptorPool(dev_data, device, descriptorPool, flags); |
| } |
| return result; |
| } |
| // Ensure the pool contains enough descriptors and descriptor sets to satisfy |
| // an allocation request. Fills common_data with the total number of descriptors of each type required, |
| // as well as DescriptorSetLayout ptrs used for later update. |
| static bool PreCallValidateAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, |
| cvdescriptorset::AllocateDescriptorSetsData *common_data) { |
| // Always update common data |
| cvdescriptorset::UpdateAllocateDescriptorSetsData(dev_data, pAllocateInfo, common_data); |
| if (dev_data->instance_data->disabled.allocate_descriptor_sets) return false; |
| // All state checks for AllocateDescriptorSets is done in single function |
| return cvdescriptorset::ValidateAllocateDescriptorSets(dev_data, pAllocateInfo, common_data); |
| } |
| // Allocation state was good and call down chain was made so update state based on allocating descriptor sets |
| static void PostCallRecordAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, |
| VkDescriptorSet *pDescriptorSets, |
| const cvdescriptorset::AllocateDescriptorSetsData *common_data) { |
| // All the updates are contained in a single cvdescriptorset function |
| cvdescriptorset::PerformAllocateDescriptorSets(pAllocateInfo, pDescriptorSets, common_data, &dev_data->descriptorPoolMap, |
| &dev_data->setMap, dev_data); |
| } |
| |
| // TODO: PostCallRecord routine is dependent on data generated in PreCallValidate -- needs to be moved out |
| VKAPI_ATTR VkResult VKAPI_CALL AllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, |
| VkDescriptorSet *pDescriptorSets) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| cvdescriptorset::AllocateDescriptorSetsData common_data(pAllocateInfo->descriptorSetCount); |
| bool skip = PreCallValidateAllocateDescriptorSets(dev_data, pAllocateInfo, &common_data); |
| lock.unlock(); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| VkResult result = dev_data->dispatch_table.AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); |
| |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| PostCallRecordAllocateDescriptorSets(dev_data, pAllocateInfo, pDescriptorSets, &common_data); |
| lock.unlock(); |
| } |
| return result; |
| } |
| // Verify state before freeing DescriptorSets |
| static bool PreCallValidateFreeDescriptorSets(const layer_data *dev_data, VkDescriptorPool pool, uint32_t count, |
| const VkDescriptorSet *descriptor_sets) { |
| if (dev_data->instance_data->disabled.free_descriptor_sets) return false; |
| bool skip = false; |
| // First make sure sets being destroyed are not currently in-use |
| for (uint32_t i = 0; i < count; ++i) { |
| if (descriptor_sets[i] != VK_NULL_HANDLE) { |
| skip |= validateIdleDescriptorSet(dev_data, descriptor_sets[i], "vkFreeDescriptorSets"); |
| } |
| } |
| |
| DESCRIPTOR_POOL_STATE *pool_state = GetDescriptorPoolState(dev_data, pool); |
| if (pool_state && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pool_state->createInfo.flags)) { |
| // Can't Free from a NON_FREE pool |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, |
| HandleToUint64(pool), __LINE__, VALIDATION_ERROR_28600270, "DS", |
| "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " |
| "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT. %s", |
| validation_error_map[VALIDATION_ERROR_28600270]); |
| } |
| return skip; |
| } |
| // Sets have been removed from the pool so update underlying state |
| static void PostCallRecordFreeDescriptorSets(layer_data *dev_data, VkDescriptorPool pool, uint32_t count, |
| const VkDescriptorSet *descriptor_sets) { |
| DESCRIPTOR_POOL_STATE *pool_state = GetDescriptorPoolState(dev_data, pool); |
| // Update available descriptor sets in pool |
| pool_state->availableSets += count; |
| |
| // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap |
| for (uint32_t i = 0; i < count; ++i) { |
| if (descriptor_sets[i] != VK_NULL_HANDLE) { |
| auto descriptor_set = dev_data->setMap[descriptor_sets[i]]; |
| uint32_t type_index = 0, descriptor_count = 0; |
| for (uint32_t j = 0; j < descriptor_set->GetBindingCount(); ++j) { |
| type_index = static_cast<uint32_t>(descriptor_set->GetTypeFromIndex(j)); |
| descriptor_count = descriptor_set->GetDescriptorCountFromIndex(j); |
| pool_state->availableDescriptorTypeCount[type_index] += descriptor_count; |
| } |
| freeDescriptorSet(dev_data, descriptor_set); |
| pool_state->sets.erase(descriptor_set); |
| } |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL FreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, |
| const VkDescriptorSet *pDescriptorSets) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| // Make sure that no sets being destroyed are in-flight |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); |
| lock.unlock(); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| VkResult result = dev_data->dispatch_table.FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| PostCallRecordFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); |
| lock.unlock(); |
| } |
| return result; |
| } |
| // TODO : This is a Proof-of-concept for core validation architecture |
| // Really we'll want to break out these functions to separate files but |
| // keeping it all together here to prove out design |
| // PreCallValidate* handles validating all of the state prior to calling down chain to UpdateDescriptorSets() |
| static bool PreCallValidateUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, |
| const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, |
| const VkCopyDescriptorSet *pDescriptorCopies) { |
| if (dev_data->instance_data->disabled.update_descriptor_sets) return false; |
| // First thing to do is perform map look-ups. |
| // NOTE : UpdateDescriptorSets is somewhat unique in that it's operating on a number of DescriptorSets |
| // so we can't just do a single map look-up up-front, but do them individually in functions below |
| |
| // Now make call(s) that validate state, but don't perform state updates in this function |
| // Note, here DescriptorSets is unique in that we don't yet have an instance. Using a helper function in the |
| // namespace which will parse params and make calls into specific class instances |
| return cvdescriptorset::ValidateUpdateDescriptorSets(dev_data->report_data, dev_data, descriptorWriteCount, pDescriptorWrites, |
| descriptorCopyCount, pDescriptorCopies); |
| } |
| // PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSets() |
| static void PreCallRecordUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, |
| const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, |
| const VkCopyDescriptorSet *pDescriptorCopies) { |
| cvdescriptorset::PerformUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, |
| pDescriptorCopies); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL UpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, |
| const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, |
| const VkCopyDescriptorSet *pDescriptorCopies) { |
| // Only map look-up at top level is for device-level layer_data |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, |
| pDescriptorCopies); |
| if (!skip) { |
| // Since UpdateDescriptorSets() is void, nothing to check prior to updating state & we can update before call down chain |
| PreCallRecordUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, |
| pDescriptorCopies); |
| lock.unlock(); |
| dev_data->dispatch_table.UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, |
| pDescriptorCopies); |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL AllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, |
| VkCommandBuffer *pCommandBuffer) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); |
| if (VK_SUCCESS == result) { |
| unique_lock_t lock(global_lock); |
| auto pPool = GetCommandPoolNode(dev_data, pCreateInfo->commandPool); |
| |
| if (pPool) { |
| for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { |
| // Add command buffer to its commandPool map |
| pPool->commandBuffers.insert(pCommandBuffer[i]); |
| GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; |
| // Add command buffer to map |
| dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; |
| ResetCommandBufferState(dev_data, pCommandBuffer[i]); |
| pCB->createInfo = *pCreateInfo; |
| pCB->device = device; |
| } |
| } |
| lock.unlock(); |
| } |
| return result; |
| } |
| |
| // Add bindings between the given cmd buffer & framebuffer and the framebuffer's children |
| static void AddFramebufferBinding(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, FRAMEBUFFER_STATE *fb_state) { |
| addCommandBufferBinding(&fb_state->cb_bindings, {HandleToUint64(fb_state->framebuffer), kVulkanObjectTypeFramebuffer}, |
| cb_state); |
| for (auto attachment : fb_state->attachments) { |
| auto view_state = attachment.view_state; |
| if (view_state) { |
| AddCommandBufferBindingImageView(dev_data, cb_state, view_state); |
| } |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL BeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| // Validate command buffer level |
| GLOBAL_CB_NODE *cb_node = GetCBNode(dev_data, commandBuffer); |
| if (cb_node) { |
| // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references |
| if (cb_node->in_use.load()) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_16e00062, "MEM", |
| "Calling vkBeginCommandBuffer() on active command buffer %" PRIx64 |
| " before it has completed. You must check command buffer fence before this call. %s", |
| HandleToUint64(commandBuffer), validation_error_map[VALIDATION_ERROR_16e00062]); |
| } |
| clear_cmd_buf_and_mem_references(dev_data, cb_node); |
| if (cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { |
| // Secondary Command Buffer |
| const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; |
| if (!pInfo) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_16e00066, "DS", |
| "vkBeginCommandBuffer(): Secondary Command Buffer (0x%" PRIx64 ") must have inheritance info. %s", |
| HandleToUint64(commandBuffer), validation_error_map[VALIDATION_ERROR_16e00066]); |
| } else { |
| if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { |
| assert(pInfo->renderPass); |
| string errorString = ""; |
| auto framebuffer = GetFramebufferState(dev_data, pInfo->framebuffer); |
| if (framebuffer) { |
| if (framebuffer->createInfo.renderPass != pInfo->renderPass) { |
| // renderPass that framebuffer was created with must be compatible with local renderPass |
| skip |= |
| validateRenderPassCompatibility(dev_data, "framebuffer", framebuffer->rp_state.get(), |
| "command buffer", GetRenderPassState(dev_data, pInfo->renderPass), |
| "vkBeginCommandBuffer()", VALIDATION_ERROR_0280006e); |
| } |
| // Connect this framebuffer and its children to this cmdBuffer |
| AddFramebufferBinding(dev_data, cb_node, framebuffer); |
| } |
| } |
| if ((pInfo->occlusionQueryEnable == VK_FALSE || dev_data->enabled_features.occlusionQueryPrecise == VK_FALSE) && |
| (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer), __LINE__, |
| VALIDATION_ERROR_16e00068, "DS", |
| "vkBeginCommandBuffer(): Secondary Command Buffer (0x%" PRIx64 |
| ") must not have VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device " |
| "does not support precise occlusion queries. %s", |
| HandleToUint64(commandBuffer), validation_error_map[VALIDATION_ERROR_16e00068]); |
| } |
| } |
| if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { |
| auto renderPass = GetRenderPassState(dev_data, pInfo->renderPass); |
| if (renderPass) { |
| if (pInfo->subpass >= renderPass->createInfo.subpassCount) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer), __LINE__, |
| VALIDATION_ERROR_0280006c, "DS", |
| "vkBeginCommandBuffer(): Secondary Command Buffers (0x%" PRIx64 |
| ") must have a subpass index (%d) that is less than the number of subpasses (%d). %s", |
| HandleToUint64(commandBuffer), pInfo->subpass, renderPass->createInfo.subpassCount, |
| validation_error_map[VALIDATION_ERROR_0280006c]); |
| } |
| } |
| } |
| } |
| if (CB_RECORDING == cb_node->state) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_16e00062, "DS", |
| "vkBeginCommandBuffer(): Cannot call Begin on command buffer (0x%" PRIx64 |
| ") in the RECORDING state. Must first call vkEndCommandBuffer(). %s", |
| HandleToUint64(commandBuffer), validation_error_map[VALIDATION_ERROR_16e00062]); |
| } else if (CB_RECORDED == cb_node->state || CB_INVALID_COMPLETE == cb_node->state) { |
| VkCommandPool cmdPool = cb_node->createInfo.commandPool; |
| auto pPool = GetCommandPoolNode(dev_data, cmdPool); |
| if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_16e00064, "DS", |
| "Call to vkBeginCommandBuffer() on command buffer (0x%" PRIx64 |
| ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIx64 |
| ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set. %s", |
| HandleToUint64(commandBuffer), HandleToUint64(cmdPool), validation_error_map[VALIDATION_ERROR_16e00064]); |
| } |
| ResetCommandBufferState(dev_data, commandBuffer); |
| } |
| // Set updated state here in case implicit reset occurs above |
| cb_node->state = CB_RECORDING; |
| cb_node->beginInfo = *pBeginInfo; |
| if (cb_node->beginInfo.pInheritanceInfo) { |
| cb_node->inheritanceInfo = *(cb_node->beginInfo.pInheritanceInfo); |
| cb_node->beginInfo.pInheritanceInfo = &cb_node->inheritanceInfo; |
| // If we are a secondary command-buffer and inheriting. Update the items we should inherit. |
| if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && |
| (cb_node->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { |
| cb_node->activeRenderPass = GetRenderPassState(dev_data, cb_node->beginInfo.pInheritanceInfo->renderPass); |
| cb_node->activeSubpass = cb_node->beginInfo.pInheritanceInfo->subpass; |
| cb_node->activeFramebuffer = cb_node->beginInfo.pInheritanceInfo->framebuffer; |
| cb_node->framebuffers.insert(cb_node->beginInfo.pInheritanceInfo->framebuffer); |
| } |
| } |
| } |
| lock.unlock(); |
| if (skip) { |
| return VK_ERROR_VALIDATION_FAILED_EXT; |
| } |
| VkResult result = dev_data->dispatch_table.BeginCommandBuffer(commandBuffer, pBeginInfo); |
| |
| return result; |
| } |
| static void PostCallRecordEndCommandBuffer(layer_data *dev_data, GLOBAL_CB_NODE *cb_state) { |
| // Cached validation is specific to a specific recording of a specific command buffer. |
| for (auto descriptor_set : cb_state->validated_descriptor_sets) { |
| descriptor_set->ClearCachedValidation(cb_state); |
| } |
| cb_state->validated_descriptor_sets.clear(); |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || |
| !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { |
| // This needs spec clarification to update valid usage, see comments in PR: |
| // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 |
| skip |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer()", VALIDATION_ERROR_27400078); |
| } |
| skip |= ValidateCmd(dev_data, pCB, CMD_ENDCOMMANDBUFFER, "vkEndCommandBuffer()"); |
| for (auto query : pCB->activeQueries) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_2740007a, "DS", |
| "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d. %s", |
| HandleToUint64(query.pool), query.index, validation_error_map[VALIDATION_ERROR_2740007a]); |
| } |
| } |
| if (!skip) { |
| lock.unlock(); |
| auto result = dev_data->dispatch_table.EndCommandBuffer(commandBuffer); |
| lock.lock(); |
| PostCallRecordEndCommandBuffer(dev_data, pCB); |
| if (VK_SUCCESS == result) { |
| pCB->state = CB_RECORDED; |
| } |
| return result; |
| } else { |
| return VK_ERROR_VALIDATION_FAILED_EXT; |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL ResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| VkCommandPool cmdPool = pCB->createInfo.commandPool; |
| auto pPool = GetCommandPoolNode(dev_data, cmdPool); |
| if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_3260005c, "DS", |
| "Attempt to reset command buffer (0x%" PRIx64 ") created from command pool (0x%" PRIx64 |
| ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set. %s", |
| HandleToUint64(commandBuffer), HandleToUint64(cmdPool), validation_error_map[VALIDATION_ERROR_3260005c]); |
| } |
| skip |= checkCommandBufferInFlight(dev_data, pCB, "reset", VALIDATION_ERROR_3260005a); |
| lock.unlock(); |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| VkResult result = dev_data->dispatch_table.ResetCommandBuffer(commandBuffer, flags); |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| ResetCommandBufferState(dev_data, commandBuffer); |
| lock.unlock(); |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, |
| VkPipeline pipeline) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *cb_state = GetCBNode(dev_data, commandBuffer); |
| if (cb_state) { |
| skip |= ValidateCmdQueueFlags(dev_data, cb_state, "vkCmdBindPipeline()", VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| VALIDATION_ERROR_18002415); |
| skip |= ValidateCmd(dev_data, cb_state, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); |
| // TODO: VALIDATION_ERROR_18000612 VALIDATION_ERROR_18000616 -- using ValidatePipelineBindPoint |
| |
| auto pipe_state = getPipelineState(dev_data, pipeline); |
| if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) { |
| cb_state->status &= ~cb_state->static_status; |
| cb_state->static_status = MakeStaticStateMask(pipe_state->graphicsPipelineCI.ptr()->pDynamicState); |
| cb_state->status |= cb_state->static_status; |
| } |
| cb_state->lastBound[pipelineBindPoint].pipeline_state = pipe_state; |
| set_pipeline_state(pipe_state); |
| skip |= validate_dual_src_blend_feature(dev_data, pipe_state); |
| addCommandBufferBinding(&pipe_state->cb_bindings, {HandleToUint64(pipeline), kVulkanObjectTypePipeline}, cb_state); |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, |
| const VkViewport *pViewports) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= ValidateCmdQueueFlags(dev_data, pCB, "vkCmdSetViewport()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_1e002415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_SETVIEWPORT, "vkCmdSetViewport()"); |
| if (pCB->static_status & CBSTATUS_VIEWPORT_SET) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1e00098a, "DS", |
| "vkCmdSetViewport(): pipeline was created without VK_DYNAMIC_STATE_VIEWPORT flag. %s.", |
| validation_error_map[VALIDATION_ERROR_1e00098a]); |
| } |
| if (!skip) { |
| pCB->viewportMask |= ((1u << viewportCount) - 1u) << firstViewport; |
| pCB->status |= CBSTATUS_VIEWPORT_SET; |
| } |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, |
| const VkRect2D *pScissors) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= ValidateCmdQueueFlags(dev_data, pCB, "vkCmdSetScissor()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_1d802415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_SETSCISSOR, "vkCmdSetScissor()"); |
| if (pCB->static_status & CBSTATUS_SCISSOR_SET) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1d80049c, "DS", |
| "vkCmdSetScissor(): pipeline was created without VK_DYNAMIC_STATE_SCISSOR flag. %s.", |
| validation_error_map[VALIDATION_ERROR_1d80049c]); |
| } |
| if (!skip) { |
| pCB->scissorMask |= ((1u << scissorCount) - 1u) << firstScissor; |
| pCB->status |= CBSTATUS_SCISSOR_SET; |
| } |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= ValidateCmdQueueFlags(dev_data, pCB, "vkCmdSetLineWidth()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_1d602415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_SETLINEWIDTH, "vkCmdSetLineWidth()"); |
| |
| if (pCB->static_status & CBSTATUS_LINE_WIDTH_SET) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1d600626, "DS", |
| "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH flag. %s", |
| validation_error_map[VALIDATION_ERROR_1d600626]); |
| } |
| if (!skip) { |
| pCB->status |= CBSTATUS_LINE_WIDTH_SET; |
| } |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdSetLineWidth(commandBuffer, lineWidth); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, |
| float depthBiasSlopeFactor) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= ValidateCmdQueueFlags(dev_data, pCB, "vkCmdSetDepthBias()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_1cc02415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_SETDEPTHBIAS, "vkCmdSetDepthBias()"); |
| if (pCB->static_status & CBSTATUS_DEPTH_BIAS_SET) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1cc0062a, "DS", |
| "vkCmdSetDepthBias(): pipeline was created without VK_DYNAMIC_STATE_DEPTH_BIAS flag. %s.", |
| validation_error_map[VALIDATION_ERROR_1cc0062a]); |
| } |
| if ((depthBiasClamp != 0.0) && (!dev_data->enabled_features.depthBiasClamp)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1cc0062c, "DS", |
| "vkCmdSetDepthBias(): the depthBiasClamp device feature is disabled: the depthBiasClamp parameter must " |
| "be set to 0.0. %s", |
| validation_error_map[VALIDATION_ERROR_1cc0062c]); |
| } |
| if (!skip) { |
| pCB->status |= CBSTATUS_DEPTH_BIAS_SET; |
| } |
| } |
| lock.unlock(); |
| if (!skip) |
| dev_data->dispatch_table.CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, depthBiasSlopeFactor); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= ValidateCmdQueueFlags(dev_data, pCB, "vkCmdSetBlendConstants()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_1ca02415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_SETBLENDCONSTANTS, "vkCmdSetBlendConstants()"); |
| if (pCB->static_status & CBSTATUS_BLEND_CONSTANTS_SET) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1ca004c8, "DS", |
| "vkCmdSetBlendConstants(): pipeline was created without VK_DYNAMIC_STATE_BLEND_CONSTANTS flag. %s.", |
| validation_error_map[VALIDATION_ERROR_1ca004c8]); |
| } |
| if (!skip) { |
| pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; |
| } |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdSetBlendConstants(commandBuffer, blendConstants); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= ValidateCmdQueueFlags(dev_data, pCB, "vkCmdSetDepthBounds()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_1ce02415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_SETDEPTHBOUNDS, "vkCmdSetDepthBounds()"); |
| if (pCB->static_status & CBSTATUS_DEPTH_BOUNDS_SET) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1ce004ae, "DS", |
| "vkCmdSetDepthBounds(): pipeline was created without VK_DYNAMIC_STATE_DEPTH_BOUNDS flag. %s.", |
| validation_error_map[VALIDATION_ERROR_1ce004ae]); |
| } |
| if (!skip) { |
| pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; |
| } |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, |
| uint32_t compareMask) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= |
| ValidateCmdQueueFlags(dev_data, pCB, "vkCmdSetStencilCompareMask()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_1da02415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_SETSTENCILCOMPAREMASK, "vkCmdSetStencilCompareMask()"); |
| if (pCB->static_status & CBSTATUS_STENCIL_READ_MASK_SET) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1da004b4, "DS", |
| "vkCmdSetStencilCompareMask(): pipeline was created without VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK flag. %s.", |
| validation_error_map[VALIDATION_ERROR_1da004b4]); |
| } |
| if (!skip) { |
| pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; |
| } |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= |
| ValidateCmdQueueFlags(dev_data, pCB, "vkCmdSetStencilWriteMask()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_1de02415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASK, "vkCmdSetStencilWriteMask()"); |
| if (pCB->static_status & CBSTATUS_STENCIL_WRITE_MASK_SET) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1de004b6, "DS", |
| "vkCmdSetStencilWriteMask(): pipeline was created without VK_DYNAMIC_STATE_STENCIL_WRITE_MASK flag. %s.", |
| validation_error_map[VALIDATION_ERROR_1de004b6]); |
| } |
| if (!skip) { |
| pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; |
| } |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= |
| ValidateCmdQueueFlags(dev_data, pCB, "vkCmdSetStencilReference()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_1dc02415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_SETSTENCILREFERENCE, "vkCmdSetStencilReference()"); |
| if (pCB->static_status & CBSTATUS_STENCIL_REFERENCE_SET) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1dc004b8, "DS", |
| "vkCmdSetStencilReference(): pipeline was created without VK_DYNAMIC_STATE_STENCIL_REFERENCE flag. %s.", |
| validation_error_map[VALIDATION_ERROR_1dc004b8]); |
| } |
| if (!skip) { |
| pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; |
| } |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdSetStencilReference(commandBuffer, faceMask, reference); |
| } |
| |
| static void PreCallRecordCmdBindDescriptorSets(layer_data *device_data, GLOBAL_CB_NODE *cb_state, |
| VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, uint32_t firstSet, |
| uint32_t setCount, const VkDescriptorSet *pDescriptorSets, |
| uint32_t dynamicOffsetCount, const uint32_t *pDynamicOffsets) { |
| uint32_t total_dynamic_descriptors = 0; |
| string error_string = ""; |
| uint32_t last_set_index = firstSet + setCount - 1; |
| auto last_bound = &cb_state->lastBound[pipelineBindPoint]; |
| |
| if (last_set_index >= last_bound->boundDescriptorSets.size()) { |
| last_bound->boundDescriptorSets.resize(last_set_index + 1); |
| last_bound->dynamicOffsets.resize(last_set_index + 1); |
| } |
| auto old_final_bound_set = last_bound->boundDescriptorSets[last_set_index]; |
| auto pipeline_layout = getPipelineLayout(device_data, layout); |
| for (uint32_t set_idx = 0; set_idx < setCount; set_idx++) { |
| cvdescriptorset::DescriptorSet *descriptor_set = GetSetNode(device_data, pDescriptorSets[set_idx]); |
| if (descriptor_set) { |
| last_bound->pipeline_layout = *pipeline_layout; |
| |
| if ((last_bound->boundDescriptorSets[set_idx + firstSet] != nullptr) && |
| last_bound->boundDescriptorSets[set_idx + firstSet]->IsPushDescriptor()) { |
| last_bound->push_descriptor_set = nullptr; |
| last_bound->boundDescriptorSets[set_idx + firstSet] = nullptr; |
| } |
| |
| last_bound->boundDescriptorSets[set_idx + firstSet] = descriptor_set; |
| |
| auto set_dynamic_descriptor_count = descriptor_set->GetDynamicDescriptorCount(); |
| last_bound->dynamicOffsets[firstSet + set_idx].clear(); |
| if (set_dynamic_descriptor_count) { |
| last_bound->dynamicOffsets[firstSet + set_idx] = |
| std::vector<uint32_t>(pDynamicOffsets + total_dynamic_descriptors, |
| pDynamicOffsets + total_dynamic_descriptors + set_dynamic_descriptor_count); |
| total_dynamic_descriptors += set_dynamic_descriptor_count; |
| } |
| cb_state->validated_descriptor_sets.insert(descriptor_set); |
| } |
| // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update |
| if (firstSet > 0) { |
| for (uint32_t i = 0; i < firstSet; ++i) { |
| if (last_bound->boundDescriptorSets[i] && |
| !verify_set_layout_compatibility(last_bound->boundDescriptorSets[i], pipeline_layout, i, error_string)) { |
| last_bound->boundDescriptorSets[i] = VK_NULL_HANDLE; |
| } |
| } |
| } |
| // Check if newly last bound set invalidates any remaining bound sets |
| if ((last_bound->boundDescriptorSets.size() - 1) > (last_set_index)) { |
| if (old_final_bound_set && |
| !verify_set_layout_compatibility(old_final_bound_set, pipeline_layout, last_set_index, error_string)) { |
| last_bound->boundDescriptorSets.resize(last_set_index + 1); |
| } |
| } |
| } |
| } |
| |
| static bool PreCallValidateCmdBindDescriptorSets(layer_data *device_data, GLOBAL_CB_NODE *cb_state, |
| VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, uint32_t firstSet, |
| uint32_t setCount, const VkDescriptorSet *pDescriptorSets, |
| uint32_t dynamicOffsetCount, const uint32_t *pDynamicOffsets) { |
| bool skip = false; |
| skip |= ValidateCmdQueueFlags(device_data, cb_state, "vkCmdBindDescriptorSets()", VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| VALIDATION_ERROR_17c02415); |
| skip |= ValidateCmd(device_data, cb_state, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); |
| // Track total count of dynamic descriptor types to make sure we have an offset for each one |
| uint32_t total_dynamic_descriptors = 0; |
| string error_string = ""; |
| uint32_t last_set_index = firstSet + setCount - 1; |
| |
| if (last_set_index >= cb_state->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { |
| cb_state->lastBound[pipelineBindPoint].boundDescriptorSets.resize(last_set_index + 1); |
| cb_state->lastBound[pipelineBindPoint].dynamicOffsets.resize(last_set_index + 1); |
| } |
| auto pipeline_layout = getPipelineLayout(device_data, layout); |
| for (uint32_t set_idx = 0; set_idx < setCount; set_idx++) { |
| cvdescriptorset::DescriptorSet *descriptor_set = GetSetNode(device_data, pDescriptorSets[set_idx]); |
| if (descriptor_set) { |
| if (!descriptor_set->IsUpdated() && (descriptor_set->GetTotalDescriptorCount() != 0)) { |
| skip |= log_msg( |
| device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
| HandleToUint64(pDescriptorSets[set_idx]), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", |
| "Descriptor Set 0x%" PRIx64 " bound but it was never updated. You may want to either update it or not bind it.", |
| HandleToUint64(pDescriptorSets[set_idx])); |
| } |
| // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout |
| if (!verify_set_layout_compatibility(descriptor_set, pipeline_layout, set_idx + firstSet, error_string)) { |
| skip |= |
| log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
| HandleToUint64(pDescriptorSets[set_idx]), __LINE__, VALIDATION_ERROR_17c002cc, "DS", |
| "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout at index %u of " |
| "pipelineLayout 0x%" PRIx64 " due to: %s. %s", |
| set_idx, set_idx + firstSet, HandleToUint64(layout), error_string.c_str(), |
| validation_error_map[VALIDATION_ERROR_17c002cc]); |
| } |
| |
| auto set_dynamic_descriptor_count = descriptor_set->GetDynamicDescriptorCount(); |
| |
| if (set_dynamic_descriptor_count) { |
| // First make sure we won't overstep bounds of pDynamicOffsets array |
| if ((total_dynamic_descriptors + set_dynamic_descriptor_count) > dynamicOffsetCount) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, HandleToUint64(pDescriptorSets[set_idx]), |
| __LINE__, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", |
| "descriptorSet #%u (0x%" PRIx64 |
| ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets array. " |
| "There must be one dynamic offset for each dynamic descriptor being bound.", |
| set_idx, HandleToUint64(pDescriptorSets[set_idx]), descriptor_set->GetDynamicDescriptorCount(), |
| (dynamicOffsetCount - total_dynamic_descriptors)); |
| } else { // Validate dynamic offsets and Dynamic Offset Minimums |
| uint32_t cur_dyn_offset = total_dynamic_descriptors; |
| for (uint32_t d = 0; d < descriptor_set->GetTotalDescriptorCount(); d++) { |
| if (descriptor_set->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { |
| if (SafeModulo(pDynamicOffsets[cur_dyn_offset], |
| device_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != |
| 0) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, |
| VALIDATION_ERROR_17c002d4, "DS", |
| "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " |
| "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ". %s", |
| cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], |
| device_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment, |
| validation_error_map[VALIDATION_ERROR_17c002d4]); |
| } |
| cur_dyn_offset++; |
| } else if (descriptor_set->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { |
| if (SafeModulo(pDynamicOffsets[cur_dyn_offset], |
| device_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != |
| 0) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, |
| VALIDATION_ERROR_17c002d4, "DS", |
| "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " |
| "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ". %s", |
| cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], |
| device_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment, |
| validation_error_map[VALIDATION_ERROR_17c002d4]); |
| } |
| cur_dyn_offset++; |
| } |
| } |
| // Keep running total of dynamic descriptor count to verify at the end |
| total_dynamic_descriptors += set_dynamic_descriptor_count; |
| } |
| } |
| } else { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
| HandleToUint64(pDescriptorSets[set_idx]), __LINE__, DRAWSTATE_INVALID_SET, "DS", |
| "Attempt to bind descriptor set 0x%" PRIx64 " that doesn't exist!", |
| HandleToUint64(pDescriptorSets[set_idx])); |
| } |
| } |
| // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound |
| if (total_dynamic_descriptors != dynamicOffsetCount) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, VALIDATION_ERROR_17c002ce, "DS", |
| "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount is %u. It should " |
| "exactly match the number of dynamic descriptors. %s", |
| setCount, total_dynamic_descriptors, dynamicOffsetCount, validation_error_map[VALIDATION_ERROR_17c002ce]); |
| } |
| return skip; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, |
| VkPipelineLayout layout, uint32_t firstSet, uint32_t setCount, |
| const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, |
| const uint32_t *pDynamicOffsets) { |
| bool skip = false; |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *cb_state = GetCBNode(device_data, commandBuffer); |
| assert(cb_state); |
| skip = PreCallValidateCmdBindDescriptorSets(device_data, cb_state, pipelineBindPoint, layout, firstSet, setCount, |
| pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); |
| if (!skip) { |
| PreCallRecordCmdBindDescriptorSets(device_data, cb_state, pipelineBindPoint, layout, firstSet, setCount, pDescriptorSets, |
| dynamicOffsetCount, pDynamicOffsets); |
| lock.unlock(); |
| device_data->dispatch_table.CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, |
| pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); |
| } else { |
| lock.unlock(); |
| } |
| } |
| |
| // Validates that the supplied bind point is supported for the command buffer (vis. the command pool) |
| // Takes array of error codes as some of the VUID's (e.g. vkCmdBindPipeline) are written per bindpoint |
| // TODO add vkCmdBindPipeline bind_point validation using this call. |
| bool ValidatePipelineBindPoint(layer_data *device_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| const char *func_name, |
| const std::array<UNIQUE_VALIDATION_ERROR_CODE, VK_PIPELINE_BIND_POINT_RANGE_SIZE> &bind_errors) { |
| bool skip = false; |
| auto pool = GetCommandPoolNode(device_data, cb_state->createInfo.commandPool); |
| if (pool) { // The loss of a pool in a recording cmd is reported in DestroyCommandPool |
| static const VkQueueFlags flag_mask[VK_PIPELINE_BIND_POINT_RANGE_SIZE] = {VK_QUEUE_GRAPHICS_BIT, VK_QUEUE_COMPUTE_BIT}; |
| const auto bind_point_index = bind_point - VK_PIPELINE_BIND_POINT_BEGIN_RANGE; // typeof enum is not defined, use auto |
| const auto &qfp = GetPhysDevProperties(device_data)->queue_family_properties[pool->queueFamilyIndex]; |
| if (0 == (qfp.queueFlags & flag_mask[bind_point_index])) { |
| const UNIQUE_VALIDATION_ERROR_CODE error = bind_errors[bind_point_index]; |
| auto cb_u64 = HandleToUint64(cb_state->commandBuffer); |
| auto cp_u64 = HandleToUint64(cb_state->createInfo.commandPool); |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| cb_u64, __LINE__, error, "DS", |
| "%s: CommandBuffer 0x%" PRIxLEAST64 " was allocated from VkCommandPool 0x%" PRIxLEAST64 |
| " that does not support bindpoint %s. %s", |
| func_name, cb_u64, cp_u64, string_VkPipelineBindPoint(bind_point), validation_error_map[error]); |
| } |
| } |
| return skip; |
| } |
| |
| static bool PreCallValidateCmdPushDescriptorSetKHR(layer_data *device_data, GLOBAL_CB_NODE *cb_state, |
| const VkPipelineBindPoint bind_point, const VkPipelineLayout layout, |
| const uint32_t set, const uint32_t descriptor_write_count, |
| const VkWriteDescriptorSet *descriptor_writes, const char *func_name) { |
| bool skip = false; |
| skip |= ValidateCmd(device_data, cb_state, CMD_PUSHDESCRIPTORSETKHR, func_name); |
| skip |= ValidateCmdQueueFlags(device_data, cb_state, func_name, (VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT), |
| VALIDATION_ERROR_1be02415); |
| skip |= ValidatePipelineBindPoint(device_data, cb_state, bind_point, func_name, |
| {{VALIDATION_ERROR_1be002d6, VALIDATION_ERROR_1be002d6}}); |
| auto layout_data = getPipelineLayout(device_data, layout); |
| |
| // Validate the set index points to a push descriptor set and is in range |
| if (layout_data) { |
| const auto &set_layouts = layout_data->set_layouts; |
| const auto layout_u64 = HandleToUint64(layout); |
| if (set < set_layouts.size()) { |
| const auto *dsl = set_layouts[set].get(); |
| if (dsl && (0 == (dsl->GetCreateFlags() & VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR))) { |
| skip = |
| log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_LAYOUT_EXT, layout_u64, __LINE__, VALIDATION_ERROR_1be002da, "DS", |
| "%s: Set index %" PRIu32 |
| " does not match push descriptor set layout index for VkPipelineLayout 0x%" PRIxLEAST64 ". %s", |
| func_name, set, layout_u64, validation_error_map[VALIDATION_ERROR_1be002da]); |
| } |
| } else { |
| skip = log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_LAYOUT_EXT, |
| layout_u64, __LINE__, VALIDATION_ERROR_1be002d8, "DS", |
| "%s: Set index %" PRIu32 " is outside of range for VkPipelineLayout 0x%" PRIxLEAST64 " (set < %" PRIu32 |
| "). %s", |
| func_name, set, layout_u64, static_cast<uint32_t>(set_layouts.size()), |
| validation_error_map[VALIDATION_ERROR_1be002d8]); |
| } |
| } |
| |
| return skip; |
| } |
| static void PreCallRecordCmdPushDescriptorSetKHR(layer_data *device_data, GLOBAL_CB_NODE *cb_state, |
| VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, uint32_t set, |
| uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites) { |
| if (set >= cb_state->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { |
| cb_state->lastBound[pipelineBindPoint].boundDescriptorSets.resize(set + 1); |
| cb_state->lastBound[pipelineBindPoint].dynamicOffsets.resize(set + 1); |
| } |
| const auto &layout_state = getPipelineLayout(device_data, layout); |
| std::unique_ptr<cvdescriptorset::DescriptorSet> new_desc{ |
| new cvdescriptorset::DescriptorSet(0, 0, layout_state->set_layouts[set], device_data)}; |
| cb_state->lastBound[pipelineBindPoint].boundDescriptorSets[set] = new_desc.get(); |
| cb_state->lastBound[pipelineBindPoint].push_descriptor_set = std::move(new_desc); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, |
| VkPipelineLayout layout, uint32_t set, uint32_t descriptorWriteCount, |
| const VkWriteDescriptorSet *pDescriptorWrites) { |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| auto cb_state = GetCBNode(device_data, commandBuffer); |
| bool skip = PreCallValidateCmdPushDescriptorSetKHR(device_data, cb_state, pipelineBindPoint, layout, set, descriptorWriteCount, |
| pDescriptorWrites, "vkCmdPushDescriptorSetKHR()"); |
| if (!skip) { |
| PreCallRecordCmdPushDescriptorSetKHR(device_data, cb_state, pipelineBindPoint, layout, set, descriptorWriteCount, |
| pDescriptorWrites); |
| lock.unlock(); |
| device_data->dispatch_table.CmdPushDescriptorSetKHR(commandBuffer, pipelineBindPoint, layout, set, descriptorWriteCount, |
| pDescriptorWrites); |
| } |
| } |
| |
| static VkDeviceSize GetIndexAlignment(VkIndexType indexType) { |
| switch (indexType) { |
| case VK_INDEX_TYPE_UINT16: |
| return 2; |
| case VK_INDEX_TYPE_UINT32: |
| return 4; |
| default: |
| // Not a real index type. Express no alignment requirement here; we expect upper layer |
| // to have already picked up on the enum being nonsense. |
| return 1; |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, |
| VkIndexType indexType) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| auto buffer_state = GetBufferState(dev_data, buffer); |
| auto cb_node = GetCBNode(dev_data, commandBuffer); |
| assert(cb_node); |
| assert(buffer_state); |
| |
| skip |= ValidateBufferUsageFlags(dev_data, buffer_state, VK_BUFFER_USAGE_INDEX_BUFFER_BIT, true, VALIDATION_ERROR_17e00362, |
| "vkCmdBindIndexBuffer()", "VK_BUFFER_USAGE_INDEX_BUFFER_BIT"); |
| skip |= ValidateCmdQueueFlags(dev_data, cb_node, "vkCmdBindIndexBuffer()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_17e02415); |
| skip |= ValidateCmd(dev_data, cb_node, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); |
| skip |= ValidateMemoryIsBoundToBuffer(dev_data, buffer_state, "vkCmdBindIndexBuffer()", VALIDATION_ERROR_17e00364); |
| auto offset_align = GetIndexAlignment(indexType); |
| if (offset % offset_align) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_17e00360, "DS", |
| "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary. %s", offset, |
| string_VkIndexType(indexType), validation_error_map[VALIDATION_ERROR_17e00360]); |
| } |
| |
| if (skip) return; |
| |
| std::function<bool()> function = [=]() { |
| return ValidateBufferMemoryIsValid(dev_data, buffer_state, "vkCmdBindIndexBuffer()"); |
| }; |
| cb_node->queue_submit_functions.push_back(function); |
| cb_node->status |= CBSTATUS_INDEX_BUFFER_BOUND; |
| |
| lock.unlock(); |
| dev_data->dispatch_table.CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); |
| } |
| |
| void updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { |
| uint32_t end = firstBinding + bindingCount; |
| if (pCB->currentDrawData.buffers.size() < end) { |
| pCB->currentDrawData.buffers.resize(end); |
| } |
| for (uint32_t i = 0; i < bindingCount; ++i) { |
| pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; |
| } |
| } |
| |
| static inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, uint32_t bindingCount, |
| const VkBuffer *pBuffers, const VkDeviceSize *pOffsets) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| auto cb_node = GetCBNode(dev_data, commandBuffer); |
| assert(cb_node); |
| |
| skip |= ValidateCmdQueueFlags(dev_data, cb_node, "vkCmdBindVertexBuffers()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_18202415); |
| skip |= ValidateCmd(dev_data, cb_node, CMD_BINDVERTEXBUFFERS, "vkCmdBindVertexBuffers()"); |
| for (uint32_t i = 0; i < bindingCount; ++i) { |
| auto buffer_state = GetBufferState(dev_data, pBuffers[i]); |
| assert(buffer_state); |
| skip |= ValidateBufferUsageFlags(dev_data, buffer_state, VK_BUFFER_USAGE_VERTEX_BUFFER_BIT, true, VALIDATION_ERROR_182004e6, |
| "vkCmdBindVertexBuffers()", "VK_BUFFER_USAGE_VERTEX_BUFFER_BIT"); |
| skip |= ValidateMemoryIsBoundToBuffer(dev_data, buffer_state, "vkCmdBindVertexBuffers()", VALIDATION_ERROR_182004e8); |
| if (pOffsets[i] >= buffer_state->createInfo.size) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| HandleToUint64(buffer_state->buffer), __LINE__, VALIDATION_ERROR_182004e4, "DS", |
| "vkCmdBindVertexBuffers() offset (0x%" PRIxLEAST64 ") is beyond the end of the buffer. %s", pOffsets[i], |
| validation_error_map[VALIDATION_ERROR_182004e4]); |
| } |
| } |
| |
| if (skip) return; |
| |
| for (uint32_t i = 0; i < bindingCount; ++i) { |
| auto buffer_state = GetBufferState(dev_data, pBuffers[i]); |
| assert(buffer_state); |
| std::function<bool()> function = [=]() { |
| return ValidateBufferMemoryIsValid(dev_data, buffer_state, "vkCmdBindVertexBuffers()"); |
| }; |
| cb_node->queue_submit_functions.push_back(function); |
| } |
| |
| updateResourceTracking(cb_node, firstBinding, bindingCount, pBuffers); |
| |
| lock.unlock(); |
| dev_data->dispatch_table.CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); |
| } |
| |
| // Expects global_lock to be held by caller |
| static void MarkStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { |
| for (auto imageView : pCB->updateImages) { |
| auto view_state = GetImageViewState(dev_data, imageView); |
| if (!view_state) continue; |
| |
| auto image_state = GetImageState(dev_data, view_state->create_info.image); |
| assert(image_state); |
| std::function<bool()> function = [=]() { |
| SetImageMemoryValid(dev_data, image_state, true); |
| return false; |
| }; |
| pCB->queue_submit_functions.push_back(function); |
| } |
| for (auto buffer : pCB->updateBuffers) { |
| auto buffer_state = GetBufferState(dev_data, buffer); |
| assert(buffer_state); |
| std::function<bool()> function = [=]() { |
| SetBufferMemoryValid(dev_data, buffer_state, true); |
| return false; |
| }; |
| pCB->queue_submit_functions.push_back(function); |
| } |
| } |
| |
| // Generic function to handle validation for all CmdDraw* type functions |
| static bool ValidateCmdDrawType(layer_data *dev_data, VkCommandBuffer cmd_buffer, bool indexed, VkPipelineBindPoint bind_point, |
| CMD_TYPE cmd_type, GLOBAL_CB_NODE **cb_state, const char *caller, VkQueueFlags queue_flags, |
| UNIQUE_VALIDATION_ERROR_CODE queue_flag_code, UNIQUE_VALIDATION_ERROR_CODE msg_code, |
| UNIQUE_VALIDATION_ERROR_CODE const dynamic_state_msg_code) { |
| bool skip = false; |
| *cb_state = GetCBNode(dev_data, cmd_buffer); |
| if (*cb_state) { |
| skip |= ValidateCmdQueueFlags(dev_data, *cb_state, caller, queue_flags, queue_flag_code); |
| skip |= ValidateCmd(dev_data, *cb_state, cmd_type, caller); |
| skip |= ValidateDrawState(dev_data, *cb_state, cmd_type, indexed, bind_point, caller, dynamic_state_msg_code); |
| skip |= (VK_PIPELINE_BIND_POINT_GRAPHICS == bind_point) ? outsideRenderPass(dev_data, *cb_state, caller, msg_code) |
| : insideRenderPass(dev_data, *cb_state, caller, msg_code); |
| } |
| return skip; |
| } |
| |
| // Generic function to handle state update for all CmdDraw* and CmdDispatch* type functions |
| static void UpdateStateCmdDrawDispatchType(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point) { |
| UpdateDrawState(dev_data, cb_state, bind_point); |
| MarkStoreImagesAndBuffersAsWritten(dev_data, cb_state); |
| } |
| |
| // Generic function to handle state update for all CmdDraw* type functions |
| static void UpdateStateCmdDrawType(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point) { |
| UpdateStateCmdDrawDispatchType(dev_data, cb_state, bind_point); |
| updateResourceTrackingOnDraw(cb_state); |
| cb_state->hasDrawCmd = true; |
| } |
| |
| static bool PreCallValidateCmdDraw(layer_data *dev_data, VkCommandBuffer cmd_buffer, bool indexed, VkPipelineBindPoint bind_point, |
| GLOBAL_CB_NODE **cb_state, const char *caller) { |
| return ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DRAW, cb_state, caller, VK_QUEUE_GRAPHICS_BIT, |
| VALIDATION_ERROR_1a202415, VALIDATION_ERROR_1a200017, VALIDATION_ERROR_1a200376); |
| } |
| |
| static void PostCallRecordCmdDraw(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point) { |
| UpdateStateCmdDrawType(dev_data, cb_state, bind_point); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, |
| uint32_t firstVertex, uint32_t firstInstance) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| GLOBAL_CB_NODE *cb_state = nullptr; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateCmdDraw(dev_data, commandBuffer, false, VK_PIPELINE_BIND_POINT_GRAPHICS, &cb_state, "vkCmdDraw()"); |
| lock.unlock(); |
| if (!skip) { |
| dev_data->dispatch_table.CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); |
| lock.lock(); |
| PostCallRecordCmdDraw(dev_data, cb_state, VK_PIPELINE_BIND_POINT_GRAPHICS); |
| lock.unlock(); |
| } |
| } |
| |
| static bool PreCallValidateCmdDrawIndexed(layer_data *dev_data, VkCommandBuffer cmd_buffer, bool indexed, |
| VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, const char *caller) { |
| return ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DRAWINDEXED, cb_state, caller, VK_QUEUE_GRAPHICS_BIT, |
| VALIDATION_ERROR_1a402415, VALIDATION_ERROR_1a400017, VALIDATION_ERROR_1a40039c); |
| } |
| |
| static void PostCallRecordCmdDrawIndexed(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point) { |
| UpdateStateCmdDrawType(dev_data, cb_state, bind_point); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, uint32_t instanceCount, |
| uint32_t firstIndex, int32_t vertexOffset, uint32_t firstInstance) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| GLOBAL_CB_NODE *cb_state = nullptr; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateCmdDrawIndexed(dev_data, commandBuffer, true, VK_PIPELINE_BIND_POINT_GRAPHICS, &cb_state, |
| "vkCmdDrawIndexed()"); |
| lock.unlock(); |
| if (!skip) { |
| dev_data->dispatch_table.CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, firstInstance); |
| lock.lock(); |
| PostCallRecordCmdDrawIndexed(dev_data, cb_state, VK_PIPELINE_BIND_POINT_GRAPHICS); |
| lock.unlock(); |
| } |
| } |
| |
| static bool PreCallValidateCmdDrawIndirect(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkBuffer buffer, bool indexed, |
| VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, BUFFER_STATE **buffer_state, |
| const char *caller) { |
| bool skip = |
| ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DRAWINDIRECT, cb_state, caller, VK_QUEUE_GRAPHICS_BIT, |
| VALIDATION_ERROR_1aa02415, VALIDATION_ERROR_1aa00017, VALIDATION_ERROR_1aa003cc); |
| *buffer_state = GetBufferState(dev_data, buffer); |
| skip |= ValidateMemoryIsBoundToBuffer(dev_data, *buffer_state, caller, VALIDATION_ERROR_1aa003b4); |
| // TODO: If the drawIndirectFirstInstance feature is not enabled, all the firstInstance members of the |
| // VkDrawIndirectCommand structures accessed by this command must be 0, which will require access to the contents of 'buffer'. |
| return skip; |
| } |
| |
| static void PostCallRecordCmdDrawIndirect(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| BUFFER_STATE *buffer_state) { |
| UpdateStateCmdDrawType(dev_data, cb_state, bind_point); |
| AddCommandBufferBindingBuffer(dev_data, cb_state, buffer_state); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, |
| uint32_t stride) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| GLOBAL_CB_NODE *cb_state = nullptr; |
| BUFFER_STATE *buffer_state = nullptr; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateCmdDrawIndirect(dev_data, commandBuffer, buffer, false, VK_PIPELINE_BIND_POINT_GRAPHICS, &cb_state, |
| &buffer_state, "vkCmdDrawIndirect()"); |
| lock.unlock(); |
| if (!skip) { |
| dev_data->dispatch_table.CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); |
| lock.lock(); |
| PostCallRecordCmdDrawIndirect(dev_data, cb_state, VK_PIPELINE_BIND_POINT_GRAPHICS, buffer_state); |
| lock.unlock(); |
| } |
| } |
| |
| static bool PreCallValidateCmdDrawIndexedIndirect(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkBuffer buffer, bool indexed, |
| VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, |
| BUFFER_STATE **buffer_state, const char *caller) { |
| bool skip = |
| ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DRAWINDEXEDINDIRECT, cb_state, caller, |
| VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_1a602415, VALIDATION_ERROR_1a600017, VALIDATION_ERROR_1a600434); |
| *buffer_state = GetBufferState(dev_data, buffer); |
| skip |= ValidateMemoryIsBoundToBuffer(dev_data, *buffer_state, caller, VALIDATION_ERROR_1a60041c); |
| // TODO: If the drawIndirectFirstInstance feature is not enabled, all the firstInstance members of the |
| // VkDrawIndexedIndirectCommand structures accessed by this command must be 0, which will require access to the contents of |
| // 'buffer'. |
| return skip; |
| } |
| |
| static void PostCallRecordCmdDrawIndexedIndirect(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| BUFFER_STATE *buffer_state) { |
| UpdateStateCmdDrawType(dev_data, cb_state, bind_point); |
| AddCommandBufferBindingBuffer(dev_data, cb_state, buffer_state); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, |
| uint32_t count, uint32_t stride) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| GLOBAL_CB_NODE *cb_state = nullptr; |
| BUFFER_STATE *buffer_state = nullptr; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateCmdDrawIndexedIndirect(dev_data, commandBuffer, buffer, true, VK_PIPELINE_BIND_POINT_GRAPHICS, |
| &cb_state, &buffer_state, "vkCmdDrawIndexedIndirect()"); |
| lock.unlock(); |
| if (!skip) { |
| dev_data->dispatch_table.CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); |
| lock.lock(); |
| PostCallRecordCmdDrawIndexedIndirect(dev_data, cb_state, VK_PIPELINE_BIND_POINT_GRAPHICS, buffer_state); |
| lock.unlock(); |
| } |
| } |
| |
| static bool PreCallValidateCmdDispatch(layer_data *dev_data, VkCommandBuffer cmd_buffer, bool indexed, |
| VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, const char *caller) { |
| return ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DISPATCH, cb_state, caller, VK_QUEUE_COMPUTE_BIT, |
| VALIDATION_ERROR_19c02415, VALIDATION_ERROR_19c00017, VALIDATION_ERROR_UNDEFINED); |
| } |
| |
| static void PostCallRecordCmdDispatch(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point) { |
| UpdateStateCmdDrawDispatchType(dev_data, cb_state, bind_point); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| GLOBAL_CB_NODE *cb_state = nullptr; |
| unique_lock_t lock(global_lock); |
| bool skip = |
| PreCallValidateCmdDispatch(dev_data, commandBuffer, false, VK_PIPELINE_BIND_POINT_COMPUTE, &cb_state, "vkCmdDispatch()"); |
| lock.unlock(); |
| if (!skip) { |
| dev_data->dispatch_table.CmdDispatch(commandBuffer, x, y, z); |
| lock.lock(); |
| PostCallRecordCmdDispatch(dev_data, cb_state, VK_PIPELINE_BIND_POINT_COMPUTE); |
| lock.unlock(); |
| } |
| } |
| |
| static bool PreCallValidateCmdDispatchIndirect(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkBuffer buffer, bool indexed, |
| VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, |
| BUFFER_STATE **buffer_state, const char *caller) { |
| bool skip = |
| ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DISPATCHINDIRECT, cb_state, caller, VK_QUEUE_COMPUTE_BIT, |
| VALIDATION_ERROR_1a002415, VALIDATION_ERROR_1a000017, VALIDATION_ERROR_UNDEFINED); |
| *buffer_state = GetBufferState(dev_data, buffer); |
| skip |= ValidateMemoryIsBoundToBuffer(dev_data, *buffer_state, caller, VALIDATION_ERROR_1a000322); |
| return skip; |
| } |
| |
| static void PostCallRecordCmdDispatchIndirect(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| BUFFER_STATE *buffer_state) { |
| UpdateStateCmdDrawDispatchType(dev_data, cb_state, bind_point); |
| AddCommandBufferBindingBuffer(dev_data, cb_state, buffer_state); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| GLOBAL_CB_NODE *cb_state = nullptr; |
| BUFFER_STATE *buffer_state = nullptr; |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateCmdDispatchIndirect(dev_data, commandBuffer, buffer, false, VK_PIPELINE_BIND_POINT_COMPUTE, |
| &cb_state, &buffer_state, "vkCmdDispatchIndirect()"); |
| lock.unlock(); |
| if (!skip) { |
| dev_data->dispatch_table.CmdDispatchIndirect(commandBuffer, buffer, offset); |
| lock.lock(); |
| PostCallRecordCmdDispatchIndirect(dev_data, cb_state, VK_PIPELINE_BIND_POINT_COMPUTE, buffer_state); |
| lock.unlock(); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, |
| uint32_t regionCount, const VkBufferCopy *pRegions) { |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| auto cb_node = GetCBNode(device_data, commandBuffer); |
| auto src_buffer_state = GetBufferState(device_data, srcBuffer); |
| auto dst_buffer_state = GetBufferState(device_data, dstBuffer); |
| |
| if (cb_node && src_buffer_state && dst_buffer_state) { |
| bool skip = PreCallValidateCmdCopyBuffer(device_data, cb_node, src_buffer_state, dst_buffer_state); |
| if (!skip) { |
| PreCallRecordCmdCopyBuffer(device_data, cb_node, src_buffer_state, dst_buffer_state); |
| lock.unlock(); |
| device_data->dispatch_table.CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); |
| } |
| } else { |
| lock.unlock(); |
| assert(0); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| VkImage dstImage, VkImageLayout dstImageLayout, uint32_t regionCount, |
| const VkImageCopy *pRegions) { |
| bool skip = false; |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| auto cb_node = GetCBNode(device_data, commandBuffer); |
| auto src_image_state = GetImageState(device_data, srcImage); |
| auto dst_image_state = GetImageState(device_data, dstImage); |
| if (cb_node && src_image_state && dst_image_state) { |
| skip = PreCallValidateCmdCopyImage(device_data, cb_node, src_image_state, dst_image_state, regionCount, pRegions, |
| srcImageLayout, dstImageLayout); |
| if (!skip) { |
| PreCallRecordCmdCopyImage(device_data, cb_node, src_image_state, dst_image_state, regionCount, pRegions, srcImageLayout, |
| dstImageLayout); |
| lock.unlock(); |
| device_data->dispatch_table.CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, |
| pRegions); |
| } |
| } else { |
| lock.unlock(); |
| assert(0); |
| } |
| } |
| |
| // Validate that an image's sampleCount matches the requirement for a specific API call |
| bool ValidateImageSampleCount(layer_data *dev_data, IMAGE_STATE *image_state, VkSampleCountFlagBits sample_count, |
| const char *location, UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
| bool skip = false; |
| if (image_state->createInfo.samples != sample_count) { |
| skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| HandleToUint64(image_state->image), 0, msgCode, "DS", |
| "%s for image 0x%" PRIx64 " was created with a sample count of %s but must be %s. %s", location, |
| HandleToUint64(image_state->image), string_VkSampleCountFlagBits(image_state->createInfo.samples), |
| string_VkSampleCountFlagBits(sample_count), validation_error_map[msgCode]); |
| } |
| return skip; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| VkImage dstImage, VkImageLayout dstImageLayout, uint32_t regionCount, |
| const VkImageBlit *pRegions, VkFilter filter) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| auto cb_node = GetCBNode(dev_data, commandBuffer); |
| auto src_image_state = GetImageState(dev_data, srcImage); |
| auto dst_image_state = GetImageState(dev_data, dstImage); |
| |
| bool skip = PreCallValidateCmdBlitImage(dev_data, cb_node, src_image_state, dst_image_state, regionCount, pRegions, |
| srcImageLayout, dstImageLayout, filter); |
| |
| if (!skip) { |
| PreCallRecordCmdBlitImage(dev_data, cb_node, src_image_state, dst_image_state, regionCount, pRegions, srcImageLayout, |
| dstImageLayout); |
| lock.unlock(); |
| dev_data->dispatch_table.CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, |
| pRegions, filter); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, |
| VkImageLayout dstImageLayout, uint32_t regionCount, |
| const VkBufferImageCopy *pRegions) { |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = false; |
| auto cb_node = GetCBNode(device_data, commandBuffer); |
| auto src_buffer_state = GetBufferState(device_data, srcBuffer); |
| auto dst_image_state = GetImageState(device_data, dstImage); |
| if (cb_node && src_buffer_state && dst_image_state) { |
| skip = PreCallValidateCmdCopyBufferToImage(device_data, dstImageLayout, cb_node, src_buffer_state, dst_image_state, |
| regionCount, pRegions, "vkCmdCopyBufferToImage()"); |
| } else { |
| lock.unlock(); |
| assert(0); |
| // TODO: report VU01244 here, or put in object tracker? |
| } |
| if (!skip) { |
| PreCallRecordCmdCopyBufferToImage(device_data, cb_node, src_buffer_state, dst_image_state, regionCount, pRegions, |
| dstImageLayout); |
| lock.unlock(); |
| device_data->dispatch_table.CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, pRegions); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| VkBuffer dstBuffer, uint32_t regionCount, const VkBufferImageCopy *pRegions) { |
| bool skip = false; |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| auto cb_node = GetCBNode(device_data, commandBuffer); |
| auto src_image_state = GetImageState(device_data, srcImage); |
| auto dst_buffer_state = GetBufferState(device_data, dstBuffer); |
| if (cb_node && src_image_state && dst_buffer_state) { |
| skip = PreCallValidateCmdCopyImageToBuffer(device_data, srcImageLayout, cb_node, src_image_state, dst_buffer_state, |
| regionCount, pRegions, "vkCmdCopyImageToBuffer()"); |
| } else { |
| lock.unlock(); |
| assert(0); |
| // TODO: report VU01262 here, or put in object tracker? |
| } |
| if (!skip) { |
| PreCallRecordCmdCopyImageToBuffer(device_data, cb_node, src_image_state, dst_buffer_state, regionCount, pRegions, |
| srcImageLayout); |
| lock.unlock(); |
| device_data->dispatch_table.CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, pRegions); |
| } |
| } |
| |
| static bool PreCallCmdUpdateBuffer(layer_data *device_data, const GLOBAL_CB_NODE *cb_state, const BUFFER_STATE *dst_buffer_state) { |
| bool skip = false; |
| skip |= ValidateMemoryIsBoundToBuffer(device_data, dst_buffer_state, "vkCmdUpdateBuffer()", VALIDATION_ERROR_1e400046); |
| // Validate that DST buffer has correct usage flags set |
| skip |= ValidateBufferUsageFlags(device_data, dst_buffer_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, |
| VALIDATION_ERROR_1e400044, "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
| skip |= ValidateCmdQueueFlags(device_data, cb_state, "vkCmdUpdateBuffer()", |
| VK_QUEUE_TRANSFER_BIT | VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, VALIDATION_ERROR_1e402415); |
| skip |= ValidateCmd(device_data, cb_state, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); |
| skip |= insideRenderPass(device_data, cb_state, "vkCmdUpdateBuffer()", VALIDATION_ERROR_1e400017); |
| return skip; |
| } |
| |
| static void PostCallRecordCmdUpdateBuffer(layer_data *device_data, GLOBAL_CB_NODE *cb_state, BUFFER_STATE *dst_buffer_state) { |
| // Update bindings between buffer and cmd buffer |
| AddCommandBufferBindingBuffer(device_data, cb_state, dst_buffer_state); |
| std::function<bool()> function = [=]() { |
| SetBufferMemoryValid(device_data, dst_buffer_state, true); |
| return false; |
| }; |
| cb_state->queue_submit_functions.push_back(function); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, |
| VkDeviceSize dataSize, const uint32_t *pData) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| auto cb_state = GetCBNode(dev_data, commandBuffer); |
| assert(cb_state); |
| auto dst_buff_state = GetBufferState(dev_data, dstBuffer); |
| assert(dst_buff_state); |
| skip |= PreCallCmdUpdateBuffer(dev_data, cb_state, dst_buff_state); |
| lock.unlock(); |
| if (!skip) { |
| dev_data->dispatch_table.CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); |
| lock.lock(); |
| PostCallRecordCmdUpdateBuffer(dev_data, cb_state, dst_buff_state); |
| lock.unlock(); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, |
| VkDeviceSize size, uint32_t data) { |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| auto cb_node = GetCBNode(device_data, commandBuffer); |
| auto buffer_state = GetBufferState(device_data, dstBuffer); |
| |
| if (cb_node && buffer_state) { |
| bool skip = PreCallValidateCmdFillBuffer(device_data, cb_node, buffer_state); |
| if (!skip) { |
| PreCallRecordCmdFillBuffer(device_data, cb_node, buffer_state); |
| lock.unlock(); |
| device_data->dispatch_table.CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); |
| } |
| } else { |
| lock.unlock(); |
| assert(0); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, |
| const VkClearAttachment *pAttachments, uint32_t rectCount, |
| const VkClearRect *pRects) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| { |
| lock_guard_t lock(global_lock); |
| skip = PreCallValidateCmdClearAttachments(dev_data, commandBuffer, attachmentCount, pAttachments, rectCount, pRects); |
| } |
| if (!skip) dev_data->dispatch_table.CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, |
| const VkClearColorValue *pColor, uint32_t rangeCount, |
| const VkImageSubresourceRange *pRanges) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| bool skip = PreCallValidateCmdClearColorImage(dev_data, commandBuffer, image, imageLayout, rangeCount, pRanges); |
| if (!skip) { |
| PreCallRecordCmdClearImage(dev_data, commandBuffer, image, imageLayout, rangeCount, pRanges); |
| lock.unlock(); |
| dev_data->dispatch_table.CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, |
| const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, |
| const VkImageSubresourceRange *pRanges) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| bool skip = PreCallValidateCmdClearDepthStencilImage(dev_data, commandBuffer, image, imageLayout, rangeCount, pRanges); |
| if (!skip) { |
| PreCallRecordCmdClearImage(dev_data, commandBuffer, image, imageLayout, rangeCount, pRanges); |
| lock.unlock(); |
| dev_data->dispatch_table.CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, pRanges); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| VkImage dstImage, VkImageLayout dstImageLayout, uint32_t regionCount, |
| const VkImageResolve *pRegions) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| auto cb_node = GetCBNode(dev_data, commandBuffer); |
| auto src_image_state = GetImageState(dev_data, srcImage); |
| auto dst_image_state = GetImageState(dev_data, dstImage); |
| |
| bool skip = PreCallValidateCmdResolveImage(dev_data, cb_node, src_image_state, dst_image_state, regionCount, pRegions); |
| |
| if (!skip) { |
| PreCallRecordCmdResolveImage(dev_data, cb_node, src_image_state, dst_image_state); |
| lock.unlock(); |
| dev_data->dispatch_table.CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, |
| pRegions); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL GetImageSubresourceLayout(VkDevice device, VkImage image, const VkImageSubresource *pSubresource, |
| VkSubresourceLayout *pLayout) { |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| bool skip = PreCallValidateGetImageSubresourceLayout(device_data, image, pSubresource); |
| if (!skip) { |
| lock.unlock(); |
| device_data->dispatch_table.GetImageSubresourceLayout(device, image, pSubresource, pLayout); |
| } |
| } |
| |
| bool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| pCB->eventToStageMap[event] = stageMask; |
| } |
| auto queue_data = dev_data->queueMap.find(queue); |
| if (queue_data != dev_data->queueMap.end()) { |
| queue_data->second.eventToStageMap[event] = stageMask; |
| } |
| return false; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= ValidateCmdQueueFlags(dev_data, pCB, "vkCmdSetEvent()", VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| VALIDATION_ERROR_1d402415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); |
| skip |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent()", VALIDATION_ERROR_1d400017); |
| skip |= ValidateStageMaskGsTsEnables(dev_data, stageMask, "vkCmdSetEvent()", VALIDATION_ERROR_1d4008fc, |
| VALIDATION_ERROR_1d4008fe); |
| auto event_state = GetEventNode(dev_data, event); |
| if (event_state) { |
| addCommandBufferBinding(&event_state->cb_bindings, {HandleToUint64(event), kVulkanObjectTypeEvent}, pCB); |
| event_state->cb_bindings.insert(pCB); |
| } |
| pCB->events.push_back(event); |
| if (!pCB->waitedEvents.count(event)) { |
| pCB->writeEventsBeforeWait.push_back(event); |
| } |
| pCB->eventUpdates.emplace_back([=](VkQueue q) { return setEventStageMask(q, commandBuffer, event, stageMask); }); |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdSetEvent(commandBuffer, event, stageMask); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= ValidateCmdQueueFlags(dev_data, pCB, "vkCmdResetEvent()", VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| VALIDATION_ERROR_1c402415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); |
| skip |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent()", VALIDATION_ERROR_1c400017); |
| skip |= ValidateStageMaskGsTsEnables(dev_data, stageMask, "vkCmdResetEvent()", VALIDATION_ERROR_1c400904, |
| VALIDATION_ERROR_1c400906); |
| auto event_state = GetEventNode(dev_data, event); |
| if (event_state) { |
| addCommandBufferBinding(&event_state->cb_bindings, {HandleToUint64(event), kVulkanObjectTypeEvent}, pCB); |
| event_state->cb_bindings.insert(pCB); |
| } |
| pCB->events.push_back(event); |
| if (!pCB->waitedEvents.count(event)) { |
| pCB->writeEventsBeforeWait.push_back(event); |
| } |
| // TODO : Add check for VALIDATION_ERROR_32c008f8 |
| pCB->eventUpdates.emplace_back( |
| [=](VkQueue q) { return setEventStageMask(q, commandBuffer, event, VkPipelineStageFlags(0)); }); |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdResetEvent(commandBuffer, event, stageMask); |
| } |
| |
| // Return input pipeline stage flags, expanded for individual bits if VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT |
| static VkPipelineStageFlags ExpandPipelineStageFlags(VkPipelineStageFlags inflags) { |
| return (inflags != VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT) |
| ? inflags |
| : (VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT | VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT | VK_PIPELINE_STAGE_VERTEX_INPUT_BIT | |
| VK_PIPELINE_STAGE_VERTEX_SHADER_BIT | VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT | |
| VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT | VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT | |
| VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT | VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT | |
| VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT | VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | |
| VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT); |
| } |
| |
| // Verify image barrier image state and that the image is consistent with FB image |
| static bool ValidateImageBarrierImage(layer_data *device_data, const char *funcName, GLOBAL_CB_NODE const *cb_state, |
| VkFramebuffer framebuffer, uint32_t active_subpass, const safe_VkSubpassDescription &sub_desc, |
| uint64_t rp_handle, uint32_t img_index, const VkImageMemoryBarrier &img_barrier) { |
| bool skip = false; |
| const auto &fb_state = GetFramebufferState(device_data, framebuffer); |
| assert(fb_state); |
| const auto img_bar_image = img_barrier.image; |
| bool image_match = false; |
| bool sub_image_found = false; // Do we find a corresponding subpass description |
| VkImageLayout sub_image_layout = VK_IMAGE_LAYOUT_UNDEFINED; |
| uint32_t attach_index = 0; |
| uint32_t index_count = 0; |
| // Verify that a framebuffer image matches barrier image |
| for (const auto &fb_attach : fb_state->attachments) { |
| if (img_bar_image == fb_attach.image) { |
| image_match = true; |
| attach_index = index_count; |
| break; |
| } |
| index_count++; |
| } |
| if (image_match) { // Make sure subpass is referring to matching attachment |
| if (sub_desc.pDepthStencilAttachment && sub_desc.pDepthStencilAttachment->attachment == attach_index) { |
| sub_image_layout = sub_desc.pDepthStencilAttachment->layout; |
| sub_image_found = true; |
| } else { |
| for (uint32_t j = 0; j < sub_desc.colorAttachmentCount; ++j) { |
| if (sub_desc.pColorAttachments && sub_desc.pColorAttachments[j].attachment == attach_index) { |
| sub_image_layout = sub_desc.pColorAttachments[j].layout; |
| sub_image_found = true; |
| break; |
| } else if (sub_desc.pResolveAttachments && sub_desc.pResolveAttachments[j].attachment == attach_index) { |
| sub_image_layout = sub_desc.pResolveAttachments[j].layout; |
| sub_image_found = true; |
| break; |
| } |
| } |
| } |
| if (!sub_image_found) { |
| skip |= log_msg( |
| device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, rp_handle, |
| __LINE__, VALIDATION_ERROR_1b800936, "CORE", |
| "%s: Barrier pImageMemoryBarriers[%d].image (0x%" PRIx64 |
| ") is not referenced by the VkSubpassDescription for active subpass (%d) of current renderPass (0x%" PRIx64 "). %s", |
| funcName, img_index, HandleToUint64(img_bar_image), active_subpass, rp_handle, |
| validation_error_map[VALIDATION_ERROR_1b800936]); |
| } |
| } else { // !image_match |
| auto const fb_handle = HandleToUint64(fb_state->framebuffer); |
| skip |= |
| log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT, fb_handle, |
| __LINE__, VALIDATION_ERROR_1b800936, "CORE", |
| "%s: Barrier pImageMemoryBarriers[%d].image (0x%" PRIx64 |
| ") does not match an image from the current framebuffer (0x%" PRIx64 "). %s", |
| funcName, img_index, HandleToUint64(img_bar_image), fb_handle, validation_error_map[VALIDATION_ERROR_1b800936]); |
| } |
| if (img_barrier.oldLayout != img_barrier.newLayout) { |
| skip |= |
| log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, VALIDATION_ERROR_1b80093a, "CORE", |
| "%s: As the Image Barrier for image 0x%" PRIx64 |
| " is being executed within a render pass instance, oldLayout must equal newLayout yet they are %s and %s. %s", |
| funcName, HandleToUint64(img_barrier.image), string_VkImageLayout(img_barrier.oldLayout), |
| string_VkImageLayout(img_barrier.newLayout), validation_error_map[VALIDATION_ERROR_1b80093a]); |
| } else { |
| if (sub_image_found && sub_image_layout != img_barrier.oldLayout) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| rp_handle, __LINE__, VALIDATION_ERROR_1b800938, "CORE", |
| "%s: Barrier pImageMemoryBarriers[%d].image (0x%" PRIx64 |
| ") is referenced by the VkSubpassDescription for active subpass (%d) of current renderPass (0x%" PRIx64 |
| ") as having layout %s, but image barrier has layout %s. %s", |
| funcName, img_index, HandleToUint64(img_bar_image), active_subpass, rp_handle, |
| string_VkImageLayout(img_barrier.oldLayout), string_VkImageLayout(sub_image_layout), |
| validation_error_map[VALIDATION_ERROR_1b800938]); |
| } |
| } |
| return skip; |
| } |
| |
| // Validate image barriers within a renderPass |
| static bool ValidateRenderPassImageBarriers(layer_data *device_data, const char *funcName, GLOBAL_CB_NODE *cb_state, |
| uint32_t active_subpass, const safe_VkSubpassDescription &sub_desc, uint64_t rp_handle, |
| VkAccessFlags sub_src_access_mask, VkAccessFlags sub_dst_access_mask, |
| uint32_t image_mem_barrier_count, const VkImageMemoryBarrier *image_barriers) { |
| bool skip = false; |
| for (uint32_t i = 0; i < image_mem_barrier_count; ++i) { |
| const auto &img_barrier = image_barriers[i]; |
| const auto &img_src_access_mask = img_barrier.srcAccessMask; |
| if (img_src_access_mask != (sub_src_access_mask & img_src_access_mask)) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| rp_handle, __LINE__, VALIDATION_ERROR_1b80092e, "CORE", |
| "%s: Barrier pImageMemoryBarriers[%d].srcAccessMask(0x%X) is not a subset of VkSubpassDependency " |
| "srcAccessMask(0x%X) of subpass %d of renderPass 0x%" PRIx64 ". %s", |
| funcName, i, img_src_access_mask, sub_src_access_mask, active_subpass, rp_handle, |
| validation_error_map[VALIDATION_ERROR_1b80092e]); |
| } |
| const auto &img_dst_access_mask = img_barrier.dstAccessMask; |
| if (img_dst_access_mask != (sub_dst_access_mask & img_dst_access_mask)) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| rp_handle, __LINE__, VALIDATION_ERROR_1b800930, "CORE", |
| "%s: Barrier pImageMemoryBarriers[%d].dstAccessMask(0x%X) is not a subset of VkSubpassDependency " |
| "dstAccessMask(0x%X) of subpass %d of renderPass 0x%" PRIx64 ". %s", |
| funcName, i, img_dst_access_mask, sub_dst_access_mask, active_subpass, rp_handle, |
| validation_error_map[VALIDATION_ERROR_1b800930]); |
| } |
| if (VK_QUEUE_FAMILY_IGNORED != img_barrier.srcQueueFamilyIndex || |
| VK_QUEUE_FAMILY_IGNORED != img_barrier.dstQueueFamilyIndex) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| rp_handle, __LINE__, VALIDATION_ERROR_1b80093c, "CORE", |
| "%s: Barrier pImageMemoryBarriers[%d].srcQueueFamilyIndex is %d and " |
| "pImageMemoryBarriers[%d].dstQueueFamilyIndex is %d but both must be VK_QUEUE_FAMILY_IGNORED. %s", |
| funcName, i, img_barrier.srcQueueFamilyIndex, i, img_barrier.dstQueueFamilyIndex, |
| validation_error_map[VALIDATION_ERROR_1b80093c]); |
| } |
| // Secondary CBs can have null framebuffer so queue up validation in that case 'til FB is known |
| if (VK_NULL_HANDLE == cb_state->activeFramebuffer) { |
| assert(VK_COMMAND_BUFFER_LEVEL_SECONDARY == cb_state->createInfo.level); |
| // Secondary CB case w/o FB specified delay validation |
| cb_state->cmd_execute_commands_functions.emplace_back([=](VkFramebuffer fb) { |
| return ValidateImageBarrierImage(device_data, funcName, cb_state, fb, active_subpass, sub_desc, rp_handle, i, |
| img_barrier); |
| }); |
| } else { |
| skip |= ValidateImageBarrierImage(device_data, funcName, cb_state, cb_state->activeFramebuffer, active_subpass, |
| sub_desc, rp_handle, i, img_barrier); |
| } |
| } |
| return skip; |
| } |
| |
| // Validate VUs for Pipeline Barriers that are within a renderPass |
| // Pre: cb_state->activeRenderPass must be a pointer to valid renderPass state |
| static bool ValidateRenderPassPipelineBarriers(layer_data *device_data, const char *funcName, GLOBAL_CB_NODE *cb_state, |
| VkPipelineStageFlags src_stage_mask, VkPipelineStageFlags dst_stage_mask, |
| VkDependencyFlags dependency_flags, uint32_t mem_barrier_count, |
| const VkMemoryBarrier *mem_barriers, uint32_t buffer_mem_barrier_count, |
| const VkBufferMemoryBarrier *buffer_mem_barriers, uint32_t image_mem_barrier_count, |
| const VkImageMemoryBarrier *image_barriers) { |
| bool skip = false; |
| auto rp_state = cb_state->activeRenderPass; |
| const auto active_subpass = cb_state->activeSubpass; |
| auto rp_handle = HandleToUint64(rp_state->renderPass); |
| if (!rp_state->hasSelfDependency[active_subpass]) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| rp_handle, __LINE__, VALIDATION_ERROR_1b800928, "CORE", |
| "%s: Barriers cannot be set during subpass %d of renderPass 0x%" PRIx64 |
| " with no self-dependency specified. %s", |
| funcName, active_subpass, rp_handle, validation_error_map[VALIDATION_ERROR_1b800928]); |
| } else { |
| assert(rp_state->subpass_to_dependency_index[cb_state->activeSubpass] != -1); |
| // Grab ref to current subpassDescription up-front for use below |
| const auto &sub_desc = rp_state->createInfo.pSubpasses[active_subpass]; |
| const auto &sub_dep = rp_state->createInfo.pDependencies[rp_state->subpass_to_dependency_index[active_subpass]]; |
| const auto &sub_src_stage_mask = ExpandPipelineStageFlags(sub_dep.srcStageMask); |
| const auto &sub_dst_stage_mask = ExpandPipelineStageFlags(sub_dep.dstStageMask); |
| if ((sub_src_stage_mask != VK_PIPELINE_STAGE_ALL_COMMANDS_BIT) && |
| (src_stage_mask != (sub_src_stage_mask & src_stage_mask))) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| rp_handle, __LINE__, VALIDATION_ERROR_1b80092a, "CORE", |
| "%s: Barrier srcStageMask(0x%X) is not a subset of VkSubpassDependency srcStageMask(0x%X) of subpass " |
| "%d of renderPass 0x%" PRIx64 ". %s", |
| funcName, src_stage_mask, sub_src_stage_mask, active_subpass, rp_handle, |
| validation_error_map[VALIDATION_ERROR_1b80092a]); |
| } |
| if ((sub_dst_stage_mask != VK_PIPELINE_STAGE_ALL_COMMANDS_BIT) && |
| (dst_stage_mask != (sub_dst_stage_mask & dst_stage_mask))) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| rp_handle, __LINE__, VALIDATION_ERROR_1b80092c, "CORE", |
| "%s: Barrier dstStageMask(0x%X) is not a subset of VkSubpassDependency dstStageMask(0x%X) of subpass " |
| "%d of renderPass 0x%" PRIx64 ". %s", |
| funcName, dst_stage_mask, sub_dst_stage_mask, active_subpass, rp_handle, |
| validation_error_map[VALIDATION_ERROR_1b80092c]); |
| } |
| if (0 != buffer_mem_barrier_count) { |
| skip |= |
| log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| rp_handle, __LINE__, VALIDATION_ERROR_1b800934, "CORE", |
| "%s: bufferMemoryBarrierCount is non-zero (%d) for subpass %d of renderPass 0x%" PRIx64 ". %s", funcName, |
| buffer_mem_barrier_count, active_subpass, rp_handle, validation_error_map[VALIDATION_ERROR_1b800934]); |
| } |
| const auto &sub_src_access_mask = sub_dep.srcAccessMask; |
| const auto &sub_dst_access_mask = sub_dep.dstAccessMask; |
| for (uint32_t i = 0; i < mem_barrier_count; ++i) { |
| const auto &mb_src_access_mask = mem_barriers[i].srcAccessMask; |
| if (mb_src_access_mask != (sub_src_access_mask & mb_src_access_mask)) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, rp_handle, __LINE__, VALIDATION_ERROR_1b80092e, "CORE", |
| "%s: Barrier pMemoryBarriers[%d].srcAccessMask(0x%X) is not a subset of VkSubpassDependency " |
| "srcAccessMask(0x%X) of subpass %d of renderPass 0x%" PRIx64 ". %s", |
| funcName, i, mb_src_access_mask, sub_src_access_mask, active_subpass, rp_handle, |
| validation_error_map[VALIDATION_ERROR_1b80092e]); |
| } |
| const auto &mb_dst_access_mask = mem_barriers[i].dstAccessMask; |
| if (mb_dst_access_mask != (sub_dst_access_mask & mb_dst_access_mask)) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, rp_handle, __LINE__, VALIDATION_ERROR_1b800930, "CORE", |
| "%s: Barrier pMemoryBarriers[%d].dstAccessMask(0x%X) is not a subset of VkSubpassDependency " |
| "dstAccessMask(0x%X) of subpass %d of renderPass 0x%" PRIx64 ". %s", |
| funcName, i, mb_dst_access_mask, sub_dst_access_mask, active_subpass, rp_handle, |
| validation_error_map[VALIDATION_ERROR_1b800930]); |
| } |
| } |
| skip |= ValidateRenderPassImageBarriers(device_data, funcName, cb_state, active_subpass, sub_desc, rp_handle, |
| sub_src_access_mask, sub_dst_access_mask, image_mem_barrier_count, image_barriers); |
| if (sub_dep.dependencyFlags != dependency_flags) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| rp_handle, __LINE__, VALIDATION_ERROR_1b800932, "CORE", |
| "%s: dependencyFlags param (0x%X) does not equal VkSubpassDependency dependencyFlags value (0x%X) for " |
| "subpass %d of renderPass 0x%" PRIx64 ". %s", |
| funcName, dependency_flags, sub_dep.dependencyFlags, cb_state->activeSubpass, rp_handle, |
| validation_error_map[VALIDATION_ERROR_1b800932]); |
| } |
| } |
| return skip; |
| } |
| |
| // Array to mask individual accessMask to corresponding stageMask |
| // accessMask active bit position (0-31) maps to index |
| const static VkPipelineStageFlags AccessMaskToPipeStage[20] = { |
| // VK_ACCESS_INDIRECT_COMMAND_READ_BIT = 0 |
| VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT, |
| // VK_ACCESS_INDEX_READ_BIT = 1 |
| VK_PIPELINE_STAGE_VERTEX_INPUT_BIT, |
| // VK_ACCESS_VERTEX_ATTRIBUTE_READ_BIT = 2 |
| VK_PIPELINE_STAGE_VERTEX_INPUT_BIT, |
| // VK_ACCESS_UNIFORM_READ_BIT = 3 |
| VK_PIPELINE_STAGE_VERTEX_SHADER_BIT | VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT | |
| VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT | VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT | |
| VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT | VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, |
| // VK_ACCESS_INPUT_ATTACHMENT_READ_BIT = 4 |
| VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT, |
| // VK_ACCESS_SHADER_READ_BIT = 5 |
| VK_PIPELINE_STAGE_VERTEX_SHADER_BIT | VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT | |
| VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT | VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT | |
| VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT | VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, |
| // VK_ACCESS_SHADER_WRITE_BIT = 6 |
| VK_PIPELINE_STAGE_VERTEX_SHADER_BIT | VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT | |
| VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT | VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT | |
| VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT | VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, |
| // VK_ACCESS_COLOR_ATTACHMENT_READ_BIT = 7 |
| VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, |
| // VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT = 8 |
| VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, |
| // VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT = 9 |
| VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT | VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT, |
| // VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT = 10 |
| VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT | VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT, |
| // VK_ACCESS_TRANSFER_READ_BIT = 11 |
| VK_PIPELINE_STAGE_TRANSFER_BIT, |
| // VK_ACCESS_TRANSFER_WRITE_BIT = 12 |
| VK_PIPELINE_STAGE_TRANSFER_BIT, |
| // VK_ACCESS_HOST_READ_BIT = 13 |
| VK_PIPELINE_STAGE_HOST_BIT, |
| // VK_ACCESS_HOST_WRITE_BIT = 14 |
| VK_PIPELINE_STAGE_HOST_BIT, |
| // VK_ACCESS_MEMORY_READ_BIT = 15 |
| VK_ACCESS_FLAG_BITS_MAX_ENUM, // Always match |
| // VK_ACCESS_MEMORY_WRITE_BIT = 16 |
| VK_ACCESS_FLAG_BITS_MAX_ENUM, // Always match |
| // VK_ACCESS_COMMAND_PROCESS_READ_BIT_NVX = 17 |
| VK_PIPELINE_STAGE_COMMAND_PROCESS_BIT_NVX, |
| // VK_ACCESS_COMMAND_PROCESS_WRITE_BIT_NVX = 18 |
| VK_PIPELINE_STAGE_COMMAND_PROCESS_BIT_NVX, |
| }; |
| |
| // Verify that all bits of access_mask are supported by the src_stage_mask |
| static bool ValidateAccessMaskPipelineStage(VkAccessFlags access_mask, VkPipelineStageFlags stage_mask) { |
| // Early out if all commands set, or access_mask NULL |
| if ((stage_mask & VK_PIPELINE_STAGE_ALL_COMMANDS_BIT) || (0 == access_mask)) return true; |
| |
| stage_mask = ExpandPipelineStageFlags(stage_mask); |
| int index = 0; |
| // for each of the set bits in access_mask, make sure that supporting stage mask bit(s) are set |
| while (access_mask) { |
| index = (u_ffs(access_mask) - 1); |
| assert(index >= 0); |
| // Must have "!= 0" compare to prevent warning from MSVC |
| if ((AccessMaskToPipeStage[index] & stage_mask) == 0) return false; // early out |
| access_mask &= ~(1 << index); // Mask off bit that's been checked |
| } |
| return true; |
| } |
| |
| namespace barrier_queue_families { |
| enum VuIndex { |
| kSrcOrDstMustBeIgnore, |
| kSpecialOrIgnoreOnly, |
| kSrcIgnoreRequiresDstIgnore, |
| kDstValidOrSpecialIfNotIgnore, |
| kSrcValidOrSpecialIfNotIgnore, |
| kSrcAndDestMustBeIgnore, |
| kBothIgnoreOrBothValid, |
| kSubmitQueueMustMatchSrcOrDst |
| }; |
| static const char *vu_summary[] = {"Source or destination queue family must be ignored.", |
| "Source or destination queue family must be special or ignored.", |
| "Destination queue family must be ignored if source queue family is.", |
| "Destination queue family must be valid, ignored, or special.", |
| "Source queue family must be valid, ignored, or special.", |
| "Source and destination queue family must both be ignored.", |
| "Source and destination queue family must both be ignore or both valid.", |
| "Source or destination queue family must match submit queue family, if not ignored."}; |
| |
| static const UNIQUE_VALIDATION_ERROR_CODE image_error_codes[] = { |
| VALIDATION_ERROR_0a000aca, // VUID-VkImageMemoryBarrier-image-01381 -- kSrcOrDstMustBeIgnore |
| VALIDATION_ERROR_0a000dcc, // VUID-VkImageMemoryBarrier-image-01766 -- kSpecialOrIgnoreOnly |
| VALIDATION_ERROR_0a000962, // VUID-VkImageMemoryBarrier-image-01201 -- kSrcIgnoreRequiresDstIgnore |
| VALIDATION_ERROR_0a000dd0, // VUID-VkImageMemoryBarrier-image-01768 -- kDstValidOrSpecialIfNotIgnore |
| VALIDATION_ERROR_0a000dce, // VUID-VkImageMemoryBarrier-image-01767 -- kSrcValidOrSpecialIfNotIgnore |
| VALIDATION_ERROR_0a00095e, // VUID-VkImageMemoryBarrier-image-01199 -- kSrcAndDestMustBeIgnore |
| VALIDATION_ERROR_0a000960, // VUID-VkImageMemoryBarrier-image-01200 -- kBothIgnoreOrBothValid |
| VALIDATION_ERROR_0a00096a, // VUID-VkImageMemoryBarrier-image-01205 -- kSubmitQueueMustMatchSrcOrDst |
| }; |
| |
| static const UNIQUE_VALIDATION_ERROR_CODE buffer_error_codes[] = { |
| VALIDATION_ERROR_0180094e, // VUID-VkBufferMemoryBarrier-buffer-01191 -- kSrcOrDstMustBeIgnore |
| VALIDATION_ERROR_01800dc6, // VUID-VkBufferMemoryBarrier-buffer-01763 -- kSpecialOrIgnoreOnly |
| VALIDATION_ERROR_01800952, // VUID-VkBufferMemoryBarrier-buffer-01193 -- kSrcIgnoreRequiresDstIgnore |
| VALIDATION_ERROR_01800dca, // VUID-VkBufferMemoryBarrier-buffer-01765 -- kDstValidOrSpecialIfNotIgnore |
| VALIDATION_ERROR_01800dc8, // VUID-VkBufferMemoryBarrier-buffer-01764 -- kSrcValidOrSpecialIfNotIgnore |
| VALIDATION_ERROR_0180094c, // VUID-VkBufferMemoryBarrier-buffer-01190 -- kSrcAndDestMustBeIgnore |
| VALIDATION_ERROR_01800950, // VUID-VkBufferMemoryBarrier-buffer-01192 -- kBothIgnoreOrBothValid |
| VALIDATION_ERROR_01800958, // VUID-VkBufferMemoryBarrier-buffer-01196 -- kSubmitQueueMustMatchSrcOrDst |
| }; |
| |
| class ValidatorState { |
| public: |
| ValidatorState(const layer_data *device_data, const char *func_name, const GLOBAL_CB_NODE *cb_state, |
| const uint64_t barrier_handle64, const VkSharingMode sharing_mode, const VulkanObjectType object_type, |
| const UNIQUE_VALIDATION_ERROR_CODE *val_codes) |
| : report_data_(device_data->report_data), |
| func_name_(func_name), |
| cb_handle64_(HandleToUint64(cb_state->commandBuffer)), |
| barrier_handle64_(barrier_handle64), |
| sharing_mode_(sharing_mode), |
| object_type_(object_type), |
| val_codes_(val_codes), |
| limit_(static_cast<uint32_t>(device_data->phys_dev_properties.queue_family_properties.size())), |
| mem_ext_(device_data->extensions.vk_khr_external_memory) {} |
| |
| // Create a validator state from an image state... reducing the image specific to the generic version. |
| ValidatorState(const layer_data *device_data, const char *func_name, const GLOBAL_CB_NODE *cb_state, |
| const VkImageMemoryBarrier *barrier, const IMAGE_STATE *state) |
| : ValidatorState(device_data, func_name, cb_state, HandleToUint64(barrier->image), state->createInfo.sharingMode, |
| kVulkanObjectTypeImage, image_error_codes) {} |
| |
| // Create a validator state from an buffer state... reducing the buffer specific to the generic version. |
| ValidatorState(const layer_data *device_data, const char *func_name, const GLOBAL_CB_NODE *cb_state, |
| const VkBufferMemoryBarrier *barrier, const BUFFER_STATE *state) |
| : ValidatorState(device_data, func_name, cb_state, HandleToUint64(barrier->buffer), state->createInfo.sharingMode, |
| kVulkanObjectTypeImage, buffer_error_codes) {} |
| |
| // Log the messages using boilerplate from object state, and Vu specific information from the template arg |
| // One and two family versions, in the single family version, Vu holds the name of the passed parameter |
| bool LogMsg(VuIndex vu_index, size_t location, uint32_t family, const char *param_name) const { |
| const UNIQUE_VALIDATION_ERROR_CODE val_code = val_codes_[vu_index]; |
| const char *annotation = GetFamilyAnnotation(family); |
| return log_msg(report_data_, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, cb_handle64_, |
| location, val_code, "DS", |
| "%s: Barrier using %s 0x%" PRIx64 " created with sharingMode %s, has %s %u%s. %s %s", func_name_, |
| GetTypeString(), barrier_handle64_, GetModeString(), param_name, family, annotation, vu_summary[vu_index], |
| validation_error_map[val_code]); |
| } |
| |
| bool LogMsg(VuIndex vu_index, size_t location, uint32_t src_family, uint32_t dst_family) const { |
| const UNIQUE_VALIDATION_ERROR_CODE val_code = val_codes_[vu_index]; |
| const char *src_annotation = GetFamilyAnnotation(src_family); |
| const char *dst_annotation = GetFamilyAnnotation(dst_family); |
| return log_msg(report_data_, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, cb_handle64_, |
| location, val_code, "DS", |
| "%s: Barrier using %s 0x%" PRIx64 |
| " created with sharingMode %s, has srcQueueFamilyIndex %u%s and dstQueueFamilyIndex %u%s. %s %s", |
| func_name_, GetTypeString(), barrier_handle64_, GetModeString(), src_family, src_annotation, dst_family, |
| dst_annotation, vu_summary[vu_index], validation_error_map[val_code]); |
| } |
| |
| // This abstract Vu can only be tested at submit time, thus we need a callback from the closure containing the needed |
| // data. Note that the mem_barrier is copied to the closure as the lambda lifespan exceed the guarantees of validity for |
| // application input. |
| static bool ValidateAtQueueSubmit(const VkQueue queue, const layer_data *device_data, uint32_t src_family, uint32_t dst_family, |
| const ValidatorState &val) { |
| auto queue_data_it = device_data->queueMap.find(queue); |
| if (queue_data_it == device_data->queueMap.end()) return false; |
| |
| uint32_t queue_family = queue_data_it->second.queueFamilyIndex; |
| if ((src_family != queue_family) && (dst_family != queue_family)) { |
| const UNIQUE_VALIDATION_ERROR_CODE val_code = val.val_codes_[kSubmitQueueMustMatchSrcOrDst]; |
| const char *src_annotation = val.GetFamilyAnnotation(src_family); |
| const char *dst_annotation = val.GetFamilyAnnotation(dst_family); |
| return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, |
| HandleToUint64(queue), __LINE__, val_code, "DS", |
| "%s: Barrier submitted to queue with family index %u, using %s 0x%" PRIx64 |
| " created with sharingMode %s, has srcQueueFamilyIndex %u%s and dstQueueFamilyIndex %u%s. %s %s", |
| "vkQueueSubmit", queue_family, val.GetTypeString(), val.barrier_handle64_, val.GetModeString(), |
| src_family, src_annotation, dst_family, dst_annotation, vu_summary[kSubmitQueueMustMatchSrcOrDst], |
| validation_error_map[val_code]); |
| } |
| return false; |
| } |
| // Logical helpers for semantic clarity |
| inline bool KhrExternalMem() const { return mem_ext_; } |
| inline bool IsValid(uint32_t queue_family) const { return (queue_family < limit_); } |
| inline bool IsSpecial(uint32_t queue_family) const { |
| return (queue_family == VK_QUEUE_FAMILY_EXTERNAL_KHR) || (queue_family == VK_QUEUE_FAMILY_FOREIGN_EXT); |
| } |
| inline bool IsValidOrSpecial(uint32_t queue_family) const { |
| return IsValid(queue_family) || (mem_ext_ && IsSpecial(queue_family)); |
| } |
| inline bool IsIgnored(uint32_t queue_family) const { return queue_family == VK_QUEUE_FAMILY_IGNORED; } |
| |
| // Helpers for LogMsg (and log_msg) |
| const char *GetModeString() const { return string_VkSharingMode(sharing_mode_); } |
| |
| // Descriptive text for the various types of queue family index |
| const char *GetFamilyAnnotation(uint32_t family) const { |
| const char *external = " (VK_QUEUE_FAMILY_EXTERNAL_KHR)"; |
| const char *foreign = " (VK_QUEUE_FAMILY_FOREIGN_EXT)"; |
| const char *ignored = " (VK_QUEUE_FAMILY_IGNORED)"; |
| const char *valid = " (VALID)"; |
| const char *invalid = " (INVALID)"; |
| switch (family) { |
| case VK_QUEUE_FAMILY_EXTERNAL_KHR: |
| return external; |
| case VK_QUEUE_FAMILY_FOREIGN_EXT: |
| return foreign; |
| case VK_QUEUE_FAMILY_IGNORED: |
| return ignored; |
| default: |
| if (IsValid(family)) { |
| return valid; |
| } |
| return invalid; |
| }; |
| } |
| const char *GetTypeString() const { return object_string[object_type_]; } |
| VkSharingMode GetSharingMode() const { return sharing_mode_; } |
| |
| protected: |
| const debug_report_data *const report_data_; |
| const char *const func_name_; |
| const uint64_t cb_handle64_; |
| const uint64_t barrier_handle64_; |
| const VkSharingMode sharing_mode_; |
| const VulkanObjectType object_type_; |
| const UNIQUE_VALIDATION_ERROR_CODE *val_codes_; |
| const uint32_t limit_; |
| const bool mem_ext_; |
| }; |
| |
| bool Validate(const layer_data *device_data, const char *func_name, GLOBAL_CB_NODE *cb_state, const ValidatorState &val, |
| const uint32_t src_queue_family, const uint32_t dst_queue_family) { |
| bool skip = false; |
| |
| const bool mode_concurrent = val.GetSharingMode() == VK_SHARING_MODE_CONCURRENT; |
| const bool src_ignored = val.IsIgnored(src_queue_family); |
| const bool dst_ignored = val.IsIgnored(dst_queue_family); |
| if (val.KhrExternalMem()) { |
| if (mode_concurrent) { |
| if (!(src_ignored || dst_ignored)) { |
| skip |= val.LogMsg(kSrcOrDstMustBeIgnore, __LINE__, src_queue_family, dst_queue_family); |
| } |
| if ((src_ignored && !(dst_ignored || val.IsSpecial(dst_queue_family))) || |
| (dst_ignored && !(src_ignored || val.IsSpecial(src_queue_family)))) { |
| skip |= val.LogMsg(kSpecialOrIgnoreOnly, __LINE__, src_queue_family, dst_queue_family); |
| } |
| } else { |
| // VK_SHARING_MODE_EXCLUSIVE |
| if (src_ignored && !dst_ignored) { |
| skip |= val.LogMsg(kSrcIgnoreRequiresDstIgnore, __LINE__, src_queue_family, dst_queue_family); |
| } |
| if (!dst_ignored && !val.IsValidOrSpecial(dst_queue_family)) { |
| skip |= val.LogMsg(kDstValidOrSpecialIfNotIgnore, __LINE__, dst_queue_family, "dstQueueFamilyIndex"); |
| } |
| if (!src_ignored && !val.IsValidOrSpecial(src_queue_family)) { |
| skip |= val.LogMsg(kSrcValidOrSpecialIfNotIgnore, __LINE__, src_queue_family, "srcQueueFamilyIndex"); |
| } |
| } |
| } else { |
| // No memory extension |
| if (mode_concurrent) { |
| if (!src_ignored || !dst_ignored) { |
| skip |= val.LogMsg(kSrcAndDestMustBeIgnore, __LINE__, src_queue_family, dst_queue_family); |
| } |
| } else { |
| // VK_SHARING_MODE_EXCLUSIVE |
| if (!((src_ignored && dst_ignored) || (val.IsValid(src_queue_family) && val.IsValid(dst_queue_family)))) { |
| skip |= val.LogMsg(kBothIgnoreOrBothValid, __LINE__, src_queue_family, dst_queue_family); |
| } |
| } |
| } |
| if (!mode_concurrent && !src_ignored && !dst_ignored) { |
| // Only enqueue submit time check if it is needed. If more submit time checks are added, change the criteria |
| // TODO create a better named list, or rename the submit time lists to something that matches the broader usage... |
| // Note: if we want to create a semantic that separates state lookup, validation, and state update this should go |
| // to a local queue of update_state_actions or something. |
| cb_state->eventUpdates.emplace_back([device_data, src_queue_family, dst_queue_family, val](VkQueue queue) { |
| return ValidatorState::ValidateAtQueueSubmit(queue, device_data, src_queue_family, dst_queue_family, val); |
| }); |
| } |
| return skip; |
| } |
| } // namespace barrier_queue_families |
| |
| // Type specific wrapper for image barriers |
| bool ValidateBarrierQueueFamilies(const layer_data *device_data, const char *func_name, GLOBAL_CB_NODE *cb_state, |
| const VkImageMemoryBarrier *barrier, const IMAGE_STATE *state_data) { |
| // State data is required |
| if (!state_data) { |
| return false; |
| } |
| |
| // Create the validator state from the image state |
| barrier_queue_families::ValidatorState val(device_data, func_name, cb_state, barrier, state_data); |
| const uint32_t src_queue_family = barrier->srcQueueFamilyIndex; |
| const uint32_t dst_queue_family = barrier->dstQueueFamilyIndex; |
| return barrier_queue_families::Validate(device_data, func_name, cb_state, val, src_queue_family, dst_queue_family); |
| } |
| |
| // Type specific wrapper for buffer barriers |
| bool ValidateBarrierQueueFamilies(const layer_data *device_data, const char *func_name, GLOBAL_CB_NODE *cb_state, |
| const VkBufferMemoryBarrier *barrier, const BUFFER_STATE *state_data) { |
| // State data is required |
| if (!state_data) { |
| return false; |
| } |
| |
| // Create the validator state from the buffer state |
| barrier_queue_families::ValidatorState val(device_data, func_name, cb_state, barrier, state_data); |
| const uint32_t src_queue_family = barrier->srcQueueFamilyIndex; |
| const uint32_t dst_queue_family = barrier->dstQueueFamilyIndex; |
| return barrier_queue_families::Validate(device_data, func_name, cb_state, val, src_queue_family, dst_queue_family); |
| } |
| |
| static bool ValidateBarriers(layer_data *device_data, const char *funcName, GLOBAL_CB_NODE *cb_state, |
| VkPipelineStageFlags src_stage_mask, VkPipelineStageFlags dst_stage_mask, uint32_t memBarrierCount, |
| const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, |
| const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, |
| const VkImageMemoryBarrier *pImageMemBarriers) { |
| bool skip = false; |
| for (uint32_t i = 0; i < memBarrierCount; ++i) { |
| const auto &mem_barrier = pMemBarriers[i]; |
| if (!ValidateAccessMaskPipelineStage(mem_barrier.srcAccessMask, src_stage_mask)) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, VALIDATION_ERROR_1b800940, "DS", |
| "%s: pMemBarriers[%d].srcAccessMask (0x%X) is not supported by srcStageMask (0x%X). %s", funcName, i, |
| mem_barrier.srcAccessMask, src_stage_mask, validation_error_map[VALIDATION_ERROR_1b800940]); |
| } |
| if (!ValidateAccessMaskPipelineStage(mem_barrier.dstAccessMask, dst_stage_mask)) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, VALIDATION_ERROR_1b800942, "DS", |
| "%s: pMemBarriers[%d].dstAccessMask (0x%X) is not supported by dstStageMask (0x%X). %s", funcName, i, |
| mem_barrier.dstAccessMask, dst_stage_mask, validation_error_map[VALIDATION_ERROR_1b800942]); |
| } |
| } |
| for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { |
| auto mem_barrier = &pImageMemBarriers[i]; |
| if (!ValidateAccessMaskPipelineStage(mem_barrier->srcAccessMask, src_stage_mask)) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, VALIDATION_ERROR_1b800940, "DS", |
| "%s: pImageMemBarriers[%d].srcAccessMask (0x%X) is not supported by srcStageMask (0x%X). %s", funcName, |
| i, mem_barrier->srcAccessMask, src_stage_mask, validation_error_map[VALIDATION_ERROR_1b800940]); |
| } |
| if (!ValidateAccessMaskPipelineStage(mem_barrier->dstAccessMask, dst_stage_mask)) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, VALIDATION_ERROR_1b800942, "DS", |
| "%s: pImageMemBarriers[%d].dstAccessMask (0x%X) is not supported by dstStageMask (0x%X). %s", funcName, |
| i, mem_barrier->dstAccessMask, dst_stage_mask, validation_error_map[VALIDATION_ERROR_1b800942]); |
| } |
| |
| auto image_data = GetImageState(device_data, mem_barrier->image); |
| skip |= ValidateBarrierQueueFamilies(device_data, funcName, cb_state, mem_barrier, image_data); |
| |
| if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, VALIDATION_ERROR_0a00095c, "DS", |
| "%s: Image Layout cannot be transitioned to UNDEFINED or PREINITIALIZED. %s", funcName, |
| validation_error_map[VALIDATION_ERROR_0a00095c]); |
| } |
| |
| if (image_data) { |
| // There is no VUID for this, but there is blanket text: |
| // "Non-sparse resources must be bound completely and contiguously to a single VkDeviceMemory object before |
| // recording commands in a command buffer." |
| // TODO: Update this when VUID is defined |
| skip |= ValidateMemoryIsBoundToImage(device_data, image_data, funcName, VALIDATION_ERROR_UNDEFINED); |
| |
| auto aspect_mask = mem_barrier->subresourceRange.aspectMask; |
| skip |= ValidateImageAspectMask(device_data, image_data->image, image_data->createInfo.format, aspect_mask, funcName); |
| |
| std::string param_name = "pImageMemoryBarriers[" + std::to_string(i) + "].subresourceRange"; |
| skip |= ValidateImageBarrierSubresourceRange(device_data, image_data, mem_barrier->subresourceRange, funcName, |
| param_name.c_str()); |
| } |
| } |
| |
| for (uint32_t i = 0; i < bufferBarrierCount; ++i) { |
| auto mem_barrier = &pBufferMemBarriers[i]; |
| if (!mem_barrier) continue; |
| |
| if (!ValidateAccessMaskPipelineStage(mem_barrier->srcAccessMask, src_stage_mask)) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, VALIDATION_ERROR_1b800940, "DS", |
| "%s: pBufferMemBarriers[%d].srcAccessMask (0x%X) is not supported by srcStageMask (0x%X). %s", funcName, |
| i, mem_barrier->srcAccessMask, src_stage_mask, validation_error_map[VALIDATION_ERROR_1b800940]); |
| } |
| if (!ValidateAccessMaskPipelineStage(mem_barrier->dstAccessMask, dst_stage_mask)) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, VALIDATION_ERROR_1b800942, "DS", |
| "%s: pBufferMemBarriers[%d].dstAccessMask (0x%X) is not supported by dstStageMask (0x%X). %s", funcName, |
| i, mem_barrier->dstAccessMask, dst_stage_mask, validation_error_map[VALIDATION_ERROR_1b800942]); |
| } |
| // Validate buffer barrier queue family indices |
| auto buffer_state = GetBufferState(device_data, mem_barrier->buffer); |
| skip |= ValidateBarrierQueueFamilies(device_data, funcName, cb_state, mem_barrier, buffer_state); |
| |
| if (buffer_state) { |
| // There is no VUID for this, but there is blanket text: |
| // "Non-sparse resources must be bound completely and contiguously to a single VkDeviceMemory object before |
| // recording commands in a command buffer" |
| // TODO: Update this when VUID is defined |
| skip |= ValidateMemoryIsBoundToBuffer(device_data, buffer_state, funcName, VALIDATION_ERROR_UNDEFINED); |
| |
| auto buffer_size = buffer_state->createInfo.size; |
| if (mem_barrier->offset >= buffer_size) { |
| skip |= log_msg( |
| device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, VALIDATION_ERROR_01800946, "DS", |
| "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " which is not less than total size 0x%" PRIx64 ". %s", |
| funcName, HandleToUint64(mem_barrier->buffer), HandleToUint64(mem_barrier->offset), HandleToUint64(buffer_size), |
| validation_error_map[VALIDATION_ERROR_01800946]); |
| } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { |
| skip |= |
| log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(cb_state->commandBuffer), __LINE__, VALIDATION_ERROR_0180094a, "DS", |
| "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 |
| " whose sum is greater than total size 0x%" PRIx64 ". %s", |
| funcName, HandleToUint64(mem_barrier->buffer), HandleToUint64(mem_barrier->offset), |
| HandleToUint64(mem_barrier->size), HandleToUint64(buffer_size), |
| validation_error_map[VALIDATION_ERROR_0180094a]); |
| } |
| } |
| } |
| return skip; |
| } |
| |
| bool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, |
| VkPipelineStageFlags sourceStageMask) { |
| bool skip = false; |
| VkPipelineStageFlags stageMask = 0; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map); |
| for (uint32_t i = 0; i < eventCount; ++i) { |
| auto event = pCB->events[firstEventIndex + i]; |
| auto queue_data = dev_data->queueMap.find(queue); |
| if (queue_data == dev_data->queueMap.end()) return false; |
| auto event_data = queue_data->second.eventToStageMap.find(event); |
| if (event_data != queue_data->second.eventToStageMap.end()) { |
| stageMask |= event_data->second; |
| } else { |
| auto global_event_data = GetEventNode(dev_data, event); |
| if (!global_event_data) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, |
| HandleToUint64(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", |
| "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", HandleToUint64(event)); |
| } else { |
| stageMask |= global_event_data->stageMask; |
| } |
| } |
| } |
| // TODO: Need to validate that host_bit is only set if set event is called |
| // but set event can be called at any time. |
| if (sourceStageMask != stageMask && sourceStageMask != (stageMask | VK_PIPELINE_STAGE_HOST_BIT)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCB->commandBuffer), __LINE__, VALIDATION_ERROR_1e62d401, "DS", |
| "Submitting cmdbuffer with call to VkCmdWaitEvents using srcStageMask 0x%X which must be the bitwise OR of " |
| "the stageMask parameters used in calls to vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if used with " |
| "vkSetEvent but instead is 0x%X. %s", |
| sourceStageMask, stageMask, validation_error_map[VALIDATION_ERROR_1e62d401]); |
| } |
| return skip; |
| } |
| |
| // Note that we only check bits that HAVE required queueflags -- don't care entries are skipped |
| static std::unordered_map<VkPipelineStageFlags, VkQueueFlags> supported_pipeline_stages_table = { |
| {VK_PIPELINE_STAGE_COMMAND_PROCESS_BIT_NVX, VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT}, |
| {VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT, VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT}, |
| {VK_PIPELINE_STAGE_VERTEX_INPUT_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| {VK_PIPELINE_STAGE_VERTEX_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| {VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| {VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| {VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| {VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| {VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| {VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| {VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| {VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, VK_QUEUE_COMPUTE_BIT}, |
| {VK_PIPELINE_STAGE_TRANSFER_BIT, VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT | VK_QUEUE_TRANSFER_BIT}, |
| {VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT, VK_QUEUE_GRAPHICS_BIT}}; |
| |
| static const VkPipelineStageFlags stage_flag_bit_array[] = {VK_PIPELINE_STAGE_COMMAND_PROCESS_BIT_NVX, |
| VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT, |
| VK_PIPELINE_STAGE_VERTEX_INPUT_BIT, |
| VK_PIPELINE_STAGE_VERTEX_SHADER_BIT, |
| VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT, |
| VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT, |
| VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT, |
| VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT, |
| VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT, |
| VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT, |
| VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, |
| VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, |
| VK_PIPELINE_STAGE_TRANSFER_BIT, |
| VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT}; |
| |
| bool CheckStageMaskQueueCompatibility(layer_data *dev_data, VkCommandBuffer command_buffer, VkPipelineStageFlags stage_mask, |
| VkQueueFlags queue_flags, const char *function, const char *src_or_dest, |
| UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| bool skip = false; |
| // Lookup each bit in the stagemask and check for overlap between its table bits and queue_flags |
| for (const auto &item : stage_flag_bit_array) { |
| if (stage_mask & item) { |
| if ((supported_pipeline_stages_table[item] & queue_flags) == 0) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(command_buffer), __LINE__, error_code, "DL", |
| "%s(): %s flag %s is not compatible with the queue family properties of this command buffer. %s", |
| function, src_or_dest, string_VkPipelineStageFlagBits(static_cast<VkPipelineStageFlagBits>(item)), |
| validation_error_map[error_code]); |
| } |
| } |
| } |
| return skip; |
| } |
| |
| bool ValidateStageMasksAgainstQueueCapabilities(layer_data *dev_data, GLOBAL_CB_NODE const *cb_state, |
| VkPipelineStageFlags source_stage_mask, VkPipelineStageFlags dest_stage_mask, |
| const char *function, UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| bool skip = false; |
| uint32_t queue_family_index = dev_data->commandPoolMap[cb_state->createInfo.commandPool].queueFamilyIndex; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(dev_data->physical_device), instance_layer_data_map); |
| auto physical_device_state = GetPhysicalDeviceState(instance_data, dev_data->physical_device); |
| |
| // Any pipeline stage included in srcStageMask or dstStageMask must be supported by the capabilities of the queue family |
| // specified by the queueFamilyIndex member of the VkCommandPoolCreateInfo structure that was used to create the VkCommandPool |
| // that commandBuffer was allocated from, as specified in the table of supported pipeline stages. |
| |
| if (queue_family_index < physical_device_state->queue_family_properties.size()) { |
| VkQueueFlags specified_queue_flags = physical_device_state->queue_family_properties[queue_family_index].queueFlags; |
| |
| if ((source_stage_mask & VK_PIPELINE_STAGE_ALL_COMMANDS_BIT) == 0) { |
| skip |= CheckStageMaskQueueCompatibility(dev_data, cb_state->commandBuffer, source_stage_mask, specified_queue_flags, |
| function, "srcStageMask", error_code); |
| } |
| if ((dest_stage_mask & VK_PIPELINE_STAGE_ALL_COMMANDS_BIT) == 0) { |
| skip |= CheckStageMaskQueueCompatibility(dev_data, cb_state->commandBuffer, dest_stage_mask, specified_queue_flags, |
| function, "dstStageMask", error_code); |
| } |
| } |
| return skip; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, |
| VkPipelineStageFlags sourceStageMask, VkPipelineStageFlags dstStageMask, |
| uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, |
| uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, |
| uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *cb_state = GetCBNode(dev_data, commandBuffer); |
| if (cb_state) { |
| skip |= ValidateStageMasksAgainstQueueCapabilities(dev_data, cb_state, sourceStageMask, dstStageMask, "vkCmdWaitEvents", |
| VALIDATION_ERROR_1e600918); |
| skip |= ValidateStageMaskGsTsEnables(dev_data, sourceStageMask, "vkCmdWaitEvents()", VALIDATION_ERROR_1e60090e, |
| VALIDATION_ERROR_1e600912); |
| skip |= ValidateStageMaskGsTsEnables(dev_data, dstStageMask, "vkCmdWaitEvents()", VALIDATION_ERROR_1e600910, |
| VALIDATION_ERROR_1e600914); |
| skip |= ValidateCmdQueueFlags(dev_data, cb_state, "vkCmdWaitEvents()", VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| VALIDATION_ERROR_1e602415); |
| skip |= ValidateCmd(dev_data, cb_state, CMD_WAITEVENTS, "vkCmdWaitEvents()"); |
| skip |= ValidateBarriersToImages(dev_data, cb_state, imageMemoryBarrierCount, pImageMemoryBarriers, "vkCmdWaitEvents()"); |
| skip |= ValidateBarriers(dev_data, "vkCmdWaitEvents()", cb_state, sourceStageMask, dstStageMask, memoryBarrierCount, |
| pMemoryBarriers, bufferMemoryBarrierCount, pBufferMemoryBarriers, imageMemoryBarrierCount, |
| pImageMemoryBarriers); |
| if (!skip) { |
| auto first_event_index = cb_state->events.size(); |
| for (uint32_t i = 0; i < eventCount; ++i) { |
| auto event_state = GetEventNode(dev_data, pEvents[i]); |
| if (event_state) { |
| addCommandBufferBinding(&event_state->cb_bindings, {HandleToUint64(pEvents[i]), kVulkanObjectTypeEvent}, |
| cb_state); |
| event_state->cb_bindings.insert(cb_state); |
| } |
| cb_state->waitedEvents.insert(pEvents[i]); |
| cb_state->events.push_back(pEvents[i]); |
| } |
| cb_state->eventUpdates.emplace_back( |
| [=](VkQueue q) { return validateEventStageMask(q, cb_state, eventCount, first_event_index, sourceStageMask); }); |
| TransitionImageLayouts(dev_data, commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); |
| } |
| } |
| lock.unlock(); |
| if (!skip) |
| dev_data->dispatch_table.CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, |
| memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, pBufferMemoryBarriers, |
| imageMemoryBarrierCount, pImageMemoryBarriers); |
| } |
| |
| static bool PreCallValidateCmdPipelineBarrier(layer_data *device_data, GLOBAL_CB_NODE *cb_state, VkPipelineStageFlags srcStageMask, |
| VkPipelineStageFlags dstStageMask, VkDependencyFlags dependencyFlags, |
| uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, |
| uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, |
| uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { |
| bool skip = false; |
| skip |= ValidateStageMasksAgainstQueueCapabilities(device_data, cb_state, srcStageMask, dstStageMask, "vkCmdPipelineBarrier", |
| VALIDATION_ERROR_1b80093e); |
| skip |= ValidateCmdQueueFlags(device_data, cb_state, "vkCmdPipelineBarrier()", |
| VK_QUEUE_TRANSFER_BIT | VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, VALIDATION_ERROR_1b802415); |
| skip |= ValidateCmd(device_data, cb_state, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); |
| skip |= ValidateStageMaskGsTsEnables(device_data, srcStageMask, "vkCmdPipelineBarrier()", VALIDATION_ERROR_1b800920, |
| VALIDATION_ERROR_1b800924); |
| skip |= ValidateStageMaskGsTsEnables(device_data, dstStageMask, "vkCmdPipelineBarrier()", VALIDATION_ERROR_1b800922, |
| VALIDATION_ERROR_1b800926); |
| if (cb_state->activeRenderPass) { |
| skip |= ValidateRenderPassPipelineBarriers(device_data, "vkCmdPipelineBarrier()", cb_state, srcStageMask, dstStageMask, |
| dependencyFlags, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, |
| pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); |
| if (skip) return true; // Early return to avoid redundant errors from below calls |
| } |
| skip |= |
| ValidateBarriersToImages(device_data, cb_state, imageMemoryBarrierCount, pImageMemoryBarriers, "vkCmdPipelineBarrier()"); |
| skip |= ValidateBarriers(device_data, "vkCmdPipelineBarrier()", cb_state, srcStageMask, dstStageMask, memoryBarrierCount, |
| pMemoryBarriers, bufferMemoryBarrierCount, pBufferMemoryBarriers, imageMemoryBarrierCount, |
| pImageMemoryBarriers); |
| return skip; |
| } |
| |
| static void PreCallRecordCmdPipelineBarrier(layer_data *device_data, GLOBAL_CB_NODE *cb_state, VkCommandBuffer commandBuffer, |
| uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { |
| TransitionImageLayouts(device_data, commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, |
| VkPipelineStageFlags dstStageMask, VkDependencyFlags dependencyFlags, |
| uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, |
| uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, |
| uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { |
| bool skip = false; |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *cb_state = GetCBNode(device_data, commandBuffer); |
| if (cb_state) { |
| skip |= PreCallValidateCmdPipelineBarrier(device_data, cb_state, srcStageMask, dstStageMask, dependencyFlags, |
| memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, |
| pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); |
| if (!skip) { |
| PreCallRecordCmdPipelineBarrier(device_data, cb_state, commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); |
| } |
| } else { |
| assert(0); |
| } |
| lock.unlock(); |
| if (!skip) { |
| device_data->dispatch_table.CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, |
| memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, |
| pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); |
| } |
| } |
| |
| static bool setQueryState(VkQueue queue, VkCommandBuffer commandBuffer, QueryObject object, bool value) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| pCB->queryToStateMap[object] = value; |
| } |
| auto queue_data = dev_data->queueMap.find(queue); |
| if (queue_data != dev_data->queueMap.end()) { |
| queue_data->second.queryToStateMap[object] = value; |
| } |
| return false; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= ValidateCmdQueueFlags(dev_data, pCB, "vkCmdBeginQuery()", VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| VALIDATION_ERROR_17802415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); |
| } |
| lock.unlock(); |
| |
| if (skip) return; |
| |
| dev_data->dispatch_table.CmdBeginQuery(commandBuffer, queryPool, slot, flags); |
| |
| lock.lock(); |
| if (pCB) { |
| QueryObject query = {queryPool, slot}; |
| pCB->activeQueries.insert(query); |
| pCB->startedQueries.insert(query); |
| addCommandBufferBinding(&GetQueryPoolNode(dev_data, queryPool)->cb_bindings, |
| {HandleToUint64(queryPool), kVulkanObjectTypeQueryPool}, pCB); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| QueryObject query = {queryPool, slot}; |
| GLOBAL_CB_NODE *cb_state = GetCBNode(dev_data, commandBuffer); |
| if (cb_state) { |
| if (!cb_state->activeQueries.count(query)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1ae00652, "DS", |
| "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d. %s", |
| HandleToUint64(queryPool), slot, validation_error_map[VALIDATION_ERROR_1ae00652]); |
| } |
| skip |= ValidateCmdQueueFlags(dev_data, cb_state, "VkCmdEndQuery()", VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| VALIDATION_ERROR_1ae02415); |
| skip |= ValidateCmd(dev_data, cb_state, CMD_ENDQUERY, "VkCmdEndQuery()"); |
| } |
| lock.unlock(); |
| |
| if (skip) return; |
| |
| dev_data->dispatch_table.CmdEndQuery(commandBuffer, queryPool, slot); |
| |
| lock.lock(); |
| if (cb_state) { |
| cb_state->activeQueries.erase(query); |
| cb_state->queryUpdates.emplace_back([=](VkQueue q) { return setQueryState(q, commandBuffer, query, true); }); |
| addCommandBufferBinding(&GetQueryPoolNode(dev_data, queryPool)->cb_bindings, |
| {HandleToUint64(queryPool), kVulkanObjectTypeQueryPool}, cb_state); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, |
| uint32_t queryCount) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *cb_state = GetCBNode(dev_data, commandBuffer); |
| skip |= insideRenderPass(dev_data, cb_state, "vkCmdResetQueryPool()", VALIDATION_ERROR_1c600017); |
| skip |= ValidateCmd(dev_data, cb_state, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); |
| skip |= ValidateCmdQueueFlags(dev_data, cb_state, "VkCmdResetQueryPool()", VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| VALIDATION_ERROR_1c602415); |
| lock.unlock(); |
| |
| if (skip) return; |
| |
| dev_data->dispatch_table.CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); |
| |
| lock.lock(); |
| for (uint32_t i = 0; i < queryCount; i++) { |
| QueryObject query = {queryPool, firstQuery + i}; |
| cb_state->waitedEventsBeforeQueryReset[query] = cb_state->waitedEvents; |
| cb_state->queryUpdates.emplace_back([=](VkQueue q) { return setQueryState(q, commandBuffer, query, false); }); |
| } |
| addCommandBufferBinding(&GetQueryPoolNode(dev_data, queryPool)->cb_bindings, |
| {HandleToUint64(queryPool), kVulkanObjectTypeQueryPool}, cb_state); |
| } |
| |
| static bool IsQueryInvalid(layer_data *dev_data, QUEUE_STATE *queue_data, VkQueryPool queryPool, uint32_t queryIndex) { |
| QueryObject query = {queryPool, queryIndex}; |
| auto query_data = queue_data->queryToStateMap.find(query); |
| if (query_data != queue_data->queryToStateMap.end()) { |
| if (!query_data->second) return true; |
| } else { |
| auto it = dev_data->queryToStateMap.find(query); |
| if (it == dev_data->queryToStateMap.end() || !it->second) return true; |
| } |
| |
| return false; |
| } |
| |
| static bool validateQuery(VkQueue queue, GLOBAL_CB_NODE *pCB, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(pCB->commandBuffer), layer_data_map); |
| auto queue_data = GetQueueState(dev_data, queue); |
| if (!queue_data) return false; |
| for (uint32_t i = 0; i < queryCount; i++) { |
| if (IsQueryInvalid(dev_data, queue_data, queryPool, firstQuery + i)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUERY, "DS", |
| "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", |
| HandleToUint64(queryPool), firstQuery + i); |
| } |
| } |
| return skip; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, |
| uint32_t queryCount, VkBuffer dstBuffer, VkDeviceSize dstOffset, |
| VkDeviceSize stride, VkQueryResultFlags flags) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| |
| auto cb_node = GetCBNode(dev_data, commandBuffer); |
| auto dst_buff_state = GetBufferState(dev_data, dstBuffer); |
| if (cb_node && dst_buff_state) { |
| skip |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_state, "vkCmdCopyQueryPoolResults()", VALIDATION_ERROR_19400674); |
| // Validate that DST buffer has correct usage flags set |
| skip |= |
| ValidateBufferUsageFlags(dev_data, dst_buff_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, VALIDATION_ERROR_19400672, |
| "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
| skip |= ValidateCmdQueueFlags(dev_data, cb_node, "vkCmdCopyQueryPoolResults()", |
| VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, VALIDATION_ERROR_19402415); |
| skip |= ValidateCmd(dev_data, cb_node, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); |
| skip |= insideRenderPass(dev_data, cb_node, "vkCmdCopyQueryPoolResults()", VALIDATION_ERROR_19400017); |
| } |
| lock.unlock(); |
| |
| if (skip) return; |
| |
| dev_data->dispatch_table.CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, dstOffset, stride, |
| flags); |
| |
| lock.lock(); |
| if (cb_node && dst_buff_state) { |
| AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_state); |
| cb_node->queue_submit_functions.emplace_back([=]() { |
| SetBufferMemoryValid(dev_data, dst_buff_state, true); |
| return false; |
| }); |
| cb_node->queryUpdates.emplace_back([=](VkQueue q) { return validateQuery(q, cb_node, queryPool, firstQuery, queryCount); }); |
| addCommandBufferBinding(&GetQueryPoolNode(dev_data, queryPool)->cb_bindings, |
| {HandleToUint64(queryPool), kVulkanObjectTypeQueryPool}, cb_node); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, VkShaderStageFlags stageFlags, |
| uint32_t offset, uint32_t size, const void *pValues) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *cb_state = GetCBNode(dev_data, commandBuffer); |
| if (cb_state) { |
| skip |= ValidateCmdQueueFlags(dev_data, cb_state, "vkCmdPushConstants()", VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| VALIDATION_ERROR_1bc02415); |
| skip |= ValidateCmd(dev_data, cb_state, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); |
| } |
| skip |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); |
| if (0 == stageFlags) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1bc2dc03, "DS", |
| "vkCmdPushConstants() call has no stageFlags set. %s", validation_error_map[VALIDATION_ERROR_1bc2dc03]); |
| } |
| |
| // Check if specified push constant range falls within a pipeline-defined range which has matching stageFlags. |
| // The spec doesn't seem to disallow having multiple push constant ranges with the |
| // same offset and size, but different stageFlags. So we can't just check the |
| // stageFlags in the first range with matching offset and size. |
| if (!skip) { |
| const auto &ranges = getPipelineLayout(dev_data, layout)->push_constant_ranges; |
| bool found_matching_range = false; |
| for (const auto &range : ranges) { |
| if ((stageFlags == range.stageFlags) && (offset >= range.offset) && (offset + size <= range.offset + range.size)) { |
| found_matching_range = true; |
| break; |
| } |
| } |
| if (!found_matching_range) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1bc002de, "DS", |
| "vkCmdPushConstants() stageFlags = 0x%" PRIx32 |
| " do not match the stageFlags in any of the ranges with offset = %d and size = %d in pipeline layout 0x%" PRIx64 |
| ". %s", |
| (uint32_t)stageFlags, offset, size, HandleToUint64(layout), validation_error_map[VALIDATION_ERROR_1bc002de]); |
| } |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, |
| VkQueryPool queryPool, uint32_t slot) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *cb_state = GetCBNode(dev_data, commandBuffer); |
| if (cb_state) { |
| skip |= ValidateCmdQueueFlags(dev_data, cb_state, "vkCmdWriteTimestamp()", VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| VALIDATION_ERROR_1e802415); |
| skip |= ValidateCmd(dev_data, cb_state, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); |
| } |
| lock.unlock(); |
| |
| if (skip) return; |
| |
| dev_data->dispatch_table.CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); |
| |
| lock.lock(); |
| if (cb_state) { |
| QueryObject query = {queryPool, slot}; |
| cb_state->queryUpdates.emplace_back([=](VkQueue q) { return setQueryState(q, commandBuffer, query, true); }); |
| } |
| } |
| |
| static bool MatchUsage(layer_data *dev_data, uint32_t count, const VkAttachmentReference *attachments, |
| const VkFramebufferCreateInfo *fbci, VkImageUsageFlagBits usage_flag, |
| UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| bool skip = false; |
| |
| for (uint32_t attach = 0; attach < count; attach++) { |
| if (attachments[attach].attachment != VK_ATTACHMENT_UNUSED) { |
| // Attachment counts are verified elsewhere, but prevent an invalid access |
| if (attachments[attach].attachment < fbci->attachmentCount) { |
| const VkImageView *image_view = &fbci->pAttachments[attachments[attach].attachment]; |
| auto view_state = GetImageViewState(dev_data, *image_view); |
| if (view_state) { |
| const VkImageCreateInfo *ici = &GetImageState(dev_data, view_state->create_info.image)->createInfo; |
| if (ici != nullptr) { |
| if ((ici->usage & usage_flag) == 0) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, error_code, "DS", |
| "vkCreateFramebuffer: Framebuffer Attachment (%d) conflicts with the image's " |
| "IMAGE_USAGE flags (%s). %s", |
| attachments[attach].attachment, string_VkImageUsageFlagBits(usage_flag), |
| validation_error_map[error_code]); |
| } |
| } |
| } |
| } |
| } |
| } |
| return skip; |
| } |
| |
| // Validate VkFramebufferCreateInfo which includes: |
| // 1. attachmentCount equals renderPass attachmentCount |
| // 2. corresponding framebuffer and renderpass attachments have matching formats |
| // 3. corresponding framebuffer and renderpass attachments have matching sample counts |
| // 4. fb attachments only have a single mip level |
| // 5. fb attachment dimensions are each at least as large as the fb |
| // 6. fb attachments use idenity swizzle |
| // 7. fb attachments used by renderPass for color/input/ds have correct usage bit set |
| // 8. fb dimensions are within physical device limits |
| static bool ValidateFramebufferCreateInfo(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { |
| bool skip = false; |
| |
| auto rp_state = GetRenderPassState(dev_data, pCreateInfo->renderPass); |
| if (rp_state) { |
| const VkRenderPassCreateInfo *rpci = rp_state->createInfo.ptr(); |
| if (rpci->attachmentCount != pCreateInfo->attachmentCount) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| HandleToUint64(pCreateInfo->renderPass), __LINE__, VALIDATION_ERROR_094006d8, "DS", |
| "vkCreateFramebuffer(): VkFramebufferCreateInfo attachmentCount of %u does not match attachmentCount " |
| "of %u of renderPass (0x%" PRIx64 ") being used to create Framebuffer. %s", |
| pCreateInfo->attachmentCount, rpci->attachmentCount, HandleToUint64(pCreateInfo->renderPass), |
| validation_error_map[VALIDATION_ERROR_094006d8]); |
| } else { |
| // attachmentCounts match, so make sure corresponding attachment details line up |
| const VkImageView *image_views = pCreateInfo->pAttachments; |
| for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { |
| auto view_state = GetImageViewState(dev_data, image_views[i]); |
| auto &ivci = view_state->create_info; |
| if (ivci.format != rpci->pAttachments[i].format) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| HandleToUint64(pCreateInfo->renderPass), __LINE__, VALIDATION_ERROR_094006e0, "DS", |
| "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has format of %s that does not " |
| "match the format of %s used by the corresponding attachment for renderPass (0x%" PRIx64 "). %s", |
| i, string_VkFormat(ivci.format), string_VkFormat(rpci->pAttachments[i].format), |
| HandleToUint64(pCreateInfo->renderPass), validation_error_map[VALIDATION_ERROR_094006e0]); |
| } |
| const VkImageCreateInfo *ici = &GetImageState(dev_data, ivci.image)->createInfo; |
| if (ici->samples != rpci->pAttachments[i].samples) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| HandleToUint64(pCreateInfo->renderPass), __LINE__, VALIDATION_ERROR_094006e2, "DS", |
| "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has %s samples that do not match the %s " |
| "samples used by the corresponding attachment for renderPass (0x%" PRIx64 "). %s", |
| i, string_VkSampleCountFlagBits(ici->samples), string_VkSampleCountFlagBits(rpci->pAttachments[i].samples), |
| HandleToUint64(pCreateInfo->renderPass), validation_error_map[VALIDATION_ERROR_094006e2]); |
| } |
| // Verify that view only has a single mip level |
| if (ivci.subresourceRange.levelCount != 1) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 0, __LINE__, VALIDATION_ERROR_094006e6, "DS", |
| "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has mip levelCount of %u but " |
| "only a single mip level (levelCount == 1) is allowed when creating a Framebuffer. %s", |
| i, ivci.subresourceRange.levelCount, validation_error_map[VALIDATION_ERROR_094006e6]); |
| } |
| const uint32_t mip_level = ivci.subresourceRange.baseMipLevel; |
| uint32_t mip_width = max(1u, ici->extent.width >> mip_level); |
| uint32_t mip_height = max(1u, ici->extent.height >> mip_level); |
| if ((ivci.subresourceRange.layerCount < pCreateInfo->layers) || (mip_width < pCreateInfo->width) || |
| (mip_height < pCreateInfo->height)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 0, __LINE__, VALIDATION_ERROR_094006e4, "DS", |
| "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u mip level %u has dimensions " |
| "smaller than the corresponding framebuffer dimensions. Here are the respective dimensions for " |
| "attachment #%u, framebuffer:\n" |
| "width: %u, %u\n" |
| "height: %u, %u\n" |
| "layerCount: %u, %u\n%s", |
| i, ivci.subresourceRange.baseMipLevel, i, mip_width, pCreateInfo->width, mip_height, |
| pCreateInfo->height, ivci.subresourceRange.layerCount, pCreateInfo->layers, |
| validation_error_map[VALIDATION_ERROR_094006e4]); |
| } |
| if (((ivci.components.r != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.r != VK_COMPONENT_SWIZZLE_R)) || |
| ((ivci.components.g != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.g != VK_COMPONENT_SWIZZLE_G)) || |
| ((ivci.components.b != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.b != VK_COMPONENT_SWIZZLE_B)) || |
| ((ivci.components.a != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.a != VK_COMPONENT_SWIZZLE_A))) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 0, __LINE__, VALIDATION_ERROR_094006e8, "DS", |
| "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has non-identy swizzle. All " |
| "framebuffer attachments must have been created with the identity swizzle. Here are the actual " |
| "swizzle values:\n" |
| "r swizzle = %s\n" |
| "g swizzle = %s\n" |
| "b swizzle = %s\n" |
| "a swizzle = %s\n" |
| "%s", |
| i, string_VkComponentSwizzle(ivci.components.r), string_VkComponentSwizzle(ivci.components.g), |
| string_VkComponentSwizzle(ivci.components.b), string_VkComponentSwizzle(ivci.components.a), |
| validation_error_map[VALIDATION_ERROR_094006e8]); |
| } |
| } |
| } |
| // Verify correct attachment usage flags |
| for (uint32_t subpass = 0; subpass < rpci->subpassCount; subpass++) { |
| // Verify input attachments: |
| skip |= |
| MatchUsage(dev_data, rpci->pSubpasses[subpass].inputAttachmentCount, rpci->pSubpasses[subpass].pInputAttachments, |
| pCreateInfo, VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT, VALIDATION_ERROR_094006de); |
| // Verify color attachments: |
| skip |= |
| MatchUsage(dev_data, rpci->pSubpasses[subpass].colorAttachmentCount, rpci->pSubpasses[subpass].pColorAttachments, |
| pCreateInfo, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, VALIDATION_ERROR_094006da); |
| // Verify depth/stencil attachments: |
| if (rpci->pSubpasses[subpass].pDepthStencilAttachment != nullptr) { |
| skip |= MatchUsage(dev_data, 1, rpci->pSubpasses[subpass].pDepthStencilAttachment, pCreateInfo, |
| VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT, VALIDATION_ERROR_094006dc); |
| } |
| } |
| } |
| // Verify FB dimensions are within physical device limits |
| if (pCreateInfo->width > dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_094006ec, "DS", |
| "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo width exceeds physical device limits. Requested " |
| "width: %u, device max: %u\n%s", |
| pCreateInfo->width, dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth, |
| validation_error_map[VALIDATION_ERROR_094006ec]); |
| } |
| if (pCreateInfo->height > dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_094006f0, "DS", |
| "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo height exceeds physical device limits. Requested " |
| "height: %u, device max: %u\n%s", |
| pCreateInfo->height, dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight, |
| validation_error_map[VALIDATION_ERROR_094006f0]); |
| } |
| if (pCreateInfo->layers > dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_094006f4, "DS", |
| "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo layers exceeds physical device limits. Requested " |
| "layers: %u, device max: %u\n%s", |
| pCreateInfo->layers, dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers, |
| validation_error_map[VALIDATION_ERROR_094006f4]); |
| } |
| // Verify FB dimensions are greater than zero |
| if (pCreateInfo->width <= 0) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_094006ea, "DS", |
| "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo width must be greater than zero. %s", |
| validation_error_map[VALIDATION_ERROR_094006ea]); |
| } |
| if (pCreateInfo->height <= 0) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_094006ee, "DS", |
| "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo height must be greater than zero. %s", |
| validation_error_map[VALIDATION_ERROR_094006ee]); |
| } |
| if (pCreateInfo->layers <= 0) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_094006f2, "DS", |
| "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo layers must be greater than zero. %s", |
| validation_error_map[VALIDATION_ERROR_094006f2]); |
| } |
| return skip; |
| } |
| |
| // Validate VkFramebufferCreateInfo state prior to calling down chain to create Framebuffer object |
| // Return true if an error is encountered and callback returns true to skip call down chain |
| // false indicates that call down chain should proceed |
| static bool PreCallValidateCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { |
| // TODO : Verify that renderPass FB is created with is compatible with FB |
| bool skip = false; |
| skip |= ValidateFramebufferCreateInfo(dev_data, pCreateInfo); |
| return skip; |
| } |
| |
| // CreateFramebuffer state has been validated and call down chain completed so record new framebuffer object |
| static void PostCallRecordCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo, VkFramebuffer fb) { |
| // Shadow create info and store in map |
| std::unique_ptr<FRAMEBUFFER_STATE> fb_state( |
| new FRAMEBUFFER_STATE(fb, pCreateInfo, GetRenderPassStateSharedPtr(dev_data, pCreateInfo->renderPass))); |
| |
| for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { |
| VkImageView view = pCreateInfo->pAttachments[i]; |
| auto view_state = GetImageViewState(dev_data, view); |
| if (!view_state) { |
| continue; |
| } |
| MT_FB_ATTACHMENT_INFO fb_info; |
| fb_info.view_state = view_state; |
| fb_info.image = view_state->create_info.image; |
| fb_state->attachments.push_back(fb_info); |
| } |
| dev_data->frameBufferMap[fb] = std::move(fb_state); |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkFramebuffer *pFramebuffer) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateCreateFramebuffer(dev_data, pCreateInfo); |
| lock.unlock(); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| VkResult result = dev_data->dispatch_table.CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); |
| |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| PostCallRecordCreateFramebuffer(dev_data, pCreateInfo, *pFramebuffer); |
| lock.unlock(); |
| } |
| return result; |
| } |
| |
| static bool FindDependency(const uint32_t index, const uint32_t dependent, const std::vector<DAGNode> &subpass_to_node, |
| std::unordered_set<uint32_t> &processed_nodes) { |
| // If we have already checked this node we have not found a dependency path so return false. |
| if (processed_nodes.count(index)) return false; |
| processed_nodes.insert(index); |
| const DAGNode &node = subpass_to_node[index]; |
| // Look for a dependency path. If one exists return true else recurse on the previous nodes. |
| if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { |
| for (auto elem : node.prev) { |
| if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) return true; |
| } |
| } else { |
| return true; |
| } |
| return false; |
| } |
| |
| static bool CheckDependencyExists(const layer_data *dev_data, const uint32_t subpass, |
| const std::vector<uint32_t> &dependent_subpasses, const std::vector<DAGNode> &subpass_to_node, |
| bool &skip) { |
| bool result = true; |
| // Loop through all subpasses that share the same attachment and make sure a dependency exists |
| for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { |
| if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) continue; |
| const DAGNode &node = subpass_to_node[subpass]; |
| // Check for a specified dependency between the two nodes. If one exists we are done. |
| auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); |
| auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); |
| if (prev_elem == node.prev.end() && next_elem == node.next.end()) { |
| // If no dependency exits an implicit dependency still might. If not, throw an error. |
| std::unordered_set<uint32_t> processed_nodes; |
| if (!(FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || |
| FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes))) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", |
| "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, |
| dependent_subpasses[k]); |
| result = false; |
| } |
| } |
| } |
| return result; |
| } |
| |
| static bool CheckPreserved(const layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, |
| const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip) { |
| const DAGNode &node = subpass_to_node[index]; |
| // If this node writes to the attachment return true as next nodes need to preserve the attachment. |
| const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; |
| for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| if (attachment == subpass.pColorAttachments[j].attachment) return true; |
| } |
| for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| if (attachment == subpass.pInputAttachments[j].attachment) return true; |
| } |
| if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| if (attachment == subpass.pDepthStencilAttachment->attachment) return true; |
| } |
| bool result = false; |
| // Loop through previous nodes and see if any of them write to the attachment. |
| for (auto elem : node.prev) { |
| result |= CheckPreserved(dev_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip); |
| } |
| // If the attachment was written to by a previous node than this node needs to preserve it. |
| if (result && depth > 0) { |
| bool has_preserved = false; |
| for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { |
| if (subpass.pPreserveAttachments[j] == attachment) { |
| has_preserved = true; |
| break; |
| } |
| } |
| if (!has_preserved) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", |
| "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); |
| } |
| } |
| return result; |
| } |
| |
| template <class T> |
| bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { |
| return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || |
| ((offset1 > offset2) && (offset1 < (offset2 + size2))); |
| } |
| |
| bool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { |
| return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && |
| isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); |
| } |
| |
| static bool ValidateDependencies(const layer_data *dev_data, FRAMEBUFFER_STATE const *framebuffer, |
| RENDER_PASS_STATE const *renderPass) { |
| bool skip = false; |
| auto const pFramebufferInfo = framebuffer->createInfo.ptr(); |
| auto const pCreateInfo = renderPass->createInfo.ptr(); |
| auto const &subpass_to_node = renderPass->subpassToNode; |
| std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); |
| std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); |
| std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); |
| // Find overlapping attachments |
| for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { |
| for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { |
| VkImageView viewi = pFramebufferInfo->pAttachments[i]; |
| VkImageView viewj = pFramebufferInfo->pAttachments[j]; |
| if (viewi == viewj) { |
| overlapping_attachments[i].push_back(j); |
| overlapping_attachments[j].push_back(i); |
| continue; |
| } |
| auto view_state_i = GetImageViewState(dev_data, viewi); |
| auto view_state_j = GetImageViewState(dev_data, viewj); |
| if (!view_state_i || !view_state_j) { |
| continue; |
| } |
| auto view_ci_i = view_state_i->create_info; |
| auto view_ci_j = view_state_j->create_info; |
| if (view_ci_i.image == view_ci_j.image && isRegionOverlapping(view_ci_i.subresourceRange, view_ci_j.subresourceRange)) { |
| overlapping_attachments[i].push_back(j); |
| overlapping_attachments[j].push_back(i); |
| continue; |
| } |
| auto image_data_i = GetImageState(dev_data, view_ci_i.image); |
| auto image_data_j = GetImageState(dev_data, view_ci_j.image); |
| if (!image_data_i || !image_data_j) { |
| continue; |
| } |
| if (image_data_i->binding.mem == image_data_j->binding.mem && |
| isRangeOverlapping(image_data_i->binding.offset, image_data_i->binding.size, image_data_j->binding.offset, |
| image_data_j->binding.size)) { |
| overlapping_attachments[i].push_back(j); |
| overlapping_attachments[j].push_back(i); |
| } |
| } |
| } |
| for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { |
| uint32_t attachment = i; |
| for (auto other_attachment : overlapping_attachments[i]) { |
| if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT, |
| HandleToUint64(framebuffer->framebuffer), __LINE__, VALIDATION_ERROR_12200682, "DS", |
| "Attachment %d aliases attachment %d but doesn't set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT. %s", |
| attachment, other_attachment, validation_error_map[VALIDATION_ERROR_12200682]); |
| } |
| if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT, |
| HandleToUint64(framebuffer->framebuffer), __LINE__, VALIDATION_ERROR_12200682, "DS", |
| "Attachment %d aliases attachment %d but doesn't set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT. %s", |
| other_attachment, attachment, validation_error_map[VALIDATION_ERROR_12200682]); |
| } |
| } |
| } |
| // Find for each attachment the subpasses that use them. |
| unordered_set<uint32_t> attachmentIndices; |
| for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
| attachmentIndices.clear(); |
| for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| uint32_t attachment = subpass.pInputAttachments[j].attachment; |
| if (attachment == VK_ATTACHMENT_UNUSED) continue; |
| input_attachment_to_subpass[attachment].push_back(i); |
| for (auto overlapping_attachment : overlapping_attachments[attachment]) { |
| input_attachment_to_subpass[overlapping_attachment].push_back(i); |
| } |
| } |
| for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| uint32_t attachment = subpass.pColorAttachments[j].attachment; |
| if (attachment == VK_ATTACHMENT_UNUSED) continue; |
| output_attachment_to_subpass[attachment].push_back(i); |
| for (auto overlapping_attachment : overlapping_attachments[attachment]) { |
| output_attachment_to_subpass[overlapping_attachment].push_back(i); |
| } |
| attachmentIndices.insert(attachment); |
| } |
| if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| uint32_t attachment = subpass.pDepthStencilAttachment->attachment; |
| output_attachment_to_subpass[attachment].push_back(i); |
| for (auto overlapping_attachment : overlapping_attachments[attachment]) { |
| output_attachment_to_subpass[overlapping_attachment].push_back(i); |
| } |
| |
| if (attachmentIndices.count(attachment)) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", |
| "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", attachment, i); |
| } |
| } |
| } |
| // If there is a dependency needed make sure one exists |
| for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
| // If the attachment is an input then all subpasses that output must have a dependency relationship |
| for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| uint32_t attachment = subpass.pInputAttachments[j].attachment; |
| if (attachment == VK_ATTACHMENT_UNUSED) continue; |
| CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip); |
| } |
| // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship |
| for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| uint32_t attachment = subpass.pColorAttachments[j].attachment; |
| if (attachment == VK_ATTACHMENT_UNUSED) continue; |
| CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip); |
| CheckDependencyExists(dev_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip); |
| } |
| if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; |
| CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip); |
| CheckDependencyExists(dev_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip); |
| } |
| } |
| // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was |
| // written. |
| for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
| for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| CheckPreserved(dev_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip); |
| } |
| } |
| return skip; |
| } |
| |
| static bool CreatePassDAG(const layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo, |
| std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency, |
| std::vector<int32_t> &subpass_to_dep_index) { |
| bool skip = false; |
| for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| DAGNode &subpass_node = subpass_to_node[i]; |
| subpass_node.pass = i; |
| subpass_to_dep_index[i] = -1; // Default to no dependency and overwrite below as needed |
| } |
| for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { |
| const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; |
| if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL || dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { |
| if (dependency.srcSubpass == dependency.dstSubpass) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); |
| } |
| } else if (dependency.srcSubpass > dependency.dstSubpass) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", |
| "Dependency graph must be specified such that an earlier pass cannot depend on a later pass."); |
| } else if (dependency.srcSubpass == dependency.dstSubpass) { |
| has_self_dependency[dependency.srcSubpass] = true; |
| subpass_to_dep_index[dependency.srcSubpass] = i; |
| } else { |
| subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); |
| subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); |
| } |
| } |
| return skip; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkShaderModule *pShaderModule) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool spirv_valid; |
| |
| if (PreCallValidateCreateShaderModule(dev_data, pCreateInfo, &spirv_valid)) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| VkResult res = dev_data->dispatch_table.CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); |
| |
| if (res == VK_SUCCESS) { |
| lock_guard_t lock(global_lock); |
| unique_ptr<shader_module> new_shader_module(spirv_valid ? new shader_module(pCreateInfo) : new shader_module()); |
| dev_data->shaderModuleMap[*pShaderModule] = std::move(new_shader_module); |
| } |
| return res; |
| } |
| |
| static bool ValidateAttachmentIndex(layer_data *dev_data, uint32_t attachment, uint32_t attachment_count, const char *type) { |
| bool skip = false; |
| if (attachment >= attachment_count && attachment != VK_ATTACHMENT_UNUSED) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_12200684, "DS", |
| "CreateRenderPass: %s attachment %d must be less than the total number of attachments %d. %s", type, |
| attachment, attachment_count, validation_error_map[VALIDATION_ERROR_12200684]); |
| } |
| return skip; |
| } |
| |
| static bool IsPowerOfTwo(unsigned x) { return x && !(x & (x - 1)); } |
| |
| static bool ValidateRenderpassAttachmentUsage(layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo) { |
| bool skip = false; |
| for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
| if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_14000698, "DS", |
| "CreateRenderPass: Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS. %s", i, |
| validation_error_map[VALIDATION_ERROR_14000698]); |
| } |
| |
| for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { |
| uint32_t attachment = subpass.pPreserveAttachments[j]; |
| if (attachment == VK_ATTACHMENT_UNUSED) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_140006aa, "DS", |
| "CreateRenderPass: Preserve attachment (%d) must not be VK_ATTACHMENT_UNUSED. %s", j, |
| validation_error_map[VALIDATION_ERROR_140006aa]); |
| } else { |
| skip |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Preserve"); |
| |
| bool found = (subpass.pDepthStencilAttachment != NULL && subpass.pDepthStencilAttachment->attachment == attachment); |
| for (uint32_t r = 0; !found && r < subpass.inputAttachmentCount; ++r) { |
| found = (subpass.pInputAttachments[r].attachment == attachment); |
| } |
| for (uint32_t r = 0; !found && r < subpass.colorAttachmentCount; ++r) { |
| found = (subpass.pColorAttachments[r].attachment == attachment) || |
| (subpass.pResolveAttachments != NULL && subpass.pResolveAttachments[r].attachment == attachment); |
| } |
| if (found) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| VALIDATION_ERROR_140006ac, "DS", |
| "CreateRenderPass: subpass %u pPreserveAttachments[%u] (%u) must not be used elsewhere in the subpass. %s", |
| i, j, attachment, validation_error_map[VALIDATION_ERROR_140006ac]); |
| } |
| } |
| } |
| |
| auto subpass_performs_resolve = |
| subpass.pResolveAttachments && |
| std::any_of(subpass.pResolveAttachments, subpass.pResolveAttachments + subpass.colorAttachmentCount, |
| [](VkAttachmentReference ref) { return ref.attachment != VK_ATTACHMENT_UNUSED; }); |
| |
| unsigned sample_count = 0; |
| |
| for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| uint32_t attachment; |
| if (subpass.pResolveAttachments) { |
| attachment = subpass.pResolveAttachments[j].attachment; |
| skip |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Resolve"); |
| |
| if (!skip && attachment != VK_ATTACHMENT_UNUSED && |
| pCreateInfo->pAttachments[attachment].samples != VK_SAMPLE_COUNT_1_BIT) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 0, __LINE__, VALIDATION_ERROR_140006a2, "DS", |
| "CreateRenderPass: Subpass %u requests multisample resolve into attachment %u, which must " |
| "have VK_SAMPLE_COUNT_1_BIT but has %s. %s", |
| i, attachment, string_VkSampleCountFlagBits(pCreateInfo->pAttachments[attachment].samples), |
| validation_error_map[VALIDATION_ERROR_140006a2]); |
| } |
| |
| if (!skip && subpass.pResolveAttachments[j].attachment != VK_ATTACHMENT_UNUSED && |
| subpass.pColorAttachments[j].attachment == VK_ATTACHMENT_UNUSED) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 0, __LINE__, VALIDATION_ERROR_1400069e, "DS", |
| "CreateRenderPass: Subpass %u requests multisample resolve from attachment %u which has " |
| "attachment=VK_ATTACHMENT_UNUSED. %s", |
| i, attachment, validation_error_map[VALIDATION_ERROR_1400069e]); |
| } |
| } |
| attachment = subpass.pColorAttachments[j].attachment; |
| skip |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Color"); |
| |
| if (!skip && attachment != VK_ATTACHMENT_UNUSED) { |
| sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; |
| |
| if (subpass_performs_resolve && pCreateInfo->pAttachments[attachment].samples == VK_SAMPLE_COUNT_1_BIT) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 0, __LINE__, VALIDATION_ERROR_140006a0, "DS", |
| "CreateRenderPass: Subpass %u requests multisample resolve from attachment %u which has " |
| "VK_SAMPLE_COUNT_1_BIT. %s", |
| i, attachment, validation_error_map[VALIDATION_ERROR_140006a0]); |
| } |
| |
| if (subpass_performs_resolve && subpass.pResolveAttachments[j].attachment != VK_ATTACHMENT_UNUSED) { |
| const auto &color_desc = pCreateInfo->pAttachments[attachment]; |
| const auto &resolve_desc = pCreateInfo->pAttachments[subpass.pResolveAttachments[j].attachment]; |
| if (color_desc.format != resolve_desc.format) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 0, __LINE__, VALIDATION_ERROR_140006a4, "DS", |
| "CreateRenderPass: Subpass %u pColorAttachments[%u] resolves to an attachment with a " |
| "different format. color format: %u, resolve format: %u. %s", |
| i, j, color_desc.format, resolve_desc.format, validation_error_map[VALIDATION_ERROR_140006a4]); |
| } |
| } |
| |
| if (dev_data->extensions.vk_amd_mixed_attachment_samples && subpass.pDepthStencilAttachment && |
| subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| const auto depth_stencil_sample_count = |
| pCreateInfo->pAttachments[subpass.pDepthStencilAttachment->attachment].samples; |
| if (pCreateInfo->pAttachments[attachment].samples > depth_stencil_sample_count) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, VALIDATION_ERROR_14000bc4, "DS", |
| "CreateRenderPass: Subpass %u pColorAttachments[%u] has %s which is larger than " |
| "depth/stencil attachment %s. %s", |
| i, j, string_VkSampleCountFlagBits(pCreateInfo->pAttachments[attachment].samples), |
| string_VkSampleCountFlagBits(depth_stencil_sample_count), |
| validation_error_map[VALIDATION_ERROR_14000bc4]); |
| } |
| } |
| } |
| } |
| |
| if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| uint32_t attachment = subpass.pDepthStencilAttachment->attachment; |
| skip |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Depth stencil"); |
| |
| if (!skip && attachment != VK_ATTACHMENT_UNUSED) { |
| sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; |
| } |
| } |
| |
| for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| uint32_t attachment = subpass.pInputAttachments[j].attachment; |
| skip |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Input"); |
| } |
| |
| if (!dev_data->extensions.vk_amd_mixed_attachment_samples && sample_count && !IsPowerOfTwo(sample_count)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| __LINE__, VALIDATION_ERROR_0082b401, "DS", |
| "CreateRenderPass: Subpass %u attempts to render to attachments with inconsistent sample counts. %s", |
| i, validation_error_map[VALIDATION_ERROR_0082b401]); |
| } |
| } |
| return skip; |
| } |
| |
| static void MarkAttachmentFirstUse(RENDER_PASS_STATE *render_pass, uint32_t index, bool is_read) { |
| if (index == VK_ATTACHMENT_UNUSED) return; |
| |
| if (!render_pass->attachment_first_read.count(index)) render_pass->attachment_first_read[index] = is_read; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| |
| unique_lock_t lock(global_lock); |
| // TODO: As part of wrapping up the mem_tracker/core_validation merge the following routine should be consolidated with |
| // ValidateLayouts. |
| skip |= ValidateRenderpassAttachmentUsage(dev_data, pCreateInfo); |
| for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { |
| skip |= ValidateStageMaskGsTsEnables(dev_data, pCreateInfo->pDependencies[i].srcStageMask, "vkCreateRenderPass()", |
| VALIDATION_ERROR_13e006b8, VALIDATION_ERROR_13e006bc); |
| skip |= ValidateStageMaskGsTsEnables(dev_data, pCreateInfo->pDependencies[i].dstStageMask, "vkCreateRenderPass()", |
| VALIDATION_ERROR_13e006ba, VALIDATION_ERROR_13e006be); |
| } |
| if (!skip) { |
| skip |= ValidateLayouts(dev_data, device, pCreateInfo); |
| } |
| lock.unlock(); |
| |
| if (skip) { |
| return VK_ERROR_VALIDATION_FAILED_EXT; |
| } |
| |
| VkResult result = dev_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); |
| |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| |
| std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); |
| std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); |
| std::vector<int32_t> subpass_to_dep_index(pCreateInfo->subpassCount); |
| skip |= CreatePassDAG(dev_data, pCreateInfo, subpass_to_node, has_self_dependency, subpass_to_dep_index); |
| |
| auto render_pass = std::make_shared<RENDER_PASS_STATE>(pCreateInfo); |
| render_pass->renderPass = *pRenderPass; |
| render_pass->hasSelfDependency = has_self_dependency; |
| render_pass->subpassToNode = subpass_to_node; |
| render_pass->subpass_to_dependency_index = subpass_to_dep_index; |
| |
| for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
| for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| MarkAttachmentFirstUse(render_pass.get(), subpass.pColorAttachments[j].attachment, false); |
| |
| // resolve attachments are considered to be written |
| if (subpass.pResolveAttachments) { |
| MarkAttachmentFirstUse(render_pass.get(), subpass.pResolveAttachments[j].attachment, false); |
| } |
| } |
| if (subpass.pDepthStencilAttachment) { |
| MarkAttachmentFirstUse(render_pass.get(), subpass.pDepthStencilAttachment->attachment, false); |
| } |
| for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| MarkAttachmentFirstUse(render_pass.get(), subpass.pInputAttachments[j].attachment, true); |
| } |
| } |
| |
| dev_data->renderPassMap[*pRenderPass] = std::move(render_pass); |
| } |
| return result; |
| } |
| |
| static bool validatePrimaryCommandBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, char const *cmd_name, |
| UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| bool skip = false; |
| if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCB->commandBuffer), __LINE__, error_code, "DS", |
| "Cannot execute command %s on a secondary command buffer. %s", cmd_name, validation_error_map[error_code]); |
| } |
| return skip; |
| } |
| |
| static bool VerifyRenderAreaBounds(const layer_data *dev_data, const VkRenderPassBeginInfo *pRenderPassBegin) { |
| bool skip = false; |
| const safe_VkFramebufferCreateInfo *pFramebufferInfo = |
| &GetFramebufferState(dev_data, pRenderPassBegin->framebuffer)->createInfo; |
| if (pRenderPassBegin->renderArea.offset.x < 0 || |
| (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || |
| pRenderPassBegin->renderArea.offset.y < 0 || |
| (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { |
| skip |= static_cast<bool>(log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| DRAWSTATE_INVALID_RENDER_AREA, "CORE", |
| "Cannot execute a render pass with renderArea not within the bound of the framebuffer. RenderArea: x %d, y %d, width " |
| "%d, height %d. Framebuffer: width %d, height %d.", |
| pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, |
| pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); |
| } |
| return skip; |
| } |
| |
| // If this is a stencil format, make sure the stencil[Load|Store]Op flag is checked, while if it is a depth/color attachment the |
| // [load|store]Op flag must be checked |
| // TODO: The memory valid flag in DEVICE_MEM_INFO should probably be split to track the validity of stencil memory separately. |
| template <typename T> |
| static bool FormatSpecificLoadAndStoreOpSettings(VkFormat format, T color_depth_op, T stencil_op, T op) { |
| if (color_depth_op != op && stencil_op != op) { |
| return false; |
| } |
| bool check_color_depth_load_op = !FormatIsStencilOnly(format); |
| bool check_stencil_load_op = FormatIsDepthAndStencil(format) || !check_color_depth_load_op; |
| |
| return ((check_color_depth_load_op && (color_depth_op == op)) || (check_stencil_load_op && (stencil_op == op))); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, |
| VkSubpassContents contents) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *cb_node = GetCBNode(dev_data, commandBuffer); |
| auto render_pass_state = pRenderPassBegin ? GetRenderPassState(dev_data, pRenderPassBegin->renderPass) : nullptr; |
| auto framebuffer = pRenderPassBegin ? GetFramebufferState(dev_data, pRenderPassBegin->framebuffer) : nullptr; |
| if (cb_node) { |
| if (render_pass_state) { |
| uint32_t clear_op_size = 0; // Make sure pClearValues is at least as large as last LOAD_OP_CLEAR |
| cb_node->activeFramebuffer = pRenderPassBegin->framebuffer; |
| for (uint32_t i = 0; i < render_pass_state->createInfo.attachmentCount; ++i) { |
| MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; |
| auto pAttachment = &render_pass_state->createInfo.pAttachments[i]; |
| if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, pAttachment->stencilLoadOp, |
| VK_ATTACHMENT_LOAD_OP_CLEAR)) { |
| clear_op_size = static_cast<uint32_t>(i) + 1; |
| std::function<bool()> function = [=]() { |
| SetImageMemoryValid(dev_data, GetImageState(dev_data, fb_info.image), true); |
| return false; |
| }; |
| cb_node->queue_submit_functions.push_back(function); |
| } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, |
| pAttachment->stencilLoadOp, VK_ATTACHMENT_LOAD_OP_DONT_CARE)) { |
| std::function<bool()> function = [=]() { |
| SetImageMemoryValid(dev_data, GetImageState(dev_data, fb_info.image), false); |
| return false; |
| }; |
| cb_node->queue_submit_functions.push_back(function); |
| } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, |
| pAttachment->stencilLoadOp, VK_ATTACHMENT_LOAD_OP_LOAD)) { |
| std::function<bool()> function = [=]() { |
| return ValidateImageMemoryIsValid(dev_data, GetImageState(dev_data, fb_info.image), |
| "vkCmdBeginRenderPass()"); |
| }; |
| cb_node->queue_submit_functions.push_back(function); |
| } |
| if (render_pass_state->attachment_first_read[i]) { |
| std::function<bool()> function = [=]() { |
| return ValidateImageMemoryIsValid(dev_data, GetImageState(dev_data, fb_info.image), |
| "vkCmdBeginRenderPass()"); |
| }; |
| cb_node->queue_submit_functions.push_back(function); |
| } |
| } |
| if (clear_op_size > pRenderPassBegin->clearValueCount) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| HandleToUint64(render_pass_state->renderPass), __LINE__, VALIDATION_ERROR_1200070c, "DS", |
| "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but there " |
| "must be at least %u entries in pClearValues array to account for the highest index attachment in " |
| "renderPass 0x%" PRIx64 |
| " that uses VK_ATTACHMENT_LOAD_OP_CLEAR is %u. Note that the pClearValues array is indexed by " |
| "attachment number so even if some pClearValues entries between 0 and %u correspond to attachments " |
| "that aren't cleared they will be ignored. %s", |
| pRenderPassBegin->clearValueCount, clear_op_size, HandleToUint64(render_pass_state->renderPass), |
| clear_op_size, clear_op_size - 1, validation_error_map[VALIDATION_ERROR_1200070c]); |
| } |
| skip |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); |
| skip |= VerifyFramebufferAndRenderPassLayouts(dev_data, cb_node, pRenderPassBegin, |
| GetFramebufferState(dev_data, pRenderPassBegin->framebuffer)); |
| if (framebuffer->rp_state->renderPass != render_pass_state->renderPass) { |
| skip |= validateRenderPassCompatibility(dev_data, "render pass", render_pass_state, "framebuffer", |
| framebuffer->rp_state.get(), "vkCmdBeginRenderPass()", |
| VALIDATION_ERROR_12000710); |
| } |
| skip |= insideRenderPass(dev_data, cb_node, "vkCmdBeginRenderPass()", VALIDATION_ERROR_17a00017); |
| skip |= ValidateDependencies(dev_data, framebuffer, render_pass_state); |
| skip |= validatePrimaryCommandBuffer(dev_data, cb_node, "vkCmdBeginRenderPass()", VALIDATION_ERROR_17a00019); |
| skip |= ValidateCmdQueueFlags(dev_data, cb_node, "vkCmdBeginRenderPass()", VK_QUEUE_GRAPHICS_BIT, |
| VALIDATION_ERROR_17a02415); |
| skip |= ValidateCmd(dev_data, cb_node, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); |
| cb_node->activeRenderPass = render_pass_state; |
| // This is a shallow copy as that is all that is needed for now |
| cb_node->activeRenderPassBeginInfo = *pRenderPassBegin; |
| cb_node->activeSubpass = 0; |
| cb_node->activeSubpassContents = contents; |
| cb_node->framebuffers.insert(pRenderPassBegin->framebuffer); |
| // Connect this framebuffer and its children to this cmdBuffer |
| AddFramebufferBinding(dev_data, cb_node, framebuffer); |
| // Connect this RP to cmdBuffer |
| addCommandBufferBinding(&render_pass_state->cb_bindings, |
| {HandleToUint64(render_pass_state->renderPass), kVulkanObjectTypeRenderPass}, cb_node); |
| // transition attachments to the correct layouts for beginning of renderPass and first subpass |
| TransitionBeginRenderPassLayouts(dev_data, cb_node, render_pass_state, framebuffer); |
| } |
| } |
| lock.unlock(); |
| if (!skip) { |
| dev_data->dispatch_table.CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| skip |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass()", VALIDATION_ERROR_1b600019); |
| skip |= ValidateCmdQueueFlags(dev_data, pCB, "vkCmdNextSubpass()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_1b602415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); |
| skip |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass()", VALIDATION_ERROR_1b600017); |
| |
| auto subpassCount = pCB->activeRenderPass->createInfo.subpassCount; |
| if (pCB->activeSubpass == subpassCount - 1) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(commandBuffer), __LINE__, VALIDATION_ERROR_1b60071a, "DS", |
| "vkCmdNextSubpass(): Attempted to advance beyond final subpass. %s", |
| validation_error_map[VALIDATION_ERROR_1b60071a]); |
| } |
| } |
| lock.unlock(); |
| |
| if (skip) return; |
| |
| dev_data->dispatch_table.CmdNextSubpass(commandBuffer, contents); |
| |
| if (pCB) { |
| lock.lock(); |
| pCB->activeSubpass++; |
| pCB->activeSubpassContents = contents; |
| TransitionSubpassLayouts(dev_data, pCB, pCB->activeRenderPass, pCB->activeSubpass, |
| GetFramebufferState(dev_data, pCB->activeRenderPassBeginInfo.framebuffer)); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| auto pCB = GetCBNode(dev_data, commandBuffer); |
| FRAMEBUFFER_STATE *framebuffer = NULL; |
| if (pCB) { |
| RENDER_PASS_STATE *rp_state = pCB->activeRenderPass; |
| framebuffer = GetFramebufferState(dev_data, pCB->activeFramebuffer); |
| if (rp_state) { |
| if (pCB->activeSubpass != rp_state->createInfo.subpassCount - 1) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer), __LINE__, |
| VALIDATION_ERROR_1b00071c, "DS", "vkCmdEndRenderPass(): Called before reaching final subpass. %s", |
| validation_error_map[VALIDATION_ERROR_1b00071c]); |
| } |
| |
| for (size_t i = 0; i < rp_state->createInfo.attachmentCount; ++i) { |
| MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; |
| auto pAttachment = &rp_state->createInfo.pAttachments[i]; |
| if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->storeOp, pAttachment->stencilStoreOp, |
| VK_ATTACHMENT_STORE_OP_STORE)) { |
| std::function<bool()> function = [=]() { |
| SetImageMemoryValid(dev_data, GetImageState(dev_data, fb_info.image), true); |
| return false; |
| }; |
| pCB->queue_submit_functions.push_back(function); |
| } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->storeOp, |
| pAttachment->stencilStoreOp, VK_ATTACHMENT_STORE_OP_DONT_CARE)) { |
| std::function<bool()> function = [=]() { |
| SetImageMemoryValid(dev_data, GetImageState(dev_data, fb_info.image), false); |
| return false; |
| }; |
| pCB->queue_submit_functions.push_back(function); |
| } |
| } |
| } |
| skip |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass()", VALIDATION_ERROR_1b000017); |
| skip |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass()", VALIDATION_ERROR_1b000019); |
| skip |= ValidateCmdQueueFlags(dev_data, pCB, "vkCmdEndRenderPass()", VK_QUEUE_GRAPHICS_BIT, VALIDATION_ERROR_1b002415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); |
| } |
| lock.unlock(); |
| |
| if (skip) return; |
| |
| dev_data->dispatch_table.CmdEndRenderPass(commandBuffer); |
| |
| if (pCB) { |
| lock.lock(); |
| TransitionFinalSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, framebuffer); |
| pCB->activeRenderPass = nullptr; |
| pCB->activeSubpass = 0; |
| pCB->activeFramebuffer = VK_NULL_HANDLE; |
| } |
| } |
| |
| static bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, |
| VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB, const char *caller) { |
| bool skip = false; |
| if (!pSubCB->beginInfo.pInheritanceInfo) { |
| return skip; |
| } |
| VkFramebuffer primary_fb = pCB->activeFramebuffer; |
| VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; |
| if (secondary_fb != VK_NULL_HANDLE) { |
| if (primary_fb != secondary_fb) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(primaryBuffer), __LINE__, VALIDATION_ERROR_1b2000c6, "DS", |
| "vkCmdExecuteCommands() called w/ invalid secondary command buffer 0x%" PRIx64 |
| " which has a framebuffer 0x%" PRIx64 |
| " that is not the same as the primary command buffer's current active framebuffer 0x%" PRIx64 ". %s", |
| HandleToUint64(secondaryBuffer), HandleToUint64(secondary_fb), HandleToUint64(primary_fb), |
| validation_error_map[VALIDATION_ERROR_1b2000c6]); |
| } |
| auto fb = GetFramebufferState(dev_data, secondary_fb); |
| if (!fb) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(primaryBuffer), __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", |
| "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%" PRIx64 |
| " which has invalid framebuffer 0x%" PRIx64 ".", |
| HandleToUint64(secondaryBuffer), HandleToUint64(secondary_fb)); |
| return skip; |
| } |
| } |
| return skip; |
| } |
| |
| static bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { |
| bool skip = false; |
| unordered_set<int> activeTypes; |
| for (auto queryObject : pCB->activeQueries) { |
| auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); |
| if (queryPoolData != dev_data->queryPoolMap.end()) { |
| if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && |
| pSubCB->beginInfo.pInheritanceInfo) { |
| VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; |
| if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCB->commandBuffer), __LINE__, VALIDATION_ERROR_1b2000d0, "DS", |
| "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%" PRIx64 |
| " which has invalid active query pool 0x%" PRIx64 |
| ". Pipeline statistics is being queried so the command buffer must have all bits set on the queryPool. %s", |
| HandleToUint64(pCB->commandBuffer), HandleToUint64(queryPoolData->first), |
| validation_error_map[VALIDATION_ERROR_1b2000d0]); |
| } |
| } |
| activeTypes.insert(queryPoolData->second.createInfo.queryType); |
| } |
| } |
| for (auto queryObject : pSubCB->startedQueries) { |
| auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); |
| if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", |
| "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%" PRIx64 |
| " which has invalid active query pool 0x%" PRIx64 |
| " of type %d but a query of that type has been started on secondary Cmd Buffer 0x%" PRIx64 ".", |
| HandleToUint64(pCB->commandBuffer), HandleToUint64(queryPoolData->first), |
| queryPoolData->second.createInfo.queryType, HandleToUint64(pSubCB->commandBuffer)); |
| } |
| } |
| |
| auto primary_pool = GetCommandPoolNode(dev_data, pCB->createInfo.commandPool); |
| auto secondary_pool = GetCommandPoolNode(dev_data, pSubCB->createInfo.commandPool); |
| if (primary_pool && secondary_pool && (primary_pool->queueFamilyIndex != secondary_pool->queueFamilyIndex)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pSubCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", |
| "vkCmdExecuteCommands(): Primary command buffer 0x%" PRIx64 |
| " created in queue family %d has secondary command buffer 0x%" PRIx64 " created in queue family %d.", |
| HandleToUint64(pCB->commandBuffer), primary_pool->queueFamilyIndex, HandleToUint64(pSubCB->commandBuffer), |
| secondary_pool->queueFamilyIndex); |
| } |
| |
| return skip; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, |
| const VkCommandBuffer *pCommandBuffers) { |
| bool skip = false; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| GLOBAL_CB_NODE *pCB = GetCBNode(dev_data, commandBuffer); |
| if (pCB) { |
| GLOBAL_CB_NODE *pSubCB = NULL; |
| for (uint32_t i = 0; i < commandBuffersCount; i++) { |
| pSubCB = GetCBNode(dev_data, pCommandBuffers[i]); |
| assert(pSubCB); |
| if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCommandBuffers[i]), __LINE__, VALIDATION_ERROR_1b2000b0, "DS", |
| "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%" PRIx64 |
| " in element %u of pCommandBuffers array. All cmd buffers in pCommandBuffers array must be secondary. %s", |
| HandleToUint64(pCommandBuffers[i]), i, validation_error_map[VALIDATION_ERROR_1b2000b0]); |
| } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set |
| if (pSubCB->beginInfo.pInheritanceInfo != nullptr) { |
| auto secondary_rp_state = GetRenderPassState(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); |
| if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(pCommandBuffers[i]), |
| __LINE__, VALIDATION_ERROR_1b2000c0, "DS", |
| "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIx64 |
| ") executed within render pass (0x%" PRIx64 |
| ") must have had vkBeginCommandBuffer() called w/ " |
| "VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set. %s", |
| HandleToUint64(pCommandBuffers[i]), HandleToUint64(pCB->activeRenderPass->renderPass), |
| validation_error_map[VALIDATION_ERROR_1b2000c0]); |
| } else { |
| // Make sure render pass is compatible with parent command buffer pass if has continue |
| if (pCB->activeRenderPass->renderPass != secondary_rp_state->renderPass) { |
| skip |= validateRenderPassCompatibility(dev_data, "primary command buffer", pCB->activeRenderPass, |
| "secondary command buffer", secondary_rp_state, |
| "vkCmdExecuteCommands()", VALIDATION_ERROR_1b2000c4); |
| } |
| // If framebuffer for secondary CB is not NULL, then it must match active FB from primaryCB |
| skip |= |
| validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB, "vkCmdExecuteCommands()"); |
| if (VK_NULL_HANDLE == pSubCB->activeFramebuffer) { |
| // Inherit primary's activeFramebuffer and while running validate functions |
| for (auto &function : pSubCB->cmd_execute_commands_functions) { |
| skip |= function(pCB->activeFramebuffer); |
| } |
| } |
| } |
| } |
| } |
| // TODO(mlentine): Move more logic into this method |
| skip |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); |
| skip |= validateCommandBufferState(dev_data, pSubCB, "vkCmdExecuteCommands()", 0, VALIDATION_ERROR_1b2000b2); |
| if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { |
| if (pSubCB->in_use.load() || pCB->linkedCommandBuffers.count(pSubCB)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(pCB->commandBuffer), __LINE__, |
| VALIDATION_ERROR_1b2000b4, "DS", |
| "Attempt to simultaneously execute command buffer 0x%" PRIx64 |
| " without VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set! %s", |
| HandleToUint64(pCB->commandBuffer), validation_error_map[VALIDATION_ERROR_1b2000b4]); |
| } |
| if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { |
| // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(pCommandBuffers[i]), __LINE__, |
| DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", |
| "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIx64 |
| ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary " |
| "command buffer (0x%" PRIx64 |
| ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set, even " |
| "though it does.", |
| HandleToUint64(pCommandBuffers[i]), HandleToUint64(pCB->commandBuffer)); |
| pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; |
| } |
| } |
| if (!pCB->activeQueries.empty() && !dev_data->enabled_features.inheritedQueries) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| HandleToUint64(pCommandBuffers[i]), __LINE__, VALIDATION_ERROR_1b2000ca, "DS", |
| "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIx64 |
| ") cannot be submitted with a query in flight and inherited queries not supported on this device. %s", |
| HandleToUint64(pCommandBuffers[i]), validation_error_map[VALIDATION_ERROR_1b2000ca]); |
| } |
| // TODO: separate validate from update! This is very tangled. |
| // Propagate layout transitions to the primary cmd buffer |
| for (auto ilm_entry : pSubCB->imageLayoutMap) { |
| if (pCB->imageLayoutMap.find(ilm_entry.first) != pCB->imageLayoutMap.end()) { |
| pCB->imageLayoutMap[ilm_entry.first].layout = ilm_entry.second.layout; |
| } else { |
| assert(ilm_entry.first.hasSubresource); |
| IMAGE_CMD_BUF_LAYOUT_NODE node; |
| if (!FindCmdBufLayout(dev_data, pCB, ilm_entry.first.image, ilm_entry.first.subresource, node)) { |
| node.initialLayout = ilm_entry.second.initialLayout; |
| } |
| node.layout = ilm_entry.second.layout; |
| SetLayout(dev_data, pCB, ilm_entry.first, node); |
| } |
| } |
| pSubCB->primaryCommandBuffer = pCB->commandBuffer; |
| pCB->linkedCommandBuffers.insert(pSubCB); |
| pSubCB->linkedCommandBuffers.insert(pCB); |
| for (auto &function : pSubCB->queryUpdates) { |
| pCB->queryUpdates.push_back(function); |
| } |
| for (auto &function : pSubCB->queue_submit_functions) { |
| pCB->queue_submit_functions.push_back(function); |
| } |
| } |
| skip |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteCommands()", VALIDATION_ERROR_1b200019); |
| skip |= |
| ValidateCmdQueueFlags(dev_data, pCB, "vkCmdExecuteCommands()", |
| VK_QUEUE_TRANSFER_BIT | VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, VALIDATION_ERROR_1b202415); |
| skip |= ValidateCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteCommands()"); |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL MapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, |
| void **ppData) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| |
| bool skip = false; |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| unique_lock_t lock(global_lock); |
| DEVICE_MEM_INFO *mem_info = GetMemObjInfo(dev_data, mem); |
| if (mem_info) { |
| // TODO : This could me more fine-grained to track just region that is valid |
| mem_info->global_valid = true; |
| auto end_offset = (VK_WHOLE_SIZE == size) ? mem_info->alloc_info.allocationSize - 1 : offset + size - 1; |
| skip |= ValidateMapImageLayouts(dev_data, device, mem_info, offset, end_offset); |
| // TODO : Do we need to create new "bound_range" for the mapped range? |
| SetMemRangesValid(dev_data, mem_info, offset, end_offset); |
| if ((dev_data->phys_dev_mem_props.memoryTypes[mem_info->alloc_info.memoryTypeIndex].propertyFlags & |
| VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { |
| skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem), __LINE__, VALIDATION_ERROR_31200554, "MEM", |
| "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIx64 ". %s", |
| HandleToUint64(mem), validation_error_map[VALIDATION_ERROR_31200554]); |
| } |
| } |
| skip |= ValidateMapMemRange(dev_data, mem, offset, size); |
| lock.unlock(); |
| |
| if (!skip) { |
| result = dev_data->dispatch_table.MapMemory(device, mem, offset, size, flags, ppData); |
| if (VK_SUCCESS == result) { |
| lock.lock(); |
| // TODO : What's the point of this range? See comment on creating new "bound_range" above, which may replace this |
| storeMemRanges(dev_data, mem, offset, size); |
| initializeAndTrackMemory(dev_data, mem, offset, size, ppData); |
| lock.unlock(); |
| } |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool skip = false; |
| |
| unique_lock_t lock(global_lock); |
| skip |= deleteMemRanges(dev_data, mem); |
| lock.unlock(); |
| if (!skip) { |
| dev_data->dispatch_table.UnmapMemory(device, mem); |
| } |
| } |
| |
| static bool validateMemoryIsMapped(layer_data *dev_data, const char *funcName, uint32_t memRangeCount, |
| const VkMappedMemoryRange *pMemRanges) { |
| bool skip = false; |
| for (uint32_t i = 0; i < memRangeCount; ++i) { |
| auto mem_info = GetMemObjInfo(dev_data, pMemRanges[i].memory); |
| if (mem_info) { |
| if (pMemRanges[i].size == VK_WHOLE_SIZE) { |
| if (mem_info->mem_range.offset > pMemRanges[i].offset) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(pMemRanges[i].memory), __LINE__, VALIDATION_ERROR_0c20055c, "MEM", |
| "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER |
| ") is less than Memory Object's offset (" PRINTF_SIZE_T_SPECIFIER "). %s", |
| funcName, static_cast<size_t>(pMemRanges[i].offset), |
| static_cast<size_t>(mem_info->mem_range.offset), validation_error_map[VALIDATION_ERROR_0c20055c]); |
| } |
| } else { |
| const uint64_t data_end = (mem_info->mem_range.size == VK_WHOLE_SIZE) |
| ? mem_info->alloc_info.allocationSize |
| : (mem_info->mem_range.offset + mem_info->mem_range.size); |
| if ((mem_info->mem_range.offset > pMemRanges[i].offset) || |
| (data_end < (pMemRanges[i].offset + pMemRanges[i].size))) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(pMemRanges[i].memory), __LINE__, VALIDATION_ERROR_0c20055a, "MEM", |
| "%s: Flush/Invalidate size or offset (" PRINTF_SIZE_T_SPECIFIER ", " PRINTF_SIZE_T_SPECIFIER |
| ") exceed the Memory Object's upper-bound (" PRINTF_SIZE_T_SPECIFIER "). %s", |
| funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), |
| static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(data_end), |
| validation_error_map[VALIDATION_ERROR_0c20055a]); |
| } |
| } |
| } |
| } |
| return skip; |
| } |
| |
| static bool ValidateAndCopyNoncoherentMemoryToDriver(layer_data *dev_data, uint32_t mem_range_count, |
| const VkMappedMemoryRange *mem_ranges) { |
| bool skip = false; |
| for (uint32_t i = 0; i < mem_range_count; ++i) { |
| auto mem_info = GetMemObjInfo(dev_data, mem_ranges[i].memory); |
| if (mem_info) { |
| if (mem_info->shadow_copy) { |
| VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) |
| ? mem_info->mem_range.size |
| : (mem_info->alloc_info.allocationSize - mem_info->mem_range.offset); |
| char *data = static_cast<char *>(mem_info->shadow_copy); |
| for (uint64_t j = 0; j < mem_info->shadow_pad_size; ++j) { |
| if (data[j] != NoncoherentMemoryFillValue) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem_ranges[i].memory), __LINE__, MEMTRACK_INVALID_MAP, "MEM", |
| "Memory underflow was detected on mem obj 0x%" PRIx64, HandleToUint64(mem_ranges[i].memory)); |
| } |
| } |
| for (uint64_t j = (size + mem_info->shadow_pad_size); j < (2 * mem_info->shadow_pad_size + size); ++j) { |
| if (data[j] != NoncoherentMemoryFillValue) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, HandleToUint64(mem_ranges[i].memory), |
| __LINE__, MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj 0x%" PRIx64, |
| HandleToUint64(mem_ranges[i].memory)); |
| } |
| } |
| memcpy(mem_info->p_driver_data, static_cast<void *>(data + mem_info->shadow_pad_size), (size_t)(size)); |
| } |
| } |
| } |
| return skip; |
| } |
| |
| static void CopyNoncoherentMemoryFromDriver(layer_data *dev_data, uint32_t mem_range_count, const VkMappedMemoryRange *mem_ranges) { |
| for (uint32_t i = 0; i < mem_range_count; ++i) { |
| auto mem_info = GetMemObjInfo(dev_data, mem_ranges[i].memory); |
| if (mem_info && mem_info->shadow_copy) { |
| VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) |
| ? mem_info->mem_range.size |
| : (mem_info->alloc_info.allocationSize - mem_ranges[i].offset); |
| char *data = static_cast<char *>(mem_info->shadow_copy); |
| memcpy(data + mem_info->shadow_pad_size, mem_info->p_driver_data, (size_t)(size)); |
| } |
| } |
| } |
| |
| static bool ValidateMappedMemoryRangeDeviceLimits(layer_data *dev_data, const char *func_name, uint32_t mem_range_count, |
| const VkMappedMemoryRange *mem_ranges) { |
| bool skip = false; |
| for (uint32_t i = 0; i < mem_range_count; ++i) { |
| uint64_t atom_size = dev_data->phys_dev_properties.properties.limits.nonCoherentAtomSize; |
| if (SafeModulo(mem_ranges[i].offset, atom_size) != 0) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem_ranges->memory), __LINE__, VALIDATION_ERROR_0c20055e, "MEM", |
| "%s: Offset in pMemRanges[%d] is 0x%" PRIxLEAST64 |
| ", which is not a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (0x%" PRIxLEAST64 "). %s", |
| func_name, i, mem_ranges[i].offset, atom_size, validation_error_map[VALIDATION_ERROR_0c20055e]); |
| } |
| if ((mem_ranges[i].size != VK_WHOLE_SIZE) && (SafeModulo(mem_ranges[i].size, atom_size) != 0)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| HandleToUint64(mem_ranges->memory), __LINE__, VALIDATION_ERROR_0c200560, "MEM", |
| "%s: Size in pMemRanges[%d] is 0x%" PRIxLEAST64 |
| ", which is not a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (0x%" PRIxLEAST64 "). %s", |
| func_name, i, mem_ranges[i].size, atom_size, validation_error_map[VALIDATION_ERROR_0c200560]); |
| } |
| } |
| return skip; |
| } |
| |
| static bool PreCallValidateFlushMappedMemoryRanges(layer_data *dev_data, uint32_t mem_range_count, |
| const VkMappedMemoryRange *mem_ranges) { |
| bool skip = false; |
| lock_guard_t lock(global_lock); |
| skip |= ValidateAndCopyNoncoherentMemoryToDriver(dev_data, mem_range_count, mem_ranges); |
| skip |= validateMemoryIsMapped(dev_data, "vkFlushMappedMemoryRanges", mem_range_count, mem_ranges); |
| return skip; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL FlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, |
| const VkMappedMemoryRange *pMemRanges) { |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| |
| if (!PreCallValidateFlushMappedMemoryRanges(dev_data, memRangeCount, pMemRanges)) { |
| result = dev_data->dispatch_table.FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateInvalidateMappedMemoryRanges(layer_data *dev_data, uint32_t mem_range_count, |
| const VkMappedMemoryRange *mem_ranges) { |
| bool skip = false; |
| lock_guard_t lock(global_lock); |
| skip |= validateMemoryIsMapped(dev_data, "vkInvalidateMappedMemoryRanges", mem_range_count, mem_ranges); |
| return skip; |
| } |
| |
| static void PostCallRecordInvalidateMappedMemoryRanges(layer_data *dev_data, uint32_t mem_range_count, |
| const VkMappedMemoryRange *mem_ranges) { |
| lock_guard_t lock(global_lock); |
| // Update our shadow copy with modified driver data |
| CopyNoncoherentMemoryFromDriver(dev_data, mem_range_count, mem_ranges); |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL InvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, |
| const VkMappedMemoryRange *pMemRanges) { |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| |
| if (!PreCallValidateInvalidateMappedMemoryRanges(dev_data, memRangeCount, pMemRanges)) { |
| result = dev_data->dispatch_table.InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); |
| if (result == VK_SUCCESS) { |
| PostCallRecordInvalidateMappedMemoryRanges(dev_data, memRangeCount, pMemRanges); |
| } |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateBindImageMemory(layer_data *dev_data, VkImage image, IMAGE_STATE *image_state, VkDeviceMemory mem, |
| VkDeviceSize memoryOffset, const char *api_name) { |
| bool skip = false; |
| if (image_state) { |
| unique_lock_t lock(global_lock); |
| // Track objects tied to memory |
| uint64_t image_handle = HandleToUint64(image); |
| skip = ValidateSetMemBinding(dev_data, mem, image_handle, kVulkanObjectTypeImage, api_name); |
| if (!image_state->memory_requirements_checked) { |
| // There's not an explicit requirement in the spec to call vkGetImageMemoryRequirements() prior to calling |
| // BindImageMemory but it's implied in that memory being bound must conform with VkMemoryRequirements from |
| // vkGetImageMemoryRequirements() |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| image_handle, __LINE__, DRAWSTATE_INVALID_IMAGE, "DS", |
| "%s: Binding memory to image 0x%" PRIx64 |
| " but vkGetImageMemoryRequirements() has not been called on that image.", |
| api_name, HandleToUint64(image_handle)); |
| // Make the call for them so we can verify the state |
| lock.unlock(); |
| dev_data->dispatch_table.GetImageMemoryRequirements(dev_data->device, image, &image_state->requirements); |
| lock.lock(); |
| } |
| |
| // Validate bound memory range information |
| auto mem_info = GetMemObjInfo(dev_data, mem); |
| if (mem_info) { |
| skip |= ValidateInsertImageMemoryRange(dev_data, image, mem_info, memoryOffset, image_state->requirements, |
| image_state->createInfo.tiling == VK_IMAGE_TILING_LINEAR, api_name); |
| skip |= ValidateMemoryTypes(dev_data, mem_info, image_state->requirements.memoryTypeBits, api_name, |
| VALIDATION_ERROR_1740082e); |
| } |
| |
| // Validate memory requirements alignment |
| if (SafeModulo(memoryOffset, image_state->requirements.alignment) != 0) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| image_handle, __LINE__, VALIDATION_ERROR_17400830, "DS", |
| "%s: memoryOffset is 0x%" PRIxLEAST64 |
| " but must be an integer multiple of the VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 |
| ", returned from a call to vkGetImageMemoryRequirements with image. %s", |
| api_name, memoryOffset, image_state->requirements.alignment, |
| validation_error_map[VALIDATION_ERROR_17400830]); |
| } |
| |
| // Validate memory requirements size |
| if (mem_info) { |
| if (image_state->requirements.size > mem_info->alloc_info.allocationSize - memoryOffset) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| image_handle, __LINE__, VALIDATION_ERROR_17400832, "DS", |
| "%s: memory size minus memoryOffset is 0x%" PRIxLEAST64 |
| " but must be at least as large as VkMemoryRequirements::size value 0x%" PRIxLEAST64 |
| ", returned from a call to vkGetImageMemoryRequirements with image. %s", |
| api_name, mem_info->alloc_info.allocationSize - memoryOffset, image_state->requirements.size, |
| validation_error_map[VALIDATION_ERROR_17400832]); |
| } |
| } |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordBindImageMemory(layer_data *dev_data, VkImage image, IMAGE_STATE *image_state, VkDeviceMemory mem, |
| VkDeviceSize memoryOffset, const char *api_name) { |
| if (image_state) { |
| unique_lock_t lock(global_lock); |
| // Track bound memory range information |
| auto mem_info = GetMemObjInfo(dev_data, mem); |
| if (mem_info) { |
| InsertImageMemoryRange(dev_data, image, mem_info, memoryOffset, image_state->requirements, |
| image_state->createInfo.tiling == VK_IMAGE_TILING_LINEAR); |
| } |
| |
| // Track objects tied to memory |
| uint64_t image_handle = HandleToUint64(image); |
| SetMemBinding(dev_data, mem, image_state, memoryOffset, image_handle, kVulkanObjectTypeImage, api_name); |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| IMAGE_STATE *image_state; |
| { |
| unique_lock_t lock(global_lock); |
| image_state = GetImageState(dev_data, image); |
| } |
| bool skip = PreCallValidateBindImageMemory(dev_data, image, image_state, mem, memoryOffset, "vkBindImageMemory()"); |
| if (!skip) { |
| result = dev_data->dispatch_table.BindImageMemory(device, image, mem, memoryOffset); |
| if (result == VK_SUCCESS) { |
| PostCallRecordBindImageMemory(dev_data, image, image_state, mem, memoryOffset, "vkBindImageMemory()"); |
| } |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateBindImageMemory2KHR(layer_data *dev_data, std::vector<IMAGE_STATE *> *image_state, |
| uint32_t bindInfoCount, const VkBindImageMemoryInfoKHR *pBindInfos) { |
| { |
| unique_lock_t lock(global_lock); |
| for (uint32_t i = 0; i < bindInfoCount; i++) { |
| (*image_state)[i] = GetImageState(dev_data, pBindInfos[i].image); |
| } |
| } |
| bool skip = false; |
| char api_name[128]; |
| for (uint32_t i = 0; i < bindInfoCount; i++) { |
| sprintf(api_name, "vkBindImageMemory2KHR() pBindInfos[%u]", i); |
| skip |= PreCallValidateBindImageMemory(dev_data, pBindInfos[i].image, (*image_state)[i], pBindInfos[i].memory, |
| pBindInfos[i].memoryOffset, api_name); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordBindImageMemory2KHR(layer_data *dev_data, const std::vector<IMAGE_STATE *> &image_state, |
| uint32_t bindInfoCount, const VkBindImageMemoryInfoKHR *pBindInfos) { |
| for (uint32_t i = 0; i < bindInfoCount; i++) { |
| PostCallRecordBindImageMemory(dev_data, pBindInfos[i].image, image_state[i], pBindInfos[i].memory, |
| pBindInfos[i].memoryOffset, "vkBindImageMemory2KHR()"); |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL BindImageMemory2KHR(VkDevice device, uint32_t bindInfoCount, |
| const VkBindImageMemoryInfoKHR *pBindInfos) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| std::vector<IMAGE_STATE *> image_state(bindInfoCount); |
| if (!PreCallValidateBindImageMemory2KHR(dev_data, &image_state, bindInfoCount, pBindInfos)) { |
| result = dev_data->dispatch_table.BindImageMemory2KHR(device, bindInfoCount, pBindInfos); |
| if (result == VK_SUCCESS) { |
| PostCallRecordBindImageMemory2KHR(dev_data, image_state, bindInfoCount, pBindInfos); |
| } |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { |
| bool skip = false; |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| auto event_state = GetEventNode(dev_data, event); |
| if (event_state) { |
| event_state->needsSignaled = false; |
| event_state->stageMask = VK_PIPELINE_STAGE_HOST_BIT; |
| if (event_state->write_in_use) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, |
| HandleToUint64(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
| "Cannot call vkSetEvent() on event 0x%" PRIx64 " that is already in use by a command buffer.", |
| HandleToUint64(event)); |
| } |
| } |
| lock.unlock(); |
| // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event |
| // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the |
| // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) |
| for (auto queue_data : dev_data->queueMap) { |
| auto event_entry = queue_data.second.eventToStageMap.find(event); |
| if (event_entry != queue_data.second.eventToStageMap.end()) { |
| event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; |
| } |
| } |
| if (!skip) result = dev_data->dispatch_table.SetEvent(device, event); |
| return result; |
| } |
| |
| static bool PreCallValidateQueueBindSparse(layer_data *dev_data, VkQueue queue, uint32_t bindInfoCount, |
| const VkBindSparseInfo *pBindInfo, VkFence fence) { |
| auto pFence = GetFenceNode(dev_data, fence); |
| bool skip = ValidateFenceForSubmit(dev_data, pFence); |
| if (skip) { |
| return true; |
| } |
| |
| unordered_set<VkSemaphore> signaled_semaphores; |
| unordered_set<VkSemaphore> unsignaled_semaphores; |
| unordered_set<VkSemaphore> internal_semaphores; |
| for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { |
| const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; |
| |
| std::vector<SEMAPHORE_WAIT> semaphore_waits; |
| std::vector<VkSemaphore> semaphore_signals; |
| for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { |
| VkSemaphore semaphore = bindInfo.pWaitSemaphores[i]; |
| auto pSemaphore = GetSemaphoreNode(dev_data, semaphore); |
| if (pSemaphore && (pSemaphore->scope == kSyncScopeInternal || internal_semaphores.count(semaphore))) { |
| if (unsignaled_semaphores.count(semaphore) || |
| (!(signaled_semaphores.count(semaphore)) && !(pSemaphore->signaled))) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| HandleToUint64(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
| "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", |
| HandleToUint64(queue), HandleToUint64(semaphore)); |
| } else { |
| signaled_semaphores.erase(semaphore); |
| unsignaled_semaphores.insert(semaphore); |
| } |
| } |
| if (pSemaphore && pSemaphore->scope == kSyncScopeExternalTemporary) { |
| internal_semaphores.insert(semaphore); |
| } |
| } |
| for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { |
| VkSemaphore semaphore = bindInfo.pSignalSemaphores[i]; |
| auto pSemaphore = GetSemaphoreNode(dev_data, semaphore); |
| if (pSemaphore && pSemaphore->scope == kSyncScopeInternal) { |
| if (signaled_semaphores.count(semaphore) || (!(unsignaled_semaphores.count(semaphore)) && pSemaphore->signaled)) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| HandleToUint64(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
| "Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 |
| " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", |
| HandleToUint64(queue), HandleToUint64(semaphore), HandleToUint64(pSemaphore->signaler.first)); |
| } else { |
| unsignaled_semaphores.erase(semaphore); |
| signaled_semaphores.insert(semaphore); |
| } |
| } |
| } |
| // Store sparse binding image_state and after binding is complete make sure that any requiring metadata have it bound |
| std::unordered_set<IMAGE_STATE *> sparse_images; |
| // If we're binding sparse image memory make sure reqs were queried and note if metadata is required and bound |
| for (uint32_t i = 0; i < bindInfo.imageBindCount; ++i) { |
| const auto &opaque_bind = bindInfo.pImageOpaqueBinds[i]; |
| auto image_state = GetImageState(dev_data, opaque_bind.image); |
| sparse_images.insert(image_state); |
| if (!image_state->get_sparse_reqs_called || image_state->sparse_requirements.empty()) { |
| // For now just warning if sparse image binding occurs without calling to get reqs first |
| return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| HandleToUint64(image_state->image), __LINE__, MEMTRACK_INVALID_STATE, "CV", |
| "vkQueueBindSparse(): Binding sparse memory to image 0x%" PRIx64 |
| " without first calling vkGetImageSparseMemoryRequirements[2KHR]() to retrieve requirements.", |
| HandleToUint64(image_state->image)); |
| } |
| for (uint32_t j = 0; j < opaque_bind.bindCount; ++j) { |
| if (opaque_bind.pBinds[j].flags & VK_IMAGE_ASPECT_METADATA_BIT) { |
| image_state->sparse_metadata_bound = true; |
| } |
| } |
| } |
| for (uint32_t i = 0; i < bindInfo.imageOpaqueBindCount; ++i) { |
| auto image_state = GetImageState(dev_data, bindInfo.pImageOpaqueBinds[i].image); |
| sparse_images.insert(image_state); |
| if (!image_state->get_sparse_reqs_called || image_state->sparse_requirements.empty()) { |
| // For now just warning if sparse image binding occurs without calling to get reqs first |
| return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| HandleToUint64(image_state->image), __LINE__, MEMTRACK_INVALID_STATE, "CV", |
| "vkQueueBindSparse(): Binding opaque sparse memory to image 0x%" PRIx64 |
| " without first calling vkGetImageSparseMemoryRequirements[2KHR]() to retrieve requirements.", |
| HandleToUint64(image_state->image)); |
| } |
| } |
| for (const auto &sparse_image_state : sparse_images) { |
| if (sparse_image_state->sparse_metadata_required && !sparse_image_state->sparse_metadata_bound) { |
| // Warn if sparse image binding metadata required for image with sparse binding, but metadata not bound |
| return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| HandleToUint64(sparse_image_state->image), __LINE__, MEMTRACK_INVALID_STATE, "CV", |
| "vkQueueBindSparse(): Binding sparse memory to image 0x%" PRIx64 |
| " which requires a metadata aspect but no binding with VK_IMAGE_ASPECT_METADATA_BIT set was made.", |
| HandleToUint64(sparse_image_state->image)); |
| } |
| } |
| } |
| |
| return skip; |
| } |
| static void PostCallRecordQueueBindSparse(layer_data *dev_data, VkQueue queue, uint32_t bindInfoCount, |
| const VkBindSparseInfo *pBindInfo, VkFence fence) { |
| uint64_t early_retire_seq = 0; |
| auto pFence = GetFenceNode(dev_data, fence); |
| auto pQueue = GetQueueState(dev_data, queue); |
| |
| if (pFence) { |
| if (pFence->scope == kSyncScopeInternal) { |
| SubmitFence(pQueue, pFence, std::max(1u, bindInfoCount)); |
| if (!bindInfoCount) { |
| // No work to do, just dropping a fence in the queue by itself. |
| pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), std::vector<SEMAPHORE_WAIT>(), |
| std::vector<VkSemaphore>(), std::vector<VkSemaphore>(), fence); |
| } |
| } else { |
| // Retire work up until this fence early, we will not see the wait that corresponds to this signal |
| early_retire_seq = pQueue->seq + pQueue->submissions.size(); |
| if (!dev_data->external_sync_warning) { |
| dev_data->external_sync_warning = true; |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| HandleToUint64(fence), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
| "vkQueueBindSparse(): Signaling external fence 0x%" PRIx64 " on queue 0x%" PRIx64 |
| " will disable validation of preceding command buffer lifecycle states and the in-use status of associated " |
| "objects.", |
| HandleToUint64(fence), HandleToUint64(queue)); |
| } |
| } |
| } |
| |
| for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { |
| const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; |
| // Track objects tied to memory |
| for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { |
| for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { |
| auto sparse_binding = bindInfo.pBufferBinds[j].pBinds[k]; |
| SetSparseMemBinding(dev_data, {sparse_binding.memory, sparse_binding.memoryOffset, sparse_binding.size}, |
| HandleToUint64(bindInfo.pBufferBinds[j].buffer), kVulkanObjectTypeBuffer); |
| } |
| } |
| for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { |
| for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { |
| auto sparse_binding = bindInfo.pImageOpaqueBinds[j].pBinds[k]; |
| SetSparseMemBinding(dev_data, {sparse_binding.memory, sparse_binding.memoryOffset, sparse_binding.size}, |
| HandleToUint64(bindInfo.pImageOpaqueBinds[j].image), kVulkanObjectTypeImage); |
| } |
| } |
| for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { |
| for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { |
| auto sparse_binding = bindInfo.pImageBinds[j].pBinds[k]; |
| // TODO: This size is broken for non-opaque bindings, need to update to comprehend full sparse binding data |
| VkDeviceSize size = sparse_binding.extent.depth * sparse_binding.extent.height * sparse_binding.extent.width * 4; |
| SetSparseMemBinding(dev_data, {sparse_binding.memory, sparse_binding.memoryOffset, size}, |
| HandleToUint64(bindInfo.pImageBinds[j].image), kVulkanObjectTypeImage); |
| } |
| } |
| |
| std::vector<SEMAPHORE_WAIT> semaphore_waits; |
| std::vector<VkSemaphore> semaphore_signals; |
| std::vector<VkSemaphore> semaphore_externals; |
| for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { |
| VkSemaphore semaphore = bindInfo.pWaitSemaphores[i]; |
| auto pSemaphore = GetSemaphoreNode(dev_data, semaphore); |
| if (pSemaphore) { |
| if (pSemaphore->scope == kSyncScopeInternal) { |
| if (pSemaphore->signaler.first != VK_NULL_HANDLE) { |
| semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); |
| pSemaphore->in_use.fetch_add(1); |
| } |
| pSemaphore->signaler.first = VK_NULL_HANDLE; |
| pSemaphore->signaled = false; |
| } else { |
| semaphore_externals.push_back(semaphore); |
| pSemaphore->in_use.fetch_add(1); |
| if (pSemaphore->scope == kSyncScopeExternalTemporary) { |
| pSemaphore->scope = kSyncScopeInternal; |
| } |
| } |
| } |
| } |
| for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { |
| VkSemaphore semaphore = bindInfo.pSignalSemaphores[i]; |
| auto pSemaphore = GetSemaphoreNode(dev_data, semaphore); |
| if (pSemaphore) { |
| if (pSemaphore->scope == kSyncScopeInternal) { |
| pSemaphore->signaler.first = queue; |
| pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; |
| pSemaphore->signaled = true; |
| pSemaphore->in_use.fetch_add(1); |
| semaphore_signals.push_back(semaphore); |
| } else { |
| // Retire work up until this submit early, we will not see the wait that corresponds to this signal |
| early_retire_seq = std::max(early_retire_seq, pQueue->seq + pQueue->submissions.size() + 1); |
| if (!dev_data->external_sync_warning) { |
| dev_data->external_sync_warning = true; |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| HandleToUint64(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
| "vkQueueBindSparse(): Signaling external semaphore 0x%" PRIx64 " on queue 0x%" PRIx64 |
| " will disable validation of preceding command buffer lifecycle states and the in-use status of " |
| "associated objects.", |
| HandleToUint64(semaphore), HandleToUint64(queue)); |
| } |
| } |
| } |
| } |
| |
| pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), semaphore_waits, semaphore_signals, semaphore_externals, |
| bindIdx == bindInfoCount - 1 ? fence : VK_NULL_HANDLE); |
| } |
| |
| if (early_retire_seq) { |
| RetireWorkOnQueue(dev_data, pQueue, early_retire_seq); |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL QueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, |
| VkFence fence) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateQueueBindSparse(dev_data, queue, bindInfoCount, pBindInfo, fence); |
| lock.unlock(); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| VkResult result = dev_data->dispatch_table.QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); |
| |
| lock.lock(); |
| PostCallRecordQueueBindSparse(dev_data, queue, bindInfoCount, pBindInfo, fence); |
| lock.unlock(); |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); |
| if (result == VK_SUCCESS) { |
| lock_guard_t lock(global_lock); |
| SEMAPHORE_NODE *sNode = &dev_data->semaphoreMap[*pSemaphore]; |
| sNode->signaler.first = VK_NULL_HANDLE; |
| sNode->signaler.second = 0; |
| sNode->signaled = false; |
| sNode->scope = kSyncScopeInternal; |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateImportSemaphore(layer_data *dev_data, VkSemaphore semaphore, const char *caller_name) { |
| SEMAPHORE_NODE *sema_node = GetSemaphoreNode(dev_data, semaphore); |
| VK_OBJECT obj_struct = {HandleToUint64(semaphore), kVulkanObjectTypeSemaphore}; |
| bool skip = false; |
| if (sema_node) { |
| skip |= ValidateObjectNotInUse(dev_data, sema_node, obj_struct, caller_name, VALIDATION_ERROR_UNDEFINED); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordImportSemaphore(layer_data *dev_data, VkSemaphore semaphore, |
| VkExternalSemaphoreHandleTypeFlagBitsKHR handle_type, VkSemaphoreImportFlagsKHR flags) { |
| SEMAPHORE_NODE *sema_node = GetSemaphoreNode(dev_data, semaphore); |
| if (sema_node && sema_node->scope != kSyncScopeExternalPermanent) { |
| if ((handle_type == VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT_KHR || flags & VK_SEMAPHORE_IMPORT_TEMPORARY_BIT_KHR) && |
| sema_node->scope == kSyncScopeInternal) { |
| sema_node->scope = kSyncScopeExternalTemporary; |
| } else { |
| sema_node->scope = kSyncScopeExternalPermanent; |
| } |
| } |
| } |
| |
| #ifdef VK_USE_PLATFORM_WIN32_KHR |
| VKAPI_ATTR VkResult VKAPI_CALL |
| ImportSemaphoreWin32HandleKHR(VkDevice device, const VkImportSemaphoreWin32HandleInfoKHR *pImportSemaphoreWin32HandleInfo) { |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool skip = |
| PreCallValidateImportSemaphore(dev_data, pImportSemaphoreWin32HandleInfo->semaphore, "vkImportSemaphoreWin32HandleKHR"); |
| |
| if (!skip) { |
| result = dev_data->dispatch_table.ImportSemaphoreWin32HandleKHR(device, pImportSemaphoreWin32HandleInfo); |
| } |
| |
| if (result == VK_SUCCESS) { |
| PostCallRecordImportSemaphore(dev_data, pImportSemaphoreWin32HandleInfo->semaphore, |
| pImportSemaphoreWin32HandleInfo->handleType, pImportSemaphoreWin32HandleInfo->flags); |
| } |
| return result; |
| } |
| #endif |
| |
| VKAPI_ATTR VkResult VKAPI_CALL ImportSemaphoreFdKHR(VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) { |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool skip = PreCallValidateImportSemaphore(dev_data, pImportSemaphoreFdInfo->semaphore, "vkImportSemaphoreFdKHR"); |
| |
| if (!skip) { |
| result = dev_data->dispatch_table.ImportSemaphoreFdKHR(device, pImportSemaphoreFdInfo); |
| } |
| |
| if (result == VK_SUCCESS) { |
| PostCallRecordImportSemaphore(dev_data, pImportSemaphoreFdInfo->semaphore, pImportSemaphoreFdInfo->handleType, |
| pImportSemaphoreFdInfo->flags); |
| } |
| return result; |
| } |
| |
| static void PostCallRecordGetSemaphore(layer_data *dev_data, VkSemaphore semaphore, |
| VkExternalSemaphoreHandleTypeFlagBitsKHR handle_type) { |
| SEMAPHORE_NODE *sema_node = GetSemaphoreNode(dev_data, semaphore); |
| if (sema_node && handle_type != VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT_KHR) { |
| // Cannot track semaphore state once it is exported, except for Sync FD handle types which have copy transference |
| sema_node->scope = kSyncScopeExternalPermanent; |
| } |
| } |
| |
| #ifdef VK_USE_PLATFORM_WIN32_KHR |
| VKAPI_ATTR VkResult VKAPI_CALL GetSemaphoreWin32HandleKHR(VkDevice device, |
| const VkSemaphoreGetWin32HandleInfoKHR *pGetWin32HandleInfo, |
| HANDLE *pHandle) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.GetSemaphoreWin32HandleKHR(device, pGetWin32HandleInfo, pHandle); |
| |
| if (result == VK_SUCCESS) { |
| PostCallRecordGetSemaphore(dev_data, pGetWin32HandleInfo->semaphore, pGetWin32HandleInfo->handleType); |
| } |
| return result; |
| } |
| #endif |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetSemaphoreFdKHR(VkDevice device, const VkSemaphoreGetFdInfoKHR *pGetFdInfo, int *pFd) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.GetSemaphoreFdKHR(device, pGetFdInfo, pFd); |
| |
| if (result == VK_SUCCESS) { |
| PostCallRecordGetSemaphore(dev_data, pGetFdInfo->semaphore, pGetFdInfo->handleType); |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateImportFence(layer_data *dev_data, VkFence fence, const char *caller_name) { |
| FENCE_NODE *fence_node = GetFenceNode(dev_data, fence); |
| bool skip = false; |
| if (fence_node && fence_node->scope == kSyncScopeInternal && fence_node->state == FENCE_INFLIGHT) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| HandleToUint64(fence), __LINE__, VALIDATION_ERROR_UNDEFINED, "DS", |
| "Cannot call %s on fence 0x%" PRIx64 " that is currently in use.", caller_name, HandleToUint64(fence)); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordImportFence(layer_data *dev_data, VkFence fence, VkExternalFenceHandleTypeFlagBitsKHR handle_type, |
| VkFenceImportFlagsKHR flags) { |
| FENCE_NODE *fence_node = GetFenceNode(dev_data, fence); |
| if (fence_node && fence_node->scope != kSyncScopeExternalPermanent) { |
| if ((handle_type == VK_EXTERNAL_FENCE_HANDLE_TYPE_SYNC_FD_BIT_KHR || flags & VK_FENCE_IMPORT_TEMPORARY_BIT_KHR) && |
| fence_node->scope == kSyncScopeInternal) { |
| fence_node->scope = kSyncScopeExternalTemporary; |
| } else { |
| fence_node->scope = kSyncScopeExternalPermanent; |
| } |
| } |
| } |
| |
| #ifdef VK_USE_PLATFORM_WIN32_KHR |
| VKAPI_ATTR VkResult VKAPI_CALL ImportFenceWin32HandleKHR(VkDevice device, |
| const VkImportFenceWin32HandleInfoKHR *pImportFenceWin32HandleInfo) { |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool skip = PreCallValidateImportFence(dev_data, pImportFenceWin32HandleInfo->fence, "vkImportFenceWin32HandleKHR"); |
| |
| if (!skip) { |
| result = dev_data->dispatch_table.ImportFenceWin32HandleKHR(device, pImportFenceWin32HandleInfo); |
| } |
| |
| if (result == VK_SUCCESS) { |
| PostCallRecordImportFence(dev_data, pImportFenceWin32HandleInfo->fence, pImportFenceWin32HandleInfo->handleType, |
| pImportFenceWin32HandleInfo->flags); |
| } |
| return result; |
| } |
| #endif |
| |
| VKAPI_ATTR VkResult VKAPI_CALL ImportFenceFdKHR(VkDevice device, const VkImportFenceFdInfoKHR *pImportFenceFdInfo) { |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool skip = PreCallValidateImportFence(dev_data, pImportFenceFdInfo->fence, "vkImportFenceFdKHR"); |
| |
| if (!skip) { |
| result = dev_data->dispatch_table.ImportFenceFdKHR(device, pImportFenceFdInfo); |
| } |
| |
| if (result == VK_SUCCESS) { |
| PostCallRecordImportFence(dev_data, pImportFenceFdInfo->fence, pImportFenceFdInfo->handleType, pImportFenceFdInfo->flags); |
| } |
| return result; |
| } |
| |
| static void PostCallRecordGetFence(layer_data *dev_data, VkFence fence, VkExternalFenceHandleTypeFlagBitsKHR handle_type) { |
| FENCE_NODE *fence_node = GetFenceNode(dev_data, fence); |
| if (fence_node) { |
| if (handle_type != VK_EXTERNAL_FENCE_HANDLE_TYPE_SYNC_FD_BIT_KHR) { |
| // Export with reference transference becomes external |
| fence_node->scope = kSyncScopeExternalPermanent; |
| } else if (fence_node->scope == kSyncScopeInternal) { |
| // Export with copy transference has a side effect of resetting the fence |
| fence_node->state = FENCE_UNSIGNALED; |
| } |
| } |
| } |
| |
| #ifdef VK_USE_PLATFORM_WIN32_KHR |
| VKAPI_ATTR VkResult VKAPI_CALL GetFenceWin32HandleKHR(VkDevice device, const VkFenceGetWin32HandleInfoKHR *pGetWin32HandleInfo, |
| HANDLE *pHandle) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.GetFenceWin32HandleKHR(device, pGetWin32HandleInfo, pHandle); |
| |
| if (result == VK_SUCCESS) { |
| PostCallRecordGetFence(dev_data, pGetWin32HandleInfo->fence, pGetWin32HandleInfo->handleType); |
| } |
| return result; |
| } |
| #endif |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetFenceFdKHR(VkDevice device, const VkFenceGetFdInfoKHR *pGetFdInfo, int *pFd) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.GetFenceFdKHR(device, pGetFdInfo, pFd); |
| |
| if (result == VK_SUCCESS) { |
| PostCallRecordGetFence(dev_data, pGetFdInfo->fence, pGetFdInfo->handleType); |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = dev_data->dispatch_table.CreateEvent(device, pCreateInfo, pAllocator, pEvent); |
| if (result == VK_SUCCESS) { |
| lock_guard_t lock(global_lock); |
| dev_data->eventMap[*pEvent].needsSignaled = false; |
| dev_data->eventMap[*pEvent].write_in_use = 0; |
| dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateCreateSwapchainKHR(layer_data *dev_data, const char *func_name, |
| VkSwapchainCreateInfoKHR const *pCreateInfo, SURFACE_STATE *surface_state, |
| SWAPCHAIN_NODE *old_swapchain_state) { |
| auto most_recent_swapchain = surface_state->swapchain ? surface_state->swapchain : surface_state->old_swapchain; |
| |
| // TODO: revisit this. some of these rules are being relaxed. |
| |
| // All physical devices and queue families are required to be able |
| // to present to any native window on Android; require the |
| // application to have established support on any other platform. |
| if (!dev_data->instance_data->extensions.vk_khr_android_surface) { |
| auto support_predicate = [dev_data](decltype(surface_state->gpu_queue_support)::value_type qs) -> bool { |
| // TODO: should restrict search only to queue families of VkDeviceQueueCreateInfos, not whole phys. device |
| return (qs.first.gpu == dev_data->physical_device) && qs.second; |
| }; |
| const auto &support = surface_state->gpu_queue_support; |
| bool is_supported = std::any_of(support.begin(), support.end(), support_predicate); |
| |
| if (!is_supported) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_146009ec, "DS", |
| "%s: pCreateInfo->surface is not known at this time to be supported for presentation by this device. The " |
| "vkGetPhysicalDeviceSurfaceSupportKHR() must be called beforehand, and it must return VK_TRUE support with " |
| "this surface for at least one queue family of this device. %s", |
| func_name, validation_error_map[VALIDATION_ERROR_146009ec])) |
| return true; |
| } |
| } |
| |
| if (most_recent_swapchain != old_swapchain_state || (surface_state->old_swapchain && surface_state->swapchain)) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, DRAWSTATE_SWAPCHAIN_ALREADY_EXISTS, "DS", |
| "%s: surface has an existing swapchain other than oldSwapchain", func_name)) |
| return true; |
| } |
| if (old_swapchain_state && old_swapchain_state->createInfo.surface != pCreateInfo->surface) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| HandleToUint64(pCreateInfo->oldSwapchain), __LINE__, DRAWSTATE_SWAPCHAIN_WRONG_SURFACE, "DS", |
| "%s: pCreateInfo->oldSwapchain's surface is not pCreateInfo->surface", func_name)) |
| return true; |
| } |
| |
| if ((pCreateInfo->imageExtent.width == 0) || (pCreateInfo->imageExtent.height == 0)) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_14600d32, "DS", |
| "%s: pCreateInfo->imageExtent = (%d, %d) which is illegal. %s", func_name, pCreateInfo->imageExtent.width, |
| pCreateInfo->imageExtent.height, validation_error_map[VALIDATION_ERROR_14600d32])) |
| return true; |
| } |
| |
| auto physical_device_state = GetPhysicalDeviceState(dev_data->instance_data, dev_data->physical_device); |
| if (physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState == UNCALLED) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| HandleToUint64(dev_data->physical_device), __LINE__, DRAWSTATE_SWAPCHAIN_CREATE_BEFORE_QUERY, "DS", |
| "%s: surface capabilities not retrieved for this physical device", func_name)) |
| return true; |
| } else { // have valid capabilities |
| auto &capabilities = physical_device_state->surfaceCapabilities; |
| // Validate pCreateInfo->minImageCount against VkSurfaceCapabilitiesKHR::{min|max}ImageCount: |
| if (pCreateInfo->minImageCount < capabilities.minImageCount) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_146009ee, "DS", |
| "%s called with minImageCount = %d, which is outside the bounds returned by " |
| "vkGetPhysicalDeviceSurfaceCapabilitiesKHR() (i.e. minImageCount = %d, maxImageCount = %d). %s", |
| func_name, pCreateInfo->minImageCount, capabilities.minImageCount, capabilities.maxImageCount, |
| validation_error_map[VALIDATION_ERROR_146009ee])) |
| return true; |
| } |
| |
| if ((capabilities.maxImageCount > 0) && (pCreateInfo->minImageCount > capabilities.maxImageCount)) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_146009f0, "DS", |
| "%s called with minImageCount = %d, which is outside the bounds returned by " |
| "vkGetPhysicalDeviceSurfaceCapabilitiesKHR() (i.e. minImageCount = %d, maxImageCount = %d). %s", |
| func_name, pCreateInfo->minImageCount, capabilities.minImageCount, capabilities.maxImageCount, |
| validation_error_map[VALIDATION_ERROR_146009f0])) |
| return true; |
| } |
| |
| // Validate pCreateInfo->imageExtent against VkSurfaceCapabilitiesKHR::{current|min|max}ImageExtent: |
| if ((pCreateInfo->imageExtent.width < capabilities.minImageExtent.width) || |
| (pCreateInfo->imageExtent.width > capabilities.maxImageExtent.width) || |
| (pCreateInfo->imageExtent.height < capabilities.minImageExtent.height) || |
| (pCreateInfo->imageExtent.height > capabilities.maxImageExtent.height)) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_146009f4, "DS", |
| "%s called with imageExtent = (%d,%d), which is outside the bounds returned by " |
| "vkGetPhysicalDeviceSurfaceCapabilitiesKHR(): currentExtent = (%d,%d), minImageExtent = (%d,%d), " |
| "maxImageExtent = (%d,%d). %s", |
| func_name, pCreateInfo->imageExtent.width, pCreateInfo->imageExtent.height, |
| capabilities.currentExtent.width, capabilities.currentExtent.height, capabilities.minImageExtent.width, |
| capabilities.minImageExtent.height, capabilities.maxImageExtent.width, capabilities.maxImageExtent.height, |
| validation_error_map[VALIDATION_ERROR_146009f4])) |
| return true; |
| } |
| // pCreateInfo->preTransform should have exactly one bit set, and that bit must also be set in |
| // VkSurfaceCapabilitiesKHR::supportedTransforms. |
| if (!pCreateInfo->preTransform || (pCreateInfo->preTransform & (pCreateInfo->preTransform - 1)) || |
| !(pCreateInfo->preTransform & capabilities.supportedTransforms)) { |
| // This is an error situation; one for which we'd like to give the developer a helpful, multi-line error message. Build |
| // it up a little at a time, and then log it: |
| std::string errorString = ""; |
| char str[1024]; |
| // Here's the first part of the message: |
| sprintf(str, "%s called with a non-supported pCreateInfo->preTransform (i.e. %s). Supported values are:\n", func_name, |
| string_VkSurfaceTransformFlagBitsKHR(pCreateInfo->preTransform)); |
| errorString += str; |
| for (int i = 0; i < 32; i++) { |
| // Build up the rest of the message: |
| if ((1 << i) & capabilities.supportedTransforms) { |
| const char *newStr = string_VkSurfaceTransformFlagBitsKHR((VkSurfaceTransformFlagBitsKHR)(1 << i)); |
| sprintf(str, " %s\n", newStr); |
| errorString += str; |
| } |
| } |
| // Log the message that we've built up: |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_146009fe, "DS", "%s. %s", errorString.c_str(), |
| validation_error_map[VALIDATION_ERROR_146009fe])) |
| return true; |
| } |
| |
| // pCreateInfo->compositeAlpha should have exactly one bit set, and that bit must also be set in |
| // VkSurfaceCapabilitiesKHR::supportedCompositeAlpha |
| if (!pCreateInfo->compositeAlpha || (pCreateInfo->compositeAlpha & (pCreateInfo->compositeAlpha - 1)) || |
| !((pCreateInfo->compositeAlpha) & capabilities.supportedCompositeAlpha)) { |
| // This is an error situation; one for which we'd like to give the developer a helpful, multi-line error message. Build |
| // it up a little at a time, and then log it: |
| std::string errorString = ""; |
| char str[1024]; |
| // Here's the first part of the message: |
| sprintf(str, "%s called with a non-supported pCreateInfo->compositeAlpha (i.e. %s). Supported values are:\n", |
| func_name, string_VkCompositeAlphaFlagBitsKHR(pCreateInfo->compositeAlpha)); |
| errorString += str; |
| for (int i = 0; i < 32; i++) { |
| // Build up the rest of the message: |
| if ((1 << i) & capabilities.supportedCompositeAlpha) { |
| const char *newStr = string_VkCompositeAlphaFlagBitsKHR((VkCompositeAlphaFlagBitsKHR)(1 << i)); |
| sprintf(str, " %s\n", newStr); |
| errorString += str; |
| } |
| } |
| // Log the message that we've built up: |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_14600a00, "DS", "%s. %s", errorString.c_str(), |
| validation_error_map[VALIDATION_ERROR_14600a00])) |
| return true; |
| } |
| // Validate pCreateInfo->imageArrayLayers against VkSurfaceCapabilitiesKHR::maxImageArrayLayers: |
| if (pCreateInfo->imageArrayLayers > capabilities.maxImageArrayLayers) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_146009f6, "DS", |
| "%s called with a non-supported imageArrayLayers (i.e. %d). Maximum value is %d. %s", func_name, |
| pCreateInfo->imageArrayLayers, capabilities.maxImageArrayLayers, |
| validation_error_map[VALIDATION_ERROR_146009f6])) |
| return true; |
| } |
| // Validate pCreateInfo->imageUsage against VkSurfaceCapabilitiesKHR::supportedUsageFlags: |
| if (pCreateInfo->imageUsage != (pCreateInfo->imageUsage & capabilities.supportedUsageFlags)) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_146009f8, "DS", |
| "%s called with a non-supported pCreateInfo->imageUsage (i.e. 0x%08x). Supported flag bits are 0x%08x. %s", |
| func_name, pCreateInfo->imageUsage, capabilities.supportedUsageFlags, |
| validation_error_map[VALIDATION_ERROR_146009f8])) |
| return true; |
| } |
| } |
| |
| // Validate pCreateInfo values with the results of vkGetPhysicalDeviceSurfaceFormatsKHR(): |
| if (physical_device_state->vkGetPhysicalDeviceSurfaceFormatsKHRState != QUERY_DETAILS) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, DRAWSTATE_SWAPCHAIN_CREATE_BEFORE_QUERY, "DS", |
| "%s called before calling vkGetPhysicalDeviceSurfaceFormatsKHR().", func_name)) |
| return true; |
| } else { |
| // Validate pCreateInfo->imageFormat against VkSurfaceFormatKHR::format: |
| bool foundFormat = false; |
| bool foundColorSpace = false; |
| bool foundMatch = false; |
| for (auto const &format : physical_device_state->surface_formats) { |
| if (pCreateInfo->imageFormat == format.format) { |
| // Validate pCreateInfo->imageColorSpace against VkSurfaceFormatKHR::colorSpace: |
| foundFormat = true; |
| if (pCreateInfo->imageColorSpace == format.colorSpace) { |
| foundMatch = true; |
| break; |
| } |
| } else { |
| if (pCreateInfo->imageColorSpace == format.colorSpace) { |
| foundColorSpace = true; |
| } |
| } |
| } |
| if (!foundMatch) { |
| if (!foundFormat) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_146009f2, "DS", |
| "%s called with a non-supported pCreateInfo->imageFormat (i.e. %d). %s", func_name, |
| pCreateInfo->imageFormat, validation_error_map[VALIDATION_ERROR_146009f2])) |
| return true; |
| } |
| if (!foundColorSpace) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_146009f2, "DS", |
| "%s called with a non-supported pCreateInfo->imageColorSpace (i.e. %d). %s", func_name, |
| pCreateInfo->imageColorSpace, validation_error_map[VALIDATION_ERROR_146009f2])) |
| return true; |
| } |
| } |
| } |
| |
| // Validate pCreateInfo values with the results of vkGetPhysicalDeviceSurfacePresentModesKHR(): |
| if (physical_device_state->vkGetPhysicalDeviceSurfacePresentModesKHRState != QUERY_DETAILS) { |
| // FIFO is required to always be supported |
| if (pCreateInfo->presentMode != VK_PRESENT_MODE_FIFO_KHR) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, DRAWSTATE_SWAPCHAIN_CREATE_BEFORE_QUERY, "DS", |
| "%s called before calling vkGetPhysicalDeviceSurfacePresentModesKHR().", func_name)) |
| return true; |
| } |
| } else { |
| // Validate pCreateInfo->presentMode against vkGetPhysicalDeviceSurfacePresentModesKHR(): |
| bool foundMatch = std::find(physical_device_state->present_modes.begin(), physical_device_state->present_modes.end(), |
| pCreateInfo->presentMode) != physical_device_state->present_modes.end(); |
| if (!foundMatch) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_14600a02, "DS", |
| "%s called with a non-supported presentMode (i.e. %s). %s", func_name, |
| string_VkPresentModeKHR(pCreateInfo->presentMode), validation_error_map[VALIDATION_ERROR_14600a02])) |
| return true; |
| } |
| } |
| // Validate state for shared presentable case |
| if (VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR == pCreateInfo->presentMode || |
| VK_PRESENT_MODE_SHARED_CONTINUOUS_REFRESH_KHR == pCreateInfo->presentMode) { |
| if (!dev_data->extensions.vk_khr_shared_presentable_image) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, DRAWSTATE_EXTENSION_NOT_ENABLED, "DS", |
| "%s called with presentMode %s which requires the VK_KHR_shared_presentable_image extension, which has not " |
| "been enabled.", |
| func_name, string_VkPresentModeKHR(pCreateInfo->presentMode))) |
| return true; |
| } else if (pCreateInfo->minImageCount != 1) { |
| if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(dev_data->device), __LINE__, VALIDATION_ERROR_14600ace, "DS", |
| "%s called with presentMode %s, but minImageCount value is %d. For shared presentable image, minImageCount " |
| "must be 1. %s", |
| func_name, string_VkPresentModeKHR(pCreateInfo->presentMode), pCreateInfo->minImageCount, |
| validation_error_map[VALIDATION_ERROR_14600ace])) |
| return true; |
| } |
| } |
| |
| return false; |
| } |
| |
| static void PostCallRecordCreateSwapchainKHR(layer_data *dev_data, VkResult result, const VkSwapchainCreateInfoKHR *pCreateInfo, |
| VkSwapchainKHR *pSwapchain, SURFACE_STATE *surface_state, |
| SWAPCHAIN_NODE *old_swapchain_state) { |
| if (VK_SUCCESS == result) { |
| lock_guard_t lock(global_lock); |
| auto swapchain_state = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(pCreateInfo, *pSwapchain)); |
| if (VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR == pCreateInfo->presentMode || |
| VK_PRESENT_MODE_SHARED_CONTINUOUS_REFRESH_KHR == pCreateInfo->presentMode) { |
| swapchain_state->shared_presentable = true; |
| } |
| surface_state->swapchain = swapchain_state.get(); |
| dev_data->swapchainMap[*pSwapchain] = std::move(swapchain_state); |
| } else { |
| surface_state->swapchain = nullptr; |
| } |
| // Spec requires that even if CreateSwapchainKHR fails, oldSwapchain behaves as replaced. |
| if (old_swapchain_state) { |
| old_swapchain_state->replaced = true; |
| } |
| surface_state->old_swapchain = old_swapchain_state; |
| return; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkSwapchainKHR *pSwapchain) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| auto surface_state = GetSurfaceState(dev_data->instance_data, pCreateInfo->surface); |
| auto old_swapchain_state = GetSwapchainNode(dev_data, pCreateInfo->oldSwapchain); |
| |
| if (PreCallValidateCreateSwapchainKHR(dev_data, "vkCreateSwapChainKHR()", pCreateInfo, surface_state, old_swapchain_state)) { |
| return VK_ERROR_VALIDATION_FAILED_EXT; |
| } |
| |
| VkResult result = dev_data->dispatch_table.CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); |
| |
| PostCallRecordCreateSwapchainKHR(dev_data, result, pCreateInfo, pSwapchain, surface_state, old_swapchain_state); |
| |
| return result; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| bool skip = false; |
| |
| unique_lock_t lock(global_lock); |
| auto swapchain_data = GetSwapchainNode(dev_data, swapchain); |
| if (swapchain_data) { |
| if (swapchain_data->images.size() > 0) { |
| for (auto swapchain_image : swapchain_data->images) { |
| auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); |
| if (image_sub != dev_data->imageSubresourceMap.end()) { |
| for (auto imgsubpair : image_sub->second) { |
| auto image_item = dev_data->imageLayoutMap.find(imgsubpair); |
| if (image_item != dev_data->imageLayoutMap.end()) { |
| dev_data->imageLayoutMap.erase(image_item); |
| } |
| } |
| dev_data->imageSubresourceMap.erase(image_sub); |
| } |
| skip = ClearMemoryObjectBindings(dev_data, HandleToUint64(swapchain_image), kVulkanObjectTypeSwapchainKHR); |
| dev_data->imageMap.erase(swapchain_image); |
| } |
| } |
| |
| auto surface_state = GetSurfaceState(dev_data->instance_data, swapchain_data->createInfo.surface); |
| if (surface_state) { |
| if (surface_state->swapchain == swapchain_data) surface_state->swapchain = nullptr; |
| if (surface_state->old_swapchain == swapchain_data) surface_state->old_swapchain = nullptr; |
| } |
| |
| dev_data->swapchainMap.erase(swapchain); |
| } |
| lock.unlock(); |
| if (!skip) dev_data->dispatch_table.DestroySwapchainKHR(device, swapchain, pAllocator); |
| } |
| |
| static bool PreCallValidateGetSwapchainImagesKHR(layer_data *device_data, SWAPCHAIN_NODE *swapchain_state, VkDevice device, |
| uint32_t *pSwapchainImageCount, VkImage *pSwapchainImages) { |
| bool skip = false; |
| if (swapchain_state && pSwapchainImages) { |
| lock_guard_t lock(global_lock); |
| // Compare the preliminary value of *pSwapchainImageCount with the value this time: |
| if (swapchain_state->vkGetSwapchainImagesKHRState == UNCALLED) { |
| skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(device), __LINE__, SWAPCHAIN_PRIOR_COUNT, "DS", |
| "vkGetSwapchainImagesKHR() called with non-NULL pSwapchainImageCount; but no prior positive value has " |
| "been seen for pSwapchainImages."); |
| } else if (*pSwapchainImageCount > swapchain_state->get_swapchain_image_count) { |
| skip |= |
| log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(device), __LINE__, SWAPCHAIN_INVALID_COUNT, "DS", |
| "vkGetSwapchainImagesKHR() called with non-NULL pSwapchainImageCount, and with pSwapchainImages set to a " |
| "value (%d) that is greater than the value (%d) that was returned when pSwapchainImageCount was NULL.", |
| *pSwapchainImageCount, swapchain_state->get_swapchain_image_count); |
| } |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordGetSwapchainImagesKHR(layer_data *device_data, SWAPCHAIN_NODE *swapchain_state, VkDevice device, |
| uint32_t *pSwapchainImageCount, VkImage *pSwapchainImages) { |
| lock_guard_t lock(global_lock); |
| |
| if (*pSwapchainImageCount > swapchain_state->images.size()) swapchain_state->images.resize(*pSwapchainImageCount); |
| |
| if (pSwapchainImages) { |
| if (swapchain_state->vkGetSwapchainImagesKHRState < QUERY_DETAILS) { |
| swapchain_state->vkGetSwapchainImagesKHRState = QUERY_DETAILS; |
| } |
| for (uint32_t i = 0; i < *pSwapchainImageCount; ++i) { |
| if (swapchain_state->images[i] != VK_NULL_HANDLE) continue; // Already retrieved this. |
| |
| IMAGE_LAYOUT_NODE image_layout_node; |
| image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; |
| image_layout_node.format = swapchain_state->createInfo.imageFormat; |
| // Add imageMap entries for each swapchain image |
| VkImageCreateInfo image_ci = {}; |
| image_ci.flags = 0; |
| image_ci.imageType = VK_IMAGE_TYPE_2D; |
| image_ci.format = swapchain_state->createInfo.imageFormat; |
| image_ci.extent.width = swapchain_state->createInfo.imageExtent.width; |
| image_ci.extent.height = swapchain_state->createInfo.imageExtent.height; |
| image_ci.extent.depth = 1; |
| image_ci.mipLevels = 1; |
| image_ci.arrayLayers = swapchain_state->createInfo.imageArrayLayers; |
| image_ci.samples = VK_SAMPLE_COUNT_1_BIT; |
| image_ci.tiling = VK_IMAGE_TILING_OPTIMAL; |
| image_ci.usage = swapchain_state->createInfo.imageUsage; |
| image_ci.sharingMode = swapchain_state->createInfo.imageSharingMode; |
| device_data->imageMap[pSwapchainImages[i]] = unique_ptr<IMAGE_STATE>(new IMAGE_STATE(pSwapchainImages[i], &image_ci)); |
| auto &image_state = device_data->imageMap[pSwapchainImages[i]]; |
| image_state->valid = false; |
| image_state->binding.mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; |
| swapchain_state->images[i] = pSwapchainImages[i]; |
| ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; |
| device_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); |
| device_data->imageLayoutMap[subpair] = image_layout_node; |
| } |
| } |
| |
| if (*pSwapchainImageCount) { |
| if (swapchain_state->vkGetSwapchainImagesKHRState < QUERY_COUNT) { |
| swapchain_state->vkGetSwapchainImagesKHRState = QUERY_COUNT; |
| } |
| swapchain_state->get_swapchain_image_count = *pSwapchainImageCount; |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pSwapchainImageCount, |
| VkImage *pSwapchainImages) { |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| |
| auto swapchain_state = GetSwapchainNode(device_data, swapchain); |
| bool skip = PreCallValidateGetSwapchainImagesKHR(device_data, swapchain_state, device, pSwapchainImageCount, pSwapchainImages); |
| |
| if (!skip) { |
| result = device_data->dispatch_table.GetSwapchainImagesKHR(device, swapchain, pSwapchainImageCount, pSwapchainImages); |
| } |
| |
| if ((result == VK_SUCCESS || result == VK_INCOMPLETE)) { |
| PostCallRecordGetSwapchainImagesKHR(device_data, swapchain_state, device, pSwapchainImageCount, pSwapchainImages); |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map); |
| bool skip = false; |
| |
| lock_guard_t lock(global_lock); |
| auto queue_state = GetQueueState(dev_data, queue); |
| |
| for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { |
| auto pSemaphore = GetSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); |
| if (pSemaphore && !pSemaphore->signaled) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
| "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", |
| HandleToUint64(queue), HandleToUint64(pPresentInfo->pWaitSemaphores[i])); |
| } |
| } |
| |
| for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { |
| auto swapchain_data = GetSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); |
| if (swapchain_data) { |
| if (pPresentInfo->pImageIndices[i] >= swapchain_data->images.size()) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| HandleToUint64(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_INVALID_IMAGE, "DS", |
| "vkQueuePresentKHR: Swapchain image index too large (%u). There are only %u images in this swapchain.", |
| pPresentInfo->pImageIndices[i], (uint32_t)swapchain_data->images.size()); |
| } else { |
| auto image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; |
| auto image_state = GetImageState(dev_data, image); |
| |
| if (image_state->shared_presentable) { |
| image_state->layout_locked = true; |
| } |
| |
| skip |= ValidateImageMemoryIsValid(dev_data, image_state, "vkQueuePresentKHR()"); |
| |
| if (!image_state->acquired) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| HandleToUint64(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_IMAGE_NOT_ACQUIRED, "DS", |
| "vkQueuePresentKHR: Swapchain image index %u has not been acquired.", pPresentInfo->pImageIndices[i]); |
| } |
| |
| vector<VkImageLayout> layouts; |
| if (FindLayouts(dev_data, image, layouts)) { |
| for (auto layout : layouts) { |
| if ((layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) && (!dev_data->extensions.vk_khr_shared_presentable_image || |
| (layout != VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR))) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, |
| HandleToUint64(queue), __LINE__, VALIDATION_ERROR_11200a20, "DS", |
| "Images passed to present must be in layout VK_IMAGE_LAYOUT_PRESENT_SRC_KHR or " |
| "VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR but is in %s. %s", |
| string_VkImageLayout(layout), validation_error_map[VALIDATION_ERROR_11200a20]); |
| } |
| } |
| } |
| } |
| |
| // All physical devices and queue families are required to be able |
| // to present to any native window on Android; require the |
| // application to have established support on any other platform. |
| if (!dev_data->instance_data->extensions.vk_khr_android_surface) { |
| auto surface_state = GetSurfaceState(dev_data->instance_data, swapchain_data->createInfo.surface); |
| auto support_it = surface_state->gpu_queue_support.find({dev_data->physical_device, queue_state->queueFamilyIndex}); |
| |
| if (support_it == surface_state->gpu_queue_support.end()) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| HandleToUint64(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_UNSUPPORTED_QUEUE, "DS", |
| "vkQueuePresentKHR: Presenting image without calling vkGetPhysicalDeviceSurfaceSupportKHR"); |
| } else if (!support_it->second) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| HandleToUint64(pPresentInfo->pSwapchains[i]), __LINE__, VALIDATION_ERROR_31800a18, "DS", |
| "vkQueuePresentKHR: Presenting image on queue that cannot present to this surface. %s", |
| validation_error_map[VALIDATION_ERROR_31800a18]); |
| } |
| } |
| } |
| } |
| if (pPresentInfo && pPresentInfo->pNext) { |
| // Verify ext struct |
| const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext); |
| if (present_regions) { |
| for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) { |
| auto swapchain_data = GetSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); |
| assert(swapchain_data); |
| VkPresentRegionKHR region = present_regions->pRegions[i]; |
| for (uint32_t j = 0; j < region.rectangleCount; ++j) { |
| VkRectLayerKHR rect = region.pRectangles[j]; |
| if ((rect.offset.x + rect.extent.width) > swapchain_data->createInfo.imageExtent.width) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, HandleToUint64(pPresentInfo->pSwapchains[i]), |
| __LINE__, VALIDATION_ERROR_11e009da, "DS", |
| "vkQueuePresentKHR(): For VkPresentRegionKHR down pNext chain, " |
| "pRegion[%i].pRectangles[%i], the sum of offset.x (%i) and extent.width (%i) is greater " |
| "than the corresponding swapchain's imageExtent.width (%i). %s", |
| i, j, rect.offset.x, rect.extent.width, swapchain_data->createInfo.imageExtent.width, |
| validation_error_map[VALIDATION_ERROR_11e009da]); |
| } |
| if ((rect.offset.y + rect.extent.height) > swapchain_data->createInfo.imageExtent.height) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, HandleToUint64(pPresentInfo->pSwapchains[i]), |
| __LINE__, VALIDATION_ERROR_11e009da, "DS", |
| "vkQueuePresentKHR(): For VkPresentRegionKHR down pNext chain, " |
| "pRegion[%i].pRectangles[%i], the sum of offset.y (%i) and extent.height (%i) is greater " |
| "than the corresponding swapchain's imageExtent.height (%i). %s", |
| i, j, rect.offset.y, rect.extent.height, swapchain_data->createInfo.imageExtent.height, |
| validation_error_map[VALIDATION_ERROR_11e009da]); |
| } |
| if (rect.layer > swapchain_data->createInfo.imageArrayLayers) { |
| skip |= log_msg( |
| dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| HandleToUint64(pPresentInfo->pSwapchains[i]), __LINE__, VALIDATION_ERROR_11e009dc, "DS", |
| "vkQueuePresentKHR(): For VkPresentRegionKHR down pNext chain, pRegion[%i].pRectangles[%i], the layer " |
| "(%i) is greater than the corresponding swapchain's imageArrayLayers (%i). %s", |
| i, j, rect.layer, swapchain_data->createInfo.imageArrayLayers, |
| validation_error_map[VALIDATION_ERROR_11e009dc]); |
| } |
| } |
| } |
| } |
| |
| const auto *present_times_info = lvl_find_in_chain<VkPresentTimesInfoGOOGLE>(pPresentInfo->pNext); |
| if (present_times_info) { |
| if (pPresentInfo->swapchainCount != present_times_info->swapchainCount) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| HandleToUint64(pPresentInfo->pSwapchains[0]), __LINE__, |
| |
| VALIDATION_ERROR_118009be, "DS", |
| "vkQueuePresentKHR(): VkPresentTimesInfoGOOGLE.swapchainCount is %i but pPresentInfo->swapchainCount " |
| "is %i. For VkPresentTimesInfoGOOGLE down pNext chain of VkPresentInfoKHR, " |
| "VkPresentTimesInfoGOOGLE.swapchainCount must equal VkPresentInfoKHR.swapchainCount.", |
| present_times_info->swapchainCount, pPresentInfo->swapchainCount); |
| } |
| } |
| } |
| |
| if (skip) { |
| return VK_ERROR_VALIDATION_FAILED_EXT; |
| } |
| |
| VkResult result = dev_data->dispatch_table.QueuePresentKHR(queue, pPresentInfo); |
| |
| if (result != VK_ERROR_VALIDATION_FAILED_EXT) { |
| // Semaphore waits occur before error generation, if the call reached |
| // the ICD. (Confirm?) |
| for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { |
| auto pSemaphore = GetSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); |
| if (pSemaphore) { |
| pSemaphore->signaler.first = VK_NULL_HANDLE; |
| pSemaphore->signaled = false; |
| } |
| } |
| |
| for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { |
| // Note: this is imperfect, in that we can get confused about what |
| // did or didn't succeed-- but if the app does that, it's confused |
| // itself just as much. |
| auto local_result = pPresentInfo->pResults ? pPresentInfo->pResults[i] : result; |
| |
| if (local_result != VK_SUCCESS && local_result != VK_SUBOPTIMAL_KHR) continue; // this present didn't actually happen. |
| |
| // Mark the image as having been released to the WSI |
| auto swapchain_data = GetSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); |
| auto image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; |
| auto image_state = GetImageState(dev_data, image); |
| image_state->acquired = false; |
| } |
| |
| // Note: even though presentation is directed to a queue, there is no |
| // direct ordering between QP and subsequent work, so QP (and its |
| // semaphore waits) /never/ participate in any completion proof. |
| } |
| |
| return result; |
| } |
| |
| static bool PreCallValidateCreateSharedSwapchainsKHR(layer_data *dev_data, uint32_t swapchainCount, |
| const VkSwapchainCreateInfoKHR *pCreateInfos, VkSwapchainKHR *pSwapchains, |
| std::vector<SURFACE_STATE *> &surface_state, |
| std::vector<SWAPCHAIN_NODE *> &old_swapchain_state) { |
| if (pCreateInfos) { |
| lock_guard_t lock(global_lock); |
| for (uint32_t i = 0; i < swapchainCount; i++) { |
| surface_state.push_back(GetSurfaceState(dev_data->instance_data, pCreateInfos[i].surface)); |
| old_swapchain_state.push_back(GetSwapchainNode(dev_data, pCreateInfos[i].oldSwapchain)); |
| std::stringstream func_name; |
| func_name << "vkCreateSharedSwapchainsKHR[" << swapchainCount << "]"; |
| if (PreCallValidateCreateSwapchainKHR(dev_data, func_name.str().c_str(), &pCreateInfos[i], surface_state[i], |
| old_swapchain_state[i])) { |
| return true; |
| } |
| } |
| } |
| return false; |
| } |
| |
| static void PostCallRecordCreateSharedSwapchainsKHR(layer_data *dev_data, VkResult result, uint32_t swapchainCount, |
| const VkSwapchainCreateInfoKHR *pCreateInfos, VkSwapchainKHR *pSwapchains, |
| std::vector<SURFACE_STATE *> &surface_state, |
| std::vector<SWAPCHAIN_NODE *> &old_swapchain_state) { |
| if (VK_SUCCESS == result) { |
| for (uint32_t i = 0; i < swapchainCount; i++) { |
| auto swapchain_state = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(&pCreateInfos[i], pSwapchains[i])); |
| if (VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR == pCreateInfos[i].presentMode || |
| VK_PRESENT_MODE_SHARED_CONTINUOUS_REFRESH_KHR == pCreateInfos[i].presentMode) { |
| swapchain_state->shared_presentable = true; |
| } |
| surface_state[i]->swapchain = swapchain_state.get(); |
| dev_data->swapchainMap[pSwapchains[i]] = std::move(swapchain_state); |
| } |
| } else { |
| for (uint32_t i = 0; i < swapchainCount; i++) { |
| surface_state[i]->swapchain = nullptr; |
| } |
| } |
| // Spec requires that even if CreateSharedSwapchainKHR fails, oldSwapchain behaves as replaced. |
| for (uint32_t i = 0; i < swapchainCount; i++) { |
| if (old_swapchain_state[i]) { |
| old_swapchain_state[i]->replaced = true; |
| } |
| surface_state[i]->old_swapchain = old_swapchain_state[i]; |
| } |
| return; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateSharedSwapchainsKHR(VkDevice device, uint32_t swapchainCount, |
| const VkSwapchainCreateInfoKHR *pCreateInfos, |
| const VkAllocationCallbacks *pAllocator, VkSwapchainKHR *pSwapchains) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| std::vector<SURFACE_STATE *> surface_state; |
| std::vector<SWAPCHAIN_NODE *> old_swapchain_state; |
| |
| if (PreCallValidateCreateSharedSwapchainsKHR(dev_data, swapchainCount, pCreateInfos, pSwapchains, surface_state, |
| old_swapchain_state)) { |
| return VK_ERROR_VALIDATION_FAILED_EXT; |
| } |
| |
| VkResult result = |
| dev_data->dispatch_table.CreateSharedSwapchainsKHR(device, swapchainCount, pCreateInfos, pAllocator, pSwapchains); |
| |
| PostCallRecordCreateSharedSwapchainsKHR(dev_data, result, swapchainCount, pCreateInfos, pSwapchains, surface_state, |
| old_swapchain_state); |
| |
| return result; |
| } |
| |
| static bool PreCallValidateAcquireNextImageKHR(layer_data *dev_data, VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, |
| VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { |
| bool skip = false; |
| if (fence == VK_NULL_HANDLE && semaphore == VK_NULL_HANDLE) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| HandleToUint64(device), __LINE__, DRAWSTATE_SWAPCHAIN_NO_SYNC_FOR_ACQUIRE, "DS", |
| "vkAcquireNextImageKHR: Semaphore and fence cannot both be VK_NULL_HANDLE. There would be no way to " |
| "determine the completion of this operation."); |
| } |
| |
| auto pSemaphore = GetSemaphoreNode(dev_data, semaphore); |
| if (pSemaphore && pSemaphore->scope == kSyncScopeInternal && pSemaphore->signaled) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| HandleToUint64(semaphore), __LINE__, VALIDATION_ERROR_16400a0c, "DS", |
| "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state. %s", |
| validation_error_map[VALIDATION_ERROR_16400a0c]); |
| } |
| |
| auto pFence = GetFenceNode(dev_data, fence); |
| if (pFence) { |
| skip |= ValidateFenceForSubmit(dev_data, pFence); |
| } |
| |
| auto swapchain_data = GetSwapchainNode(dev_data, swapchain); |
| if (swapchain_data->replaced) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| HandleToUint64(swapchain), __LINE__, DRAWSTATE_SWAPCHAIN_REPLACED, "DS", |
| "vkAcquireNextImageKHR: This swapchain has been replaced. The application can still present any images it " |
| "has acquired, but cannot acquire any more."); |
| } |
| |
| auto physical_device_state = GetPhysicalDeviceState(dev_data->instance_data, dev_data->physical_device); |
| if (physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState != UNCALLED) { |
| uint64_t acquired_images = std::count_if(swapchain_data->images.begin(), swapchain_data->images.end(), |
| [=](VkImage image) { return GetImageState(dev_data, image)->acquired; }); |
| if (acquired_images > swapchain_data->images.size() - physical_device_state->surfaceCapabilities.minImageCount) { |
| skip |= |
| log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| HandleToUint64(swapchain), __LINE__, DRAWSTATE_SWAPCHAIN_TOO_MANY_IMAGES, "DS", |
| "vkAcquireNextImageKHR: Application has already acquired the maximum number of images (0x%" PRIxLEAST64 ")", |
| acquired_images); |
| } |
| } |
| |
| if (swapchain_data->images.size() == 0) { |
| skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| HandleToUint64(swapchain), __LINE__, DRAWSTATE_SWAPCHAIN_IMAGES_NOT_FOUND, "DS", |
| "vkAcquireNextImageKHR: No images found to acquire from. Application probably did not call " |
| "vkGetSwapchainImagesKHR after swapchain creation."); |
| } |
| return skip; |
| } |
| |
| static void PostCallRecordAcquireNextImageKHR(layer_data *dev_data, VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, |
| VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { |
| auto pFence = GetFenceNode(dev_data, fence); |
| if (pFence && pFence->scope == kSyncScopeInternal) { |
| // Treat as inflight since it is valid to wait on this fence, even in cases where it is technically a temporary |
| // import |
| pFence->state = FENCE_INFLIGHT; |
| pFence->signaler.first = VK_NULL_HANDLE; // ANI isn't on a queue, so this can't participate in a completion proof. |
| } |
| |
| auto pSemaphore = GetSemaphoreNode(dev_data, semaphore); |
| if (pSemaphore && pSemaphore->scope == kSyncScopeInternal) { |
| // Treat as signaled since it is valid to wait on this semaphore, even in cases where it is technically a |
| // temporary import |
| pSemaphore->signaled = true; |
| pSemaphore->signaler.first = VK_NULL_HANDLE; |
| } |
| |
| // Mark the image as acquired. |
| auto swapchain_data = GetSwapchainNode(dev_data, swapchain); |
| auto image = swapchain_data->images[*pImageIndex]; |
| auto image_state = GetImageState(dev_data, image); |
| image_state->acquired = true; |
| image_state->shared_presentable = swapchain_data->shared_presentable; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, |
| VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| |
| unique_lock_t lock(global_lock); |
| bool skip = PreCallValidateAcquireNextImageKHR(dev_data, device, swapchain, timeout, semaphore, fence, pImageIndex); |
| lock.unlock(); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| VkResult result = dev_data->dispatch_table.AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); |
| |
| lock.lock(); |
| if (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) { |
| PostCallRecordAcquireNextImageKHR(dev_data, device, swapchain, timeout, semaphore, fence, pImageIndex); |
| } |
| lock.unlock(); |
| |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL EnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount, |
| VkPhysicalDevice *pPhysicalDevices) { |
| bool skip = false; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map); |
| assert(instance_data); |
| |
| // For this instance, flag when vkEnumeratePhysicalDevices goes to QUERY_COUNT and then QUERY_DETAILS |
| if (NULL == pPhysicalDevices) { |
| instance_data->vkEnumeratePhysicalDevicesState = QUERY_COUNT; |
| } else { |
| if (UNCALLED == instance_data->vkEnumeratePhysicalDevicesState) { |
| // Flag warning here. You can call this without having queried the count, but it may not be |
| // robust on platforms with multiple physical devices. |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, |
| 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", |
| "Call sequence has vkEnumeratePhysicalDevices() w/ non-NULL pPhysicalDevices. You should first call " |
| "vkEnumeratePhysicalDevices() w/ NULL pPhysicalDevices to query pPhysicalDeviceCount."); |
| } // TODO : Could also flag a warning if re-calling this function in QUERY_DETAILS state |
| else if (instance_data->physical_devices_count != *pPhysicalDeviceCount) { |
| // Having actual count match count from app is not a requirement, so this can be a warning |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", |
| "Call to vkEnumeratePhysicalDevices() w/ pPhysicalDeviceCount value %u, but actual count supported by " |
| "this instance is %u.", |
| *pPhysicalDeviceCount, instance_data->physical_devices_count); |
| } |
| instance_data->vkEnumeratePhysicalDevicesState = QUERY_DETAILS; |
| } |
| if (skip) { |
| return VK_ERROR_VALIDATION_FAILED_EXT; |
| } |
| VkResult result = instance_data->dispatch_table.EnumeratePhysicalDevices(instance, pPhysicalDeviceCount, pPhysicalDevices); |
| if (NULL == pPhysicalDevices) { |
| instance_data->physical_devices_count = *pPhysicalDeviceCount; |
| } else if (result == VK_SUCCESS) { // Save physical devices |
| for (uint32_t i = 0; i < *pPhysicalDeviceCount; i++) { |
| auto &phys_device_state = instance_data->physical_device_map[pPhysicalDevices[i]]; |
| phys_device_state.phys_device = pPhysicalDevices[i]; |
| // Init actual features for each physical device |
| instance_data->dispatch_table.GetPhysicalDeviceFeatures(pPhysicalDevices[i], &phys_device_state.features); |
| } |
| } |
| return result; |
| } |
| |
| // Common function to handle validation for GetPhysicalDeviceQueueFamilyProperties & 2KHR version |
| static bool ValidateCommonGetPhysicalDeviceQueueFamilyProperties(instance_layer_data *instance_data, |
| PHYSICAL_DEVICE_STATE *pd_state, |
| uint32_t requested_queue_family_property_count, bool qfp_null, |
| const char *caller_name) { |
| bool skip = false; |
| if (!qfp_null) { |
| // Verify that for each physical device, this command is called first with NULL pQueueFamilyProperties in order to get count |
| if (UNCALLED == pd_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { |
| skip |= log_msg( |
| instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| HandleToUint64(pd_state->phys_device), __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", |
| "%s is called with non-NULL pQueueFamilyProperties before obtaining pQueueFamilyPropertyCount. It is recommended " |
| "to first call %s with NULL pQueueFamilyProperties in order to obtain the maximal pQueueFamilyPropertyCount.", |
| caller_name, caller_name); |
| // Then verify that pCount that is passed in on second call matches what was returned |
| } else if (pd_state->queue_family_count != requested_queue_family_property_count) { |
| skip |= log_msg( |
| instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| HandleToUint64(pd_state->phys_device), __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", |
| "%s is called with non-NULL pQueueFamilyProperties and pQueueFamilyPropertyCount value %" PRIu32 |
| ", but the largest previously returned pQueueFamilyPropertyCount for this physicalDevice is %" PRIu32 |
| ". It is recommended to instead receive all the properties by calling %s with pQueueFamilyPropertyCount that was " |
| "previously obtained by calling %s with NULL pQueueFamilyProperties.", |
| caller_name, requested_queue_family_property_count, pd_state->queue_family_count, caller_name, caller_name); |
| } |
| pd_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_DETAILS; |
| } |
| |
| return skip; |
| } |
| |
| static bool PreCallValidateGetPhysicalDeviceQueueFamilyProperties(instance_layer_data *instance_data, |
| PHYSICAL_DEVICE_STATE *pd_state, |
| uint32_t *pQueueFamilyPropertyCount, |
| VkQueueFamilyProperties *pQueueFamilyProperties) { |
| return ValidateCommonGetPhysicalDeviceQueueFamilyProperties(instance_data, pd_state, *pQueueFamilyPropertyCount, |
| (nullptr == pQueueFamilyProperties), |
| "vkGetPhysicalDeviceQueueFamilyProperties()"); |
| } |
| |
| static bool PreCallValidateGetPhysicalDeviceQueueFamilyProperties2KHR(instance_layer_data *instance_data, |
| PHYSICAL_DEVICE_STATE *pd_state, |
| uint32_t *pQueueFamilyPropertyCount, |
| VkQueueFamilyProperties2KHR *pQueueFamilyProperties) { |
| return ValidateCommonGetPhysicalDeviceQueueFamilyProperties(instance_data, pd_state, *pQueueFamilyPropertyCount, |
| (nullptr == pQueueFamilyProperties), |
| "vkGetPhysicalDeviceQueueFamilyProperties2KHR()"); |
| } |
| |
| // Common function to update state for GetPhysicalDeviceQueueFamilyProperties & 2KHR version |
| static void StateUpdateCommonGetPhysicalDeviceQueueFamilyProperties(PHYSICAL_DEVICE_STATE *pd_state, uint32_t count, |
| VkQueueFamilyProperties2KHR *pQueueFamilyProperties) { |
| if (!pQueueFamilyProperties) { |
| if (UNCALLED == pd_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) |
| pd_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_COUNT; |
| pd_state->queue_family_count = count; |
| } else { // Save queue family properties |
| pd_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_DETAILS; |
| pd_state->queue_family_count = std::max(pd_state->queue_family_count, count); |
| |
| pd_state->queue_family_properties.resize(std::max(static_cast<uint32_t>(pd_state->queue_family_properties.size()), count)); |
| for (uint32_t i = 0; i < count; ++i) { |
| pd_state->queue_family_properties[i] = pQueueFamilyProperties[i].queueFamilyProperties; |
| } |
| } |
| } |
| |
| static void PostCallRecordGetPhysicalDeviceQueueFamilyProperties(PHYSICAL_DEVICE_STATE *pd_state, uint32_t count, |
| VkQueueFamilyProperties *pQueueFamilyProperties) { |
| VkQueueFamilyProperties2KHR *pqfp = nullptr; |
| std::vector<VkQueueFamilyProperties2KHR> qfp; |
| qfp.resize(count); |
| if (pQueueFamilyProperties) { |
| for (uint32_t i = 0; i < count; ++i) { |
| qfp[i].sType = VK_STRUCTURE_TYPE_QUEUE_FAMILY_PROPERTIES_2_KHR; |
| qfp[i].pNext = nullptr; |
| qfp[i].queueFamilyProperties = pQueueFamilyProperties[i]; |
| } |
| pqfp = qfp.data(); |
| } |
| StateUpdateCommonGetPhysicalDeviceQueueFamilyProperties(pd_state, count, pqfp); |
| } |
| |
| static void PostCallRecordGetPhysicalDeviceQueueFamilyProperties2KHR(PHYSICAL_DEVICE_STATE *pd_state, uint32_t count, |
| VkQueueFamilyProperties2KHR *pQueueFamilyProperties) { |
| StateUpdateCommonGetPhysicalDeviceQueueFamilyProperties(pd_state, count, pQueueFamilyProperties); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL GetPhysicalDeviceQueueFamilyProperties(VkPhysicalDevice physicalDevice, |
| uint32_t *pQueueFamilyPropertyCount, |
| VkQueueFamilyProperties *pQueueFamilyProperties) { |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| auto physical_device_state = GetPhysicalDeviceState(instance_data, physicalDevice); |
| assert(physical_device_state); |
| unique_lock_t lock(global_lock); |
| |
| bool skip = PreCallValidateGetPhysicalDeviceQueueFamilyProperties(instance_data, physical_device_state, |
| pQueueFamilyPropertyCount, pQueueFamilyProperties); |
| |
| lock.unlock(); |
| |
| if (skip) return; |
| |
| instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(physicalDevice, pQueueFamilyPropertyCount, |
| pQueueFamilyProperties); |
| |
| lock.lock(); |
| PostCallRecordGetPhysicalDeviceQueueFamilyProperties(physical_device_state, *pQueueFamilyPropertyCount, pQueueFamilyProperties); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL GetPhysicalDeviceQueueFamilyProperties2KHR(VkPhysicalDevice physicalDevice, |
| uint32_t *pQueueFamilyPropertyCount, |
| VkQueueFamilyProperties2KHR *pQueueFamilyProperties) { |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| auto physical_device_state = GetPhysicalDeviceState(instance_data, physicalDevice); |
| assert(physical_device_state); |
| unique_lock_t lock(global_lock); |
| |
| bool skip = PreCallValidateGetPhysicalDeviceQueueFamilyProperties2KHR(instance_data, physical_device_state, |
| pQueueFamilyPropertyCount, pQueueFamilyProperties); |
| |
| lock.unlock(); |
| |
| if (skip) return; |
| |
| instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties2KHR(physicalDevice, pQueueFamilyPropertyCount, |
| pQueueFamilyProperties); |
| |
| lock.lock(); |
| PostCallRecordGetPhysicalDeviceQueueFamilyProperties2KHR(physical_device_state, *pQueueFamilyPropertyCount, |
| pQueueFamilyProperties); |
| } |
| |
| template <typename TCreateInfo, typename FPtr> |
| static VkResult CreateSurface(VkInstance instance, TCreateInfo const *pCreateInfo, VkAllocationCallbacks const *pAllocator, |
| VkSurfaceKHR *pSurface, FPtr fptr) { |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map); |
| |
| // Call down the call chain: |
| VkResult result = (instance_data->dispatch_table.*fptr)(instance, pCreateInfo, pAllocator, pSurface); |
| |
| if (result == VK_SUCCESS) { |
| unique_lock_t lock(global_lock); |
| instance_data->surface_map[*pSurface] = SURFACE_STATE(*pSurface); |
| lock.unlock(); |
| } |
| |
| return result; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroySurfaceKHR(VkInstance instance, VkSurfaceKHR surface, const VkAllocationCallbacks *pAllocator) { |
| bool skip = false; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map); |
| unique_lock_t lock(global_lock); |
| auto surface_state = GetSurfaceState(instance_data, surface); |
| |
| if ((surface_state) && (surface_state->swapchain)) { |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, |
| HandleToUint64(instance), __LINE__, VALIDATION_ERROR_26c009e4, "DS", |
| "vkDestroySurfaceKHR() called before its associated VkSwapchainKHR was destroyed. %s", |
| validation_error_map[VALIDATION_ERROR_26c009e4]); |
| } |
| instance_data->surface_map.erase(surface); |
| lock.unlock(); |
| if (!skip) { |
| instance_data->dispatch_table.DestroySurfaceKHR(instance, surface, pAllocator); |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateDisplayPlaneSurfaceKHR(VkInstance instance, const VkDisplaySurfaceCreateInfoKHR *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateDisplayPlaneSurfaceKHR); |
| } |
| |
| #ifdef VK_USE_PLATFORM_ANDROID_KHR |
| VKAPI_ATTR VkResult VKAPI_CALL CreateAndroidSurfaceKHR(VkInstance instance, const VkAndroidSurfaceCreateInfoKHR *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateAndroidSurfaceKHR); |
| } |
| #endif // VK_USE_PLATFORM_ANDROID_KHR |
| |
| #ifdef VK_USE_PLATFORM_IOS_MVK |
| VKAPI_ATTR VkResult VKAPI_CALL CreateIOSSurfaceMVK(VkInstance instance, const VkIOSSurfaceCreateInfoMVK *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateIOSSurfaceMVK); |
| } |
| #endif // VK_USE_PLATFORM_IOS_MVK |
| |
| #ifdef VK_USE_PLATFORM_MACOS_MVK |
| VKAPI_ATTR VkResult VKAPI_CALL CreateMacOSSurfaceMVK(VkInstance instance, const VkMacOSSurfaceCreateInfoMVK *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateMacOSSurfaceMVK); |
| } |
| #endif // VK_USE_PLATFORM_MACOS_MVK |
| |
| #ifdef VK_USE_PLATFORM_MIR_KHR |
| VKAPI_ATTR VkResult VKAPI_CALL CreateMirSurfaceKHR(VkInstance instance, const VkMirSurfaceCreateInfoKHR *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateMirSurfaceKHR); |
| } |
| |
| VKAPI_ATTR VkBool32 VKAPI_CALL GetPhysicalDeviceMirPresentationSupportKHR(VkPhysicalDevice physicalDevice, |
| uint32_t queueFamilyIndex, MirConnection *connection) { |
| bool skip = false; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| |
| unique_lock_t lock(global_lock); |
| const auto pd_state = GetPhysicalDeviceState(instance_data, physicalDevice); |
| |
| skip |= ValidatePhysicalDeviceQueueFamily(instance_data, pd_state, queueFamilyIndex, VALIDATION_ERROR_2d2009e2, |
| "vkGetPhysicalDeviceMirPresentationSupportKHR", "queueFamilyIndex"); |
| |
| lock.unlock(); |
| |
| if (skip) return VK_FALSE; |
| |
| // Call down the call chain: |
| VkBool32 result = |
| instance_data->dispatch_table.GetPhysicalDeviceMirPresentationSupportKHR(physicalDevice, queueFamilyIndex, connection); |
| |
| return result; |
| } |
| #endif // VK_USE_PLATFORM_MIR_KHR |
| |
| #ifdef VK_USE_PLATFORM_WAYLAND_KHR |
| VKAPI_ATTR VkResult VKAPI_CALL CreateWaylandSurfaceKHR(VkInstance instance, const VkWaylandSurfaceCreateInfoKHR *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateWaylandSurfaceKHR); |
| } |
| |
| VKAPI_ATTR VkBool32 VKAPI_CALL GetPhysicalDeviceWaylandPresentationSupportKHR(VkPhysicalDevice physicalDevice, |
| uint32_t queueFamilyIndex, |
| struct wl_display *display) { |
| bool skip = false; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| |
| unique_lock_t lock(global_lock); |
| const auto pd_state = GetPhysicalDeviceState(instance_data, physicalDevice); |
| |
| skip |= ValidatePhysicalDeviceQueueFamily(instance_data, pd_state, queueFamilyIndex, VALIDATION_ERROR_2f000a34, |
| "vkGetPhysicalDeviceWaylandPresentationSupportKHR", "queueFamilyIndex"); |
| |
| lock.unlock(); |
| |
| if (skip) return VK_FALSE; |
| |
| // Call down the call chain: |
| VkBool32 result = |
| instance_data->dispatch_table.GetPhysicalDeviceWaylandPresentationSupportKHR(physicalDevice, queueFamilyIndex, display); |
| |
| return result; |
| } |
| #endif // VK_USE_PLATFORM_WAYLAND_KHR |
| |
| #ifdef VK_USE_PLATFORM_WIN32_KHR |
| VKAPI_ATTR VkResult VKAPI_CALL CreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateWin32SurfaceKHR); |
| } |
| |
| VKAPI_ATTR VkBool32 VKAPI_CALL GetPhysicalDeviceWin32PresentationSupportKHR(VkPhysicalDevice physicalDevice, |
| uint32_t queueFamilyIndex) { |
| bool skip = false; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| |
| unique_lock_t lock(global_lock); |
| const auto pd_state = GetPhysicalDeviceState(instance_data, physicalDevice); |
| |
| skip |= ValidatePhysicalDeviceQueueFamily(instance_data, pd_state, queueFamilyIndex, VALIDATION_ERROR_2f200a3a, |
| "vkGetPhysicalDeviceWin32PresentationSupportKHR", "queueFamilyIndex"); |
| |
| lock.unlock(); |
| |
| if (skip) return VK_FALSE; |
| |
| // Call down the call chain: |
| VkBool32 result = instance_data->dispatch_table.GetPhysicalDeviceWin32PresentationSupportKHR(physicalDevice, queueFamilyIndex); |
| |
| return result; |
| } |
| #endif // VK_USE_PLATFORM_WIN32_KHR |
| |
| #ifdef VK_USE_PLATFORM_XCB_KHR |
| VKAPI_ATTR VkResult VKAPI_CALL CreateXcbSurfaceKHR(VkInstance instance, const VkXcbSurfaceCreateInfoKHR *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateXcbSurfaceKHR); |
| } |
| |
| VKAPI_ATTR VkBool32 VKAPI_CALL GetPhysicalDeviceXcbPresentationSupportKHR(VkPhysicalDevice physicalDevice, |
| uint32_t queueFamilyIndex, xcb_connection_t *connection, |
| xcb_visualid_t visual_id) { |
| bool skip = false; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| |
| unique_lock_t lock(global_lock); |
| const auto pd_state = GetPhysicalDeviceState(instance_data, physicalDevice); |
| |
| skip |= ValidatePhysicalDeviceQueueFamily(instance_data, pd_state, queueFamilyIndex, VALIDATION_ERROR_2f400a40, |
| "vkGetPhysicalDeviceXcbPresentationSupportKHR", "queueFamilyIndex"); |
| |
| lock.unlock(); |
| |
| if (skip) return VK_FALSE; |
| |
| // Call down the call chain: |
| VkBool32 result = instance_data->dispatch_table.GetPhysicalDeviceXcbPresentationSupportKHR(physicalDevice, queueFamilyIndex, |
| connection, visual_id); |
| |
| return result; |
| } |
| #endif // VK_USE_PLATFORM_XCB_KHR |
| |
| #ifdef VK_USE_PLATFORM_XLIB_KHR |
| VKAPI_ATTR VkResult VKAPI_CALL CreateXlibSurfaceKHR(VkInstance instance, const VkXlibSurfaceCreateInfoKHR *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateXlibSurfaceKHR); |
| } |
| |
| VKAPI_ATTR VkBool32 VKAPI_CALL GetPhysicalDeviceXlibPresentationSupportKHR(VkPhysicalDevice physicalDevice, |
| uint32_t queueFamilyIndex, Display *dpy, |
| VisualID visualID) { |
| bool skip = false; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| |
| unique_lock_t lock(global_lock); |
| const auto pd_state = GetPhysicalDeviceState(instance_data, physicalDevice); |
| |
| skip |= ValidatePhysicalDeviceQueueFamily(instance_data, pd_state, queueFamilyIndex, VALIDATION_ERROR_2f600a46, |
| "vkGetPhysicalDeviceXlibPresentationSupportKHR", "queueFamilyIndex"); |
| |
| lock.unlock(); |
| |
| if (skip) return VK_FALSE; |
| |
| // Call down the call chain: |
| VkBool32 result = |
| instance_data->dispatch_table.GetPhysicalDeviceXlibPresentationSupportKHR(physicalDevice, queueFamilyIndex, dpy, visualID); |
| |
| return result; |
| } |
| #endif // VK_USE_PLATFORM_XLIB_KHR |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfaceCapabilitiesKHR(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, |
| VkSurfaceCapabilitiesKHR *pSurfaceCapabilities) { |
| auto instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| |
| unique_lock_t lock(global_lock); |
| auto physical_device_state = GetPhysicalDeviceState(instance_data, physicalDevice); |
| lock.unlock(); |
| |
| auto result = |
| instance_data->dispatch_table.GetPhysicalDeviceSurfaceCapabilitiesKHR(physicalDevice, surface, pSurfaceCapabilities); |
| |
| if (result == VK_SUCCESS) { |
| physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState = QUERY_DETAILS; |
| physical_device_state->surfaceCapabilities = *pSurfaceCapabilities; |
| } |
| |
| return result; |
| } |
| |
| static void PostCallRecordGetPhysicalDeviceSurfaceCapabilities2KHR(instance_layer_data *instanceData, |
| VkPhysicalDevice physicalDevice, |
| VkSurfaceCapabilities2KHR *pSurfaceCapabilities) { |
| unique_lock_t lock(global_lock); |
| auto physicalDeviceState = GetPhysicalDeviceState(instanceData, physicalDevice); |
| physicalDeviceState->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState = QUERY_DETAILS; |
| physicalDeviceState->surfaceCapabilities = pSurfaceCapabilities->surfaceCapabilities; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfaceCapabilities2KHR(VkPhysicalDevice physicalDevice, |
| const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo, |
| VkSurfaceCapabilities2KHR *pSurfaceCapabilities) { |
| auto instanceData = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| |
| auto result = |
| instanceData->dispatch_table.GetPhysicalDeviceSurfaceCapabilities2KHR(physicalDevice, pSurfaceInfo, pSurfaceCapabilities); |
| |
| if (result == VK_SUCCESS) { |
| PostCallRecordGetPhysicalDeviceSurfaceCapabilities2KHR(instanceData, physicalDevice, pSurfaceCapabilities); |
| } |
| |
| return result; |
| } |
| |
| static void PostCallRecordGetPhysicalDeviceSurfaceCapabilities2EXT(instance_layer_data *instanceData, |
| VkPhysicalDevice physicalDevice, |
| VkSurfaceCapabilities2EXT *pSurfaceCapabilities) { |
| unique_lock_t lock(global_lock); |
| auto physicalDeviceState = GetPhysicalDeviceState(instanceData, physicalDevice); |
| physicalDeviceState->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState = QUERY_DETAILS; |
| physicalDeviceState->surfaceCapabilities.minImageCount = pSurfaceCapabilities->minImageCount; |
| physicalDeviceState->surfaceCapabilities.maxImageCount = pSurfaceCapabilities->maxImageCount; |
| physicalDeviceState->surfaceCapabilities.currentExtent = pSurfaceCapabilities->currentExtent; |
| physicalDeviceState->surfaceCapabilities.minImageExtent = pSurfaceCapabilities->minImageExtent; |
| physicalDeviceState->surfaceCapabilities.maxImageExtent = pSurfaceCapabilities->maxImageExtent; |
| physicalDeviceState->surfaceCapabilities.maxImageArrayLayers = pSurfaceCapabilities->maxImageArrayLayers; |
| physicalDeviceState->surfaceCapabilities.supportedTransforms = pSurfaceCapabilities->supportedTransforms; |
| physicalDeviceState->surfaceCapabilities.currentTransform = pSurfaceCapabilities->currentTransform; |
| physicalDeviceState->surfaceCapabilities.supportedCompositeAlpha = pSurfaceCapabilities->supportedCompositeAlpha; |
| physicalDeviceState->surfaceCapabilities.supportedUsageFlags = pSurfaceCapabilities->supportedUsageFlags; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfaceCapabilities2EXT(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, |
| VkSurfaceCapabilities2EXT *pSurfaceCapabilities) { |
| auto instanceData = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| |
| auto result = |
| instanceData->dispatch_table.GetPhysicalDeviceSurfaceCapabilities2EXT(physicalDevice, surface, pSurfaceCapabilities); |
| |
| if (result == VK_SUCCESS) { |
| PostCallRecordGetPhysicalDeviceSurfaceCapabilities2EXT(instanceData, physicalDevice, pSurfaceCapabilities); |
| } |
| |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfaceSupportKHR(VkPhysicalDevice physicalDevice, uint32_t queueFamilyIndex, |
| VkSurfaceKHR surface, VkBool32 *pSupported) { |
| bool skip = false; |
| auto instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| |
| unique_lock_t lock(global_lock); |
| const auto pd_state = GetPhysicalDeviceState(instance_data, physicalDevice); |
| auto surface_state = GetSurfaceState(instance_data, surface); |
| |
| skip |= ValidatePhysicalDeviceQueueFamily(instance_data, pd_state, queueFamilyIndex, VALIDATION_ERROR_2ee009ea, |
| "vkGetPhysicalDeviceSurfaceSupportKHR", "queueFamilyIndex"); |
| |
| lock.unlock(); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| auto result = |
| instance_data->dispatch_table.GetPhysicalDeviceSurfaceSupportKHR(physicalDevice, queueFamilyIndex, surface, pSupported); |
| |
| if (result == VK_SUCCESS) { |
| surface_state->gpu_queue_support[{physicalDevice, queueFamilyIndex}] = (*pSupported == VK_TRUE); |
| } |
| |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfacePresentModesKHR(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, |
| uint32_t *pPresentModeCount, |
| VkPresentModeKHR *pPresentModes) { |
| bool skip = false; |
| auto instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| unique_lock_t lock(global_lock); |
| // TODO: this isn't quite right. available modes may differ by surface AND physical device. |
| auto physical_device_state = GetPhysicalDeviceState(instance_data, physicalDevice); |
| auto &call_state = physical_device_state->vkGetPhysicalDeviceSurfacePresentModesKHRState; |
| |
| if (pPresentModes) { |
| // Compare the preliminary value of *pPresentModeCount with the value this time: |
| auto prev_mode_count = (uint32_t)physical_device_state->present_modes.size(); |
| switch (call_state) { |
| case UNCALLED: |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice), __LINE__, |
| DEVLIMITS_MUST_QUERY_COUNT, "DL", |
| "vkGetPhysicalDeviceSurfacePresentModesKHR() called with non-NULL pPresentModeCount; but no prior " |
| "positive value has been seen for pPresentModeCount."); |
| break; |
| default: |
| // both query count and query details |
| if (*pPresentModeCount != prev_mode_count) { |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice), __LINE__, |
| DEVLIMITS_COUNT_MISMATCH, "DL", |
| "vkGetPhysicalDeviceSurfacePresentModesKHR() called with *pPresentModeCount (%u) that differs " |
| "from the value (%u) that was returned when pPresentModes was NULL.", |
| *pPresentModeCount, prev_mode_count); |
| } |
| break; |
| } |
| } |
| lock.unlock(); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| auto result = instance_data->dispatch_table.GetPhysicalDeviceSurfacePresentModesKHR(physicalDevice, surface, pPresentModeCount, |
| pPresentModes); |
| |
| if (result == VK_SUCCESS || result == VK_INCOMPLETE) { |
| lock.lock(); |
| |
| if (*pPresentModeCount) { |
| if (call_state < QUERY_COUNT) call_state = QUERY_COUNT; |
| if (*pPresentModeCount > physical_device_state->present_modes.size()) |
| physical_device_state->present_modes.resize(*pPresentModeCount); |
| } |
| if (pPresentModes) { |
| if (call_state < QUERY_DETAILS) call_state = QUERY_DETAILS; |
| for (uint32_t i = 0; i < *pPresentModeCount; i++) { |
| physical_device_state->present_modes[i] = pPresentModes[i]; |
| } |
| } |
| } |
| |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfaceFormatsKHR(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, |
| uint32_t *pSurfaceFormatCount, |
| VkSurfaceFormatKHR *pSurfaceFormats) { |
| bool skip = false; |
| auto instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| unique_lock_t lock(global_lock); |
| auto physical_device_state = GetPhysicalDeviceState(instance_data, physicalDevice); |
| auto &call_state = physical_device_state->vkGetPhysicalDeviceSurfaceFormatsKHRState; |
| |
| if (pSurfaceFormats) { |
| auto prev_format_count = (uint32_t)physical_device_state->surface_formats.size(); |
| |
| switch (call_state) { |
| case UNCALLED: |
| // Since we haven't recorded a preliminary value of *pSurfaceFormatCount, that likely means that the application |
| // didn't |
| // previously call this function with a NULL value of pSurfaceFormats: |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice), __LINE__, |
| DEVLIMITS_MUST_QUERY_COUNT, "DL", |
| "vkGetPhysicalDeviceSurfaceFormatsKHR() called with non-NULL pSurfaceFormatCount; but no prior " |
| "positive value has been seen for pSurfaceFormats."); |
| break; |
| default: |
| if (prev_format_count != *pSurfaceFormatCount) { |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice), __LINE__, |
| DEVLIMITS_COUNT_MISMATCH, "DL", |
| "vkGetPhysicalDeviceSurfaceFormatsKHR() called with non-NULL pSurfaceFormatCount, and with " |
| "pSurfaceFormats set to a value (%u) that is greater than the value (%u) that was returned " |
| "when pSurfaceFormatCount was NULL.", |
| *pSurfaceFormatCount, prev_format_count); |
| } |
| break; |
| } |
| } |
| lock.unlock(); |
| |
| if (skip) return VK_ERROR_VALIDATION_FAILED_EXT; |
| |
| // Call down the call chain: |
| auto result = instance_data->dispatch_table.GetPhysicalDeviceSurfaceFormatsKHR(physicalDevice, surface, pSurfaceFormatCount, |
| pSurfaceFormats); |
| |
| if (result == VK_SUCCESS || result == VK_INCOMPLETE) { |
| lock.lock(); |
| |
| if (*pSurfaceFormatCount) { |
| if (call_state < QUERY_COUNT) call_state = QUERY_COUNT; |
| if (*pSurfaceFormatCount > physical_device_state->surface_formats.size()) |
| physical_device_state->surface_formats.resize(*pSurfaceFormatCount); |
| } |
| if (pSurfaceFormats) { |
| if (call_state < QUERY_DETAILS) call_state = QUERY_DETAILS; |
| for (uint32_t i = 0; i < *pSurfaceFormatCount; i++) { |
| physical_device_state->surface_formats[i] = pSurfaceFormats[i]; |
| } |
| } |
| } |
| return result; |
| } |
| |
| static void PostCallRecordGetPhysicalDeviceSurfaceFormats2KHR(instance_layer_data *instanceData, VkPhysicalDevice physicalDevice, |
| uint32_t *pSurfaceFormatCount, VkSurfaceFormat2KHR *pSurfaceFormats) { |
| unique_lock_t lock(global_lock); |
| auto physicalDeviceState = GetPhysicalDeviceState(instanceData, physicalDevice); |
| if (*pSurfaceFormatCount) { |
| if (physicalDeviceState->vkGetPhysicalDeviceSurfaceFormatsKHRState < QUERY_COUNT) { |
| physicalDeviceState->vkGetPhysicalDeviceSurfaceFormatsKHRState = QUERY_COUNT; |
| } |
| if (*pSurfaceFormatCount > physicalDeviceState->surface_formats.size()) |
| physicalDeviceState->surface_formats.resize(*pSurfaceFormatCount); |
| } |
| if (pSurfaceFormats) { |
| if (physicalDeviceState->vkGetPhysicalDeviceSurfaceFormatsKHRState < QUERY_DETAILS) { |
| physicalDeviceState->vkGetPhysicalDeviceSurfaceFormatsKHRState = QUERY_DETAILS; |
| } |
| for (uint32_t i = 0; i < *pSurfaceFormatCount; i++) { |
| physicalDeviceState->surface_formats[i] = pSurfaceFormats[i].surfaceFormat; |
| } |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfaceFormats2KHR(VkPhysicalDevice physicalDevice, |
| const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo, |
| uint32_t *pSurfaceFormatCount, |
| VkSurfaceFormat2KHR *pSurfaceFormats) { |
| auto instanceData = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| auto result = instanceData->dispatch_table.GetPhysicalDeviceSurfaceFormats2KHR(physicalDevice, pSurfaceInfo, |
| pSurfaceFormatCount, pSurfaceFormats); |
| if (result == VK_SUCCESS || result == VK_INCOMPLETE) { |
| PostCallRecordGetPhysicalDeviceSurfaceFormats2KHR(instanceData, physicalDevice, pSurfaceFormatCount, pSurfaceFormats); |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateDebugReportCallbackEXT(VkInstance instance, |
| const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, |
| VkDebugReportCallbackEXT *pMsgCallback) { |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map); |
| VkResult res = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); |
| if (VK_SUCCESS == res) { |
| lock_guard_t lock(global_lock); |
| res = layer_create_msg_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); |
| } |
| return res; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback, |
| const VkAllocationCallbacks *pAllocator) { |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map); |
| instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); |
| lock_guard_t lock(global_lock); |
| layer_destroy_msg_callback(instance_data->report_data, msgCallback, pAllocator); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, |
| VkDebugReportObjectTypeEXT objType, uint64_t object, size_t location, |
| int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map); |
| instance_data->dispatch_table.DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL EnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { |
| return util_GetLayerProperties(1, &global_layer, pCount, pProperties); |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, |
| VkLayerProperties *pProperties) { |
| return util_GetLayerProperties(1, &global_layer, pCount, pProperties); |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL EnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, |
| VkExtensionProperties *pProperties) { |
| if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) |
| return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); |
| |
| return VK_ERROR_LAYER_NOT_PRESENT; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName, |
| uint32_t *pCount, VkExtensionProperties *pProperties) { |
| if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) |
| return util_GetExtensionProperties(1, device_extensions, pCount, pProperties); |
| |
| assert(physicalDevice); |
| |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| return instance_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL EnumeratePhysicalDeviceGroupsKHX( |
| VkInstance instance, uint32_t *pPhysicalDeviceGroupCount, VkPhysicalDeviceGroupPropertiesKHX *pPhysicalDeviceGroupProperties) { |
| bool skip = false; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map); |
| |
| if (instance_data) { |
| // For this instance, flag when EnumeratePhysicalDeviceGroupsKHX goes to QUERY_COUNT and then QUERY_DETAILS. |
| if (NULL == pPhysicalDeviceGroupProperties) { |
| instance_data->vkEnumeratePhysicalDeviceGroupsState = QUERY_COUNT; |
| } else { |
| if (UNCALLED == instance_data->vkEnumeratePhysicalDeviceGroupsState) { |
| // Flag warning here. You can call this without having queried the count, but it may not be |
| // robust on platforms with multiple physical devices. |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", |
| "Call sequence has vkEnumeratePhysicalDeviceGroupsKHX() w/ non-NULL " |
| "pPhysicalDeviceGroupProperties. You should first call vkEnumeratePhysicalDeviceGroupsKHX() w/ " |
| "NULL pPhysicalDeviceGroupProperties to query pPhysicalDeviceGroupCount."); |
| } // TODO : Could also flag a warning if re-calling this function in QUERY_DETAILS state |
| else if (instance_data->physical_device_groups_count != *pPhysicalDeviceGroupCount) { |
| // Having actual count match count from app is not a requirement, so this can be a warning |
| skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", |
| "Call to vkEnumeratePhysicalDeviceGroupsKHX() w/ pPhysicalDeviceGroupCount value %u, but actual " |
| "count supported by this instance is %u.", |
| *pPhysicalDeviceGroupCount, instance_data->physical_device_groups_count); |
| } |
| instance_data->vkEnumeratePhysicalDeviceGroupsState = QUERY_DETAILS; |
| } |
| if (skip) { |
| return VK_ERROR_VALIDATION_FAILED_EXT; |
| } |
| VkResult result = instance_data->dispatch_table.EnumeratePhysicalDeviceGroupsKHX(instance, pPhysicalDeviceGroupCount, |
| pPhysicalDeviceGroupProperties); |
| if (NULL == pPhysicalDeviceGroupProperties) { |
| instance_data->physical_device_groups_count = *pPhysicalDeviceGroupCount; |
| } else if (result == VK_SUCCESS) { // Save physical devices |
| for (uint32_t i = 0; i < *pPhysicalDeviceGroupCount; i++) { |
| for (uint32_t j = 0; j < pPhysicalDeviceGroupProperties[i].physicalDeviceCount; j++) { |
| VkPhysicalDevice cur_phys_dev = pPhysicalDeviceGroupProperties[i].physicalDevices[j]; |
| auto &phys_device_state = instance_data->physical_device_map[cur_phys_dev]; |
| phys_device_state.phys_device = cur_phys_dev; |
| // Init actual features for each physical device |
| instance_data->dispatch_table.GetPhysicalDeviceFeatures(cur_phys_dev, &phys_device_state.features); |
| } |
| } |
| } |
| return result; |
| } else { |
| log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 0, __LINE__, |
| DEVLIMITS_INVALID_INSTANCE, "DL", |
| "Invalid instance (0x%" PRIx64 ") passed into vkEnumeratePhysicalDeviceGroupsKHX().", HandleToUint64(instance)); |
| } |
| return VK_ERROR_VALIDATION_FAILED_EXT; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL CreateDescriptorUpdateTemplateKHR(VkDevice device, |
| const VkDescriptorUpdateTemplateCreateInfoKHR *pCreateInfo, |
| const VkAllocationCallbacks *pAllocator, |
| VkDescriptorUpdateTemplateKHR *pDescriptorUpdateTemplate) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = |
| dev_data->dispatch_table.CreateDescriptorUpdateTemplateKHR(device, pCreateInfo, pAllocator, pDescriptorUpdateTemplate); |
| if (VK_SUCCESS == result) { |
| lock_guard_t lock(global_lock); |
| // Shadow template createInfo for later updates |
| safe_VkDescriptorUpdateTemplateCreateInfoKHR *local_create_info = |
| new safe_VkDescriptorUpdateTemplateCreateInfoKHR(pCreateInfo); |
| std::unique_ptr<TEMPLATE_STATE> template_state(new TEMPLATE_STATE(*pDescriptorUpdateTemplate, local_create_info)); |
| dev_data->desc_template_map[*pDescriptorUpdateTemplate] = std::move(template_state); |
| } |
| return result; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL DestroyDescriptorUpdateTemplateKHR(VkDevice device, |
| VkDescriptorUpdateTemplateKHR descriptorUpdateTemplate, |
| const VkAllocationCallbacks *pAllocator) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| unique_lock_t lock(global_lock); |
| dev_data->desc_template_map.erase(descriptorUpdateTemplate); |
| lock.unlock(); |
| dev_data->dispatch_table.DestroyDescriptorUpdateTemplateKHR(device, descriptorUpdateTemplate, pAllocator); |
| } |
| |
| // PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSetsWithTemplate() |
| static void PostCallRecordUpdateDescriptorSetWithTemplateKHR(layer_data *device_data, VkDescriptorSet descriptorSet, |
| VkDescriptorUpdateTemplateKHR descriptorUpdateTemplate, |
| const void *pData) { |
| auto const template_map_entry = device_data->desc_template_map.find(descriptorUpdateTemplate); |
| if (template_map_entry == device_data->desc_template_map.end()) { |
| assert(0); |
| } |
| |
| cvdescriptorset::PerformUpdateDescriptorSetsWithTemplateKHR(device_data, descriptorSet, template_map_entry->second, pData); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL UpdateDescriptorSetWithTemplateKHR(VkDevice device, VkDescriptorSet descriptorSet, |
| VkDescriptorUpdateTemplateKHR descriptorUpdateTemplate, |
| const void *pData) { |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| device_data->dispatch_table.UpdateDescriptorSetWithTemplateKHR(device, descriptorSet, descriptorUpdateTemplate, pData); |
| |
| PostCallRecordUpdateDescriptorSetWithTemplateKHR(device_data, descriptorSet, descriptorUpdateTemplate, pData); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdPushDescriptorSetWithTemplateKHR(VkCommandBuffer commandBuffer, |
| VkDescriptorUpdateTemplateKHR descriptorUpdateTemplate, |
| VkPipelineLayout layout, uint32_t set, const void *pData) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = false; |
| GLOBAL_CB_NODE *cb_state = GetCBNode(dev_data, commandBuffer); |
| // Minimal validation for command buffer state |
| if (cb_state) { |
| skip |= ValidateCmd(dev_data, cb_state, CMD_PUSHDESCRIPTORSETWITHTEMPLATEKHR, "vkCmdPushDescriptorSetWithTemplateKHR()"); |
| } |
| lock.unlock(); |
| |
| if (!skip) { |
| dev_data->dispatch_table.CmdPushDescriptorSetWithTemplateKHR(commandBuffer, descriptorUpdateTemplate, layout, set, pData); |
| } |
| } |
| |
| static void PostCallRecordGetPhysicalDeviceDisplayPlanePropertiesKHR(instance_layer_data *instanceData, |
| VkPhysicalDevice physicalDevice, uint32_t *pPropertyCount, |
| VkDisplayPlanePropertiesKHR *pProperties) { |
| unique_lock_t lock(global_lock); |
| auto physical_device_state = GetPhysicalDeviceState(instanceData, physicalDevice); |
| |
| if (*pPropertyCount) { |
| if (physical_device_state->vkGetPhysicalDeviceDisplayPlanePropertiesKHRState < QUERY_COUNT) { |
| physical_device_state->vkGetPhysicalDeviceDisplayPlanePropertiesKHRState = QUERY_COUNT; |
| } |
| physical_device_state->display_plane_property_count = *pPropertyCount; |
| } |
| if (pProperties) { |
| if (physical_device_state->vkGetPhysicalDeviceDisplayPlanePropertiesKHRState < QUERY_DETAILS) { |
| physical_device_state->vkGetPhysicalDeviceDisplayPlanePropertiesKHRState = QUERY_DETAILS; |
| } |
| } |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceDisplayPlanePropertiesKHR(VkPhysicalDevice physicalDevice, uint32_t *pPropertyCount, |
| VkDisplayPlanePropertiesKHR *pProperties) { |
| VkResult result = VK_SUCCESS; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| |
| result = instance_data->dispatch_table.GetPhysicalDeviceDisplayPlanePropertiesKHR(physicalDevice, pPropertyCount, pProperties); |
| |
| if (result == VK_SUCCESS || result == VK_INCOMPLETE) { |
| PostCallRecordGetPhysicalDeviceDisplayPlanePropertiesKHR(instance_data, physicalDevice, pPropertyCount, pProperties); |
| } |
| |
| return result; |
| } |
| |
| static bool ValidateGetPhysicalDeviceDisplayPlanePropertiesKHRQuery(instance_layer_data *instance_data, |
| VkPhysicalDevice physicalDevice, uint32_t planeIndex, |
| const char *api_name) { |
| bool skip = false; |
| auto physical_device_state = GetPhysicalDeviceState(instance_data, physicalDevice); |
| if (physical_device_state->vkGetPhysicalDeviceDisplayPlanePropertiesKHRState == UNCALLED) { |
| skip |= log_msg( |
| instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| HandleToUint64(physicalDevice), __LINE__, SWAPCHAIN_GET_SUPPORTED_DISPLAYS_WITHOUT_QUERY, "DL", |
| "Potential problem with calling %s() without first querying vkGetPhysicalDeviceDisplayPlanePropertiesKHR.", api_name); |
| } else { |
| if (planeIndex >= physical_device_state->display_plane_property_count) { |
| skip |= log_msg( |
| instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| HandleToUint64(physicalDevice), __LINE__, VALIDATION_ERROR_29c009c2, "DL", |
| "%s(): planeIndex must be in the range [0, %d] that was returned by vkGetPhysicalDeviceDisplayPlanePropertiesKHR. " |
| "Do you have the plane index hardcoded? %s", |
| api_name, physical_device_state->display_plane_property_count - 1, validation_error_map[VALIDATION_ERROR_29c009c2]); |
| } |
| } |
| return skip; |
| } |
| |
| static bool PreCallValidateGetDisplayPlaneSupportedDisplaysKHR(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice, |
| uint32_t planeIndex) { |
| bool skip = false; |
| lock_guard_t lock(global_lock); |
| skip |= ValidateGetPhysicalDeviceDisplayPlanePropertiesKHRQuery(instance_data, physicalDevice, planeIndex, |
| "vkGetDisplayPlaneSupportedDisplaysKHR"); |
| return skip; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetDisplayPlaneSupportedDisplaysKHR(VkPhysicalDevice physicalDevice, uint32_t planeIndex, |
| uint32_t *pDisplayCount, VkDisplayKHR *pDisplays) { |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| bool skip = PreCallValidateGetDisplayPlaneSupportedDisplaysKHR(instance_data, physicalDevice, planeIndex); |
| if (!skip) { |
| result = |
| instance_data->dispatch_table.GetDisplayPlaneSupportedDisplaysKHR(physicalDevice, planeIndex, pDisplayCount, pDisplays); |
| } |
| return result; |
| } |
| |
| static bool PreCallValidateGetDisplayPlaneCapabilitiesKHR(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice, |
| uint32_t planeIndex) { |
| bool skip = false; |
| lock_guard_t lock(global_lock); |
| skip |= ValidateGetPhysicalDeviceDisplayPlanePropertiesKHRQuery(instance_data, physicalDevice, planeIndex, |
| "vkGetDisplayPlaneCapabilitiesKHR"); |
| return skip; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL GetDisplayPlaneCapabilitiesKHR(VkPhysicalDevice physicalDevice, VkDisplayModeKHR mode, |
| uint32_t planeIndex, VkDisplayPlaneCapabilitiesKHR *pCapabilities) { |
| VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| bool skip = PreCallValidateGetDisplayPlaneCapabilitiesKHR(instance_data, physicalDevice, planeIndex); |
| |
| if (!skip) { |
| result = instance_data->dispatch_table.GetDisplayPlaneCapabilitiesKHR(physicalDevice, mode, planeIndex, pCapabilities); |
| } |
| |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL DebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) { |
| unique_lock_t lock(global_lock); |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| if (pNameInfo->pObjectName) { |
| device_data->report_data->debugObjectNameMap->insert( |
| std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName)); |
| } else { |
| device_data->report_data->debugObjectNameMap->erase(pNameInfo->object); |
| } |
| lock.unlock(); |
| VkResult result = device_data->dispatch_table.DebugMarkerSetObjectNameEXT(device, pNameInfo); |
| return result; |
| } |
| |
| VKAPI_ATTR VkResult VKAPI_CALL DebugMarkerSetObjectTagEXT(VkDevice device, VkDebugMarkerObjectTagInfoEXT *pTagInfo) { |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| VkResult result = device_data->dispatch_table.DebugMarkerSetObjectTagEXT(device, pTagInfo); |
| return result; |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdDebugMarkerBeginEXT(VkCommandBuffer commandBuffer, VkDebugMarkerMarkerInfoEXT *pMarkerInfo) { |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = false; |
| GLOBAL_CB_NODE *cb_state = GetCBNode(device_data, commandBuffer); |
| // Minimal validation for command buffer state |
| if (cb_state) { |
| skip |= ValidateCmd(device_data, cb_state, CMD_DEBUGMARKERBEGINEXT, "vkCmdDebugMarkerBeginEXT()"); |
| } |
| lock.unlock(); |
| if (!skip) { |
| device_data->dispatch_table.CmdDebugMarkerBeginEXT(commandBuffer, pMarkerInfo); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdDebugMarkerEndEXT(VkCommandBuffer commandBuffer) { |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = false; |
| GLOBAL_CB_NODE *cb_state = GetCBNode(device_data, commandBuffer); |
| // Minimal validation for command buffer state |
| if (cb_state) { |
| skip |= ValidateCmd(device_data, cb_state, CMD_DEBUGMARKERENDEXT, "vkCmdDebugMarkerEndEXT()"); |
| } |
| lock.unlock(); |
| if (!skip) { |
| device_data->dispatch_table.CmdDebugMarkerEndEXT(commandBuffer); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdDebugMarkerInsertEXT(VkCommandBuffer commandBuffer, VkDebugMarkerMarkerInfoEXT *pMarkerInfo) { |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| device_data->dispatch_table.CmdDebugMarkerInsertEXT(commandBuffer, pMarkerInfo); |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdSetDiscardRectangleEXT(VkCommandBuffer commandBuffer, uint32_t firstDiscardRectangle, |
| uint32_t discardRectangleCount, const VkRect2D *pDiscardRectangles) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = false; |
| GLOBAL_CB_NODE *cb_state = GetCBNode(dev_data, commandBuffer); |
| // Minimal validation for command buffer state |
| if (cb_state) { |
| skip |= ValidateCmd(dev_data, cb_state, CMD_SETDISCARDRECTANGLEEXT, "vkCmdSetDiscardRectangleEXT()"); |
| } |
| lock.unlock(); |
| |
| if (!skip) { |
| dev_data->dispatch_table.CmdSetDiscardRectangleEXT(commandBuffer, firstDiscardRectangle, discardRectangleCount, |
| pDiscardRectangles); |
| } |
| } |
| |
| VKAPI_ATTR void VKAPI_CALL CmdSetSampleLocationsEXT(VkCommandBuffer commandBuffer, |
| const VkSampleLocationsInfoEXT *pSampleLocationsInfo) { |
| layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| unique_lock_t lock(global_lock); |
| bool skip = false; |
| GLOBAL_CB_NODE *cb_state = GetCBNode(dev_data, commandBuffer); |
| // Minimal validation for command buffer state |
| if (cb_state) { |
| skip |= ValidateCmd(dev_data, cb_state, CMD_SETSAMPLELOCATIONSEXT, "vkCmdSetSampleLocationsEXT()"); |
| } |
| lock.unlock(); |
| |
| if (!skip) { |
| dev_data->dispatch_table.CmdSetSampleLocationsEXT(commandBuffer, pSampleLocationsInfo); |
| } |
| } |
| |
| VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice device, const char *funcName); |
| VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName); |
| VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName); |
| |
| // Map of all APIs to be intercepted by this layer |
| static const std::unordered_map<std::string, void *> name_to_funcptr_map = { |
| {"vkGetInstanceProcAddr", (void *)GetInstanceProcAddr}, |
| {"vk_layerGetPhysicalDeviceProcAddr", (void *)GetPhysicalDeviceProcAddr}, |
| {"vkGetDeviceProcAddr", (void *)GetDeviceProcAddr}, |
| {"vkCreateInstance", (void *)CreateInstance}, |
| {"vkCreateDevice", (void *)CreateDevice}, |
| {"vkEnumeratePhysicalDevices", (void *)EnumeratePhysicalDevices}, |
| {"vkGetPhysicalDeviceQueueFamilyProperties", (void *)GetPhysicalDeviceQueueFamilyProperties}, |
| {"vkDestroyInstance", (void *)DestroyInstance}, |
| {"vkEnumerateInstanceLayerProperties", (void *)EnumerateInstanceLayerProperties}, |
| {"vkEnumerateDeviceLayerProperties", (void *)EnumerateDeviceLayerProperties}, |
| {"vkEnumerateInstanceExtensionProperties", (void *)EnumerateInstanceExtensionProperties}, |
| {"vkEnumerateDeviceExtensionProperties", (void *)EnumerateDeviceExtensionProperties}, |
| {"vkCreateDescriptorUpdateTemplateKHR", (void *)CreateDescriptorUpdateTemplateKHR}, |
| {"vkDestroyDescriptorUpdateTemplateKHR", (void *)DestroyDescriptorUpdateTemplateKHR}, |
| {"vkUpdateDescriptorSetWithTemplateKHR", (void *)UpdateDescriptorSetWithTemplateKHR}, |
| {"vkCmdPushDescriptorSetWithTemplateKHR", (void *)CmdPushDescriptorSetWithTemplateKHR}, |
| {"vkCmdPushDescriptorSetKHR", (void *)CmdPushDescriptorSetKHR}, |
| {"vkCreateSwapchainKHR", (void *)CreateSwapchainKHR}, |
| {"vkDestroySwapchainKHR", (void *)DestroySwapchainKHR}, |
| {"vkGetSwapchainImagesKHR", (void *)GetSwapchainImagesKHR}, |
| {"vkAcquireNextImageKHR", (void *)AcquireNextImageKHR}, |
| {"vkQueuePresentKHR", (void *)QueuePresentKHR}, |
| {"vkQueueSubmit", (void *)QueueSubmit}, |
| {"vkWaitForFences", (void *)WaitForFences}, |
| {"vkGetFenceStatus", (void *)GetFenceStatus}, |
| {"vkQueueWaitIdle", (void *)QueueWaitIdle}, |
| {"vkDeviceWaitIdle", (void *)DeviceWaitIdle}, |
| {"vkGetDeviceQueue", (void *)GetDeviceQueue}, |
| {"vkDestroyDevice", (void *)DestroyDevice}, |
| {"vkDestroyFence", (void *)DestroyFence}, |
| {"vkResetFences", (void *)ResetFences}, |
| {"vkDestroySemaphore", (void *)DestroySemaphore}, |
| {"vkDestroyEvent", (void *)DestroyEvent}, |
| {"vkDestroyQueryPool", (void *)DestroyQueryPool}, |
| {"vkDestroyBuffer", (void *)DestroyBuffer}, |
| {"vkDestroyBufferView", (void *)DestroyBufferView}, |
| {"vkDestroyImage", (void *)DestroyImage}, |
| {"vkDestroyImageView", (void *)DestroyImageView}, |
| {"vkDestroyShaderModule", (void *)DestroyShaderModule}, |
| {"vkDestroyPipeline", (void *)DestroyPipeline}, |
| {"vkDestroyPipelineLayout", (void *)DestroyPipelineLayout}, |
| {"vkDestroySampler", (void *)DestroySampler}, |
| {"vkDestroyDescriptorSetLayout", (void *)DestroyDescriptorSetLayout}, |
| {"vkDestroyDescriptorPool", (void *)DestroyDescriptorPool}, |
| {"vkDestroyFramebuffer", (void *)DestroyFramebuffer}, |
| {"vkDestroyRenderPass", (void *)DestroyRenderPass}, |
| {"vkCreateBuffer", (void *)CreateBuffer}, |
| {"vkCreateBufferView", (void *)CreateBufferView}, |
| {"vkCreateImage", (void *)CreateImage}, |
| {"vkCreateImageView", (void *)CreateImageView}, |
| {"vkCreateFence", (void *)CreateFence}, |
| {"vkCreatePipelineCache", (void *)CreatePipelineCache}, |
| {"vkDestroyPipelineCache", (void *)DestroyPipelineCache}, |
| {"vkGetPipelineCacheData", (void *)GetPipelineCacheData}, |
| {"vkMergePipelineCaches", (void *)MergePipelineCaches}, |
| {"vkCreateGraphicsPipelines", (void *)CreateGraphicsPipelines}, |
| {"vkCreateComputePipelines", (void *)CreateComputePipelines}, |
| {"vkCreateSampler", (void *)CreateSampler}, |
| {"vkCreateDescriptorSetLayout", (void *)CreateDescriptorSetLayout}, |
| {"vkCreatePipelineLayout", (void *)CreatePipelineLayout}, |
| {"vkCreateDescriptorPool", (void *)CreateDescriptorPool}, |
| {"vkResetDescriptorPool", (void *)ResetDescriptorPool}, |
| {"vkAllocateDescriptorSets", (void *)AllocateDescriptorSets}, |
| {"vkFreeDescriptorSets", (void *)FreeDescriptorSets}, |
| {"vkUpdateDescriptorSets", (void *)UpdateDescriptorSets}, |
| {"vkCreateCommandPool", (void *)CreateCommandPool}, |
| {"vkDestroyCommandPool", (void *)DestroyCommandPool}, |
| {"vkResetCommandPool", (void *)ResetCommandPool}, |
| {"vkCreateQueryPool", (void *)CreateQueryPool}, |
| {"vkAllocateCommandBuffers", (void *)AllocateCommandBuffers}, |
| {"vkFreeCommandBuffers", (void *)FreeCommandBuffers}, |
| {"vkBeginCommandBuffer", (void *)BeginCommandBuffer}, |
| {"vkEndCommandBuffer", (void *)EndCommandBuffer}, |
| {"vkResetCommandBuffer", (void *)ResetCommandBuffer}, |
| {"vkCmdBindPipeline", (void *)CmdBindPipeline}, |
| {"vkCmdSetViewport", (void *)CmdSetViewport}, |
| {"vkCmdSetScissor", (void *)CmdSetScissor}, |
| {"vkCmdSetLineWidth", (void *)CmdSetLineWidth}, |
| {"vkCmdSetDepthBias", (void *)CmdSetDepthBias}, |
| {"vkCmdSetBlendConstants", (void *)CmdSetBlendConstants}, |
| {"vkCmdSetDepthBounds", (void *)CmdSetDepthBounds}, |
| {"vkCmdSetStencilCompareMask", (void *)CmdSetStencilCompareMask}, |
| {"vkCmdSetStencilWriteMask", (void *)CmdSetStencilWriteMask}, |
| {"vkCmdSetStencilReference", (void *)CmdSetStencilReference}, |
| {"vkCmdBindDescriptorSets", (void *)CmdBindDescriptorSets}, |
| {"vkCmdBindVertexBuffers", (void *)CmdBindVertexBuffers}, |
| {"vkCmdBindIndexBuffer", (void *)CmdBindIndexBuffer}, |
| {"vkCmdDraw", (void *)CmdDraw}, |
| {"vkCmdDrawIndexed", (void *)CmdDrawIndexed}, |
| {"vkCmdDrawIndirect", (void *)CmdDrawIndirect}, |
| {"vkCmdDrawIndexedIndirect", (void *)CmdDrawIndexedIndirect}, |
| {"vkCmdDispatch", (void *)CmdDispatch}, |
| {"vkCmdDispatchIndirect", (void *)CmdDispatchIndirect}, |
| {"vkCmdCopyBuffer", (void *)CmdCopyBuffer}, |
| {"vkCmdCopyImage", (void *)CmdCopyImage}, |
| {"vkCmdBlitImage", (void *)CmdBlitImage}, |
| {"vkCmdCopyBufferToImage", (void *)CmdCopyBufferToImage}, |
| {"vkCmdCopyImageToBuffer", (void *)CmdCopyImageToBuffer}, |
| {"vkCmdUpdateBuffer", (void *)CmdUpdateBuffer}, |
| {"vkCmdFillBuffer", (void *)CmdFillBuffer}, |
| {"vkCmdClearColorImage", (void *)CmdClearColorImage}, |
| {"vkCmdClearDepthStencilImage", (void *)CmdClearDepthStencilImage}, |
| {"vkCmdClearAttachments", (void *)CmdClearAttachments}, |
| {"vkCmdResolveImage", (void *)CmdResolveImage}, |
| {"vkGetImageSubresourceLayout", (void *)GetImageSubresourceLayout}, |
| {"vkCmdSetEvent", (void *)CmdSetEvent}, |
| {"vkCmdResetEvent", (void *)CmdResetEvent}, |
| {"vkCmdWaitEvents", (void *)CmdWaitEvents}, |
| {"vkCmdPipelineBarrier", (void *)CmdPipelineBarrier}, |
| {"vkCmdBeginQuery", (void *)CmdBeginQuery}, |
| {"vkCmdEndQuery", (void *)CmdEndQuery}, |
| {"vkCmdResetQueryPool", (void *)CmdResetQueryPool}, |
| {"vkCmdCopyQueryPoolResults", (void *)CmdCopyQueryPoolResults}, |
| {"vkCmdPushConstants", (void *)CmdPushConstants}, |
| {"vkCmdWriteTimestamp", (void *)CmdWriteTimestamp}, |
| {"vkCreateFramebuffer", (void *)CreateFramebuffer}, |
| {"vkCreateShaderModule", (void *)CreateShaderModule}, |
| {"vkCreateRenderPass", (void *)CreateRenderPass}, |
| {"vkCmdBeginRenderPass", (void *)CmdBeginRenderPass}, |
| {"vkCmdNextSubpass", (void *)CmdNextSubpass}, |
| {"vkCmdEndRenderPass", (void *)CmdEndRenderPass}, |
| {"vkCmdExecuteCommands", (void *)CmdExecuteCommands}, |
| {"vkCmdDebugMarkerBeginEXT", (void *)CmdDebugMarkerBeginEXT}, |
| {"vkCmdDebugMarkerEndEXT", (void *)CmdDebugMarkerEndEXT}, |
| {"vkCmdDebugMarkerInsertEXT", (void *)CmdDebugMarkerInsertEXT}, |
| {"vkDebugMarkerSetObjectNameEXT", (void *)DebugMarkerSetObjectNameEXT}, |
| {"vkDebugMarkerSetObjectTagEXT", (void *)DebugMarkerSetObjectTagEXT}, |
| {"vkSetEvent", (void *)SetEvent}, |
| {"vkMapMemory", (void *)MapMemory}, |
| {"vkUnmapMemory", (void *)UnmapMemory}, |
| {"vkFlushMappedMemoryRanges", (void *)FlushMappedMemoryRanges}, |
| {"vkInvalidateMappedMemoryRanges", (void *)InvalidateMappedMemoryRanges}, |
| {"vkAllocateMemory", (void *)AllocateMemory}, |
| {"vkFreeMemory", (void *)FreeMemory}, |
| {"vkBindBufferMemory", (void *)BindBufferMemory}, |
| {"vkBindBufferMemory2KHR", (void *)BindBufferMemory2KHR}, |
| {"vkGetBufferMemoryRequirements", (void *)GetBufferMemoryRequirements}, |
| {"vkGetBufferMemoryRequirements2KHR", (void *)GetBufferMemoryRequirements2KHR}, |
| {"vkGetImageMemoryRequirements", (void *)GetImageMemoryRequirements}, |
| {"vkGetImageMemoryRequirements2KHR", (void *)GetImageMemoryRequirements2KHR}, |
| {"vkGetImageSparseMemoryRequirements", (void *)GetImageSparseMemoryRequirements}, |
| {"vkGetImageSparseMemoryRequirements2KHR", (void *)GetImageSparseMemoryRequirements2KHR}, |
| {"vkGetPhysicalDeviceSparseImageFormatProperties", (void *)GetPhysicalDeviceSparseImageFormatProperties}, |
| {"vkGetPhysicalDeviceSparseImageFormatProperties2KHR", (void *)GetPhysicalDeviceSparseImageFormatProperties2KHR}, |
| {"vkGetQueryPoolResults", (void *)GetQueryPoolResults}, |
| {"vkBindImageMemory", (void *)BindImageMemory}, |
| {"vkBindImageMemory2KHR", (void *)BindImageMemory2KHR}, |
| {"vkQueueBindSparse", (void *)QueueBindSparse}, |
| {"vkCreateSemaphore", (void *)CreateSemaphore}, |
| {"vkCreateEvent", (void *)CreateEvent}, |
| #ifdef VK_USE_PLATFORM_ANDROID_KHR |
| {"vkCreateAndroidSurfaceKHR", (void *)CreateAndroidSurfaceKHR}, |
| #endif |
| #ifdef VK_USE_PLATFORM_MIR_KHR |
| {"vkCreateMirSurfaceKHR", (void *)CreateMirSurfaceKHR}, |
| {"vkGetPhysicalDeviceMirPresentationSupportKHR", (void *)GetPhysicalDeviceMirPresentationSupportKHR}, |
| #endif |
| #ifdef VK_USE_PLATFORM_WAYLAND_KHR |
| {"vkCreateWaylandSurfaceKHR", (void *)CreateWaylandSurfaceKHR}, |
| {"vkGetPhysicalDeviceWaylandPresentationSupportKHR", (void *)GetPhysicalDeviceWaylandPresentationSupportKHR}, |
| #endif |
| #ifdef VK_USE_PLATFORM_WIN32_KHR |
| {"vkCreateWin32SurfaceKHR", (void *)CreateWin32SurfaceKHR}, |
| {"vkGetPhysicalDeviceWin32PresentationSupportKHR", (void *)GetPhysicalDeviceWin32PresentationSupportKHR}, |
| {"vkImportSemaphoreWin32HandleKHR", (void *)ImportSemaphoreWin32HandleKHR}, |
| {"vkGetSemaphoreWin32HandleKHR", (void *)GetSemaphoreWin32HandleKHR}, |
| {"vkImportFenceWin32HandleKHR", (void *)ImportFenceWin32HandleKHR}, |
| {"vkGetFenceWin32HandleKHR", (void *)GetFenceWin32HandleKHR}, |
| #endif |
| #ifdef VK_USE_PLATFORM_XCB_KHR |
| {"vkCreateXcbSurfaceKHR", (void *)CreateXcbSurfaceKHR}, |
| {"vkGetPhysicalDeviceXcbPresentationSupportKHR", (void *)GetPhysicalDeviceXcbPresentationSupportKHR}, |
| #endif |
| #ifdef VK_USE_PLATFORM_XLIB_KHR |
| {"vkCreateXlibSurfaceKHR", (void *)CreateXlibSurfaceKHR}, |
| {"vkGetPhysicalDeviceXlibPresentationSupportKHR", (void *)GetPhysicalDeviceXlibPresentationSupportKHR}, |
| #endif |
| #ifdef VK_USE_PLATFORM_IOS_MVK |
| {"vkCreateIOSSurfaceMVK", (void *)CreateIOSSurfaceMVK}, |
| #endif |
| #ifdef VK_USE_PLATFORM_MACOS_MVK |
| {"vkCreateMacOSSurfaceMVK", (void *)CreateMacOSSurfaceMVK}, |
| #endif |
| {"vkCreateDisplayPlaneSurfaceKHR", (void *)CreateDisplayPlaneSurfaceKHR}, |
| {"vkDestroySurfaceKHR", (void *)DestroySurfaceKHR}, |
| {"vkGetPhysicalDeviceSurfaceCapabilitiesKHR", (void *)GetPhysicalDeviceSurfaceCapabilitiesKHR}, |
| {"vkGetPhysicalDeviceSurfaceCapabilities2KHR", (void *)GetPhysicalDeviceSurfaceCapabilities2KHR}, |
| {"vkGetPhysicalDeviceSurfaceCapabilities2EXT", (void *)GetPhysicalDeviceSurfaceCapabilities2EXT}, |
| {"vkGetPhysicalDeviceSurfaceSupportKHR", (void *)GetPhysicalDeviceSurfaceSupportKHR}, |
| {"vkGetPhysicalDeviceSurfacePresentModesKHR", (void *)GetPhysicalDeviceSurfacePresentModesKHR}, |
| {"vkGetPhysicalDeviceSurfaceFormatsKHR", (void *)GetPhysicalDeviceSurfaceFormatsKHR}, |
| {"vkGetPhysicalDeviceSurfaceFormats2KHR", (void *)GetPhysicalDeviceSurfaceFormats2KHR}, |
| {"vkGetPhysicalDeviceQueueFamilyProperties2KHR", (void *)GetPhysicalDeviceQueueFamilyProperties2KHR}, |
| {"vkEnumeratePhysicalDeviceGroupsKHX", (void *)EnumeratePhysicalDeviceGroupsKHX}, |
| {"vkCreateDebugReportCallbackEXT", (void *)CreateDebugReportCallbackEXT}, |
| {"vkDestroyDebugReportCallbackEXT", (void *)DestroyDebugReportCallbackEXT}, |
| {"vkDebugReportMessageEXT", (void *)DebugReportMessageEXT}, |
| {"vkGetPhysicalDeviceDisplayPlanePropertiesKHR", (void *)GetPhysicalDeviceDisplayPlanePropertiesKHR}, |
| {"vkGetDisplayPlaneSupportedDisplaysKHR", (void *)GetDisplayPlaneSupportedDisplaysKHR}, |
| {"vkGetDisplayPlaneCapabilitiesKHR", (void *)GetDisplayPlaneCapabilitiesKHR}, |
| {"vkImportSemaphoreFdKHR", (void *)ImportSemaphoreFdKHR}, |
| {"vkGetSemaphoreFdKHR", (void *)GetSemaphoreFdKHR}, |
| {"vkImportFenceFdKHR", (void *)ImportFenceFdKHR}, |
| {"vkGetFenceFdKHR", (void *)GetFenceFdKHR}, |
| {"vkCreateValidationCacheEXT", (void *)CreateValidationCacheEXT}, |
| {"vkDestroyValidationCacheEXT", (void *)DestroyValidationCacheEXT}, |
| {"vkGetValidationCacheDataEXT", (void *)GetValidationCacheDataEXT}, |
| {"vkMergeValidationCachesEXT", (void *)MergeValidationCachesEXT}, |
| {"vkCmdSetDiscardRectangleEXT", (void *)CmdSetDiscardRectangleEXT}, |
| {"vkCmdSetSampleLocationsEXT", (void *)CmdSetSampleLocationsEXT}, |
| }; |
| |
| VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice device, const char *funcName) { |
| assert(device); |
| layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| |
| // Is API to be intercepted by this layer? |
| const auto &item = name_to_funcptr_map.find(funcName); |
| if (item != name_to_funcptr_map.end()) { |
| return reinterpret_cast<PFN_vkVoidFunction>(item->second); |
| } |
| |
| auto &table = device_data->dispatch_table; |
| if (!table.GetDeviceProcAddr) return nullptr; |
| return table.GetDeviceProcAddr(device, funcName); |
| } |
| |
| VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { |
| instance_layer_data *instance_data; |
| // Is API to be intercepted by this layer? |
| const auto &item = name_to_funcptr_map.find(funcName); |
| if (item != name_to_funcptr_map.end()) { |
| return reinterpret_cast<PFN_vkVoidFunction>(item->second); |
| } |
| |
| instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map); |
| auto &table = instance_data->dispatch_table; |
| if (!table.GetInstanceProcAddr) return nullptr; |
| return table.GetInstanceProcAddr(instance, funcName); |
| } |
| |
| VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) { |
| assert(instance); |
| instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map); |
| |
| auto &table = instance_data->dispatch_table; |
| if (!table.GetPhysicalDeviceProcAddr) return nullptr; |
| return table.GetPhysicalDeviceProcAddr(instance, funcName); |
| } |
| |
| } // namespace core_validation |
| |
| // loader-layer interface v0, just wrappers since there is only a layer |
| |
| VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, |
| VkExtensionProperties *pProperties) { |
| return core_validation::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); |
| } |
| |
| VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, |
| VkLayerProperties *pProperties) { |
| return core_validation::EnumerateInstanceLayerProperties(pCount, pProperties); |
| } |
| |
| VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, |
| VkLayerProperties *pProperties) { |
| // the layer command handles VK_NULL_HANDLE just fine internally |
| assert(physicalDevice == VK_NULL_HANDLE); |
| return core_validation::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); |
| } |
| |
| VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, |
| const char *pLayerName, uint32_t *pCount, |
| VkExtensionProperties *pProperties) { |
| // the layer command handles VK_NULL_HANDLE just fine internally |
| assert(physicalDevice == VK_NULL_HANDLE); |
| return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); |
| } |
| |
| VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { |
| return core_validation::GetDeviceProcAddr(dev, funcName); |
| } |
| |
| VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { |
| return core_validation::GetInstanceProcAddr(instance, funcName); |
| } |
| |
| VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance, |
| const char *funcName) { |
| return core_validation::GetPhysicalDeviceProcAddr(instance, funcName); |
| } |
| |
| VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) { |
| assert(pVersionStruct != NULL); |
| assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT); |
| |
| // Fill in the function pointers if our version is at least capable of having the structure contain them. |
| if (pVersionStruct->loaderLayerInterfaceVersion >= 2) { |
| pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr; |
| pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr; |
| pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr; |
| } |
| |
| if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) { |
| core_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion; |
| } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) { |
| pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION; |
| } |
| |
| return VK_SUCCESS; |
| } |