commit 673f4d0c1dfe78f66e8d7f036c619065800022de
author Chia-I Wu <olvaffe@gmail.com> Wed Jul 21 13:08:12 2021 -0700
committer Chia-I Wu <olvaffe@gmail.com> Wed Jul 21 20:27:51 2021 +0000
tree 433c39084ea8a523b2126c656f55cb31f89cb1f7
parent 029303e9fde8af7fa28c747c0e801adf46320add

vrend: fix boundary check for SSBO state update

(PIPE_MAX_SHADER_BUFFERS - num_ssbo) can underflow.

Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>

src/vrend_decode.c

diff --git a/src/vrend_decode.c b/src/vrend_decode.c
index 35ccc23..9fc3552 100644
--- a/src/vrend_decode.c
+++ b/src/vrend_decode.c
@@ -1208,7 +1208,7 @@
       return 0;
 
    if (start_slot > PIPE_MAX_SHADER_BUFFERS ||
-       start_slot > PIPE_MAX_SHADER_BUFFERS - num_ssbo)
+       num_ssbo > PIPE_MAX_SHADER_BUFFERS - start_slot)
       return EINVAL;
 
    for (uint32_t i = 0; i < num_ssbo; i++) {