When process dies due to a signal, show the signal and the stacktrace
at default verbosity
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@15251 a5019735-40e9-0310-863c-91ae7b9d1cf9
diff --git a/NEWS b/NEWS
index 387cf2f..8b3ea13 100644
--- a/NEWS
+++ b/NEWS
@@ -23,6 +23,9 @@
* ==================== OTHER CHANGES ====================
+* When a process dies due to a signal, Valgrind now shows the signal
+ and the stacktrace at default verbosity (i.e. verbosity 1).
+
* Address description logic (used by memcheck and helgrind)
now describes addresses in anonymous segments, file mmap-ed
segments, shared memory segments and the brk data segment.
diff --git a/coregrind/m_signals.c b/coregrind/m_signals.c
index 16d220c..78e2a6d 100644
--- a/coregrind/m_signals.c
+++ b/coregrind/m_signals.c
@@ -1639,7 +1639,7 @@
core = False;
}
- if ( (VG_(clo_verbosity) > 1 ||
+ if ( (VG_(clo_verbosity) >= 1 ||
(could_core && is_signal_from_kernel(tid, sigNo, info->si_code))
) &&
!VG_(clo_xml) ) {
diff --git a/drd/tests/tc22_exit_w_lock.stderr.exp-32bit b/drd/tests/tc22_exit_w_lock.stderr.exp-32bit
index b4e5b2c..5563126 100644
--- a/drd/tests/tc22_exit_w_lock.stderr.exp-32bit
+++ b/drd/tests/tc22_exit_w_lock.stderr.exp-32bit
@@ -135,5 +135,3 @@
at 0x........: pthread_join (drd_pthread_intercepts.c:?)
by 0x........: main (tc22_exit_w_lock.c:43)
-
-ERROR SUMMARY: 12 errors from 12 contexts (suppressed: 0 from 0)
diff --git a/drd/tests/tc22_exit_w_lock.stderr.exp-64bit b/drd/tests/tc22_exit_w_lock.stderr.exp-64bit
index cf7e0d2..03e8046 100644
--- a/drd/tests/tc22_exit_w_lock.stderr.exp-64bit
+++ b/drd/tests/tc22_exit_w_lock.stderr.exp-64bit
@@ -1,4 +1,3 @@
-
Mutex still locked at thread exit: mutex 0x........, recursion count 1, owner 3.
at 0x........: pthread_join (drd_pthread_intercepts.c:?)
by 0x........: main (tc22_exit_w_lock.c:43)
@@ -7,5 +6,3 @@
by 0x........: child_fn1 (tc22_exit_w_lock.c:18)
by 0x........: vgDrd_thread_wrapper (drd_pthread_intercepts.c:?)
-
-ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
diff --git a/drd/tests/tc22_exit_w_lock.vgtest b/drd/tests/tc22_exit_w_lock.vgtest
index 673380c..f16c1df 100644
--- a/drd/tests/tc22_exit_w_lock.vgtest
+++ b/drd/tests/tc22_exit_w_lock.vgtest
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread && [ -e ../../helgrind/tests/tc22_exit_w_lock ]
-vgopts: --num-callers=3
+vgopts: --num-callers=3 -q
prog: ../../helgrind/tests/tc22_exit_w_lock
diff --git a/gdbserver_tests/nlgone_abrt.stderr.exp b/gdbserver_tests/nlgone_abrt.stderr.exp
index f1d766b..8daa1f9 100644
--- a/gdbserver_tests/nlgone_abrt.stderr.exp
+++ b/gdbserver_tests/nlgone_abrt.stderr.exp
@@ -1,8 +1,5 @@
-Nulgrind, the minimal Valgrind tool
-
(action at startup) vgdb me ...
starting ...
aborting ...
-
diff --git a/gdbserver_tests/nlgone_abrt.vgtest b/gdbserver_tests/nlgone_abrt.vgtest
index 09916f0..86aecfd 100644
--- a/gdbserver_tests/nlgone_abrt.vgtest
+++ b/gdbserver_tests/nlgone_abrt.vgtest
@@ -2,7 +2,7 @@
prog: gone
args: abort
-vgopts: --tool=none --vgdb=yes --vgdb-error=0 --vgdb-prefix=./vgdb-prefix-nlgone-abrt
+vgopts: -q --tool=none --vgdb=yes --vgdb-error=0 --vgdb-prefix=./vgdb-prefix-nlgone-abrt
stderr_filter: filter_stderr
prereq: test -e gdb
progB: gdb
diff --git a/helgrind/tests/tc22_exit_w_lock.stderr.exp b/helgrind/tests/tc22_exit_w_lock.stderr.exp
index 6f3de66..25e5d4e 100644
--- a/helgrind/tests/tc22_exit_w_lock.stderr.exp
+++ b/helgrind/tests/tc22_exit_w_lock.stderr.exp
@@ -23,6 +23,10 @@
Thread #x: Exiting thread still holds 1 lock
...
+
+Process terminating with default action of signal 6 (SIGABRT)
+ ...
+ by 0x........: main (tc22_exit_w_lock.c:48)
---Thread-Announcement------------------------------------------
Thread #x is the program's root thread
