Implement PCMPxSTRx cases 0x0E, 0x34, 0x14, and reformat some of the
associated switch statements. Fixes #326469, #327639, #328878
respectively.
git-svn-id: svn://svn.valgrind.org/vex/trunk@2864 8f6e269a-dfd6-0310-a8e1-e2731360e62c
diff --git a/priv/guest_amd64_toIR.c b/priv/guest_amd64_toIR.c
index c69a71e..563e957 100644
--- a/priv/guest_amd64_toIR.c
+++ b/priv/guest_amd64_toIR.c
@@ -18199,14 +18199,16 @@
immediate byte. Is it one we can actually handle? Throw out any
cases for which the helper function has not been verified. */
switch (imm) {
- case 0x00:
- case 0x02: case 0x08: case 0x0A: case 0x0C: case 0x12:
- case 0x1A: case 0x38: case 0x3A: case 0x44: case 0x4A:
- case 0x46: case 0x30: case 0x40:
+ case 0x00: case 0x02: case 0x08: case 0x0A: case 0x0C: case 0x0E:
+ case 0x12: case 0x14: case 0x1A:
+ case 0x30: case 0x34: case 0x38: case 0x3A:
+ case 0x40: case 0x44: case 0x46: case 0x4A:
break;
- case 0x01: // the 16-bit character versions of the above
- case 0x03: case 0x09: case 0x0B: case 0x0D: case 0x13:
- case 0x1B: case 0x39: case 0x3B: case 0x45: case 0x4B:
+ // the 16-bit character versions of the above
+ case 0x01: case 0x03: case 0x09: case 0x0B: case 0x0D:
+ case 0x13: case 0x1B:
+ case 0x39: case 0x3B:
+ case 0x45: case 0x4B:
break;
default:
return delta0; /*FAIL*/
diff --git a/priv/guest_generic_x87.c b/priv/guest_generic_x87.c
index 26a7034..0e36e94 100644
--- a/priv/guest_generic_x87.c
+++ b/priv/guest_generic_x87.c
@@ -795,10 +795,10 @@
even if they would probably work. Life is too short to have
unvalidated cases in the code base. */
switch (imm8) {
- case 0x00:
- case 0x02: case 0x08: case 0x0A: case 0x0C: case 0x12:
- case 0x1A: case 0x38: case 0x3A: case 0x44: case 0x4A:
- case 0x46: case 0x30: case 0x40:
+ case 0x00: case 0x02: case 0x08: case 0x0A: case 0x0C: case 0x0E:
+ case 0x12: case 0x14: case 0x1A:
+ case 0x30: case 0x34: case 0x38: case 0x3A:
+ case 0x40: case 0x44: case 0x46: case 0x4A:
break;
default:
return False;
@@ -1046,9 +1046,10 @@
even if they would probably work. Life is too short to have
unvalidated cases in the code base. */
switch (imm8) {
- case 0x01:
- case 0x03: case 0x09: case 0x0B: case 0x0D: case 0x13:
- case 0x1B: case 0x39: case 0x3B: case 0x45: case 0x4B:
+ case 0x01: case 0x03: case 0x09: case 0x0B: case 0x0D:
+ case 0x13: case 0x1B:
+ case 0x39: case 0x3B:
+ case 0x45: case 0x4B:
break;
default:
return False;
